)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ed9a3ad8d91c14a5cfabad92256aac2a368d103","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* baremetal node power on|off"},{"line_number":10,"context_line":"* baremetal node reboot"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I79b75ecb5dd0b13e74f60f506ff37bda6178271c"},{"line_number":13,"context_line":"Depends-On: Ia9fed8f4987cf8ae2ca0a3cb7726596a627cba4f"},{"line_number":14,"context_line":"Partial-Bug: #1526479"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"7aa08908_5a14b49e","line":11,"updated":"2016-06-14 15:15:31.000000000","message":"please mention the file renaming","commit_id":"d9aaec1b06ba0edd4f0d593a7122de17573cf45c"}],"ironicclient/osc/v1/baremetal.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a74c5f1fd31c1bc5a235620ca1416671fca0e839","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if parsed_args.node is not None:"},{"line_number":286,"context_line":"            baremetal_client.node.set_power_state("},{"line_number":287,"context_line":"                parsed_args.node, \u0027reboot\u0027)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aa745d1_841dac75","line":285,"updated":"2015-04-16 14:10:26.000000000","message":"check is redundant for a required argument IMO","commit_id":"5b34607c33b567e9c4d1fc7d262179e309d41772"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a74c5f1fd31c1bc5a235620ca1416671fca0e839","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            baremetal_client.node.set_power_state("},{"line_number":287,"context_line":"                parsed_args.node, \u0027reboot\u0027)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aa745d1_8436cc01","line":289,"updated":"2015-04-16 14:10:26.000000000","message":"nit: return redundant","commit_id":"5b34607c33b567e9c4d1fc7d262179e309d41772"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6cf093ca0d1e44bbec8b2ee63f1d19b20a1ecb5c","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        if not parsed_args.on and not parsed_args.off:"},{"line_number":399,"context_line":"            return"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        power_state \u003d \u0027off\u0027 if parsed_args.off else \u0027on\u0027"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_aa7ced72","line":399,"updated":"2015-04-30 14:22:39.000000000","message":"please don\u0027t silently ignore user request. if you insist on having mandatory arguments as optional, you should correctly and meaningfully process case, when neither --on nor --off were provided.","commit_id":"412c596725c77fd272a1bb6849a996b3bd30715d"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"aab9df327e88a56512ae992108960074c96193a6","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        if not parsed_args.on and not parsed_args.off:"},{"line_number":399,"context_line":"            return"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        power_state \u003d \u0027off\u0027 if parsed_args.off else \u0027on\u0027"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_4042cd3f","line":399,"in_reply_to":"3acd31a7_aa7ced72","updated":"2015-04-30 19:52:52.000000000","message":"They are now marked as required via the group.","commit_id":"412c596725c77fd272a1bb6849a996b3bd30715d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eb1cf3e820872e831a1e0cd0af4aeacb87c9f4b9","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            \u0027--off\u0027,"},{"line_number":227,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":228,"context_line":"            help\u003d\u0027Turn baremetal node off\u0027,"},{"line_number":229,"context_line":"        )"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        return parser"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba15a1d1_66835bcd","line":229,"updated":"2015-09-22 15:34:39.000000000","message":"for the record: I would still prefer \u0027power on UUID\u0027, rather than \u0027power --on UUID\u0027","commit_id":"8c152949f335dcc887b082c895bb2a283dcde858"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0551c2875988a402fd65cf2ac0120fc22b20502f","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            \u0027--off\u0027,"},{"line_number":226,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":227,"context_line":"            help\u003d\u0027Turn baremetal node off\u0027,"},{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        return parser"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa69d971_b9daaf49","line":228,"updated":"2016-01-05 14:33:19.000000000","message":"The spec says this should be \u0027power on\u0027 or \u0027power off\u0027.\n\nYou already know this though :)","commit_id":"0f402730d71a5c9254089436c7eef6290a0e5e5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"37191358606de2b754bf4e0e1a128e7498e8ac8d","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    log \u003d logging.getLogger(__name__ + \".PowerBaremetal\")"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def get_parser(self, prog_name):"},{"line_number":318,"context_line":"        parser \u003d super(PowerBaremetal, self).get_parser(prog_name)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_a607d5c8","line":317,"range":{"start_line":317,"start_character":4,"end_line":317,"end_character":36},"updated":"2016-03-03 08:16:51.000000000","message":"A public method would need docstring at least, I think.\nHowever I noticed that docsring for a pubic method is missing not only in this patch but also in the base code.","commit_id":"234bfbc0f9fe5a7047d382da4fab77005d3e4378"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"8f207adb92f5446b0ed03adda56e8048633c33c2","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    log \u003d logging.getLogger(__name__ + \".PowerBaremetal\")"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def get_parser(self, prog_name):"},{"line_number":318,"context_line":"        parser \u003d super(PowerBaremetal, self).get_parser(prog_name)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":30,"id":"5a18252c_5c2e9ea5","line":317,"in_reply_to":"7af24918_a607d5c8","updated":"2016-04-14 11:29:18.000000000","message":"I disagree here. This would start to get overly verbose. The main project (OpenstackClient) does not document every usage of these methods. These are implementations of an ABC.","commit_id":"234bfbc0f9fe5a7047d382da4fab77005d3e4378"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"37191358606de2b754bf4e0e1a128e7498e8ac8d","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        )"},{"line_number":331,"context_line":"        return parser"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def take_action(self, parsed_args):"},{"line_number":334,"context_line":"        self.log.debug(\"take_action(%s)\", parsed_args)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_860c59ee","line":333,"range":{"start_line":333,"start_character":4,"end_line":333,"end_character":39},"updated":"2016-03-03 08:16:51.000000000","message":"ditto","commit_id":"234bfbc0f9fe5a7047d382da4fab77005d3e4378"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"37191358606de2b754bf4e0e1a128e7498e8ac8d","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    log \u003d logging.getLogger(__name__ + \".RebootBaremetal\")"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def get_parser(self, prog_name):"},{"line_number":348,"context_line":"        parser \u003d super(RebootBaremetal, self).get_parser(prog_name)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_c612e108","line":347,"range":{"start_line":347,"start_character":4,"end_line":347,"end_character":35},"updated":"2016-03-03 08:16:51.000000000","message":"ditto","commit_id":"234bfbc0f9fe5a7047d382da4fab77005d3e4378"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"37191358606de2b754bf4e0e1a128e7498e8ac8d","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        return parser"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def take_action(self, parsed_args):"},{"line_number":358,"context_line":"        self.log.debug(\"take_action(%s)\", parsed_args)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_c6294139","line":357,"range":{"start_line":357,"start_character":4,"end_line":357,"end_character":39},"updated":"2016-03-03 08:16:51.000000000","message":"ditto","commit_id":"234bfbc0f9fe5a7047d382da4fab77005d3e4378"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"37191358606de2b754bf4e0e1a128e7498e8ac8d","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    log \u003d logging.getLogger(__name__ + \".SetBaremetalNode\")"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def get_parser(self, prog_name):"},{"line_number":372,"context_line":"        parser \u003d super(SetBaremetalNode, self).get_parser(prog_name)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_869c5910","line":371,"range":{"start_line":371,"start_character":3,"end_line":371,"end_character":36},"updated":"2016-03-03 08:16:51.000000000","message":"Here is a public method in the base code which doesn\u0027t have docstring.\nPlease feel free to point out if I\u0027m wrong about docstring.","commit_id":"234bfbc0f9fe5a7047d382da4fab77005d3e4378"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5b53f6c3857a1871de8bdc6e83c4a738ae5ad94","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        return super(ListBaremetal, self).take_action(parsed_args)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"class PowerBaremetal(command.Command):"},{"line_number":283,"context_line":"    \"\"\"Set power state of baremetal system\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    log \u003d logging.getLogger(__name__ + \".PowerBaremetal\")"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_d00499c1","line":282,"updated":"2016-06-06 19:47:04.000000000","message":"to be consistent, shouldn\u0027t it be PowerBaremetalNode?","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"851aeb49e95d4f51c6fd8abf8e6e0ae7d82d6285","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        return super(ListBaremetal, self).take_action(parsed_args)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"class PowerBaremetal(command.Command):"},{"line_number":283,"context_line":"    \"\"\"Set power state of baremetal system\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    log \u003d logging.getLogger(__name__ + \".PowerBaremetal\")"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_18ac6333","line":282,"in_reply_to":"7aa08908_d00499c1","updated":"2016-06-07 11:50:03.000000000","message":"Done","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5b53f6c3857a1871de8bdc6e83c4a738ae5ad94","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"class PowerBaremetal(command.Command):"},{"line_number":283,"context_line":"    \"\"\"Set power state of baremetal system\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    log \u003d logging.getLogger(__name__ + \".PowerBaremetal\")"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_10a2a1ae","line":283,"updated":"2016-06-06 19:47:04.000000000","message":"s/system/node/","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"851aeb49e95d4f51c6fd8abf8e6e0ae7d82d6285","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"class PowerBaremetal(command.Command):"},{"line_number":283,"context_line":"    \"\"\"Set power state of baremetal system\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    log \u003d logging.getLogger(__name__ + \".PowerBaremetal\")"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_38679f26","line":283,"in_reply_to":"7aa08908_10a2a1ae","updated":"2016-06-07 11:50:03.000000000","message":"Done","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5b53f6c3857a1871de8bdc6e83c4a738ae5ad94","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            parsed_args.node, parsed_args.power_state)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"class RebootBaremetal(command.Command):"},{"line_number":313,"context_line":"    \"\"\"Reboot baremetal system\"\"\""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    log \u003d logging.getLogger(__name__ + \".RebootBaremetal\")"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_b0458db4","line":312,"updated":"2016-06-06 19:47:04.000000000","message":"RebootBaremetalNode ?","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"851aeb49e95d4f51c6fd8abf8e6e0ae7d82d6285","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            parsed_args.node, parsed_args.power_state)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"class RebootBaremetal(command.Command):"},{"line_number":313,"context_line":"    \"\"\"Reboot baremetal system\"\"\""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    log \u003d logging.getLogger(__name__ + \".RebootBaremetal\")"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_986e93ff","line":312,"in_reply_to":"7aa08908_b0458db4","updated":"2016-06-07 11:50:03.000000000","message":"Done","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5b53f6c3857a1871de8bdc6e83c4a738ae5ad94","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"class RebootBaremetal(command.Command):"},{"line_number":313,"context_line":"    \"\"\"Reboot baremetal system\"\"\""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    log \u003d logging.getLogger(__name__ + \".RebootBaremetal\")"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_500d498f","line":313,"updated":"2016-06-06 19:47:04.000000000","message":"s/system/node/","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"851aeb49e95d4f51c6fd8abf8e6e0ae7d82d6285","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"class RebootBaremetal(command.Command):"},{"line_number":313,"context_line":"    \"\"\"Reboot baremetal system\"\"\""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    log \u003d logging.getLogger(__name__ + \".RebootBaremetal\")"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_d8781bc7","line":313,"in_reply_to":"7aa08908_500d498f","updated":"2016-06-07 11:50:03.000000000","message":"Done","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"}],"ironicclient/tests/unit/osc/v1/test_baremetal.py":[{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"7b8302de3976e3168a6cdffdaaee62e6efc8ecf9","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        # Get the command object to test"},{"line_number":503,"context_line":"        self.cmd \u003d baremetal.PowerBaremetal(self.app, None)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def test_baremetal_reboot_no_options(self):"},{"line_number":506,"context_line":"        arglist \u003d []"},{"line_number":507,"context_line":"        verifylist \u003d []"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"7aa08908_7c7cc272","line":505,"range":{"start_line":505,"start_character":8,"end_line":505,"end_character":40},"updated":"2016-06-06 10:50:24.000000000","message":"I think this method should be called test_baremetal_power_no_options","commit_id":"175fbce18fc8c993de3616f7248d51a350b6d644"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5b53f6c3857a1871de8bdc6e83c4a738ae5ad94","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        # Get the command object to test"},{"line_number":503,"context_line":"        self.cmd \u003d baremetal.PowerBaremetal(self.app, None)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def test_baremetal_reboot_no_options(self):"},{"line_number":506,"context_line":"        arglist \u003d []"},{"line_number":507,"context_line":"        verifylist \u003d []"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_83f92983","line":505,"updated":"2016-06-06 19:47:04.000000000","message":"why is this test under Power, or did you mean to call it s/reboot/power/ ?","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"851aeb49e95d4f51c6fd8abf8e6e0ae7d82d6285","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        # Get the command object to test"},{"line_number":503,"context_line":"        self.cmd \u003d baremetal.PowerBaremetal(self.app, None)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def test_baremetal_reboot_no_options(self):"},{"line_number":506,"context_line":"        arglist \u003d []"},{"line_number":507,"context_line":"        verifylist \u003d []"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_584b8b87","line":505,"in_reply_to":"7aa08908_83f92983","updated":"2016-06-07 11:50:03.000000000","message":"Probably due to the initial refactoring. I\u0027ll move it.","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5b53f6c3857a1871de8bdc6e83c4a738ae5ad94","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        self.assertRaises(oscutils.ParserException,"},{"line_number":518,"context_line":"                          self.check_parser,"},{"line_number":519,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def test_baremetal_power_on(self):"},{"line_number":522,"context_line":"        arglist \u003d [\u0027on\u0027, \u0027node_uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_c3e691b3","line":519,"updated":"2016-06-06 19:47:04.000000000","message":"what about a test for on|off only (no uuid).","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"851aeb49e95d4f51c6fd8abf8e6e0ae7d82d6285","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        self.assertRaises(oscutils.ParserException,"},{"line_number":518,"context_line":"                          self.check_parser,"},{"line_number":519,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def test_baremetal_power_on(self):"},{"line_number":522,"context_line":"        arglist \u003d [\u0027on\u0027, \u0027node_uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_384e7f96","line":519,"in_reply_to":"7aa08908_c3e691b3","updated":"2016-06-07 11:50:03.000000000","message":"Done","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5b53f6c3857a1871de8bdc6e83c4a738ae5ad94","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def test_baremetal_power_on(self):"},{"line_number":522,"context_line":"        arglist \u003d [\u0027on\u0027, \u0027node_uuid\u0027]"},{"line_number":523,"context_line":"        verifylist \u003d [(\u0027power_state\u0027, \u0027on\u0027),"},{"line_number":524,"context_line":"                      (\u0027node\u0027, \u0027node_uuid\u0027)]"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_c37851f5","line":522,"updated":"2016-06-06 19:47:04.000000000","message":"I\u0027d like to start using reasonable values. This should be some UUID or a valid node name.","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dfea412c26030c1d88b952643c47266adee0fc2","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def test_baremetal_power_on(self):"},{"line_number":522,"context_line":"        arglist \u003d [\u0027on\u0027, \u0027node_uuid\u0027]"},{"line_number":523,"context_line":"        verifylist \u003d [(\u0027power_state\u0027, \u0027on\u0027),"},{"line_number":524,"context_line":"                      (\u0027node\u0027, \u0027node_uuid\u0027)]"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_bffa4ebb","line":522,"in_reply_to":"7aa08908_61de8e12","updated":"2016-06-07 13:21:46.000000000","message":"I don\u0027t believe that \u0027node_uuid\u0027 is a valid name. I don\u0027t think underscores are allowed.\n\nDoes it really matter? I think yes. People sometimes look at tests to see examples of how things work (or don\u0027t work). I\u0027ve seen in ironic, where the tests had non-realistic values, and how we\u0027ve changed them over time. Sometimes it was because code was added to verify the values. Sometimes it was cuz it was misleading. So I think it makes sense to do things \u0027better\u0027 and more \u0027right\u0027 at the start. Subsequent tests tend to take on a similar pattern as what already exists.\n\nAnd really, \u0027node_uuid\u0027 is confusing since it isn\u0027t a uuid and would someone call a node \u0027node_uuid\u0027? :)","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"851aeb49e95d4f51c6fd8abf8e6e0ae7d82d6285","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def test_baremetal_power_on(self):"},{"line_number":522,"context_line":"        arglist \u003d [\u0027on\u0027, \u0027node_uuid\u0027]"},{"line_number":523,"context_line":"        verifylist \u003d [(\u0027power_state\u0027, \u0027on\u0027),"},{"line_number":524,"context_line":"                      (\u0027node\u0027, \u0027node_uuid\u0027)]"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_3835dff6","line":522,"in_reply_to":"7aa08908_c37851f5","updated":"2016-06-07 11:50:03.000000000","message":"Done","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"2820df94d788d58b32a3d23cf182bf672be8b68f","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def test_baremetal_power_on(self):"},{"line_number":522,"context_line":"        arglist \u003d [\u0027on\u0027, \u0027node_uuid\u0027]"},{"line_number":523,"context_line":"        verifylist \u003d [(\u0027power_state\u0027, \u0027on\u0027),"},{"line_number":524,"context_line":"                      (\u0027node\u0027, \u0027node_uuid\u0027)]"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_61de8e12","line":522,"in_reply_to":"7aa08908_c37851f5","updated":"2016-06-07 12:23:46.000000000","message":"On second thought, isn\u0027t node_uuid a valid name? :)\n\nSince these don\u0027t actually call ironic, does it really matter? They\u0027re ultimately just strings.","commit_id":"eec31d5c030d9163eb6cc7f2daab00e890562712"}],"setup.cfg":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f680b5ede834108dda48db38402ab3cd278aee0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    baremetal \u003d ironicclient.osc.plugin"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"openstack.baremetal.v1 \u003d"},{"line_number":31,"context_line":"    baremetal_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetal"},{"line_number":32,"context_line":"    baremetal_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetal"},{"line_number":33,"context_line":"    baremetal_list \u003d ironicclient.osc.v1.baremetal:ListBaremetal"},{"line_number":34,"context_line":"    baremetal_node_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetalNode"}],"source_content_type":"text/x-ttcn-cfg","patch_set":47,"id":"7aa08908_1f2f22f7","line":31,"updated":"2016-06-07 13:28:39.000000000","message":"s/v1.baremetal/v1.baremetal_node/\n\nsimilar thing below","commit_id":"044f3277bdd543178d9c72acb4002e0cfe4372a8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f680b5ede834108dda48db38402ab3cd278aee0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    baremetal_node_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetalNode"},{"line_number":35,"context_line":"    baremetal_node_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetalNode"},{"line_number":36,"context_line":"    baremetal_node_list \u003d ironicclient.osc.v1.baremetal:ListBaremetalNode"},{"line_number":37,"context_line":"    baremetal_node_power \u003d ironicclient.osc.v1.baremetal:PowerBaremetal"},{"line_number":38,"context_line":"    baremetal_node_reboot \u003d ironicclient.osc.v1.baremetal:RebootBaremetal"},{"line_number":39,"context_line":"    baremetal_node_set \u003d ironicclient.osc.v1.baremetal:SetBaremetalNode"},{"line_number":40,"context_line":"    baremetal_node_show \u003d ironicclient.osc.v1.baremetal:ShowBaremetalNode"}],"source_content_type":"text/x-ttcn-cfg","patch_set":47,"id":"7aa08908_1f7d62e7","line":37,"updated":"2016-06-07 13:28:39.000000000","message":"s/PowerBaremetal/PowerBaremetalNode/","commit_id":"044f3277bdd543178d9c72acb4002e0cfe4372a8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f680b5ede834108dda48db38402ab3cd278aee0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    baremetal_node_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetalNode"},{"line_number":36,"context_line":"    baremetal_node_list \u003d ironicclient.osc.v1.baremetal:ListBaremetalNode"},{"line_number":37,"context_line":"    baremetal_node_power \u003d ironicclient.osc.v1.baremetal:PowerBaremetal"},{"line_number":38,"context_line":"    baremetal_node_reboot \u003d ironicclient.osc.v1.baremetal:RebootBaremetal"},{"line_number":39,"context_line":"    baremetal_node_set \u003d ironicclient.osc.v1.baremetal:SetBaremetalNode"},{"line_number":40,"context_line":"    baremetal_node_show \u003d ironicclient.osc.v1.baremetal:ShowBaremetalNode"},{"line_number":41,"context_line":"    baremetal_node_unset \u003d ironicclient.osc.v1.baremetal:UnsetBaremetalNode"}],"source_content_type":"text/x-ttcn-cfg","patch_set":47,"id":"7aa08908_9f695228","line":38,"updated":"2016-06-07 13:28:39.000000000","message":"s/RebootBaremetal/RebootBaremetalNode/","commit_id":"044f3277bdd543178d9c72acb4002e0cfe4372a8"}]}
