)]}'
{"ironicclient/shell.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"604fd582cb8622a1d768319352f621e3eaf1270a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        )"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Register global Keystone args first so their defaults are respected."},{"line_number":100,"context_line":"        # See LP 1463581"},{"line_number":101,"context_line":"        self._append_global_identity_args(parser)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Global arguments"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_377a87f2","line":100,"updated":"2015-06-15 23:05:28.000000000","message":"nit: Can a URL be added also?","commit_id":"f1deef310c6662608979d6003f01a41c9fec54c1"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b034d75c92fc36935d723e41c830fe74982d06aa","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        )"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Register global Keystone args first so their defaults are respected."},{"line_number":100,"context_line":"        # See LP 1463581"},{"line_number":101,"context_line":"        self._append_global_identity_args(parser)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Global arguments"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_1edad378","line":100,"in_reply_to":"fa32b979_377a87f2","updated":"2015-06-16 17:17:52.000000000","message":"Done","commit_id":"f1deef310c6662608979d6003f01a41c9fec54c1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fe152dc05a0f9a5f4a345988f94f4fa1b1dd2caa","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                                \u0027IRONIC_RETRY_INTERVAL\u0027,"},{"line_number":246,"context_line":"                                default\u003dstr(http.DEFAULT_RETRY_INTERVAL)))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # FIXME(gyee): this method should come from python-keystoneclient."},{"line_number":249,"context_line":"        # Will refactor this code once it is available."},{"line_number":250,"context_line":"        # https://bugs.launchpad.net/python-keystoneclient/+bug/1332337"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_ab763bd6","line":248,"updated":"2015-06-11 20:53:45.000000000","message":"It looks like this FIXME is related to the code you moved up, so maybe move this up too?","commit_id":"f1deef310c6662608979d6003f01a41c9fec54c1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"66076e7b82bb5bb3b40afdf42bc763076dc30b3b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                                \u0027IRONIC_RETRY_INTERVAL\u0027,"},{"line_number":246,"context_line":"                                default\u003dstr(http.DEFAULT_RETRY_INTERVAL)))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # FIXME(gyee): this method should come from python-keystoneclient."},{"line_number":249,"context_line":"        # Will refactor this code once it is available."},{"line_number":250,"context_line":"        # https://bugs.launchpad.net/python-keystoneclient/+bug/1332337"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_2671f3e0","line":248,"in_reply_to":"3afb71cf_ab763bd6","updated":"2015-06-16 01:37:40.000000000","message":"+1","commit_id":"f1deef310c6662608979d6003f01a41c9fec54c1"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b034d75c92fc36935d723e41c830fe74982d06aa","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                                \u0027IRONIC_RETRY_INTERVAL\u0027,"},{"line_number":246,"context_line":"                                default\u003dstr(http.DEFAULT_RETRY_INTERVAL)))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # FIXME(gyee): this method should come from python-keystoneclient."},{"line_number":249,"context_line":"        # Will refactor this code once it is available."},{"line_number":250,"context_line":"        # https://bugs.launchpad.net/python-keystoneclient/+bug/1332337"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_de478b49","line":248,"in_reply_to":"3afb71cf_ab763bd6","updated":"2015-06-16 17:17:52.000000000","message":"I\u0027m actually a little confused by this comment.  If you look at the change linked from the bug, it\u0027s removing a bunch of things registered above, in addition to the ones registered in the call I moved.  And since that\u0027s pulling args from keystoneclient already, I\u0027m not sure this is referring to that at all.\n\nThat said, this is probably a bad place for the comment either way so I\u0027ll go ahead and move it up.  I just didn\u0027t want to move a comment I didn\u0027t understand, but it seems the consensus is that I should. :-)","commit_id":"f1deef310c6662608979d6003f01a41c9fec54c1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2033537f3c0c5c1185c68cc559abc31bdc12e7f7","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                                \u0027IRONIC_RETRY_INTERVAL\u0027,"},{"line_number":246,"context_line":"                                default\u003dstr(http.DEFAULT_RETRY_INTERVAL)))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # FIXME(gyee): this method should come from python-keystoneclient."},{"line_number":249,"context_line":"        # Will refactor this code once it is available."},{"line_number":250,"context_line":"        # https://bugs.launchpad.net/python-keystoneclient/+bug/1332337"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_cb8ca881","line":248,"in_reply_to":"fa32b979_de478b49","updated":"2015-06-16 17:58:09.000000000","message":"Well, that comment WAS added with that code [1], so even if it is nonsensical, it makes more sense to move it than to leave it here :)\n\n[1] https://github.com/openstack/python-ironicclient/commit/e3d356476be376ebd3dfb3e84f379e113e5efac7#diff-55352dad10508cb48d2a81f7493b2f1d","commit_id":"f1deef310c6662608979d6003f01a41c9fec54c1"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"abb49bdd6d8b9e1e092adf2e65eee54e64f13fb6","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # FIXME(gyee): this method should come from python-keystoneclient."},{"line_number":100,"context_line":"        # Will refactor this code once it is available."},{"line_number":101,"context_line":"        # https://bugs.launchpad.net/python-keystoneclient/+bug/1332337"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Register global Keystone args first so their defaults are respected."},{"line_number":104,"context_line":"        # See https://bugs.launchpad.net/python-ironicclient/+bug/1463581"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_4b02d870","line":101,"updated":"2015-06-16 18:05:13.000000000","message":"I believe it was correct to move this comment.  As the comment was added with the call as seen here:\n\n https://review.openstack.org/#/c/111175/7/ironicclient/shell.py","commit_id":"e6ae41c537fe8bec300937df5c4392816f60e426"}]}