)]}'
{"ironicclient/common/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3d74965756db80cf7253f81c40122279a09c4a81","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    params[\u0027detail\u0027] \u003d args.detail"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    fields_ \u003d args.fields[0] if args.fields else None"},{"line_number":171,"context_line":"    if fields_ is not None:"},{"line_number":172,"context_line":"        params[\u0027fields\u0027] \u003d fields_"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_01c02f7b","line":170,"updated":"2015-07-07 21:58:37.000000000","message":"I think I asked you in another patch, why the underscore in \u0027fields_\u0027 :)","commit_id":"21595c0c9a12075129db2922e4a7681477a7cd00"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e58247db388e80e9f04d535e47503e5851740cc7","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    params[\u0027detail\u0027] \u003d args.detail"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    fields_ \u003d args.fields[0] if args.fields else None"},{"line_number":171,"context_line":"    if fields_ is not None:"},{"line_number":172,"context_line":"        params[\u0027fields\u0027] \u003d fields_"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_a57a9aef","line":170,"in_reply_to":"ba3cc151_01c02f7b","updated":"2015-07-08 09:36:09.000000000","message":"yeah that\u0027s because \"fields\" is a parameter for this function already, so to not conflict with it I appended a trailing underscore. I could change the name tho, something like \"resource_fields\" idk....","commit_id":"21595c0c9a12075129db2922e4a7681477a7cd00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3d74965756db80cf7253f81c40122279a09c4a81","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    invalid_attr \u003d set(fields) - set(valid_fields)"},{"line_number":302,"context_line":"    if invalid_attr:"},{"line_number":303,"context_line":"        raise exc.CommandError(\u0027Invalid field(s): %s \u0027 %"},{"line_number":304,"context_line":"                               \u0027, \u0027.join(invalid_attr))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_61057bc0","line":303,"updated":"2015-07-07 21:58:37.000000000","message":"For consistency with the other exceptions raised in this file, maybe use _().\n\nThere\u0027s a blank space at the end of this string -- did we need it?","commit_id":"21595c0c9a12075129db2922e4a7681477a7cd00"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e58247db388e80e9f04d535e47503e5851740cc7","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    invalid_attr \u003d set(fields) - set(valid_fields)"},{"line_number":302,"context_line":"    if invalid_attr:"},{"line_number":303,"context_line":"        raise exc.CommandError(\u0027Invalid field(s): %s \u0027 %"},{"line_number":304,"context_line":"                               \u0027, \u0027.join(invalid_attr))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_453e2e29","line":303,"in_reply_to":"ba3cc151_61057bc0","updated":"2015-07-08 09:36:09.000000000","message":"++ for i18n\n\nNo the empty space is not needed, will be removed","commit_id":"21595c0c9a12075129db2922e4a7681477a7cd00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"82a73d150c7146250daa5489447a4f44d08e0a41","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    params[\u0027detail\u0027] \u003d args.detail"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    requested_fields \u003d args.fields[0] if args.fields else None"},{"line_number":171,"context_line":"    if requested_fields is not None:"},{"line_number":172,"context_line":"        params[\u0027fields\u0027] \u003d requested_fields"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_47dff9d5","line":170,"updated":"2015-07-08 17:23:49.000000000","message":"This won\u0027t work, it breaks for eg \u0027ironic port-list\u0027.\n\nYou\u0027ll need to use eg \u0027hasattr(args, \u0027fields\u0027) for now.","commit_id":"61a0e69f866110f0ebb2ae02c253591bee2487f9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8b6436c600586a4a458d08a5789b4d9ab9530dee","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    params[\u0027detail\u0027] \u003d args.detail"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    requested_fields \u003d args.fields[0] if args.fields else None"},{"line_number":171,"context_line":"    if requested_fields is not None:"},{"line_number":172,"context_line":"        params[\u0027fields\u0027] \u003d requested_fields"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_182ceeaa","line":170,"in_reply_to":"ba3cc151_47dff9d5","updated":"2015-07-08 18:29:52.000000000","message":"Oh great catch!","commit_id":"61a0e69f866110f0ebb2ae02c253591bee2487f9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2e95a2d20514e76b7b95de99f9bb892e0f3411b3","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    invalid_attr \u003d set(fields) - set(valid_fields)"},{"line_number":303,"context_line":"    if invalid_attr:"},{"line_number":304,"context_line":"        raise exc.CommandError(_(\u0027Invalid field(s): %s\u0027) %"},{"line_number":305,"context_line":"                               \u0027, \u0027.join(invalid_attr))"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_760e2a3c","line":305,"updated":"2015-07-09 17:27:57.000000000","message":"I was thinking that we might want to mention valid fields. Eg, \u0027Valid values are: %(valid)s\u0027 % \u0027, \u0027.join(valid_fields).","commit_id":"0d8fa45b4b16cbd40d03a482e0debf03f5ee032a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5a38275ebdb27e32088eb91ac908c90c60dda10e","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    invalid_attr \u003d set(fields) - set(valid_fields)"},{"line_number":303,"context_line":"    if invalid_attr:"},{"line_number":304,"context_line":"        raise exc.CommandError(_(\u0027Invalid field(s): %s\u0027) %"},{"line_number":305,"context_line":"                               \u0027, \u0027.join(invalid_attr))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_19e5d236","line":305,"in_reply_to":"9a41bdd9_bbe3a2a3","updated":"2015-07-15 08:36:59.000000000","message":"I will update it on the patch set that is depending on this one","commit_id":"0d8fa45b4b16cbd40d03a482e0debf03f5ee032a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ac47ac7cb5d8ddec89d774c54700143530f9e014","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    invalid_attr \u003d set(fields) - set(valid_fields)"},{"line_number":303,"context_line":"    if invalid_attr:"},{"line_number":304,"context_line":"        raise exc.CommandError(_(\u0027Invalid field(s): %s\u0027) %"},{"line_number":305,"context_line":"                               \u0027, \u0027.join(invalid_attr))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_bbe3a2a3","line":305,"in_reply_to":"ba3cc151_760e2a3c","updated":"2015-07-14 16:24:27.000000000","message":"+1","commit_id":"0d8fa45b4b16cbd40d03a482e0debf03f5ee032a"}],"ironicclient/tests/unit/test_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3d74965756db80cf7253f81c40122279a09c4a81","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.assertEqual(\u0027foo\u0027, utils.bool_argument_value(\u0027arg\u0027, \u0027ee\u0027,"},{"line_number":115,"context_line":"                         strict\u003dFalse, default\u003d\u0027foo\u0027))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_check_for_invalid_fiels(self):"},{"line_number":118,"context_line":"        self.assertIsNone(utils.check_for_invalid_fields("},{"line_number":119,"context_line":"                          [\u0027a\u0027, \u0027b\u0027], [\u0027a\u0027, \u0027b\u0027, \u0027c\u0027]))"},{"line_number":120,"context_line":"        # \u0027d\u0027 is not a valid field"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_612c9b4a","line":117,"updated":"2015-07-07 21:58:37.000000000","message":"s/fiels/fields/","commit_id":"21595c0c9a12075129db2922e4a7681477a7cd00"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e58247db388e80e9f04d535e47503e5851740cc7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.assertEqual(\u0027foo\u0027, utils.bool_argument_value(\u0027arg\u0027, \u0027ee\u0027,"},{"line_number":115,"context_line":"                         strict\u003dFalse, default\u003d\u0027foo\u0027))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_check_for_invalid_fiels(self):"},{"line_number":118,"context_line":"        self.assertIsNone(utils.check_for_invalid_fields("},{"line_number":119,"context_line":"                          [\u0027a\u0027, \u0027b\u0027], [\u0027a\u0027, \u0027b\u0027, \u0027c\u0027]))"},{"line_number":120,"context_line":"        # \u0027d\u0027 is not a valid field"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_658012c0","line":117,"in_reply_to":"ba3cc151_612c9b4a","updated":"2015-07-08 09:36:09.000000000","message":"Done","commit_id":"21595c0c9a12075129db2922e4a7681477a7cd00"}],"ironicclient/tests/unit/v1/test_chassis_shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba1de7c841946c8806f35c00fbf62df68b203021","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        args.sort_dir \u003d sort_dir"},{"line_number":32,"context_line":"        args.sort_key \u003d sort_key"},{"line_number":33,"context_line":"        args.detail \u003d detail"},{"line_number":34,"context_line":"        args.fields \u003d fields"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        return args"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_0138faec","line":34,"updated":"2015-07-08 19:11:34.000000000","message":"for consistency, etc, probably want to do a similar thing to test_port_shell.py","commit_id":"79caa8b0884ec7b2b2a1bb100aea0663cfc0f0a4"}],"ironicclient/tests/unit/v1/test_port_shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e1aba83d434ddedd9e8019370313d2c2c2c637cb","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _get_client_mock_args(self, address\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":89,"context_line":"                              sort_dir\u003dNone, sort_key\u003dNone, detail\u003dFalse,"},{"line_number":90,"context_line":"                              fields\u003dNone):"},{"line_number":91,"context_line":"        args \u003d mock.MagicMock()"},{"line_number":92,"context_line":"        args.address \u003d address"},{"line_number":93,"context_line":"        args.marker \u003d marker"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_e96866f7","line":90,"updated":"2015-07-08 16:45:43.000000000","message":"might be something in the code that I\u0027m not aware of (and am too lazy to try it out), but was wondering why this needed to be changed.","commit_id":"61a0e69f866110f0ebb2ae02c253591bee2487f9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"82a73d150c7146250daa5489447a4f44d08e0a41","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _get_client_mock_args(self, address\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":89,"context_line":"                              sort_dir\u003dNone, sort_key\u003dNone, detail\u003dFalse,"},{"line_number":90,"context_line":"                              fields\u003dNone):"},{"line_number":91,"context_line":"        args \u003d mock.MagicMock()"},{"line_number":92,"context_line":"        args.address \u003d address"},{"line_number":93,"context_line":"        args.marker \u003d marker"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_c75b0985","line":90,"in_reply_to":"ba3cc151_8cc6889a","updated":"2015-07-08 17:23:49.000000000","message":"Ohhh... good thing I asked then. It shouldn\u0027t be needed but it is cuz of the change in common/utils.py I think.","commit_id":"61a0e69f866110f0ebb2ae02c253591bee2487f9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8b6436c600586a4a458d08a5789b4d9ab9530dee","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _get_client_mock_args(self, address\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":89,"context_line":"                              sort_dir\u003dNone, sort_key\u003dNone, detail\u003dFalse,"},{"line_number":90,"context_line":"                              fields\u003dNone):"},{"line_number":91,"context_line":"        args \u003d mock.MagicMock()"},{"line_number":92,"context_line":"        args.address \u003d address"},{"line_number":93,"context_line":"        args.marker \u003d marker"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_580d963c","line":90,"in_reply_to":"ba3cc151_c75b0985","updated":"2015-07-08 18:29:52.000000000","message":"Done","commit_id":"61a0e69f866110f0ebb2ae02c253591bee2487f9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"65b0c92f1543bad76b8d473e7d4d407f87c85cf9","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _get_client_mock_args(self, address\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":89,"context_line":"                              sort_dir\u003dNone, sort_key\u003dNone, detail\u003dFalse,"},{"line_number":90,"context_line":"                              fields\u003dNone):"},{"line_number":91,"context_line":"        args \u003d mock.MagicMock()"},{"line_number":92,"context_line":"        args.address \u003d address"},{"line_number":93,"context_line":"        args.marker \u003d marker"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_8cc6889a","line":90,"in_reply_to":"ba3cc151_e96866f7","updated":"2015-07-08 16:51:00.000000000","message":"I could just set \"args.fields \u003d None\" because it\u0027s needed when we do a node-port-list. But I added as a parameter already because the following patch which is adding --fields to the port CLI command will need it.\n\nSo it\u0027s like a plumbing.","commit_id":"61a0e69f866110f0ebb2ae02c253591bee2487f9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"eacc9c6072cb1bfc2c94f8137ed66d4318df4ee9","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _get_client_mock_args(self, address\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":89,"context_line":"                              sort_dir\u003dNone, sort_key\u003dNone, detail\u003dFalse):"},{"line_number":90,"context_line":"        args \u003d mock.MagicMock(spec\u003dTrue)"},{"line_number":91,"context_line":"        args.address \u003d address"},{"line_number":92,"context_line":"        args.marker \u003d marker"},{"line_number":93,"context_line":"        args.limit \u003d limit"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_4175a295","line":90,"updated":"2015-07-08 18:54:34.000000000","message":"spec \u003d True otherwise:\n\n In [2]: args \u003d mock.MagicMock()\n\n In [3]: args.fields\n Out[3]: \u003cMagicMock name\u003d\u0027mock.fields\u0027 id\u003d\u002716475600\u0027\u003e\n\n In [4]: hasattr(args, \u0027fields\u0027)\n Out[4]: True\n\n In [5]: args \u003d mock.MagicMock(spec\u003dTrue)\n\n In [7]: hasattr(args, \u0027fields\u0027)\n Out[7]: False","commit_id":"79caa8b0884ec7b2b2a1bb100aea0663cfc0f0a4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba1de7c841946c8806f35c00fbf62df68b203021","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _get_client_mock_args(self, address\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":89,"context_line":"                              sort_dir\u003dNone, sort_key\u003dNone, detail\u003dFalse):"},{"line_number":90,"context_line":"        args \u003d mock.MagicMock(spec\u003dTrue)"},{"line_number":91,"context_line":"        args.address \u003d address"},{"line_number":92,"context_line":"        args.marker \u003d marker"},{"line_number":93,"context_line":"        args.limit \u003d limit"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_81908aee","line":90,"in_reply_to":"ba3cc151_4175a295","updated":"2015-07-08 19:11:34.000000000","message":"ha ha. mock is so magical :-)","commit_id":"79caa8b0884ec7b2b2a1bb100aea0663cfc0f0a4"}],"ironicclient/v1/node_shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3d74965756db80cf7253f81c40122279a09c4a81","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \u0027--fields\u0027,"},{"line_number":49,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":50,"context_line":"    dest\u003d\u0027fields\u0027,"},{"line_number":51,"context_line":"    metavar\u003d\u0027\u003cfield\u003e\u0027,"},{"line_number":52,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":53,"context_line":"    default\u003d[],"},{"line_number":54,"context_line":"    help\u003d\"A subset of the node fields as a list. Only the fields \""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_21e8d37b","line":51,"updated":"2015-07-07 21:58:37.000000000","message":"s/field/fields/\n\nyou\u0027re thinking they\u0027ll do something like \u0027ironic node-show \u003cid\u003e --fields name,provision_state\u0027\n\nnot \u0027ironic node-show \u003cid\u003e --fields name --fields provision_state\u0027","commit_id":"21595c0c9a12075129db2922e4a7681477a7cd00"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e58247db388e80e9f04d535e47503e5851740cc7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \u0027--fields\u0027,"},{"line_number":49,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":50,"context_line":"    dest\u003d\u0027fields\u0027,"},{"line_number":51,"context_line":"    metavar\u003d\u0027\u003cfield\u003e\u0027,"},{"line_number":52,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":53,"context_line":"    default\u003d[],"},{"line_number":54,"context_line":"    help\u003d\"A subset of the node fields as a list. Only the fields \""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_c566be50","line":51,"in_reply_to":"ba3cc151_21e8d37b","updated":"2015-07-08 09:36:09.000000000","message":"The way this library works with nargs\u003d\u0027+\u0027 is:\n\nironic node-show \u003cuuid\u003e --fields uuid provision_state power_state","commit_id":"21595c0c9a12075129db2922e4a7681477a7cd00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53ab8446e64cc9b43ad614496debb27b3181212c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \u0027--fields\u0027,"},{"line_number":49,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":50,"context_line":"    dest\u003d\u0027fields\u0027,"},{"line_number":51,"context_line":"    metavar\u003d\u0027\u003cfields\u003e\u0027,"},{"line_number":52,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":53,"context_line":"    default\u003d[],"},{"line_number":54,"context_line":"    help\u003d\"A subset of the node fields as a list. Only the fields \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_92f788d2","line":51,"updated":"2015-07-08 14:53:31.000000000","message":"Sorry, Lucas, I thought it was one list of fields, comma-separated. It can be one or more fields separated by spaces, so what you had before \u0027\u003cfield\u003e\u0027 is correct. Cuz with this, help shows \u0027--fields \u003cfields\u003e [\u003cfields\u003e ...]\u0027 :-(","commit_id":"cfe77e8d0f7072935730d30fdd696206683323cc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8e99539aa76f133fc38ad5a0357d5c59b8c64997","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \u0027--fields\u0027,"},{"line_number":49,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":50,"context_line":"    dest\u003d\u0027fields\u0027,"},{"line_number":51,"context_line":"    metavar\u003d\u0027\u003cfields\u003e\u0027,"},{"line_number":52,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":53,"context_line":"    default\u003d[],"},{"line_number":54,"context_line":"    help\u003d\"A subset of the node fields as a list. Only the fields \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_d34aef82","line":51,"in_reply_to":"ba3cc151_92f788d2","updated":"2015-07-08 16:16:38.000000000","message":"Oh true! Will fix","commit_id":"cfe77e8d0f7072935730d30fdd696206683323cc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53ab8446e64cc9b43ad614496debb27b3181212c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":53,"context_line":"    default\u003d[],"},{"line_number":54,"context_line":"    help\u003d\"A subset of the node fields as a list. Only the fields \""},{"line_number":55,"context_line":"          \"specified by this option will be fetched from the server.\")"},{"line_number":56,"context_line":"def do_node_show(cc, args):"},{"line_number":57,"context_line":"    \"\"\"Show detailed information about a node.\"\"\""},{"line_number":58,"context_line":"    fields \u003d args.fields[0] if args.fields else None"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_52d580e2","line":55,"updated":"2015-07-08 14:53:31.000000000","message":"I think \u0027as a list\u0027 might be confusing; I thought it meant comma-separated and/or \u0027[field1, field2]\u0027. On the other hand, this only shows up when you do help, so you can see that it is \u0027--fields \u003cfields\u003e [\u003cfields\u003e ...]\u0027. But anyway, how about something like \u0027One or more node fields. Only these fields will be fetched from the server.\u0027\n\nOr what about \u0027The node fields to be fetched from the server\u0027. Or \u0027One or more node fields to be fetched from the server\u0027.\n\nI wonder if we also want to mention the default -- to fetch \"all\" fields. [Which would be hard to phrase correctly for node-list.]","commit_id":"cfe77e8d0f7072935730d30fdd696206683323cc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8e99539aa76f133fc38ad5a0357d5c59b8c64997","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":53,"context_line":"    default\u003d[],"},{"line_number":54,"context_line":"    help\u003d\"A subset of the node fields as a list. Only the fields \""},{"line_number":55,"context_line":"          \"specified by this option will be fetched from the server.\")"},{"line_number":56,"context_line":"def do_node_show(cc, args):"},{"line_number":57,"context_line":"    \"\"\"Show detailed information about a node.\"\"\""},{"line_number":58,"context_line":"    fields \u003d args.fields[0] if args.fields else None"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_d69bbdc7","line":55,"in_reply_to":"ba3cc151_52d580e2","updated":"2015-07-08 16:16:38.000000000","message":"I like the \"One or more node fields. Only these fields will be fetched from the server.\" \n\nThanks for the suggestions, I will update the patch.","commit_id":"cfe77e8d0f7072935730d30fdd696206683323cc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53ab8446e64cc9b43ad614496debb27b3181212c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    default\u003d[],"},{"line_number":111,"context_line":"    help\u003d\"A subset of the node fields as a list. Only the fields \""},{"line_number":112,"context_line":"          \"specified by this option will be fetched from the server. \""},{"line_number":113,"context_line":"          \"Can not be used when \u0027detail\u0027 is set.\")"},{"line_number":114,"context_line":"def do_node_list(cc, args):"},{"line_number":115,"context_line":"    \"\"\"List the nodes which are registered with the Ironic service.\"\"\""},{"line_number":116,"context_line":"    params \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_b2316c5b","line":113,"updated":"2015-07-08 14:53:31.000000000","message":"maybe s/set/specified/\n\nOr\n\ns/\u0027detail\u0027 is set/\u0027--detail\u0027 is specified/","commit_id":"cfe77e8d0f7072935730d30fdd696206683323cc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8e99539aa76f133fc38ad5a0357d5c59b8c64997","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    default\u003d[],"},{"line_number":111,"context_line":"    help\u003d\"A subset of the node fields as a list. Only the fields \""},{"line_number":112,"context_line":"          \"specified by this option will be fetched from the server. \""},{"line_number":113,"context_line":"          \"Can not be used when \u0027detail\u0027 is set.\")"},{"line_number":114,"context_line":"def do_node_list(cc, args):"},{"line_number":115,"context_line":"    \"\"\"List the nodes which are registered with the Ironic service.\"\"\""},{"line_number":116,"context_line":"    params \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_d3318f0c","line":113,"in_reply_to":"ba3cc151_b2316c5b","updated":"2015-07-08 16:16:38.000000000","message":"Done","commit_id":"cfe77e8d0f7072935730d30fdd696206683323cc"}]}