)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"ce25045fb833034e6cdcf8ed5dab139fc30aaf0a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-11-04 08:25:45 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add provision state command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I82f17397c69edc973e79d9c5ae543d9ccbb0325a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"da85f559_d9a6b952","line":8,"updated":"2015-11-10 14:25:45.000000000","message":"Can you add more description on the message?","commit_id":"9445c9ee22e88e854e4d6c691948aca223e83739"}],"ironicclient/osc/v1/baremetal.py":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"78ccb2140095732d764954a3df63a2d4c55d3883","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            properties \u003d []"},{"line_number":314,"context_line":"            properties \u003d utils.args_array_to_patch("},{"line_number":315,"context_line":"                \u0027add\u0027, parsed_args.property)"},{"line_number":316,"context_line":"            node \u003d baremetal_client.node.update(parsed_args.node, properties)._info"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        if parsed_args.provision_state:"},{"line_number":319,"context_line":"            if (parsed_args.config_drive and"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_f071bde1","line":316,"updated":"2015-08-17 15:01:13.000000000","message":"this line is too long (83 \u003e 79 characters)","commit_id":"49bc3a9aeed3da0149170d2f99c8b7ec1ab9a501"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"93a1ef3abad318c5fd113c6a661fb45ff9969d94","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            action\u003d\u0027store_const\u0027,"},{"line_number":291,"context_line":"            const\u003d\u0027manage\u0027,"},{"line_number":292,"context_line":"            dest\u003d\u0027provision_state\u0027"},{"line_number":293,"context_line":"        )"},{"line_number":294,"context_line":"        parser.add_argument("},{"line_number":295,"context_line":"            \u0027--config-drive\u0027,"},{"line_number":296,"context_line":"            metavar\u003d\u0027\u003cconfig-drive\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_74e996b6","line":293,"updated":"2015-09-23 12:33:56.000000000","message":"please add --abort, we\u0027ve landed it recently","commit_id":"362adfe0029a47ae72fe1e5316df4f357b88b364"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e54f28b6df0f624f7cf43f4f682786e142103b9c","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        if parsed_args.property:"},{"line_number":379,"context_line":"            properties \u003d []"},{"line_number":380,"context_line":"            properties \u003d utils.args_array_to_patch("},{"line_number":381,"context_line":"                \u0027add\u0027, parsed_args.property)"},{"line_number":382,"context_line":"            baremetal_client.node.update("}],"source_content_type":"text/x-python","patch_set":12,"id":"3a29b11f_1de4f3de","line":379,"updated":"2015-10-21 15:03:21.000000000","message":"this change looks unrelated","commit_id":"524b174f9de14093aef16bb23dbf70cc05d713cd"}],"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"42d54d22bf90583c8f223a82040758eea116cff2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        configdrive \u003d (parsed_args.config_drive if parsed_args.config_drive"},{"line_number":53,"context_line":"                       else None)"},{"line_number":54,"context_line":"        baremetal_client.node.set_provision_state("},{"line_number":55,"context_line":"            parsed_args.node,"},{"line_number":56,"context_line":"            parsed_args.provision_state,"}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_baadd832","line":53,"updated":"2016-06-14 15:18:04.000000000","message":"this should not be in the base class, as configdrive is only used by the deploy command","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        configdrive \u003d (parsed_args.config_drive if parsed_args.config_drive"},{"line_number":53,"context_line":"                       else None)"},{"line_number":54,"context_line":"        baremetal_client.node.set_provision_state("},{"line_number":55,"context_line":"            parsed_args.node,"},{"line_number":56,"context_line":"            parsed_args.provision_state,"}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_8e3a1ccc","line":53,"in_reply_to":"7aa08908_527e3f19","updated":"2016-06-20 13:03:24.000000000","message":"The only subclass that actually passes configdrive is the deploy command. Otherwise, I would have to duplicate this code in the deploy class... I can do that if you feel really strongly about this, but really this makes the code generic and DRY.","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        configdrive \u003d (parsed_args.config_drive if parsed_args.config_drive"},{"line_number":53,"context_line":"                       else None)"},{"line_number":54,"context_line":"        baremetal_client.node.set_provision_state("},{"line_number":55,"context_line":"            parsed_args.node,"},{"line_number":56,"context_line":"            parsed_args.provision_state,"}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_527e3f19","line":53,"in_reply_to":"7aa08908_baadd832","updated":"2016-06-15 02:18:13.000000000","message":"++","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class AbortBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":61,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027abort\u0027\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    log \u003d logging.getLogger(__name__ + \".AbortBaremetalNode\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_d2618f3a","line":61,"updated":"2016-06-15 02:18:13.000000000","message":"s/system/node/","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class AbortBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":61,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027abort\u0027\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    log \u003d logging.getLogger(__name__ + \".AbortBaremetalNode\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_ee864064","line":61,"in_reply_to":"7aa08908_d2618f3a","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7d82a5b51cff03b4dbe71eb306c170ecbd15c836","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def get_parser(self, prog_name):"},{"line_number":66,"context_line":"        parser \u003d super(AbortBaremetalNode, self).get_parser(prog_name)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":70,"context_line":"            default\u003d\u0027abort\u0027,"},{"line_number":71,"context_line":"            required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_1fb9497a","line":68,"updated":"2016-06-15 12:59:21.000000000","message":"I don\u0027t really like this hidden argument, it makes it possible to do \n\n openstack baremetal node deploy node-0 --provision-state abort\n\nand abort will be called. Maybe some class attribute can be introduced that will be set in each class defining an action...","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def get_parser(self, prog_name):"},{"line_number":66,"context_line":"        parser \u003d super(AbortBaremetalNode, self).get_parser(prog_name)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":70,"context_line":"            default\u003d\u0027abort\u0027,"},{"line_number":71,"context_line":"            required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_89ce9681","line":68,"in_reply_to":"7aa08908_1fb9497a","updated":"2016-06-20 13:03:24.000000000","message":"I\u0027ve kept the hidden argument, but added choices to be a single choice. So the parser won\u0027t allow anything else. I\u0027ve also moved this into the base class, and each subclass specifies what the command is.","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class CleanBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":77,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027clean\u0027\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    log \u003d logging.getLogger(__name__ + \".CleanBaremetalNode\")"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_b27de3e8","line":77,"updated":"2016-06-15 02:18:13.000000000","message":"s/system/node/","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class CleanBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":77,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027clean\u0027\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    log \u003d logging.getLogger(__name__ + \".CleanBaremetalNode\")"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_eea5a0b5","line":77,"in_reply_to":"7aa08908_b27de3e8","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"42d54d22bf90583c8f223a82040758eea116cff2","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(CleanBaremetalNode, self).get_parser(prog_name)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        parser.add_argument("},{"line_number":85,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":86,"context_line":"            default\u003d\u0027clean\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_1aa98c24","line":83,"updated":"2016-06-14 15:18:04.000000000","message":"the mandatory clean-steps argument missing","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(CleanBaremetalNode, self).get_parser(prog_name)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        parser.add_argument("},{"line_number":85,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":86,"context_line":"            default\u003d\u0027clean\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_4eab148a","line":83,"in_reply_to":"7aa08908_05a3cf00","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(CleanBaremetalNode, self).get_parser(prog_name)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        parser.add_argument("},{"line_number":85,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":86,"context_line":"            default\u003d\u0027clean\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_05a3cf00","line":83,"in_reply_to":"7aa08908_1aa98c24","updated":"2016-06-15 02:18:13.000000000","message":"++","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class DeployBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":218,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027deploy\u0027\"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    log \u003d logging.getLogger(__name__ + \".DeployBaremetalNode\")"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_3251f362","line":218,"updated":"2016-06-15 02:18:13.000000000","message":"s/system/node/","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class DeployBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":218,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027deploy\u0027\"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    log \u003d logging.getLogger(__name__ + \".DeployBaremetalNode\")"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_aec1d830","line":218,"in_reply_to":"7aa08908_3251f362","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                  \"directory containing the config drive files. In case it\u0027s \""},{"line_number":237,"context_line":"                  \"a directory, a config drive will be generated from it. \""},{"line_number":238,"context_line":"                  \"This parameter is only valid when setting provision state \""},{"line_number":239,"context_line":"                  \"to \u0027active\u0027.\"))"},{"line_number":240,"context_line":"        return parser"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_92042718","line":239,"updated":"2016-06-15 02:18:13.000000000","message":"They are setting the state to active here, so no need for this last sentence.","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                  \"directory containing the config drive files. In case it\u0027s \""},{"line_number":237,"context_line":"                  \"a directory, a config drive will be generated from it. \""},{"line_number":238,"context_line":"                  \"This parameter is only valid when setting provision state \""},{"line_number":239,"context_line":"                  \"to \u0027active\u0027.\"))"},{"line_number":240,"context_line":"        return parser"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_ee080094","line":239,"in_reply_to":"7aa08908_92042718","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class InspectBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":244,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027inspect\u0027\"\"\""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    log \u003d logging.getLogger(__name__ + \".InspectBaremetalNode\")"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_b2cb231d","line":244,"updated":"2016-06-15 02:18:13.000000000","message":"s/system/node/","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class InspectBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":244,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027inspect\u0027\"\"\""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    log \u003d logging.getLogger(__name__ + \".InspectBaremetalNode\")"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_2e032875","line":244,"in_reply_to":"7aa08908_b2cb231d","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"class ManageBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":386,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027manage\u0027\"\"\""},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    log \u003d logging.getLogger(__name__ + \".ManageBaremetalNode\")"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_f2d12bcd","line":386,"updated":"2016-06-15 02:18:13.000000000","message":"s/system/node/","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"class ManageBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":386,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027manage\u0027\"\"\""},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    log \u003d logging.getLogger(__name__ + \".ManageBaremetalNode\")"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_8ef85c7e","line":386,"in_reply_to":"7aa08908_f2d12bcd","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"class ProvideBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":432,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027provide\u0027\"\"\""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    log \u003d logging.getLogger(__name__ + \".ProvideBaremetalNode\")"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_32d8d3ee","line":432,"updated":"2016-06-15 02:18:13.000000000","message":"s/system/node/","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"class ProvideBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":432,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027provide\u0027\"\"\""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    log \u003d logging.getLogger(__name__ + \".ProvideBaremetalNode\")"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_6ef53082","line":432,"in_reply_to":"7aa08908_32d8d3ee","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"class RebuildBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":472,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027rebuild\u0027\"\"\""},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    log \u003d logging.getLogger(__name__ + \".RebuildBaremetalNode\")"},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_92e387a3","line":472,"updated":"2016-06-15 02:18:13.000000000","message":"s/system/node/","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"class RebuildBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":472,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027rebuild\u0027\"\"\""},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    log \u003d logging.getLogger(__name__ + \".RebuildBaremetalNode\")"},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_aeef18af","line":472,"in_reply_to":"7aa08908_92e387a3","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"class UndeployBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":660,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027deleted\u0027\"\"\""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    log \u003d logging.getLogger(__name__ + \".UndeployBaremetalNode\")"},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_d2efcf84","line":660,"updated":"2016-06-15 02:18:13.000000000","message":"s/system/node/","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"class UndeployBaremetalNode(ProvisionStateBaremetalNode):"},{"line_number":660,"context_line":"    \"\"\"Set provision state of baremetal system to \u0027deleted\u0027\"\"\""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    log \u003d logging.getLogger(__name__ + \".UndeployBaremetalNode\")"},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_0e2bccec","line":660,"in_reply_to":"7aa08908_d2efcf84","updated":"2016-06-20 13:03:24.000000000","message":"Done","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c467cd461dde06589b2a3783d660d1f6c0905d36","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        configdrive \u003d (parsed_args.config_drive if parsed_args.config_drive"},{"line_number":59,"context_line":"                       else None)"},{"line_number":60,"context_line":"        baremetal_client.node.set_provision_state("},{"line_number":61,"context_line":"            parsed_args.node,"},{"line_number":62,"context_line":"            parsed_args.provision_state,"}],"source_content_type":"text/x-python","patch_set":37,"id":"5a9d85d2_290af4d2","line":59,"updated":"2016-06-20 16:56:47.000000000","message":"this class does not define args.config_driver and should not use them. this also breaks all the commands except for deploy one.","commit_id":"471a4784e08ba9fb4f562bb19796068040520407"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"16be85f4aa3de2ec6405f9e12f7b7af9dc63d39a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        configdrive \u003d (parsed_args.config_drive if parsed_args.config_drive"},{"line_number":59,"context_line":"                       else None)"},{"line_number":60,"context_line":"        baremetal_client.node.set_provision_state("},{"line_number":61,"context_line":"            parsed_args.node,"},{"line_number":62,"context_line":"            parsed_args.provision_state,"}],"source_content_type":"text/x-python","patch_set":37,"id":"5a9d85d2_0e3bb5d2","line":59,"in_reply_to":"5a9d85d2_290af4d2","updated":"2016-06-20 19:18:36.000000000","message":"Done","commit_id":"471a4784e08ba9fb4f562bb19796068040520407"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"44afcba58fd321fd1310c0b2a3ee52604a4a82f3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    except Exception as e:"},{"line_number":45,"context_line":"        err \u003d _(\"Cannot get %(desc)s from standard input. Error: %(err)s\")"},{"line_number":46,"context_line":"        raise exc.InvalidAttribute(err % {\u0027desc\u0027: info_desc, \u0027err\u0027: e})"},{"line_number":47,"context_line":"    return info"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def _handle_json_or_file_arg(json_arg):"}],"source_content_type":"text/x-python","patch_set":38,"id":"3aaa91ec_e493104e","line":47,"updated":"2016-06-21 21:58:05.000000000","message":"This is a copy of https://github.com/openstack/python-ironicclient/blob/7dcb05a5e59991e48e376af8c2fef46bfeb4aca0/ironicclient/v1/node_shell.py#L38","commit_id":"3f6dec5b4afc472a370fc8a45d6878d7ddf0542e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"44afcba58fd321fd1310c0b2a3ee52604a4a82f3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"               {\u0027err\u0027: e, \u0027string\u0027: json_arg})"},{"line_number":72,"context_line":"        raise exc.InvalidAttribute(err)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    return json_arg"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class ProvisionStateBaremetalNode(command.Command):"}],"source_content_type":"text/x-python","patch_set":38,"id":"3aaa91ec_64c72046","line":74,"updated":"2016-06-21 21:58:05.000000000","message":"This is a copy of https://github.com/openstack/python-ironicclient/blob/7dcb05a5e59991e48e376af8c2fef46bfeb4aca0/ironicclient/v1/node_shell.py#L53","commit_id":"3f6dec5b4afc472a370fc8a45d6878d7ddf0542e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"44afcba58fd321fd1310c0b2a3ee52604a4a82f3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                  \"should be a list of clean-step dictionaries; each \""},{"line_number":132,"context_line":"                  \"dictionary should have keys \u0027interface\u0027 and \u0027step\u0027, and \""},{"line_number":133,"context_line":"                  \"optional key \u0027args\u0027. This argument must be specified (and \""},{"line_number":134,"context_line":"                  \"is only valid) when setting provision-state to \u0027clean\u0027.\"))"},{"line_number":135,"context_line":"        return parser"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":38,"id":"3aaa91ec_84aface2","line":134,"updated":"2016-06-21 21:58:05.000000000","message":"Don\u0027t need the \u0027This argument must be ...\u0027 because this is for \u0027clean\u0027.\n\nAnd we can add required\u003dTrue instead.","commit_id":"3f6dec5b4afc472a370fc8a45d6878d7ddf0542e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a2e69c7fd485b5f8255910346350a8dba23a38ef","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        configdrive \u003d (parsed_args.config_drive if parsed_args.config_drive"},{"line_number":258,"context_line":"                       else None)"},{"line_number":259,"context_line":"        baremetal_client.node.set_provision_state("},{"line_number":260,"context_line":"            parsed_args.node,"}],"source_content_type":"text/x-python","patch_set":40,"id":"3aaa91ec_ece5cbdc","line":257,"updated":"2016-06-27 12:20:31.000000000","message":"It\u0027s already None by default, why not just pass it as is?","commit_id":"77e543779fa23d088654d64c932bef5b1c7044dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5817b8d7748f90c37f02fb5f3e4410b3636af548","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        configdrive \u003d (parsed_args.config_drive if parsed_args.config_drive"},{"line_number":258,"context_line":"                       else None)"},{"line_number":259,"context_line":"        baremetal_client.node.set_provision_state("},{"line_number":260,"context_line":"            parsed_args.node,"}],"source_content_type":"text/x-python","patch_set":40,"id":"3aaa91ec_8df5facc","line":257,"in_reply_to":"3aaa91ec_e62322a6","updated":"2016-06-28 02:28:38.000000000","message":"I wasn\u0027t sure if/when Brad would get to this, so I did it in https://review.openstack.org/334735.","commit_id":"77e543779fa23d088654d64c932bef5b1c7044dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"83fc0ce83873dc9a5062aee8a45847a51baeae84","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        configdrive \u003d (parsed_args.config_drive if parsed_args.config_drive"},{"line_number":258,"context_line":"                       else None)"},{"line_number":259,"context_line":"        baremetal_client.node.set_provision_state("},{"line_number":260,"context_line":"            parsed_args.node,"}],"source_content_type":"text/x-python","patch_set":40,"id":"3aaa91ec_e62322a6","line":257,"in_reply_to":"3aaa91ec_ece5cbdc","updated":"2016-06-27 13:27:25.000000000","message":"Yes, good point. It\u0027d be good to clean this up.","commit_id":"77e543779fa23d088654d64c932bef5b1c7044dc"}],"ironicclient/tests/unit/osc/v1/test_baremetal.py":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"78ccb2140095732d764954a3df63a2d4c55d3883","unresolved":false,"context_lines":[{"line_number":447,"context_line":"             {\u0027path\u0027: \u0027/other/path\u0027, \u0027value\u0027: \u0027value2\u0027, \u0027op\u0027: \u0027add\u0027}]"},{"line_number":448,"context_line":"        )"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"class TestBaremetalShow(TestBaremetal):"},{"line_number":452,"context_line":"    def setUp(self):"},{"line_number":453,"context_line":"        super(TestBaremetalShow, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_d011195f","side":"PARENT","line":450,"updated":"2015-08-17 15:01:13.000000000","message":"too many blank lines","commit_id":"b6ec217d9abdcd4879c0b704d9f427aac11e11fe"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"78ccb2140095732d764954a3df63a2d4c55d3883","unresolved":false,"context_lines":[{"line_number":476,"context_line":"                          self.check_parser,"},{"line_number":477,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"class TestBaremetalShow(TestBaremetal):"},{"line_number":481,"context_line":"    def setUp(self):"},{"line_number":482,"context_line":"        super(TestBaremetalShow, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_50066921","line":479,"updated":"2015-08-17 15:01:13.000000000","message":"too many blank lines","commit_id":"49bc3a9aeed3da0149170d2f99c8b7ec1ab9a501"}],"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a76a3f5b1c29dc19b0d7217236c2d8a3e3bbb950","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            \u0027node_uuid\u0027, \u0027off\u0027)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"class TestDeployBaremetalProvisionState(TestBaremetal):"},{"line_number":555,"context_line":"    def setUp(self):"},{"line_number":556,"context_line":"        super(TestDeployBaremetalProvisionState, self).setUp()"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7aa08908_25936ba4","line":554,"updated":"2016-06-15 02:18:13.000000000","message":"You only have this test. What about for the other provision states? (I know, is it worth adding these sorts of tests for all of them...)","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"de9bcca53d9a7a13ce581c54a4c4ba7eced9431d","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            \u0027node_uuid\u0027, \u0027off\u0027)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"class TestDeployBaremetalProvisionState(TestBaremetal):"},{"line_number":555,"context_line":"    def setUp(self):"},{"line_number":556,"context_line":"        super(TestDeployBaremetalProvisionState, self).setUp()"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a9d85d2_09b626dc","line":554,"in_reply_to":"7aa08908_25936ba4","updated":"2016-06-20 13:03:24.000000000","message":"Not really, no.","commit_id":"efa38b3b5296bffcd4a5229fc36394a0dc0417ed"}],"releasenotes/notes/osc-plugin-ff0d897d8441a9e1.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89c81b86dfef4b458147f3595327bf0da4294c5d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the OpenStackClient plugin with new commands:"},{"line_number":5,"context_line":"    * openstack baremetal node abort"},{"line_number":6,"context_line":"    * openstack baremetal node clean"},{"line_number":7,"context_line":"    * openstack baremetal node create"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3aaa91ec_0d282332","line":4,"updated":"2016-06-27 06:51:41.000000000","message":"idea for a follow-up: I think a newline is needed here, otherwise it does not render","commit_id":"77a7108294ed9960d861f51bebaff8f345e99b3c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"2059a7aa2a4cad97a6aab5b8120cec5cab25c143","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the OpenStackClient plugin with new commands:"},{"line_number":5,"context_line":"    * openstack baremetal node abort"},{"line_number":6,"context_line":"    * openstack baremetal node clean"},{"line_number":7,"context_line":"    * openstack baremetal node create"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3aaa91ec_bb913a49","line":4,"in_reply_to":"3aaa91ec_0d282332","updated":"2016-06-27 11:30:42.000000000","message":"Done","commit_id":"77a7108294ed9960d861f51bebaff8f345e99b3c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89c81b86dfef4b458147f3595327bf0da4294c5d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    * openstack baremetal port create"},{"line_number":22,"context_line":"deprecations:"},{"line_number":23,"context_line":"  - |"},{"line_number":24,"context_line":"    Deprecating the following commands in favor of the new commands:"},{"line_number":25,"context_line":"    * openstack baremetal create"},{"line_number":26,"context_line":"    * openstack baremetal delete"},{"line_number":27,"context_line":"    * openstack baremetal list"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3aaa91ec_6d23a756","line":24,"updated":"2016-06-27 06:51:41.000000000","message":"ditto","commit_id":"77a7108294ed9960d861f51bebaff8f345e99b3c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"2059a7aa2a4cad97a6aab5b8120cec5cab25c143","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    * openstack baremetal port create"},{"line_number":22,"context_line":"deprecations:"},{"line_number":23,"context_line":"  - |"},{"line_number":24,"context_line":"    Deprecating the following commands in favor of the new commands:"},{"line_number":25,"context_line":"    * openstack baremetal create"},{"line_number":26,"context_line":"    * openstack baremetal delete"},{"line_number":27,"context_line":"    * openstack baremetal list"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3aaa91ec_9b943e37","line":24,"in_reply_to":"3aaa91ec_6d23a756","updated":"2016-06-27 11:30:42.000000000","message":"Done","commit_id":"77a7108294ed9960d861f51bebaff8f345e99b3c"}]}
