)]}'
{"ironicclient/common/http.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"bf9e39ca0475bbc6e3c0ea126e082df3e0365ad5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import socket"},{"line_number":24,"context_line":"import ssl"},{"line_number":25,"context_line":"import textwrap"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_d33b079b","line":22,"updated":"2015-10-07 16:04:59.000000000","message":"requests is not a built in library. Move it to next section.","commit_id":"fda31dafa2c696b733419a587697e340d44f2cd5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"bf9e39ca0475bbc6e3c0ea126e082df3e0365ad5","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        parts \u003d urlparse.urlparse(endpoint)"},{"line_number":214,"context_line":"        if parts.scheme \u003d\u003d \u0027https\u0027:"},{"line_number":215,"context_line":"            if kwargs.get(\u0027insecure\u0027, False) is True:"},{"line_number":216,"context_line":"                self.session.verify \u003d False"},{"line_number":217,"context_line":"            else:"},{"line_number":218,"context_line":"                if kwargs.get(\u0027cacert\u0027):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_d309c7de","line":215,"updated":"2015-10-07 16:04:59.000000000","message":"nit: False is not needed as None is returned for not-found and comparison still works.","commit_id":"fda31dafa2c696b733419a587697e340d44f2cd5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"bf9e39ca0475bbc6e3c0ea126e082df3e0365ad5","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                curl.append(\u0027 --cacert %s\u0027 % self.session.verify)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if self.session.cert:"},{"line_number":237,"context_line":"            curl.append(\u0027 --cert %s\u0027 % self.session.cert[0])"},{"line_number":238,"context_line":"            curl.append(\u0027 --key %s\u0027 % self.session.cert[1])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        if \u0027body\u0027 in kwargs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_1373bf4e","line":237,"updated":"2015-10-07 16:04:59.000000000","message":"Why leading space before -- ?","commit_id":"fda31dafa2c696b733419a587697e340d44f2cd5"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"ae66a07817d60ee3082f81e2f3bab8b770a16372","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                curl.append(\u0027 --cacert %s\u0027 % self.session.verify)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if self.session.cert:"},{"line_number":237,"context_line":"            curl.append(\u0027 --cert %s\u0027 % self.session.cert[0])"},{"line_number":238,"context_line":"            curl.append(\u0027 --key %s\u0027 % self.session.cert[1])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        if \u0027body\u0027 in kwargs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_5cf60afa","line":237,"in_reply_to":"7a2fa921_1373bf4e","updated":"2015-10-08 08:42:41.000000000","message":"missed, thanks","commit_id":"fda31dafa2c696b733419a587697e340d44f2cd5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"bf9e39ca0475bbc6e3c0ea126e082df3e0365ad5","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if self.session.cert:"},{"line_number":237,"context_line":"            curl.append(\u0027 --cert %s\u0027 % self.session.cert[0])"},{"line_number":238,"context_line":"            curl.append(\u0027 --key %s\u0027 % self.session.cert[1])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        if \u0027body\u0027 in kwargs:"},{"line_number":241,"context_line":"            curl.append(\u0027-d \\\u0027%s\\\u0027\u0027 % kwargs[\u0027body\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_739a3365","line":238,"updated":"2015-10-07 16:04:59.000000000","message":"Why leading space before -- ?","commit_id":"fda31dafa2c696b733419a587697e340d44f2cd5"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"923f5f4355dd4998cb646de986bc421208402802","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#             We still have a lot of work to do in the client to implement"},{"line_number":38,"context_line":"#             microversion support in the client properly! See"},{"line_number":39,"context_line":"#             http://specs.openstack.org/openstack/ironic-specs/specs/kilo/api-microversions.html # noqa"},{"line_number":40,"context_line":"#             for full details."},{"line_number":41,"context_line":"DEFAULT_VER \u003d \u00271.9\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da85f559_8f9348fa","line":40,"updated":"2015-11-09 11:03:38.000000000","message":"BTW, should we bump the DEFAULT_VER, the current is 1.14","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"0f8a24537212d60b0c78c0fbce789c12dc5b492d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#             We still have a lot of work to do in the client to implement"},{"line_number":38,"context_line":"#             microversion support in the client properly! See"},{"line_number":39,"context_line":"#             http://specs.openstack.org/openstack/ironic-specs/specs/kilo/api-microversions.html # noqa"},{"line_number":40,"context_line":"#             for full details."},{"line_number":41,"context_line":"DEFAULT_VER \u003d \u00271.9\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da85f559_e55eb544","line":40,"in_reply_to":"da85f559_8f9348fa","updated":"2015-11-09 11:52:08.000000000","message":"good question, AFAICC on API side only min ver is tested, and we don\u0027t test microversions on client side, so not sure about default here, we should discuss it","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5b43be0448cd6141371b1ee7f59dff18adf226d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        self.session \u003d requests.Session()"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        parts \u003d urlparse.urlparse(endpoint)"},{"line_number":214,"context_line":"        if parts.scheme \u003d\u003d \u0027https\u0027:"},{"line_number":215,"context_line":"            if kwargs.get(\u0027insecure\u0027) is True:"},{"line_number":216,"context_line":"                self.session.verify \u003d False"},{"line_number":217,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_05a90e7b","line":214,"updated":"2015-11-06 12:38:42.000000000","message":"This changes the behaviour, as previously it was raising EndpointException when scheme was not in (http, https).","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"24b461fd5911902545a53a6e7cee2211b8fe4a12","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        self.session \u003d requests.Session()"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        parts \u003d urlparse.urlparse(endpoint)"},{"line_number":214,"context_line":"        if parts.scheme \u003d\u003d \u0027https\u0027:"},{"line_number":215,"context_line":"            if kwargs.get(\u0027insecure\u0027) is True:"},{"line_number":216,"context_line":"                self.session.verify \u003d False"},{"line_number":217,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_3a731017","line":214,"in_reply_to":"fa80f949_05a90e7b","updated":"2015-11-06 14:25:09.000000000","message":"yep, will return it back","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5b43be0448cd6141371b1ee7f59dff18adf226d","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                self.session.verify \u003d False"},{"line_number":217,"context_line":"            else:"},{"line_number":218,"context_line":"                if kwargs.get(\u0027cacert\u0027):"},{"line_number":219,"context_line":"                    self.session.verify \u003d kwargs.get(\u0027cacert\u0027, True)"},{"line_number":220,"context_line":"            self.session.cert \u003d (kwargs.get(\u0027cert_file\u0027),"},{"line_number":221,"context_line":"                                 kwargs.get(\u0027key_file\u0027))"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_2523f257","line":219,"updated":"2015-11-06 12:38:42.000000000","message":"You\u0027ve already asserted that kwargs contains something in cacert, why not just do kwargs[\u0027cacert\u0027]? Or you meant just self.session.verify \u003d kwargs.get(\u0027cacert\u0027, True) without preceding if?","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"24b461fd5911902545a53a6e7cee2211b8fe4a12","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                self.session.verify \u003d False"},{"line_number":217,"context_line":"            else:"},{"line_number":218,"context_line":"                if kwargs.get(\u0027cacert\u0027):"},{"line_number":219,"context_line":"                    self.session.verify \u003d kwargs.get(\u0027cacert\u0027, True)"},{"line_number":220,"context_line":"            self.session.cert \u003d (kwargs.get(\u0027cert_file\u0027),"},{"line_number":221,"context_line":"                                 kwargs.get(\u0027key_file\u0027))"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_8d5684cc","line":219,"in_reply_to":"fa80f949_2523f257","updated":"2015-11-06 14:25:09.000000000","message":"my first condition was kwargs.get(\u0027cacert\u0027) is not \u0027\u0027, now for sure default True is no needed, I\u0027ll delete it","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5b43be0448cd6141371b1ee7f59dff18adf226d","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            if isinstance(self.session.verify, six.string_types):"},{"line_number":234,"context_line":"                curl.append(\u0027--cacert %s\u0027 % self.session.verify)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if self.session.cert:"},{"line_number":237,"context_line":"            curl.append(\u0027--cert %s\u0027 % self.session.cert[0])"},{"line_number":238,"context_line":"            curl.append(\u0027--key %s\u0027 % self.session.cert[1])"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_c519c6d8","line":236,"updated":"2015-11-06 12:38:42.000000000","message":"bool((None, None)) \u003d\u003d True, might want to check the fields one by one.","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"93fb8554967ef98d98f8111065125a5f19fd64b5","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            if isinstance(self.session.verify, six.string_types):"},{"line_number":234,"context_line":"                curl.append(\u0027--cacert %s\u0027 % self.session.verify)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if self.session.cert:"},{"line_number":237,"context_line":"            curl.append(\u0027--cert %s\u0027 % self.session.cert[0])"},{"line_number":238,"context_line":"            curl.append(\u0027--key %s\u0027 % self.session.cert[1])"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_fcd90023","line":236,"in_reply_to":"fa80f949_1c9ba473","updated":"2015-11-06 14:39:53.000000000","message":"Oh, sorry, this is correct, please ignore :)","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"714c5abc586434c9ba8d1efc6bb1d30943e117b1","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            if isinstance(self.session.verify, six.string_types):"},{"line_number":234,"context_line":"                curl.append(\u0027--cacert %s\u0027 % self.session.verify)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if self.session.cert:"},{"line_number":237,"context_line":"            curl.append(\u0027--cert %s\u0027 % self.session.cert[0])"},{"line_number":238,"context_line":"            curl.append(\u0027--key %s\u0027 % self.session.cert[1])"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_1c9ba473","line":236,"in_reply_to":"fa80f949_90f1bb03","updated":"2015-11-06 14:38:47.000000000","message":"Yes it is a log, but the command that is run does not correspond to what is logged. If you want to log the values it might be better to log it separately, not as part of command logging.","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"24b461fd5911902545a53a6e7cee2211b8fe4a12","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            if isinstance(self.session.verify, six.string_types):"},{"line_number":234,"context_line":"                curl.append(\u0027--cacert %s\u0027 % self.session.verify)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if self.session.cert:"},{"line_number":237,"context_line":"            curl.append(\u0027--cert %s\u0027 % self.session.cert[0])"},{"line_number":238,"context_line":"            curl.append(\u0027--key %s\u0027 % self.session.cert[1])"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_90f1bb03","line":236,"in_reply_to":"fa80f949_c519c6d8","updated":"2015-11-06 14:25:09.000000000","message":"it\u0027s log, it would be better for debug purpose to keep this as is, cert \u003d\u003d (None, None) means something goes wrong.","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"0cde9b4d338282d04c3ccd4761f27a65e8a09826","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            if isinstance(self.session.verify, six.string_types):"},{"line_number":234,"context_line":"                curl.append(\u0027--cacert %s\u0027 % self.session.verify)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if self.session.cert:"},{"line_number":237,"context_line":"            curl.append(\u0027--cert %s\u0027 % self.session.cert[0])"},{"line_number":238,"context_line":"            curl.append(\u0027--key %s\u0027 % self.session.cert[1])"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_4149405f","line":236,"in_reply_to":"fa80f949_fcd90023","updated":"2015-11-06 15:03:39.000000000","message":"np)","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5b43be0448cd6141371b1ee7f59dff18adf226d","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _make_connection_url(self, url):"},{"line_number":257,"context_line":"        base_url \u003d self.endpoint_trimmed"},{"line_number":258,"context_line":"        return \u0027%s/%s\u0027 % (base_url, url.lstrip(\u0027/\u0027))"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _parse_version_headers(self, resp):"},{"line_number":261,"context_line":"        min_ver \u003d resp.headers.get(\u0027X-OpenStack-Ironic-API-Minimum-Version\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_7ae75811","line":258,"updated":"2015-11-06 12:38:42.000000000","message":"Might be good to change to urljoin here.","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"24b461fd5911902545a53a6e7cee2211b8fe4a12","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _make_connection_url(self, url):"},{"line_number":257,"context_line":"        base_url \u003d self.endpoint_trimmed"},{"line_number":258,"context_line":"        return \u0027%s/%s\u0027 % (base_url, url.lstrip(\u0027/\u0027))"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _parse_version_headers(self, resp):"},{"line_number":261,"context_line":"        min_ver \u003d resp.headers.get(\u0027X-OpenStack-Ironic-API-Minimum-Version\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_50d4b3ea","line":258,"in_reply_to":"fa80f949_7ae75811","updated":"2015-11-06 14:25:09.000000000","message":"ok","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5b43be0448cd6141371b1ee7f59dff18adf226d","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                negotiated_ver \u003d self.negotiate_version(self.session, resp)"},{"line_number":302,"context_line":"                kwargs[\u0027headers\u0027][\u0027X-OpenStack-Ironic-API-Version\u0027] \u003d ("},{"line_number":303,"context_line":"                    negotiated_ver)"},{"line_number":304,"context_line":"                return self._http_request(method, url, **kwargs)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        except requests.exceptions.Timeout as e:"},{"line_number":307,"context_line":"            message \u003d (\"Error communicating with %(url)s: %(e)s\" %"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_9aa31c00","line":304,"updated":"2015-11-06 12:38:42.000000000","message":"The order should not be changed.","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"24b461fd5911902545a53a6e7cee2211b8fe4a12","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                negotiated_ver \u003d self.negotiate_version(self.session, resp)"},{"line_number":302,"context_line":"                kwargs[\u0027headers\u0027][\u0027X-OpenStack-Ironic-API-Version\u0027] \u003d ("},{"line_number":303,"context_line":"                    negotiated_ver)"},{"line_number":304,"context_line":"                return self._http_request(method, url, **kwargs)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        except requests.exceptions.Timeout as e:"},{"line_number":307,"context_line":"            message \u003d (\"Error communicating with %(url)s: %(e)s\" %"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_10f14b95","line":304,"in_reply_to":"fa80f949_9aa31c00","updated":"2015-11-06 14:25:09.000000000","message":"oh, looks like fail due rebases, thanks","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5b43be0448cd6141371b1ee7f59dff18adf226d","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":311,"context_line":"            message \u003d (\"Error finding address for %(url)s: %(e)s\" %"},{"line_number":312,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":313,"context_line":"            raise exc.ConnectionRefused(message)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        body_iter \u003d resp.iter_content(chunk_size\u003dCHUNKSIZE)"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_baf620f7","line":313,"updated":"2015-11-06 12:38:42.000000000","message":"It seems that EndpointNotFound should be raised here.\n\nAnd what about other exceptions that can be raised?","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"0cde9b4d338282d04c3ccd4761f27a65e8a09826","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":311,"context_line":"            message \u003d (\"Error finding address for %(url)s: %(e)s\" %"},{"line_number":312,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":313,"context_line":"            raise exc.ConnectionRefused(message)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        body_iter \u003d resp.iter_content(chunk_size\u003dCHUNKSIZE)"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_c106901b","line":313,"in_reply_to":"fa80f949_5c204c48","updated":"2015-11-06 15:03:39.000000000","message":"ok, I\u0027m just worried that not all RequestException means ConnectionError, so it would be lie)","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"24b461fd5911902545a53a6e7cee2211b8fe4a12","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":311,"context_line":"            message \u003d (\"Error finding address for %(url)s: %(e)s\" %"},{"line_number":312,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":313,"context_line":"            raise exc.ConnectionRefused(message)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        body_iter \u003d resp.iter_content(chunk_size\u003dCHUNKSIZE)"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_c18a131b","line":313,"in_reply_to":"fa80f949_baf620f7","updated":"2015-11-06 14:25:09.000000000","message":"CommunicationError should be here,  what  other exceptions do you mean? exceptions like  InvalidSchema InvalidUrl means bug in client, not sure we can reraise all requests exception with ironic one and does it make sense?","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"714c5abc586434c9ba8d1efc6bb1d30943e117b1","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":311,"context_line":"            message \u003d (\"Error finding address for %(url)s: %(e)s\" %"},{"line_number":312,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":313,"context_line":"            raise exc.ConnectionRefused(message)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        body_iter \u003d resp.iter_content(chunk_size\u003dCHUNKSIZE)"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_5c204c48","line":313,"in_reply_to":"fa80f949_c18a131b","updated":"2015-11-06 14:38:47.000000000","message":"Of course I don\u0027t mean adding a new class for each possible request exception, but there are other valid ones that should be reported: TooManyRedirects, SSLError, HTTPError, maybe others. I\u0027d suggest to add except RequestException block and reraise some more generic exception, like e.g. ConnectionError maybe?","commit_id":"116c04c7da53a8f3989b2005f2b5d1de3fb88c5a"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"730d221dd1bc07b007326afaa427b7d3c4c3fd4d","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        parts \u003d urlparse.urlparse(endpoint)"},{"line_number":217,"context_line":"        if parts.scheme not in SUPPORTED_ENDPOINT_SCHEME:"},{"line_number":218,"context_line":"            msg \u003d \u0027Unsupported scheme: %s\u0027 % parts.scheme"},{"line_number":219,"context_line":"            raise exc.EndpointException(msg)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        if parts.scheme \u003d\u003d \u0027https\u0027:"}],"source_content_type":"text/x-python","patch_set":16,"id":"da85f559_b5971aeb","line":218,"updated":"2015-11-11 03:23:45.000000000","message":"could you add i18n support for the msg like\n _(\u0027Unsupported scheme: %s\u0027) % parts.scheme","commit_id":"d57a93a6d38dc57c6f9131e37facf1d07d2dac26"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"ae328e0a90ec27a6ed98f2b30c962bdfca2e9640","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        parts \u003d urlparse.urlparse(endpoint)"},{"line_number":217,"context_line":"        if parts.scheme not in SUPPORTED_ENDPOINT_SCHEME:"},{"line_number":218,"context_line":"            msg \u003d \u0027Unsupported scheme: %s\u0027 % parts.scheme"},{"line_number":219,"context_line":"            raise exc.EndpointException(msg)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        if parts.scheme \u003d\u003d \u0027https\u0027:"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_3d6b18f3","line":218,"in_reply_to":"da85f559_91a30100","updated":"2015-11-18 13:24:42.000000000","message":"fixed here https://review.openstack.org/#/c/246875/","commit_id":"d57a93a6d38dc57c6f9131e37facf1d07d2dac26"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a11592781c931bdfdf0566e0e6c145e9c7492b18","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        parts \u003d urlparse.urlparse(endpoint)"},{"line_number":217,"context_line":"        if parts.scheme not in SUPPORTED_ENDPOINT_SCHEME:"},{"line_number":218,"context_line":"            msg \u003d \u0027Unsupported scheme: %s\u0027 % parts.scheme"},{"line_number":219,"context_line":"            raise exc.EndpointException(msg)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        if parts.scheme \u003d\u003d \u0027https\u0027:"}],"source_content_type":"text/x-python","patch_set":16,"id":"da85f559_91a30100","line":218,"in_reply_to":"da85f559_b5971aeb","updated":"2015-11-11 11:42:19.000000000","message":"looks like there are more places wo translate marker, I\u0027ll file a bug for this","commit_id":"d57a93a6d38dc57c6f9131e37facf1d07d2dac26"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"730d221dd1bc07b007326afaa427b7d3c4c3fd4d","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                return self._http_request(url, method, **kwargs)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        except requests.exceptions.Timeout as e:"},{"line_number":313,"context_line":"            message \u003d (\"Error communicating with %(url)s: %(e)s\" %"},{"line_number":314,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":315,"context_line":"            raise exc.EndpointNotFound(message)"},{"line_number":316,"context_line":"        except requests.exceptions.ConnectionError as e:"}],"source_content_type":"text/x-python","patch_set":16,"id":"da85f559_3561ea05","line":313,"updated":"2015-11-11 03:23:45.000000000","message":"ditto","commit_id":"d57a93a6d38dc57c6f9131e37facf1d07d2dac26"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"730d221dd1bc07b007326afaa427b7d3c4c3fd4d","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":315,"context_line":"            raise exc.EndpointNotFound(message)"},{"line_number":316,"context_line":"        except requests.exceptions.ConnectionError as e:"},{"line_number":317,"context_line":"            message \u003d (\"Error finding address for %(url)s: %(e)s\" %"},{"line_number":318,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":319,"context_line":"            raise exc.CommunicationError(message)"},{"line_number":320,"context_line":"        except requests.exceptions.RequestException as e:"}],"source_content_type":"text/x-python","patch_set":16,"id":"da85f559_555eee44","line":317,"updated":"2015-11-11 03:23:45.000000000","message":"ditto","commit_id":"d57a93a6d38dc57c6f9131e37facf1d07d2dac26"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"730d221dd1bc07b007326afaa427b7d3c4c3fd4d","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":319,"context_line":"            raise exc.CommunicationError(message)"},{"line_number":320,"context_line":"        except requests.exceptions.RequestException as e:"},{"line_number":321,"context_line":"            message \u003d (\"Error is occurred while handling \""},{"line_number":322,"context_line":"                       \"request for %(url)s: %(e)s\" %"},{"line_number":323,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":324,"context_line":"            raise exc.ConnectionRefused(message)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da85f559_f5560229","line":321,"updated":"2015-11-11 03:23:45.000000000","message":"ditto","commit_id":"d57a93a6d38dc57c6f9131e37facf1d07d2dac26"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f393041c50b81bbaa176d724e3a8e7ce90ad0898","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        if parts.scheme \u003d\u003d \u0027https\u0027:"},{"line_number":225,"context_line":"            if kwargs.get(\u0027insecure\u0027) is True:"},{"line_number":226,"context_line":"                self.session.verify \u003d False"},{"line_number":227,"context_line":"            else:"},{"line_number":228,"context_line":"                if kwargs.get(\u0027cacert\u0027):"},{"line_number":229,"context_line":"                    self.session.verify \u003d kwargs[\u0027cacert\u0027]"},{"line_number":230,"context_line":"            self.session.cert \u003d (kwargs.get(\u0027cert_file\u0027),"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_1f95383f","line":227,"updated":"2015-12-01 11:41:23.000000000","message":"nit - elif","commit_id":"cecac5f76e22cf091cbb4b08c02477d514c12a1c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f393041c50b81bbaa176d724e3a8e7ce90ad0898","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            if kwargs.get(\u0027insecure\u0027) is True:"},{"line_number":226,"context_line":"                self.session.verify \u003d False"},{"line_number":227,"context_line":"            else:"},{"line_number":228,"context_line":"                if kwargs.get(\u0027cacert\u0027):"},{"line_number":229,"context_line":"                    self.session.verify \u003d kwargs[\u0027cacert\u0027]"},{"line_number":230,"context_line":"            self.session.cert \u003d (kwargs.get(\u0027cert_file\u0027),"},{"line_number":231,"context_line":"                                 kwargs.get(\u0027key_file\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_7a0d7236","line":228,"updated":"2015-12-01 11:41:23.000000000","message":"This should be ca_file instead of cacert I beleive.","commit_id":"cecac5f76e22cf091cbb4b08c02477d514c12a1c"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"17af3d22776b1a687ef164118c586d578ae5f5fe","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            if kwargs.get(\u0027insecure\u0027) is True:"},{"line_number":226,"context_line":"                self.session.verify \u003d False"},{"line_number":227,"context_line":"            else:"},{"line_number":228,"context_line":"                if kwargs.get(\u0027cacert\u0027):"},{"line_number":229,"context_line":"                    self.session.verify \u003d kwargs[\u0027cacert\u0027]"},{"line_number":230,"context_line":"            self.session.cert \u003d (kwargs.get(\u0027cert_file\u0027),"},{"line_number":231,"context_line":"                                 kwargs.get(\u0027key_file\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_fa73a213","line":228,"in_reply_to":"9a8ffd7b_7a0d7236","updated":"2015-12-01 11:59:19.000000000","message":"yep, thanks","commit_id":"cecac5f76e22cf091cbb4b08c02477d514c12a1c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f393041c50b81bbaa176d724e3a8e7ce90ad0898","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        if not self.session.verify:"},{"line_number":241,"context_line":"            curl.append(\u0027-k\u0027)"},{"line_number":242,"context_line":"        else:"},{"line_number":243,"context_line":"            if isinstance(self.session.verify, six.string_types):"},{"line_number":244,"context_line":"                curl.append(\u0027--cacert %s\u0027 % self.session.verify)"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_bf93cc4e","line":242,"updated":"2015-12-01 11:41:23.000000000","message":"ditto","commit_id":"cecac5f76e22cf091cbb4b08c02477d514c12a1c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f393041c50b81bbaa176d724e3a8e7ce90ad0898","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            message \u003d (_(\"Error is occurred while handling \""},{"line_number":325,"context_line":"                       \"request for %(url)s: %(e)s\") %"},{"line_number":326,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":327,"context_line":"            raise exc.ConnectionRefused(message)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        body_iter \u003d resp.iter_content(chunk_size\u003dCHUNKSIZE)"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_3a936aa5","line":327,"updated":"2015-12-01 11:41:23.000000000","message":"Maybe better to use a generic ClientException?","commit_id":"cecac5f76e22cf091cbb4b08c02477d514c12a1c"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"17af3d22776b1a687ef164118c586d578ae5f5fe","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            message \u003d (_(\"Error is occurred while handling \""},{"line_number":325,"context_line":"                       \"request for %(url)s: %(e)s\") %"},{"line_number":326,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":327,"context_line":"            raise exc.ConnectionRefused(message)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        body_iter \u003d resp.iter_content(chunk_size\u003dCHUNKSIZE)"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_f51655f0","line":327,"in_reply_to":"9a8ffd7b_3a936aa5","updated":"2015-12-01 11:59:19.000000000","message":"I think it\u0027s better to keep exception as is, I consider a option don\u0027t change exception at all, it\u0027s possible to break client consumers.","commit_id":"cecac5f76e22cf091cbb4b08c02477d514c12a1c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f393041c50b81bbaa176d724e3a8e7ce90ad0898","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        return self._http_request(url, method, **kwargs)"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"def _construct_http_client(endpoint,"},{"line_number":541,"context_line":"                           session\u003dNone,"},{"line_number":542,"context_line":"                           token\u003dNone,"},{"line_number":543,"context_line":"                           auth_ref\u003dNone,"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_3ae4ca0b","line":540,"updated":"2015-12-01 11:41:23.000000000","message":"Not sure if it makes sense, but previously it had a default of None, maybe leave it as is?","commit_id":"cecac5f76e22cf091cbb4b08c02477d514c12a1c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9dfc528dfb3d19de4fa2866d02e32a2275668094","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        return \u0027%s/%s\u0027 % (base_url, url.lstrip(\u0027/\u0027))"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def _parse_version_headers(self, resp):"},{"line_number":289,"context_line":"        return self._generic_parse_version_headers(resp.getheader)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def _make_simple_request(self, conn, method, url):"},{"line_number":292,"context_line":"        conn.request(method, self._make_connection_url(url))"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a710552_70f5ce81","side":"PARENT","line":289,"updated":"2015-12-14 18:11:32.000000000","message":"Seems that it should be used still, but with resp.headers.get instead.","commit_id":"b1bd67cc41bf588fd3627ddf01d2af51b6dc24d3"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"bd8cc0a9f5115b39d9c623030b67c124bcf119c7","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        return \u0027%s/%s\u0027 % (base_url, url.lstrip(\u0027/\u0027))"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def _parse_version_headers(self, resp):"},{"line_number":289,"context_line":"        return self._generic_parse_version_headers(resp.getheader)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def _make_simple_request(self, conn, method, url):"},{"line_number":292,"context_line":"        conn.request(method, self._make_connection_url(url))"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a710552_c5db7e1a","side":"PARENT","line":289,"in_reply_to":"5a710552_70f5ce81","updated":"2015-12-15 08:53:49.000000000","message":"sure, actually I don\u0027t remember why I replaced it","commit_id":"b1bd67cc41bf588fd3627ddf01d2af51b6dc24d3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"422adee0cb362f6caa87e6db48127325735b4b39","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            msg \u003d _(\u0027Unsupported scheme: %s\u0027) % parts.scheme"},{"line_number":222,"context_line":"            raise exc.EndpointException(msg)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        if parts.scheme \u003d\u003d \u0027https\u0027:"},{"line_number":225,"context_line":"            if kwargs.get(\u0027insecure\u0027) is True:"},{"line_number":226,"context_line":"                self.session.verify \u003d False"},{"line_number":227,"context_line":"            elif kwargs.get(\u0027ca_file\u0027):"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a7b0d38_e903f50d","line":224,"updated":"2015-12-23 10:17:04.000000000","message":"There are no tests for https scheme now, could you add some?","commit_id":"2f79cb61838fad3b946da6204bce2f785be4612d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"422adee0cb362f6caa87e6db48127325735b4b39","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                       % dict(url\u003dconn_url, e\u003de))"},{"line_number":314,"context_line":"            raise exc.EndpointNotFound(message)"},{"line_number":315,"context_line":"        except requests.exceptions.RequestException as e:"},{"line_number":316,"context_line":"            message \u003d (_(\"Error is occurred while handling \""},{"line_number":317,"context_line":"                       \"request for %(url)s: %(e)s\") %"},{"line_number":318,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":319,"context_line":"            raise exc.ConnectionRefused(message)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a7b0d38_a9040d15","line":316,"updated":"2015-12-23 10:17:04.000000000","message":"s/is/has","commit_id":"2f79cb61838fad3b946da6204bce2f785be4612d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"9022099e8bacfd2df11f42dd57cab144b3e6f1b4","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            raise exc.from_response("},{"line_number":336,"context_line":"                resp, error_json.get(\u0027faultstring\u0027),"},{"line_number":337,"context_line":"                error_json.get(\u0027debuginfo\u0027), method, url)"},{"line_number":338,"context_line":"        elif resp.status_code in (301, 302, 305):"},{"line_number":339,"context_line":"            # Redirected. Reissue the request to the new location."},{"line_number":340,"context_line":"            return self._http_request(resp[\u0027location\u0027], method, **kwargs)"},{"line_number":341,"context_line":"        elif resp.status_code \u003d\u003d 300:"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa69d971_22f9e24d","line":338,"updated":"2016-01-04 11:46:10.000000000","message":"As we\u0027re switching to requests, I would like to see us use requests.codes.* instead of having magic numbers all over the place when we\u0027re checking the status codes.","commit_id":"44c16fa6951c2c9f232955e6f2245fd45ccb7a36"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"9022099e8bacfd2df11f42dd57cab144b3e6f1b4","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        resp, body_iter \u003d self._http_request(url, method, **kwargs)"},{"line_number":355,"context_line":"        content_type \u003d resp.headers.get(\u0027Content-Type\u0027)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        if (resp.status_code \u003d\u003d 204 or resp.status_code \u003d\u003d 205"},{"line_number":358,"context_line":"           or content_type is None):"},{"line_number":359,"context_line":"            return resp, list()"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"fa69d971_c2efa685","line":357,"updated":"2016-01-04 11:46:10.000000000","message":"Ditto","commit_id":"44c16fa6951c2c9f232955e6f2245fd45ccb7a36"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cdfeb0c3262e59df7577364639d93587d60034c3","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    negotiated_ver)"},{"line_number":312,"context_line":"                return self._http_request(url, method, **kwargs)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        except requests.exceptions.ConnectTimeout as e:"},{"line_number":315,"context_line":"            message \u003d (_(\"Error finding address for %(url)s: %(e)s\")"},{"line_number":316,"context_line":"                       % dict(url\u003dconn_url, e\u003de))"},{"line_number":317,"context_line":"            raise exc.EndpointNotFound(message)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_d849ab61","line":314,"updated":"2016-02-05 12:53:32.000000000","message":"So, there might be a problem here. Here is a docstring of this exception from requests lib:\n\nThe request timed out while trying to connect to the remote server. Requests that produced this error are safe to retry.\n\nWhile exc.EndpointNotFound that is raised in this case is not retried (see with_retries decorator).\n\nI\u0027d propose retrying request only in case of requests.exceptions.Timeout (not sure in which exception to wrap this), otherwise catch requests.exceptions.RequestException,  wrap it in generic exc.ClientException and raise.\n\nWDYT?","commit_id":"2ace763ec8eb5cff71c0a215eb3fad23ade87ed5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0215306ce85fd8c903f52c02308afb64cae3cdf9","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        except requests.exceptions.ConnectTimeout as e:"},{"line_number":315,"context_line":"            message \u003d (_(\"Error finding address for %(url)s: %(e)s\")"},{"line_number":316,"context_line":"                       % dict(url\u003dconn_url, e\u003de))"},{"line_number":317,"context_line":"            raise exc.EndpointNotFound(message)"},{"line_number":318,"context_line":"        except requests.exceptions.RequestException as e:"},{"line_number":319,"context_line":"            message \u003d (_(\"Error has occurred while handling \""},{"line_number":320,"context_line":"                       \"request for %(url)s: %(e)s\") %"}],"source_content_type":"text/x-python","patch_set":28,"id":"5a5ae5dd_07f23606","line":317,"updated":"2016-02-08 13:26:17.000000000","message":"I\u0027d suggest to rewrite this as\n\n except ValueError as e:\n   ...\n except requests.exceptions.RequestException as e:\n   ...\n\nas there is no substitute for socket.gaierror in requests, and timeout is clearly not something that should be treated as endpoint not found :)","commit_id":"446e7dc583f24c5c573c4697b4912588fe635b39"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d6f1b44d2b3a388f7a8f18ab79e2aef32e3a00fd","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @staticmethod"},{"line_number":257,"context_line":"    def log_http_response(resp, body\u003dNone):"},{"line_number":258,"context_line":"        status \u003d (resp.raw.version / 10.0, resp.status_code, resp.reason)"},{"line_number":259,"context_line":"        dump \u003d [\u0027\\nHTTP/%.1f %s %s\u0027 % status]"},{"line_number":260,"context_line":"        dump.extend([\u0027%s: %s\u0027 % (k, v) for k, v in resp.headers.items()])"},{"line_number":261,"context_line":"        dump.append(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a57f1b5_e7bedcd3","line":258,"updated":"2016-02-09 17:42:07.000000000","message":"Reading the requests documentation it states that using \u0027raw\u0027 requires \u0027stream\u003dTrue\u0027\n\nIs this \u0027raw\u0027 usage that?\n\nhttp://docs.python-requests.org/en/master/api/#requests.Response.raw","commit_id":"74b4fcac19b90ccc0dea2a2ee89f5401e8854b7e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9af1676fb15d9801158cb0800ab245318bad4f9e","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @staticmethod"},{"line_number":257,"context_line":"    def log_http_response(resp, body\u003dNone):"},{"line_number":258,"context_line":"        status \u003d (resp.raw.version / 10.0, resp.status_code, resp.reason)"},{"line_number":259,"context_line":"        dump \u003d [\u0027\\nHTTP/%.1f %s %s\u0027 % status]"},{"line_number":260,"context_line":"        dump.extend([\u0027%s: %s\u0027 % (k, v) for k, v in resp.headers.items()])"},{"line_number":261,"context_line":"        dump.append(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a57f1b5_34407156","line":258,"in_reply_to":"3a57f1b5_0b1e850c","updated":"2016-02-10 13:31:48.000000000","message":"That also says that we should not be using raw unless we use stream\u003dTrue.\n\nI think there should be a comment here saying we are intentionally not doing as the doc says.  My concern is in the future they may change it to match the doc and then we break.","commit_id":"74b4fcac19b90ccc0dea2a2ee89f5401e8854b7e"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"0022cf4670b882f4390b1a56cb166054e18e3183","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @staticmethod"},{"line_number":257,"context_line":"    def log_http_response(resp, body\u003dNone):"},{"line_number":258,"context_line":"        status \u003d (resp.raw.version / 10.0, resp.status_code, resp.reason)"},{"line_number":259,"context_line":"        dump \u003d [\u0027\\nHTTP/%.1f %s %s\u0027 % status]"},{"line_number":260,"context_line":"        dump.extend([\u0027%s: %s\u0027 % (k, v) for k, v in resp.headers.items()])"},{"line_number":261,"context_line":"        dump.append(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a57f1b5_69f36f0b","line":258,"in_reply_to":"3a57f1b5_34407156","updated":"2016-02-10 14:55:54.000000000","message":"Actually we don\u0027t use raw data here, we are using iter_content for this, we just get version from response, so it\u0027s not a problem.","commit_id":"74b4fcac19b90ccc0dea2a2ee89f5401e8854b7e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"900a4e9c7b14828e3e51ff7c4863bd79ae547a6f","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @staticmethod"},{"line_number":257,"context_line":"    def log_http_response(resp, body\u003dNone):"},{"line_number":258,"context_line":"        status \u003d (resp.raw.version / 10.0, resp.status_code, resp.reason)"},{"line_number":259,"context_line":"        dump \u003d [\u0027\\nHTTP/%.1f %s %s\u0027 % status]"},{"line_number":260,"context_line":"        dump.extend([\u0027%s: %s\u0027 % (k, v) for k, v in resp.headers.items()])"},{"line_number":261,"context_line":"        dump.append(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a57f1b5_a94ac781","line":258,"in_reply_to":"3a57f1b5_69f36f0b","updated":"2016-02-10 15:03:53.000000000","message":"Okay. Then as Star Wars would say, maybe a comment to explain why this \u0027raw\u0027 is not the \u0027raw\u0027 you are looking for.\n\nWhy is this \u0027raw\u0027 not the \u0027raw\u0027 that I read about in the Requests documentation.\n\nI\u0027m confused....","commit_id":"74b4fcac19b90ccc0dea2a2ee89f5401e8854b7e"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"9572416f8a8a89a42638a4325a2a5fe2c9777217","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @staticmethod"},{"line_number":257,"context_line":"    def log_http_response(resp, body\u003dNone):"},{"line_number":258,"context_line":"        status \u003d (resp.raw.version / 10.0, resp.status_code, resp.reason)"},{"line_number":259,"context_line":"        dump \u003d [\u0027\\nHTTP/%.1f %s %s\u0027 % status]"},{"line_number":260,"context_line":"        dump.extend([\u0027%s: %s\u0027 % (k, v) for k, v in resp.headers.items()])"},{"line_number":261,"context_line":"        dump.append(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a57f1b5_0b1e850c","line":258,"in_reply_to":"3a57f1b5_e7bedcd3","updated":"2016-02-10 08:52:38.000000000","message":"raw is valid in both cases when stream True or False; unfortunately, doc isn\u0027t full (\n\nplease take a look on code comment: https://github.com/kennethreitz/requests/blob/master/requests/models.py#L555","commit_id":"74b4fcac19b90ccc0dea2a2ee89f5401e8854b7e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a69866137c37b04056f40aa69f56d72fcf403839","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        self.log_curl_request(method, url, kwargs)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        body \u003d kwargs.pop(\u0027body\u0027, None)"},{"line_number":298,"context_line":"        if body:"},{"line_number":299,"context_line":"            kwargs[\u0027data\u0027] \u003d body"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"3a57f1b5_1acf9480","line":297,"updated":"2016-02-10 16:33:42.000000000","message":"A comment here to explain that this is for backwards compatibility as previously we used httplib.\n\nDo we care if they send in both \u0027data\u0027 and \u0027body\u0027?\n\nThis also makes me wonder should we be fixing the callers of this function? I\u0027m not sure.","commit_id":"02e6123318ef582ef0e44199facaea0838ea3082"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"e35dcb1e01b9121a9902069b6de4772a130155f8","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        self.log_curl_request(method, url, kwargs)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        body \u003d kwargs.pop(\u0027body\u0027, None)"},{"line_number":298,"context_line":"        if body:"},{"line_number":299,"context_line":"            kwargs[\u0027data\u0027] \u003d body"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"3a57f1b5_5fff1334","line":297,"in_reply_to":"3a57f1b5_1acf9480","updated":"2016-02-11 09:35:54.000000000","message":"Sure, I\u0027ll add.\n\nSupporting both args it\u0027s not good idea, it will just complicate code w/o any real benefit, also it\u0027s internal help function, for internal use only.\n\nAPI hasn\u0027t been changed, so no changes for caller.","commit_id":"02e6123318ef582ef0e44199facaea0838ea3082"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a69866137c37b04056f40aa69f56d72fcf403839","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        # Read body into string if it isn\u0027t obviously image data"},{"line_number":331,"context_line":"        body_str \u003d None"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        if resp.headers.get(\u0027Content-Type\u0027) !\u003d \u0027application/octet-stream\u0027:"},{"line_number":334,"context_line":"            body_str \u003d \u0027\u0027.join([chunk for chunk in body_iter])"},{"line_number":335,"context_line":"            self.log_http_response(resp, body_str)"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a57f1b5_3a0a9027","line":332,"updated":"2016-02-10 16:33:42.000000000","message":"nit: added line. Not sure if intentional","commit_id":"02e6123318ef582ef0e44199facaea0838ea3082"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"e35dcb1e01b9121a9902069b6de4772a130155f8","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        # Read body into string if it isn\u0027t obviously image data"},{"line_number":331,"context_line":"        body_str \u003d None"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        if resp.headers.get(\u0027Content-Type\u0027) !\u003d \u0027application/octet-stream\u0027:"},{"line_number":334,"context_line":"            body_str \u003d \u0027\u0027.join([chunk for chunk in body_iter])"},{"line_number":335,"context_line":"            self.log_http_response(resp, body_str)"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a57f1b5_ff94bfe2","line":332,"in_reply_to":"3a57f1b5_3a0a9027","updated":"2016-02-11 09:35:54.000000000","message":"I\u0027ll remove","commit_id":"02e6123318ef582ef0e44199facaea0838ea3082"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a69866137c37b04056f40aa69f56d72fcf403839","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        resp, body_iter \u003d self._http_request(url, method, **kwargs)"},{"line_number":362,"context_line":"        content_type \u003d resp.headers.get(\u0027Content-Type\u0027)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        if (resp.status_code \u003d\u003d 204 or resp.status_code \u003d\u003d 205"},{"line_number":365,"context_line":"           or content_type is None):"},{"line_number":366,"context_line":"            return resp, list()"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"3a57f1b5_ba3c4094","line":364,"updated":"2016-02-10 16:33:42.000000000","message":"nit:\n\n if resp.status_code in (204, 205) or ...","commit_id":"02e6123318ef582ef0e44199facaea0838ea3082"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3dbae068b8dbb8e26ff4196a1c037aa7a60045d3","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    def log_http_response(resp, body\u003dNone):"},{"line_number":258,"context_line":"        # NOTE(aarefiev): resp.raw is urllib3 response object, it\u0027s used"},{"line_number":259,"context_line":"        # only to get \u0027version\u0027, response from request with \u0027stream \u003d True\u0027"},{"line_number":260,"context_line":"        # should be used for raw reading."},{"line_number":261,"context_line":"        status \u003d (resp.raw.version / 10.0, resp.status_code, resp.reason)"},{"line_number":262,"context_line":"        dump \u003d [\u0027\\nHTTP/%.1f %s %s\u0027 % status]"},{"line_number":263,"context_line":"        dump.extend([\u0027%s: %s\u0027 % (k, v) for k, v in resp.headers.items()])"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_51ed1724","line":260,"updated":"2016-02-22 11:55:58.000000000","message":"nit: not sure if it\u0027s valuable to log HTTP version actually....","commit_id":"e5fb8fdfa691f12a994ddc5d847d8e304c2027fc"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"639fadb50cd93f3a30d4d7917079cbf5dfc94449","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    def log_http_response(resp, body\u003dNone):"},{"line_number":258,"context_line":"        # NOTE(aarefiev): resp.raw is urllib3 response object, it\u0027s used"},{"line_number":259,"context_line":"        # only to get \u0027version\u0027, response from request with \u0027stream \u003d True\u0027"},{"line_number":260,"context_line":"        # should be used for raw reading."},{"line_number":261,"context_line":"        status \u003d (resp.raw.version / 10.0, resp.status_code, resp.reason)"},{"line_number":262,"context_line":"        dump \u003d [\u0027\\nHTTP/%.1f %s %s\u0027 % status]"},{"line_number":263,"context_line":"        dump.extend([\u0027%s: %s\u0027 % (k, v) for k, v in resp.headers.items()])"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_912aff2a","line":260,"in_reply_to":"bae84128_51ed1724","updated":"2016-02-22 12:18:20.000000000","message":"not sure why it was done, if no objection I can remove it.","commit_id":"e5fb8fdfa691f12a994ddc5d847d8e304c2027fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3dbae068b8dbb8e26ff4196a1c037aa7a60045d3","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":324,"context_line":"            # NOTE(aarefiev): not valid request(invalid url, missing schema,"},{"line_number":325,"context_line":"            # and so on), retrying is not needed."},{"line_number":326,"context_line":"            if isinstance(e, ValueError):"},{"line_number":327,"context_line":"                raise exc.ValidationError(message)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"            raise exc.ConnectionRefused(message)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_b1f463f2","line":326,"updated":"2016-02-22 11:55:58.000000000","message":"what\u0027s the specific error class here? your code assumes it\u0027s a subclass of both RequestException and ValueError. If so, could you use a specific class?","commit_id":"e5fb8fdfa691f12a994ddc5d847d8e304c2027fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbf3e608188f9bff49e326dc6b7105100c24976b","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":324,"context_line":"            # NOTE(aarefiev): not valid request(invalid url, missing schema,"},{"line_number":325,"context_line":"            # and so on), retrying is not needed."},{"line_number":326,"context_line":"            if isinstance(e, ValueError):"},{"line_number":327,"context_line":"                raise exc.ValidationError(message)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"            raise exc.ConnectionRefused(message)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_4c93b94f","line":326,"in_reply_to":"bae84128_74000902","updated":"2016-02-22 14:58:15.000000000","message":"right, I\u0027ve checked the documentation, and they do seem to have many of matching exceptions: http://docs.python-requests.org/en/latest/_modules/requests/exceptions/#RequestException","commit_id":"e5fb8fdfa691f12a994ddc5d847d8e304c2027fc"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"639fadb50cd93f3a30d4d7917079cbf5dfc94449","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                       dict(url\u003dconn_url, e\u003de))"},{"line_number":324,"context_line":"            # NOTE(aarefiev): not valid request(invalid url, missing schema,"},{"line_number":325,"context_line":"            # and so on), retrying is not needed."},{"line_number":326,"context_line":"            if isinstance(e, ValueError):"},{"line_number":327,"context_line":"                raise exc.ValidationError(message)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"            raise exc.ConnectionRefused(message)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_74000902","line":326,"in_reply_to":"bae84128_b1f463f2","updated":"2016-02-22 12:18:20.000000000","message":"it\u0027s difficult to map request\u0027s exceptions to existing, it was try to  distinguish exceptions, related to wrong URL.\n\nRequestException is base exception for request, exceptions are inherited from both, base one and ValueError are `not valid url` exeptions.\n\nDo you have suggestions how it could be done in more appropriate way?","commit_id":"e5fb8fdfa691f12a994ddc5d847d8e304c2027fc"}],"ironicclient/tests/unit/test_http.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9dfc528dfb3d19de4fa2866d02e32a2275668094","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            {\u0027Content-Type\u0027: \u0027application/json\u0027},"},{"line_number":209,"context_line":"            six.StringIO(error_body),"},{"line_number":210,"context_line":"            version\u003d1,"},{"line_number":211,"context_line":"            status_code\u003d500)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        error \u003d self.assertRaises(exc.InternalServerError,"},{"line_number":214,"context_line":"                                  client.json_request,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a710552_d3112cb1","line":211,"updated":"2015-12-14 18:11:32.000000000","message":"This is being changed to httplib constants everywhere, please change in this patch too.","commit_id":"a4accf1f02b77830d4ed15792430f57f0c8c98a7"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"bd8cc0a9f5115b39d9c623030b67c124bcf119c7","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            {\u0027Content-Type\u0027: \u0027application/json\u0027},"},{"line_number":209,"context_line":"            six.StringIO(error_body),"},{"line_number":210,"context_line":"            version\u003d1,"},{"line_number":211,"context_line":"            status_code\u003d500)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        error \u003d self.assertRaises(exc.InternalServerError,"},{"line_number":214,"context_line":"                                  client.json_request,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a710552_45354e44","line":211,"in_reply_to":"5a710552_d3112cb1","updated":"2015-12-15 08:53:49.000000000","message":"ok","commit_id":"a4accf1f02b77830d4ed15792430f57f0c8c98a7"}],"ironicclient/tests/unit/utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"bf9e39ca0475bbc6e3c0ea126e082df3e0365ad5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"class Bunch(object):"},{"line_number":139,"context_line":"    def __init__(self, **kwargs):"},{"line_number":140,"context_line":"        self.__dict__.update(kwargs)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_f3e88312","line":138,"updated":"2015-10-07 16:04:59.000000000","message":"Docstring please. I don\u0027t know what this class is for...yet.","commit_id":"fda31dafa2c696b733419a587697e340d44f2cd5"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"ae66a07817d60ee3082f81e2f3bab8b770a16372","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"class Bunch(object):"},{"line_number":139,"context_line":"    def __init__(self, **kwargs):"},{"line_number":140,"context_line":"        self.__dict__.update(kwargs)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_57f6e3f9","line":138,"in_reply_to":"7a2fa921_f3e88312","updated":"2015-10-08 08:42:41.000000000","message":"I\u0027ll remove it will not needed","commit_id":"fda31dafa2c696b733419a587697e340d44f2cd5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"422adee0cb362f6caa87e6db48127325735b4b39","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def iter_content(self, chunk_size):"},{"line_number":151,"context_line":"        return iter(self.content)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def close(self):"},{"line_number":154,"context_line":"        pass"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a7b0d38_e990d5ee","line":153,"updated":"2015-12-23 10:17:04.000000000","message":"Seems to be not needed.","commit_id":"2f79cb61838fad3b946da6204bce2f785be4612d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"422adee0cb362f6caa87e6db48127325735b4b39","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.status_code \u003d status_code"},{"line_number":163,"context_line":"        self.version \u003d version"},{"line_number":164,"context_line":"        self.verify \u003d False"},{"line_number":165,"context_line":"        self.cert \u003d \u0027\u0027"},{"line_number":166,"context_line":"        self.last_request \u003d None"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def request(self, url, method, **kwargs):"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a7b0d38_e99c556b","line":165,"updated":"2015-12-23 10:17:04.000000000","message":"It is a tuple in real life, so I guess it should be some tuple here.","commit_id":"2f79cb61838fad3b946da6204bce2f785be4612d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"422adee0cb362f6caa87e6db48127325735b4b39","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.version \u003d version"},{"line_number":164,"context_line":"        self.verify \u003d False"},{"line_number":165,"context_line":"        self.cert \u003d \u0027\u0027"},{"line_number":166,"context_line":"        self.last_request \u003d None"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def request(self, url, method, **kwargs):"},{"line_number":169,"context_line":"        self.last_request \u003d FakeSessionResponse("}],"source_content_type":"text/x-python","patch_set":23,"id":"1a7b0d38_a9308d57","line":166,"updated":"2015-12-23 10:17:04.000000000","message":"I don\u0027t see any use of this, maybe remove it?","commit_id":"2f79cb61838fad3b946da6204bce2f785be4612d"}]}
