)]}'
{"id":"openstack%2Fpython-ironicclient~232633","triplet_id":"openstack%2Fpython-ironicclient~master~I3e6091eb2bc221a16fdc18b998ba138058818894","project":"openstack/python-ironicclient","branch":"master","topic":"bug/1504197","hashtags":[],"change_id":"I3e6091eb2bc221a16fdc18b998ba138058818894","subject":"Mock keystone call to avoid test failure","status":"MERGED","created":"2015-10-08 16:09:38.000000000","updated":"2015-10-13 21:53:48.000000000","submitted":"2015-10-08 20:36:27.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6f18380c3f8c57df686a4f88d17fa14f901b1272","_number":232633,"virtual_id_number":232633,"owner":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-10-08 20:36:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-08 16:14:26.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":1,"date":"2015-10-08 17:26:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":2,"date":"2015-10-08 16:14:59.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":1,"date":"2015-10-08 17:33:34.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-08 16:14:26.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2015-10-08 17:26:08.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2015-10-08 17:33:34.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-10-08 20:36:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e1766e6148ee28adcf0da7345348e84cb58a45f8","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2015-10-08 16:09:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cf615965046357ff11b5318c856439a6113cd788","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2015-10-08 16:10:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"76c3462065cec52f9f2576fc198f559674bc873f","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-10-08 16:14:26.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM assuming tests pass","accounts_in_message":[],"_revision_number":2},{"id":"739fc8c019b5a67272312456b59b8b3d44dddf2c","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-10-08 16:14:59.000000000","message":"Patch Set 2: Code-Review+2\n\nThx!","accounts_in_message":[],"_revision_number":2},{"id":"0f6b99884a3a291dacd214899adb34f9fc597834","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 17:13:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python26 http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-python26/15a0880/ : SUCCESS in 2m 36s\n- gate-python-ironicclient-python34 http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-python34/424b60e/ : SUCCESS in 3m 09s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-pep8/5c43dec/ : SUCCESS in 2m 31s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/33/232633/2/check/gate-python-ironicclient-docs/b6e16c3//doc/build/html/ : SUCCESS in 3m 01s\n- gate-python-ironicclient-python27 http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-python27/0fd37db/ : SUCCESS in 2m 43s\n- gate-python-ironicclient-pypy http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-pypy/4d713cd/ : SUCCESS in 2m 50s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/33/232633/2/check/gate-tempest-dsvm-python-ironicclient-src/f5df85d/ : SUCCESS in 34m 59s","accounts_in_message":[],"_revision_number":2},{"id":"545bfc1c98e7a2d370006da3ac2d31e8dd9dfdb0","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-10-08 17:26:08.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks Lucas","accounts_in_message":[],"_revision_number":2},{"id":"1d0bc3539eb485a2a038a71f4748fdd1531b675b","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-10-08 17:33:34.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"ef4c96e94363be8ed244be5ddd6154efbadabc55","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 17:33:40.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"cf9456d93d1e8fa422731598109112997831c6ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 18:37:54.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-ironicclient-python26 http://logs.openstack.org/33/232633/2/gate/gate-python-ironicclient-python26/724b288/ : SUCCESS in 2m 11s\n- gate-python-ironicclient-python34 http://logs.openstack.org/33/232633/2/gate/gate-python-ironicclient-python34/aee75f5/ : SUCCESS in 2m 58s\n- gate-python-ironicclient-docs http://logs.openstack.org/33/232633/2/gate/gate-python-ironicclient-docs/06432ae/ : FAILURE in 4m 55s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/33/232633/2/gate/gate-python-ironicclient-pep8/f2210a0/ : SUCCESS in 2m 07s\n- gate-python-ironicclient-python27 http://logs.openstack.org/33/232633/2/gate/gate-python-ironicclient-python27/abab388/ : SUCCESS in 2m 34s\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/33/232633/2/gate/gate-tempest-dsvm-python-ironicclient-src/024ccb8/ : FAILURE in 1h 03m 48s","accounts_in_message":[],"_revision_number":2},{"id":"42e96341a89f6469aa8ff9851c00d5526378dd82","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-10-08 18:44:41.000000000","message":"Patch Set 2:\n\nrecheck\n\nLooks like a temporary network hiccup","accounts_in_message":[],"_revision_number":2},{"id":"18a24e73e013cd21dd5065594f51e6829ffbcf5f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 19:38:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python26 http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-python26/29918e0/ : SUCCESS in 2m 30s\n- gate-python-ironicclient-python34 http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-python34/8831f65/ : SUCCESS in 3m 11s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-pep8/85dcf8a/ : SUCCESS in 2m 25s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/33/232633/2/check/gate-python-ironicclient-docs/1a51d74//doc/build/html/ : SUCCESS in 2m 27s\n- gate-python-ironicclient-python27 http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-python27/62f3f07/ : SUCCESS in 2m 37s\n- gate-python-ironicclient-pypy http://logs.openstack.org/33/232633/2/check/gate-python-ironicclient-pypy/847607b/ : SUCCESS in 3m 55s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/33/232633/2/check/gate-tempest-dsvm-python-ironicclient-src/acee7df/ : SUCCESS in 48m 24s","accounts_in_message":[],"_revision_number":2},{"id":"351d8ae2d596269091da244da18a305c6552be90","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 19:39:02.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"25617671f05ebd6bfc5c6afc98bac882b33ff464","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 20:36:27.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironicclient-python26 http://logs.openstack.org/33/232633/2/gate/gate-python-ironicclient-python26/baf49c6/ : SUCCESS in 2m 02s\n- gate-python-ironicclient-python34 http://logs.openstack.org/33/232633/2/gate/gate-python-ironicclient-python34/c9f5887/ : SUCCESS in 2m 13s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/33/232633/2/gate/gate-python-ironicclient-docs/aa3d2e5//doc/build/html/ : SUCCESS in 1m 54s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/33/232633/2/gate/gate-python-ironicclient-pep8/35a97b1/ : SUCCESS in 1m 46s\n- gate-python-ironicclient-python27 http://logs.openstack.org/33/232633/2/gate/gate-python-ironicclient-python27/13984a4/ : SUCCESS in 1m 59s\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/33/232633/2/gate/gate-tempest-dsvm-python-ironicclient-src/fe801f6/ : SUCCESS in 50m 46s","accounts_in_message":[],"_revision_number":2},{"id":"ed5963702ab5fa17cc3279df8e9e516e1423df69","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 20:36:28.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"b0bf30d29d3ab31ce80578c010308ee37341c0af","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-10-13 21:53:48.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/liberty as commit cd84edd2bec0e71d9a7f83c6fe1b9ab9b18fcecf","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"42d52af3c2238900eb69217bba5dbbcdca63abf0","revisions":{"34fe11b88cbaff153da462b76f595cda8e471b01":{"kind":"REWORK","_number":1,"created":"2015-10-08 16:09:38.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/33/232633/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/33/232633/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/232633/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/232633/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/232633/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/33/232633/1"}}},"commit":{"parents":[{"commit":"6d5779d07eb3513f3032856a995fb26530a29323","subject":"Merge \"Use doc8 style checker\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/6d5779d07eb3513f3032856a995fb26530a29323"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2015-10-08 16:06:02.000000000","tz":60},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2015-10-08 16:08:45.000000000","tz":60},"subject":"Mock keystone call to avoid test failure","message":"Mock keystone call to avoid test failure\n\nThe test test_password_prompted() was expecting a keystone failure, but\nbecause of an error in the requests/urllib3 library it was returning a\ndifferent exception and causing our tests to fail, see[1].\n\nIndependent of the the problem above on tests we should not rely on some\nexternal library failing like that, we should mock this failures to make\nour tests more reliable and that\u0027s what this patch is doing.\n\n[1] https://bugs.launchpad.net/ospurge/+bug/1503768\n\nChange-Id: I3e6091eb2bc221a16fdc18b998ba138058818894\nCloses-Bug: #1504197\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/34fe11b88cbaff153da462b76f595cda8e471b01"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/34fe11b88cbaff153da462b76f595cda8e471b01"}]},"branch":"refs/heads/master"},"42d52af3c2238900eb69217bba5dbbcdca63abf0":{"kind":"REWORK","_number":2,"created":"2015-10-08 16:10:55.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/33/232633/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/33/232633/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/232633/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/232633/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/33/232633/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/33/232633/2"}}},"commit":{"parents":[{"commit":"6d5779d07eb3513f3032856a995fb26530a29323","subject":"Merge \"Use doc8 style checker\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/6d5779d07eb3513f3032856a995fb26530a29323"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2015-10-08 16:06:02.000000000","tz":60},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2015-10-08 16:10:47.000000000","tz":60},"subject":"Mock keystone call to avoid test failure","message":"Mock keystone call to avoid test failure\n\nThe test test_password_prompted() was expecting a keystone failure, but\nbecause of an error in the requests/urllib3 library it was returning a\ndifferent exception and causing our tests to fail, see[1].\n\nIndependent of the the problem above on tests we should not rely on some\nexternal library failing like that, we should mock this failures to make\nour tests more reliable and that\u0027s what this patch is doing.\n\n[1] https://bugs.launchpad.net/ospurge/+bug/1503768\n\nChange-Id: I3e6091eb2bc221a16fdc18b998ba138058818894\nCloses-Bug: #1504197\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/42d52af3c2238900eb69217bba5dbbcdca63abf0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/42d52af3c2238900eb69217bba5dbbcdca63abf0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}