)]}'
{"ironicclient/v1/node_shell.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ce9a38575cb4d3ea517fb8953e176ef08ff99f04","unresolved":false,"context_lines":[{"line_number":478,"context_line":"    \"\"\"Get the vendor passthru methods for a node.\"\"\""},{"line_number":479,"context_line":"    methods \u003d cc.node.get_vendor_passthru_methods(args.node)"},{"line_number":480,"context_line":"    vendor_methods \u003d {\u0027node_vendor_passthru_methods\u0027:"},{"line_number":481,"context_line":"                      \u0027, \u0027.join(list(methods))}"},{"line_number":482,"context_line":"    cliutils.print_dict(vendor_methods, wrap\u003d72)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_8f99d821","line":481,"updated":"2015-10-20 19:26:15.000000000","message":"list() call is redundant","commit_id":"b04acc90ea57ffce1741510ed45a969d50cbe56e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ce9a38575cb4d3ea517fb8953e176ef08ff99f04","unresolved":false,"context_lines":[{"line_number":479,"context_line":"    methods \u003d cc.node.get_vendor_passthru_methods(args.node)"},{"line_number":480,"context_line":"    vendor_methods \u003d {\u0027node_vendor_passthru_methods\u0027:"},{"line_number":481,"context_line":"                      \u0027, \u0027.join(list(methods))}"},{"line_number":482,"context_line":"    cliutils.print_dict(vendor_methods, wrap\u003d72)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_2fa0c442","line":482,"updated":"2015-10-20 19:26:15.000000000","message":"how does it look, just a table with one row? I\u0027d better see something like\n\n Name      Methods Async Description\n heartbeat POST    True  ....","commit_id":"b04acc90ea57ffce1741510ed45a969d50cbe56e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2ab64cae837a369b4a51a94a3b9ec62d81a796c9","unresolved":false,"context_lines":[{"line_number":479,"context_line":"    methods \u003d cc.node.get_vendor_passthru_methods(args.node)"},{"line_number":480,"context_line":"    vendor_methods \u003d {\u0027node_vendor_passthru_methods\u0027:"},{"line_number":481,"context_line":"                      \u0027, \u0027.join(list(methods))}"},{"line_number":482,"context_line":"    cliutils.print_dict(vendor_methods, wrap\u003d72)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_5da696ae","line":482,"in_reply_to":"3a29b11f_2fa0c442","updated":"2015-10-23 12:03:20.000000000","message":"It doesn\u0027t. Right now it just shows the name of the methods.\n\nstack@ubuntu1404:~/devstack$ ironic node-get-vendor-passthru-methods node-0\n+------------------------------+-----------------------------------------------------------+\n| Property                     | Value                                                     |\n+------------------------------+-----------------------------------------------------------+\n| node_vendor_passthru_methods | heartbeat, pass_bootloader_install_info, pass_deploy_info |\n+------------------------------+-----------------------------------------------------------+\n\nI agree that that we should show the rest of the options, the Ironic API already give the information we just need to present it nicely in the CLI.\n\nE.g of the response body from the API:\n\n{\"heartbeat\": {\"attach\": false, \"http_methods\": [\"POST\"], \"description\": \"\", \"async\": true}, \"pass_bootloader_install_info\": {\"attach\": false, \"http_methods\": [\"POST\"], \"description\": \"\", \"async\": true}, \"pass_deploy_info\": {\"attach\": false, \"http_methods\": [\"POST\"], \"description\": \"\", \"async\": true}}","commit_id":"b04acc90ea57ffce1741510ed45a969d50cbe56e"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"27e38b8ba4099da69204a5c7b4b8002e5f887a73","unresolved":false,"context_lines":[{"line_number":479,"context_line":"    methods \u003d cc.node.get_vendor_passthru_methods(args.node)"},{"line_number":480,"context_line":"    vendor_methods \u003d {\u0027node_vendor_passthru_methods\u0027:"},{"line_number":481,"context_line":"                      \u0027, \u0027.join(list(methods))}"},{"line_number":482,"context_line":"    cliutils.print_dict(vendor_methods, wrap\u003d72)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_167b5ff6","line":482,"in_reply_to":"3a29b11f_5da696ae","updated":"2015-11-03 07:50:05.000000000","message":"Good suggestion.","commit_id":"b04acc90ea57ffce1741510ed45a969d50cbe56e"}],"ironicclient/v1/resource_fields.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"31e2db884888a6e163de630aaef176f95da363a4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \u0027driver_info\u0027: \u0027Driver Info\u0027,"},{"line_number":44,"context_line":"        \u0027driver_internal_info\u0027: \u0027Driver Internal Info\u0027,"},{"line_number":45,"context_line":"        \u0027extra\u0027: \u0027Extra\u0027,"},{"line_number":46,"context_line":"        \u0027http_methods\u0027: \u0027Support HTTP methods\u0027,"},{"line_number":47,"context_line":"        \u0027inspection_finished_at\u0027: \u0027Inspection Finished At\u0027,"},{"line_number":48,"context_line":"        \u0027inspection_started_at\u0027: \u0027Inspection Started At\u0027,"},{"line_number":49,"context_line":"        \u0027instance_info\u0027: \u0027Instance Info\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_a2c44092","line":46,"updated":"2015-11-16 14:36:08.000000000","message":"nit - supported","commit_id":"9b5fb69149eb908eae94907dbb009f7863222269"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"28a2dec58eed135840f01de4755eb3cf2951d04e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    FIELDS \u003d {"},{"line_number":34,"context_line":"        \u0027address\u0027: \u0027Address\u0027,"},{"line_number":35,"context_line":"        \u0027async\u0027: \u0027Async\u0027,"},{"line_number":36,"context_line":"        \u0027attach\u0027: \u0027Attach to response object\u0027,"},{"line_number":37,"context_line":"        \u0027chassis_uuid\u0027: \u0027Chassis UUID\u0027,"},{"line_number":38,"context_line":"        \u0027clean_step\u0027: \u0027Clean Step\u0027,"},{"line_number":39,"context_line":"        \u0027console_enabled\u0027: \u0027Console Enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_da7000df","line":36,"updated":"2015-11-17 17:44:10.000000000","message":"Is there a better way we can word this? As a user, I would have no clue what this means.","commit_id":"2ea1f72a32714a477b851af86acd1df522ed5c7a"}]}