)]}'
{"ironicclient/tests/functional/base.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"cd285e2e13a486c9200baa606b0247720ac71931","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                          .format(port_id))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def create_port(self, params\u003d\u0027\u0027):"},{"line_number":238,"context_line":"        if not any(it in params for it in (\u0027-a\u0027, \u0027--address\u0027, \u0027-n\u0027,"},{"line_number":239,"context_line":"                                           \u0027--node\u0027, \u0027--node_uuid\u0027)):"},{"line_number":240,"context_line":"            node \u003d self.create_node()"},{"line_number":241,"context_line":"            params +\u003d \u0027--address {0} --node {1}\u0027.format("}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_525f690e","line":238,"updated":"2015-11-03 14:23:49.000000000","message":"I think \"param\" would be a better variable name than \"it\" here.","commit_id":"be68b70b120b14a33dc87b0fe6df03388df5faec"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2141343b8070130bb0212d27e7477689b2ec0e58","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def create_port(self, params\u003d\u0027\u0027):"},{"line_number":238,"context_line":"        if not any(param in params for param in (\u0027-a\u0027, \u0027--address\u0027, \u0027-n\u0027,"},{"line_number":239,"context_line":"                                           \u0027--node\u0027, \u0027--node_uuid\u0027)):"},{"line_number":240,"context_line":"            node \u003d self.create_node()"},{"line_number":241,"context_line":"            params +\u003d \u0027--address {0} --node {1}\u0027.format("},{"line_number":242,"context_line":"                self.generate_mac_address(), node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_6373bd4e","line":239,"updated":"2015-11-03 15:18:12.000000000","message":"This line is going to fail PEP8 for being under-indented.","commit_id":"59146f94b58d21c8a39077cfd1e0be200a33ed75"},{"author":{"_account_id":9068,"name":"Yuriy Yekovenko","email":"yyekovenko@mirantis.com","username":"yyekovenko"},"change_message_id":"6292bf068874c1858a38fa4a4ac6ec9cb4d0615d","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def delete_port(self, port_id):"},{"line_number":208,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":209,"context_line":"        if port_list_uuid is None:"},{"line_number":210,"context_line":"            return"},{"line_number":211,"context_line":"        if port_id in port_list_uuid:"},{"line_number":212,"context_line":"            self.ironic(\u0027port-delete\u0027, params\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_2804b1c4","line":209,"updated":"2015-11-20 16:07:03.000000000","message":"self.get_port_uuids_from_port_list() returns a list (either empty or non-empty). So you shouldn\u0027t compare it with None.\nAlso, I think you don\u0027t really need to check if the list is empty. Your next check (if port_id in port_list_uuid:) will do all needed \u0027filtering\u0027.","commit_id":"444b1300fb0d16e64e859b7d067d4b889653739c"},{"author":{"_account_id":9068,"name":"Yuriy Yekovenko","email":"yyekovenko@mirantis.com","username":"yyekovenko"},"change_message_id":"6292bf068874c1858a38fa4a4ac6ec9cb4d0615d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    def create_port(self, params\u003d\u0027\u0027):"},{"line_number":220,"context_line":"        if not any(param in params for param in (\u0027-a\u0027, \u0027--address\u0027, \u0027-n\u0027,"},{"line_number":221,"context_line":"                                                 \u0027--node\u0027, \u0027--node_uuid\u0027)):"},{"line_number":222,"context_line":"            node \u003d self.create_node()"},{"line_number":223,"context_line":"            params +\u003d \u0027--address {0} --node {1}\u0027.format("},{"line_number":224,"context_line":"                utils.generate_mac_address(), node[\u0027uuid\u0027])"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_eba9c391","line":222,"updated":"2015-11-20 16:07:03.000000000","message":"I think it\u0027s not a good idea to create node inside of create_port method.\nSuggest to create node explicitly in test methods and pass node\u0027s uuid as required parameter into create_port().\naddress could be an optional parameter and may be generated here is necessary.","commit_id":"444b1300fb0d16e64e859b7d067d4b889653739c"},{"author":{"_account_id":9068,"name":"Yuriy Yekovenko","email":"yyekovenko@mirantis.com","username":"yyekovenko"},"change_message_id":"6292bf068874c1858a38fa4a4ac6ec9cb4d0615d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        self.addCleanup(self.delete_port, port[\u0027uuid\u0027])"},{"line_number":232,"context_line":"        return port"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def list_port(self, params\u003d\u0027\u0027):"},{"line_number":235,"context_line":"        return self.ironic(\u0027port-list\u0027, params\u003dparams)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def show_port(self, params):"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_2b8eeb27","line":234,"updated":"2015-11-20 16:07:03.000000000","message":"Suggest to rename to list_ports","commit_id":"444b1300fb0d16e64e859b7d067d4b889653739c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9fbdb29792f1cf7cd4beecc54c0a22fc16b9b05d","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            \u0027node-show-states\u0027, params\u003d\u0027{0} {1}\u0027.format(node_id, params))"},{"line_number":205,"context_line":"        return utils.get_dict_from_output(show_node_states)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def delete_port(self, port_id):"},{"line_number":208,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":209,"context_line":"        if port_list_uuid is None:"},{"line_number":210,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_9ae603e7","line":207,"updated":"2015-11-23 13:35:55.000000000","message":"What about port-update?","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9fbdb29792f1cf7cd4beecc54c0a22fc16b9b05d","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def delete_port(self, port_id):"},{"line_number":208,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":209,"context_line":"        if port_list_uuid is None:"},{"line_number":210,"context_line":"            return"},{"line_number":211,"context_line":"        if port_id in port_list_uuid:"},{"line_number":212,"context_line":"            self.ironic(\u0027port-delete\u0027, params\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_402aec91","line":209,"updated":"2015-11-23 13:35:55.000000000","message":"Have you seen Yuriy\u0027s comments on previous patch set? They don\u0027t seem to be addressed.","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"6a53f8adff0e31d42f0c66f183b66fd657036381","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":215,"context_line":"            if port_id in port_list_uuid:"},{"line_number":216,"context_line":"                self.fail(\u0027Ironic port {0} has not been deleted!\u0027"},{"line_number":217,"context_line":"                          .format(port_id))"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def create_port(self, params\u003d\u0027\u0027):"},{"line_number":220,"context_line":"        if not any(param in params for param in (\u0027-a\u0027, \u0027--address\u0027, \u0027-n\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a8ffd7b_0363b0dd","line":217,"updated":"2015-11-25 04:31:35.000000000","message":"Just come to mind, if this failed situation occur, should we also cover it in the port test case? The same as port create command.","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9fbdb29792f1cf7cd4beecc54c0a22fc16b9b05d","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                self.fail(\u0027Ironic port {0} has not been deleted!\u0027"},{"line_number":217,"context_line":"                          .format(port_id))"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def create_port(self, params\u003d\u0027\u0027):"},{"line_number":220,"context_line":"        if not any(param in params for param in (\u0027-a\u0027, \u0027--address\u0027, \u0027-n\u0027,"},{"line_number":221,"context_line":"                                                 \u0027--node\u0027, \u0027--node_uuid\u0027)):"},{"line_number":222,"context_line":"            node \u003d self.create_node()"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_8363fedc","line":219,"updated":"2015-11-23 13:35:55.000000000","message":"It really makes sense to add address and node parameters to this function, instead of looking for it in a list.","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"6a53f8adff0e31d42f0c66f183b66fd657036381","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                self.fail(\u0027Ironic port {0} has not been deleted!\u0027"},{"line_number":217,"context_line":"                          .format(port_id))"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def create_port(self, params\u003d\u0027\u0027):"},{"line_number":220,"context_line":"        if not any(param in params for param in (\u0027-a\u0027, \u0027--address\u0027, \u0027-n\u0027,"},{"line_number":221,"context_line":"                                                 \u0027--node\u0027, \u0027--node_uuid\u0027)):"},{"line_number":222,"context_line":"            node \u003d self.create_node()"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a8ffd7b_23491460","line":219,"in_reply_to":"ba8a016a_8363fedc","updated":"2015-11-25 04:31:35.000000000","message":"++, \u0027node\u0027 and \u0027address\u0027 are necessary for port create. The \u0027if\u0027 check below is a little obscure at the first glance, and separating them out to check will be more distinct.","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"07c8138076dd65f8e547aed1132e913624adce11","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                utils.generate_mac_address(), node[\u0027uuid\u0027])"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        port \u003d self.ironic(\u0027port-create\u0027, params\u003dparams)"},{"line_number":227,"context_line":"        port \u003d utils.get_dict_from_output(port)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        if not port.get(\u0027uuid\u0027):"},{"line_number":230,"context_line":"            self.fail(\u0027Ironic port has not been created!\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a8ffd7b_c674d69d","line":227,"updated":"2015-11-25 05:08:49.000000000","message":"Got inspiration from your chassis patch: Error might happen when creating port, please change this the same way as commented in your chassis patch.","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9fbdb29792f1cf7cd4beecc54c0a22fc16b9b05d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    def list_port(self, params\u003d\u0027\u0027):"},{"line_number":235,"context_line":"        return self.ironic(\u0027port-list\u0027, params\u003dparams)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def show_port(self, params):"},{"line_number":238,"context_line":"        port_show \u003d self.ironic(\u0027port-show\u0027, params\u003dparams)"},{"line_number":239,"context_line":"        return utils.get_dict_from_output(port_show)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_9aafe37c","line":237,"updated":"2015-11-23 13:35:55.000000000","message":"Please add port_id as a parameter to function for consistency.","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"6a53f8adff0e31d42f0c66f183b66fd657036381","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    def list_port(self, params\u003d\u0027\u0027):"},{"line_number":235,"context_line":"        return self.ironic(\u0027port-list\u0027, params\u003dparams)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def show_port(self, params):"},{"line_number":238,"context_line":"        port_show \u003d self.ironic(\u0027port-show\u0027, params\u003dparams)"},{"line_number":239,"context_line":"        return utils.get_dict_from_output(port_show)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a8ffd7b_43977890","line":237,"in_reply_to":"ba8a016a_9aafe37c","updated":"2015-11-25 04:31:35.000000000","message":"++","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2b8061d106ccd749113863794d11506db90a1067","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":240,"context_line":"        return [x[\u0027UUID\u0027] for x in port_list]"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def port_update(self, port_id, operation, params\u003d\u0027\u0027):"},{"line_number":243,"context_line":"        updated_port \u003d self.ironic(\u0027port-update\u0027,"},{"line_number":244,"context_line":"                                   params\u003d\u0027{0} {1} {2}\u0027"},{"line_number":245,"context_line":"                                   .format(port_id, operation, params))"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_6b80eff7","line":242,"updated":"2015-11-26 15:35:27.000000000","message":"This is inconsistent with all other functions, should it be update_port instead?","commit_id":"485e0685ebc064cf0c4c3c0a5839f3f479b4e254"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0156d4a8d7640b6030a6c6b997027ba7e234041f","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            self.ironic(\u0027port-delete\u0027, params\u003dport_id)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":263,"context_line":"        if port_id in port_list_uuid:"},{"line_number":264,"context_line":"            self.fail(\u0027Ironic port {0} has not been deleted!\u0027.format(port_id))"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def create_port(self,"}],"source_content_type":"text/x-python","patch_set":25,"id":"bae84128_1d6c0034","line":263,"updated":"2016-02-23 15:11:06.000000000","message":"In chassis patch, it was moved out of the base class to tests. Please move this too, to be consistent.","commit_id":"48a37f1d63c319f4a151a9a58505b870c50ba8bf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"54ddc99e8cab805b94ef053353777f7fd325d44e","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                                .format(port_id, params))"},{"line_number":287,"context_line":"        return utils.get_dict_from_output(port_show)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def get_port_uuids_from_port_list(self):"},{"line_number":290,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":291,"context_line":"        return [x[\u0027UUID\u0027] for x in port_list]"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"bae84128_6f5001d5","line":289,"updated":"2016-02-23 11:09:06.000000000","message":"s/_from_port_list//","commit_id":"48a37f1d63c319f4a151a9a58505b870c50ba8bf"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dc96c3fe49fb4c3398e883a120b62d1a3eafc843","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":297,"context_line":"        if port_id in port_list_uuid:"},{"line_number":298,"context_line":"            self.fail(\u0027Ironic port {0} has not been deleted!\u0027.format(port_id))"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def create_port(self,"},{"line_number":301,"context_line":"                    node_id,"}],"source_content_type":"text/x-python","patch_set":26,"id":"bae84128_faf8b0c6","line":298,"updated":"2016-02-25 15:21:21.000000000","message":"Please see comment on the previous patchset.","commit_id":"739f210c0c892f79af060b36ad3d2a352115cd19"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"9a33adfc6bcdcfb154c52d075c85b73920efa13b","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":297,"context_line":"        if port_id in port_list_uuid:"},{"line_number":298,"context_line":"            self.fail(\u0027Ironic port {0} has not been deleted!\u0027.format(port_id))"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def create_port(self,"},{"line_number":301,"context_line":"                    node_id,"}],"source_content_type":"text/x-python","patch_set":26,"id":"7af24918_27e4f80b","line":298,"in_reply_to":"bae84128_faf8b0c6","updated":"2016-03-01 11:38:18.000000000","message":"Done","commit_id":"739f210c0c892f79af060b36ad3d2a352115cd19"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"87ea6cdffa84cc8dbb0b67806d61eced66fb7180","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            self.fail(\u0027Ironic port has not been created!\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        port \u003d utils.get_dict_from_output(port)"},{"line_number":325,"context_line":"        self.addCleanup(self.delete_port, port[\u0027uuid\u0027], ignore_exceptions\u003dTrue)"},{"line_number":326,"context_line":"        return port"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def list_ports(self, params\u003d\u0027\u0027):"}],"source_content_type":"text/x-python","patch_set":31,"id":"5aef4532_3c18bad2","line":325,"range":{"start_line":325,"start_character":13,"end_line":325,"end_character":23},"updated":"2016-03-10 13:51:47.000000000","message":"Please, remove cleanup for port, it may cause deleting issue. It will be cleaned with associated node","commit_id":"1c1bef08f8d03333d95fa4589a0dbd50b76674f6"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"c5098590c1001610485308d41285b5eb9a7ae9ab","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            self.fail(\u0027Ironic port has not been created!\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        port \u003d utils.get_dict_from_output(port)"},{"line_number":325,"context_line":"        self.addCleanup(self.delete_port, port[\u0027uuid\u0027], ignore_exceptions\u003dTrue)"},{"line_number":326,"context_line":"        return port"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def list_ports(self, params\u003d\u0027\u0027):"}],"source_content_type":"text/x-python","patch_set":31,"id":"5aef4532_526c8607","line":325,"range":{"start_line":325,"start_character":13,"end_line":325,"end_character":23},"in_reply_to":"5aef4532_3c18bad2","updated":"2016-03-10 16:18:49.000000000","message":"Done","commit_id":"1c1bef08f8d03333d95fa4589a0dbd50b76674f6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"75edda73a6f8c4f14fc1842bf2b934b5edd5934c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        :type params: string"},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        flags +\u003d \u0027 --os-endpoint-type publicURL\u0027"},{"line_number":132,"context_line":"        if hasattr(self, \u0027os_auth_token\u0027):"},{"line_number":133,"context_line":"            return self._cmd_no_auth(\u0027ironic\u0027, action, flags, params)"},{"line_number":134,"context_line":"        else:"},{"line_number":135,"context_line":"            for keystone_object in \u0027user\u0027, \u0027project\u0027:"}],"source_content_type":"text/x-python","patch_set":34,"id":"fa0719c6_05013f6a","line":132,"updated":"2016-03-24 00:06:01.000000000","message":"This try/except block being removed appears to be unrelated to the other changes. Given this PR is supposed to be adding tests it\u0027s a little weird to see behavior change.","commit_id":"7ffc4a30cc0f6ca3c6a6fd68ad636bdbcb51fc69"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"59b51fafb26354ee856b3cc4e87a9b4302498daf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        :type params: string"},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        flags +\u003d \u0027 --os-endpoint-type publicURL\u0027"},{"line_number":132,"context_line":"        if hasattr(self, \u0027os_auth_token\u0027):"},{"line_number":133,"context_line":"            return self._cmd_no_auth(\u0027ironic\u0027, action, flags, params)"},{"line_number":134,"context_line":"        else:"},{"line_number":135,"context_line":"            for keystone_object in \u0027user\u0027, \u0027project\u0027:"}],"source_content_type":"text/x-python","patch_set":34,"id":"da0c15f0_e1bbf50c","line":132,"in_reply_to":"fa0719c6_05013f6a","updated":"2016-03-25 13:36:32.000000000","message":"Jay, it was done for propagate exception further, it\u0027s used, for example, on line 309 for ignore errors during cleanup","commit_id":"7ffc4a30cc0f6ca3c6a6fd68ad636bdbcb51fc69"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"78ada936f14b47c1f34545f883633728cd0ebce9","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def create_port(self,"},{"line_number":314,"context_line":"                    node_id,"},{"line_number":315,"context_line":"                    mac_address\u003dutils.generate_mac_address(),"},{"line_number":316,"context_line":"                    params\u003d\u0027\u0027):"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        port \u003d self.ironic(\u0027port-create\u0027,"}],"source_content_type":"text/x-python","patch_set":44,"id":"9abb7d3a_1f2101b5","line":315,"range":{"start_line":315,"start_character":20,"end_line":315,"end_character":61},"updated":"2016-05-30 10:49:42.000000000","message":"Serge, here is example for randomization on creation of something: https://github.com/openstack/python-openstackclient/blob/master/functional/tests/compute/v2/test_server.py#L50-L52","commit_id":"5d890e32b3c40d50bb56aa80c7831289a7bdad75"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"596889ad586f6f7808d6620831fd5a65c1621481","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def create_port(self,"},{"line_number":314,"context_line":"                    node_id,"},{"line_number":315,"context_line":"                    mac_address\u003dutils.generate_mac_address(),"},{"line_number":316,"context_line":"                    params\u003d\u0027\u0027):"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        port \u003d self.ironic(\u0027port-create\u0027,"}],"source_content_type":"text/x-python","patch_set":44,"id":"9abb7d3a_bed8ee1e","line":315,"range":{"start_line":315,"start_character":0,"end_line":315,"end_character":61},"updated":"2016-05-27 15:34:57.000000000","message":"it doesn\u0027t make sense, default arguments are evaluated once when the function is defined, so you always have the same mac.\n\nIt should be in method body","commit_id":"5d890e32b3c40d50bb56aa80c7831289a7bdad75"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"588462168cc15b5e68f069a56712ffa0bf090ea5","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            if not ignore_exceptions:"},{"line_number":312,"context_line":"                raise"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def create_port(self,"},{"line_number":315,"context_line":"                    node_id,"},{"line_number":316,"context_line":"                    mac_address\u003dNone,"},{"line_number":317,"context_line":"                    params\u003d\u0027\u0027):"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if mac_address is None:"},{"line_number":320,"context_line":"            mac_address \u003d data_utils.rand_mac_address()"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_84d47647","line":317,"range":{"start_line":314,"start_character":20,"end_line":317,"end_character":31},"updated":"2016-06-07 09:07:18.000000000","message":"super nit: one parameter per-line is a waste of space","commit_id":"a0fc05956f01657831e3bc0c1d2fb11b6beb185e"}],"ironicclient/tests/functional/test_ironicclient.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"df870d10dbbfccecc1226366dde40014fa19c893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"da85f559_93cb321e","side":"PARENT","line":33,"updated":"2015-11-10 13:51:42.000000000","message":"I don\u0027t think this deletion logically belongs in this changeset - it should probably go in the \"sanity tests for Node\" changeset. Though honestly, I\u0027m getting confused between all the similar patches you have in flight - would it make sense to combine them all into one?","commit_id":"1ced89b9e99ddefbc1e77495f1a430f4e7de6e84"}],"ironicclient/tests/functional/test_port.py":[{"author":{"_account_id":9068,"name":"Yuriy Yekovenko","email":"yyekovenko@mirantis.com","username":"yyekovenko"},"change_message_id":"6292bf068874c1858a38fa4a4ac6ec9cb4d0615d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def test_port_create(self):"},{"line_number":29,"context_line":"        \"\"\"Test scenario:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        1) create port"},{"line_number":32,"context_line":"        2) check that port has been successfully created"},{"line_number":33,"context_line":"        \"\"\""},{"line_number":34,"context_line":"        port \u003d self.create_port()"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_eb81c3c4","line":31,"updated":"2015-11-20 16:07:03.000000000","message":"Suggest to create a new node for each test method. It may be done in setUp method, to avoid code duplication.","commit_id":"444b1300fb0d16e64e859b7d067d4b889653739c"},{"author":{"_account_id":9068,"name":"Yuriy Yekovenko","email":"yyekovenko@mirantis.com","username":"yyekovenko"},"change_message_id":"6292bf068874c1858a38fa4a4ac6ec9cb4d0615d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        port \u003d self.create_port()"},{"line_number":74,"context_line":"        node \u003d self.create_node()"},{"line_number":75,"context_line":"        updated_port \u003d self.ironic("},{"line_number":76,"context_line":"            \u0027port-update\u0027, params\u003d\u0027{0} replace node_uuid\u003d{1}\u0027"},{"line_number":77,"context_line":"            .format(port[\u0027uuid\u0027], node[\u0027uuid\u0027]))"},{"line_number":78,"context_line":"        updated_port \u003d utils.get_dict_from_output(updated_port)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_76193679","line":75,"updated":"2015-11-20 16:07:03.000000000","message":"Suggest to create update_port method in base.py.","commit_id":"444b1300fb0d16e64e859b7d067d4b889653739c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9fbdb29792f1cf7cd4beecc54c0a22fc16b9b05d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ironicclient.tests.functional.utils as utils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from ironicclient.tests.functional import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class PortSanityTestIronicClient(base.FunctionalTestBase):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_c00edc8b","line":18,"updated":"2015-11-23 13:35:55.000000000","message":"These should be in same group of imports.","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9fbdb29792f1cf7cd4beecc54c0a22fc16b9b05d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"\"\"Test scenario:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        1) create port"},{"line_number":42,"context_line":"        2) check that port exists in port-show object"},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        port \u003d self.create_port()"},{"line_number":45,"context_line":"        port_show \u003d self.show_port(port[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_8090d44f","line":42,"updated":"2015-11-23 13:35:55.000000000","message":"check that port-show returns the same port UUID as port-create","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"80b6c61129ab0bcff21f05a6ee8a1549d1e1f5b5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        port \u003d self.create_port()"},{"line_number":45,"context_line":"        port_show \u003d self.show_port(port[\u0027uuid\u0027])"},{"line_number":46,"context_line":"        self.assertEqual(port_show[\u0027uuid\u0027], port[\u0027uuid\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_port_delete(self):"},{"line_number":49,"context_line":"        \"\"\"Test scenario:"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_966125d6","line":46,"updated":"2015-11-21 02:47:16.000000000","message":"assertEqual first param should be the value we expected, else we will confusing about the test result if case does not passed:\n\n    self.assertEqual(port[\u0027uuid\u0027], port_show[\u0027uuid\u0027])","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9fbdb29792f1cf7cd4beecc54c0a22fc16b9b05d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        port \u003d self.create_port()"},{"line_number":74,"context_line":"        node \u003d self.create_node()"},{"line_number":75,"context_line":"        updated_port \u003d self.ironic("},{"line_number":76,"context_line":"            \u0027port-update\u0027, params\u003d\u0027{0} replace node_uuid\u003d{1}\u0027"},{"line_number":77,"context_line":"            .format(port[\u0027uuid\u0027], node[\u0027uuid\u0027]))"},{"line_number":78,"context_line":"        updated_port \u003d utils.get_dict_from_output(updated_port)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_6054d053","line":76,"updated":"2015-11-23 13:35:55.000000000","message":"A-ha, it\u0027s here, I think it can be moved to base class, as it is done for node-update.","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"80b6c61129ab0bcff21f05a6ee8a1549d1e1f5b5","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            .format(port[\u0027uuid\u0027], node[\u0027uuid\u0027]))"},{"line_number":78,"context_line":"        updated_port \u003d utils.get_dict_from_output(updated_port)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.assertEqual(updated_port[\u0027node_uuid\u0027], node[\u0027uuid\u0027])"},{"line_number":81,"context_line":"        self.assertNotEqual(updated_port[\u0027node_uuid\u0027], port[\u0027node_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_b65ea910","line":80,"updated":"2015-11-21 02:47:16.000000000","message":"ditto","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"80b6c61129ab0bcff21f05a6ee8a1549d1e1f5b5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        updated_port \u003d utils.get_dict_from_output(updated_port)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.assertEqual(updated_port[\u0027node_uuid\u0027], node[\u0027uuid\u0027])"},{"line_number":81,"context_line":"        self.assertNotEqual(updated_port[\u0027node_uuid\u0027], port[\u0027node_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_569addc6","line":81,"updated":"2015-11-21 02:47:16.000000000","message":"ditto","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2b8061d106ccd749113863794d11506db90a1067","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        2) create port"},{"line_number":30,"context_line":"        3) check that port has been successfully created"},{"line_number":31,"context_line":"        \"\"\""},{"line_number":32,"context_line":"        node \u003d self.create_node()"},{"line_number":33,"context_line":"        port \u003d self.create_port(node[\u0027uuid\u0027])"},{"line_number":34,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":35,"context_line":"        self.assertIn(port[\u0027uuid\u0027], port_list_uuid)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_eb47ffb9","line":32,"updated":"2015-11-26 15:35:27.000000000","message":"Yuriy, suggested this in one of the earlier patch sets, these lines should go to setUp as they are needed for all tests, then it can be removed from all methods:\n\n def setUp(self):\n     self.node \u003d self.create_node()\n     self.port \u003d self.create_port(self.node[\u0027uuid\u0027])","commit_id":"485e0685ebc064cf0c4c3c0a5839f3f479b4e254"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"374c2393b2929b656043a989a240116fd3ee0432","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(PortSanityTestIronicClient, self).setUp()"},{"line_number":27,"context_line":"        self.node \u003d self.create_node()"},{"line_number":28,"context_line":"        self.port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_port_create(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_ba68a8bb","line":27,"updated":"2015-12-01 16:31:15.000000000","message":"Do we really need new node for all ports testcase?","commit_id":"85cf53818c8d7acc5be2dd601544c08e6eeb4e86"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"ef8cc06fb8f872d251571a7c38deddc4188db4f5","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(PortSanityTestIronicClient, self).setUp()"},{"line_number":27,"context_line":"        self.node \u003d self.create_node()"},{"line_number":28,"context_line":"        self.port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_port_create(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_a01174ae","line":27,"in_reply_to":"7a740942_57d50d41","updated":"2015-12-04 10:11:27.000000000","message":"every node_create needs 3 calls to API: create, list, and delete node, so yes it definitely increase test time.","commit_id":"85cf53818c8d7acc5be2dd601544c08e6eeb4e86"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"0271541f7923ed207dc7b287524ef27c66b299de","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(PortSanityTestIronicClient, self).setUp()"},{"line_number":27,"context_line":"        self.node \u003d self.create_node()"},{"line_number":28,"context_line":"        self.port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_port_create(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_fbaff1e0","line":27,"in_reply_to":"9a8ffd7b_ba68a8bb","updated":"2015-12-02 06:13:21.000000000","message":"As there are not many port related test cases, I think it is ok to have a new node created for the new port.","commit_id":"85cf53818c8d7acc5be2dd601544c08e6eeb4e86"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"69f5a6ca9b756cc038af5e04f7e9e400784bf68d","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(PortSanityTestIronicClient, self).setUp()"},{"line_number":27,"context_line":"        self.node \u003d self.create_node()"},{"line_number":28,"context_line":"        self.port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_port_create(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_57d50d41","line":27,"in_reply_to":"9a8ffd7b_ba68a8bb","updated":"2015-12-03 23:30:33.000000000","message":"I think it is reasonable to have a new node, are you thinking about performance problems Anton? Maybe I\u0027m missing something...","commit_id":"85cf53818c8d7acc5be2dd601544c08e6eeb4e86"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c3a7a516e87a659f0066dd750d87532cb86f1d30","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":38,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], port_list_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_port_show(self):"},{"line_number":41,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a740942_1ddab84c","line":38,"updated":"2015-12-08 03:26:35.000000000","message":"it is better that we add more negative testing cases to cover port creating case, such as the existing mac or invalid mac etc.","commit_id":"ed570bf3183a6fefe0ec093ba7b2cc76b0c29a40"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"acd202fa3038289c510ad87fe43078f0ba1e58a5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":38,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], port_list_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_port_show(self):"},{"line_number":41,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a7e1126_a59134f3","line":38,"in_reply_to":"7a740942_1ddab84c","updated":"2015-12-18 13:36:06.000000000","message":"Added new patch https://review.openstack.org/#/c/259354/\nNegative tests for testing actions with port.","commit_id":"ed570bf3183a6fefe0ec093ba7b2cc76b0c29a40"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6ab737383157d340ea57df6b9e0ddd4d72731790","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        port_show \u003d self.show_port(self.port[\u0027uuid\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(self.port[\u0027uuid\u0027], port_show[\u0027uuid\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_port_delete(self):"},{"line_number":51,"context_line":"        \"\"\"Test steps:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        1) create node"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a7b0d38_ea1ff069","line":50,"updated":"2015-12-28 15:32:32.000000000","message":"This test completely duplicates delete_port function. You could just call delete_port here. Or maybe completely remove it, if it does not work after-creation cleanups will fail anyway.","commit_id":"693a1e1b27f3658a16f5ec80932f629b440ce8cc"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"02ac3d82136726ebf22e2b1248fba77a3076aae9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        port_show \u003d self.show_port(self.port[\u0027uuid\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(self.port[\u0027uuid\u0027], port_show[\u0027uuid\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_port_delete(self):"},{"line_number":51,"context_line":"        \"\"\"Test steps:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        1) create node"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa69d971_2c3129a3","line":50,"in_reply_to":"1a7b0d38_ea1ff069","updated":"2015-12-30 09:40:03.000000000","message":"Done","commit_id":"693a1e1b27f3658a16f5ec80932f629b440ce8cc"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"d870faf03658d3887499cebe1f1c9a90d1513438","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        port_show \u003d self.show_port(self.port[\u0027uuid\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(self.port[\u0027uuid\u0027], port_show[\u0027uuid\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_port_update(self):"},{"line_number":51,"context_line":"        \"\"\"Test steps:"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5a5ae5dd_03983d77","line":49,"updated":"2016-02-05 09:38:43.000000000","message":"nit: assert node uuid","commit_id":"2455121da05123afc290671f873b0c83c0cfa1ce"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"abb8ebf35ebc7cc231c235826dab812d37853ffb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def test_port_create(self):"},{"line_number":31,"context_line":"        \"\"\"Test steps:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        1) create node"},{"line_number":34,"context_line":"        2) create port"},{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":32,"id":"3afc51ec_74adfe30","line":33,"updated":"2016-03-11 16:22:38.000000000","message":"Maybe it would be good to add \"in setUp()\" here like in your another patch.","commit_id":"86d5dbc0ba163466bc6e7b1588175861bb3458b6"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"936660377deff72d8cff79e975a3ba3608971879","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def test_port_create(self):"},{"line_number":31,"context_line":"        \"\"\"Test steps:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        1) create node"},{"line_number":34,"context_line":"        2) create port"},{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":32,"id":"1af94dfe_13877710","line":33,"in_reply_to":"3afc51ec_74adfe30","updated":"2016-03-15 15:16:22.000000000","message":"Done","commit_id":"86d5dbc0ba163466bc6e7b1588175861bb3458b6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e6837d08ee7cf0a0f6911dba329200f6b0f5c42f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        port_show \u003d self.show_port(self.port[\u0027uuid\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(self.port[\u0027uuid\u0027], port_show[\u0027uuid\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_port_update(self):"},{"line_number":51,"context_line":"        \"\"\"Test steps:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        1) create node"}],"source_content_type":"text/x-python","patch_set":32,"id":"3afc51ec_ed88e024","line":50,"updated":"2016-03-14 13:25:53.000000000","message":"As you don\u0027t cleanup the port anymore, port deletion is not being tested directly. Please add test for delete port.","commit_id":"86d5dbc0ba163466bc6e7b1588175861bb3458b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"92ea77f106202664f2d3d8b2b62f07ab52715197","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"\"\"Test steps:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        1) create node in setUp()"},{"line_number":34,"context_line":"        2) create port in setUp()"},{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        port_list_uuid \u003d self.get_uuids_from_port_list()"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_d66390af","line":34,"updated":"2016-05-26 13:19:09.000000000","message":"just a nit for next time. It would have been fine to put these two as one, eg:  1) create node and port (in setUp())","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"09d49ed68efe64f150bfff03920c83a3e00f6720","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"\"\"Test steps:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        1) create node in setUp()"},{"line_number":34,"context_line":"        2) create port in setUp()"},{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        port_list_uuid \u003d self.get_uuids_from_port_list()"}],"source_content_type":"text/x-python","patch_set":41,"id":"9abb7d3a_a29f435e","line":34,"in_reply_to":"bab6814e_d66390af","updated":"2016-05-27 11:34:36.000000000","message":"Done","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"92ea77f106202664f2d3d8b2b62f07ab52715197","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        port_list_uuid \u003d self.get_uuids_from_port_list()"},{"line_number":38,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], port_list_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_port_delete(self):"},{"line_number":41,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_3623fc59","line":38,"updated":"2016-05-26 13:19:09.000000000","message":"there should only be one port, so you could have checked for equality.","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5bc580d20433fd9ca1ae5a7b7df454a967233ea","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        port_list_uuid \u003d self.get_uuids_from_port_list()"},{"line_number":38,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], port_list_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_port_delete(self):"},{"line_number":41,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":41,"id":"9abb7d3a_8f5c8cee","line":38,"in_reply_to":"9abb7d3a_4292d758","updated":"2016-05-30 19:10:10.000000000","message":"I\u0027m not familiar with functional tests. Is it expected that the test environment might not be clean? Ie, that apart from this test, there may be other tests going on that can modify the environment?","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"84011a31ecb49fc6e68194791b8c309708b6a6b9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        port_list_uuid \u003d self.get_uuids_from_port_list()"},{"line_number":38,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], port_list_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_port_delete(self):"},{"line_number":41,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":41,"id":"7aa08908_f5cb9870","line":38,"in_reply_to":"9abb7d3a_8f5c8cee","updated":"2016-06-06 14:24:58.000000000","message":"Ruby, we have no strict rule for that, but it`s quite usual when we use one environment for development of several different tests, so it`s preferred to keep tests non-destructive. Thus environment can contain nodes, ports etc prepared for another tests.","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"09d49ed68efe64f150bfff03920c83a3e00f6720","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        3) check that port has been successfully created"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        port_list_uuid \u003d self.get_uuids_from_port_list()"},{"line_number":38,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], port_list_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_port_delete(self):"},{"line_number":41,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":41,"id":"9abb7d3a_4292d758","line":38,"in_reply_to":"bab6814e_3623fc59","updated":"2016-05-27 11:34:36.000000000","message":"Ruby, i tried to check for equality, and this leads test to failure in condition when test environment has some ports created before test.","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"92ea77f106202664f2d3d8b2b62f07ab52715197","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.delete_port(self.port[\u0027uuid\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        port_list_uuid \u003d self.get_uuids_from_port_list()"},{"line_number":55,"context_line":"        self.assertNotIn(self.port[\u0027uuid\u0027], port_list_uuid)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_port_show(self):"},{"line_number":58,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_56e5e006","line":55,"updated":"2016-05-26 13:19:09.000000000","message":"in fact, port_list_uuid should be empty","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"09d49ed68efe64f150bfff03920c83a3e00f6720","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.delete_port(self.port[\u0027uuid\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        port_list_uuid \u003d self.get_uuids_from_port_list()"},{"line_number":55,"context_line":"        self.assertNotIn(self.port[\u0027uuid\u0027], port_list_uuid)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_port_show(self):"},{"line_number":58,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":41,"id":"9abb7d3a_e25f8b73","line":55,"in_reply_to":"bab6814e_56e5e006","updated":"2016-05-27 11:34:36.000000000","message":"Here also list should be empty in scope of test but can contain something if testing environment is not clean.","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"92ea77f106202664f2d3d8b2b62f07ab52715197","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        3) check that port-show returns the same port UUID as port-create"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        port_show \u003d self.show_port(self.port[\u0027uuid\u0027])"},{"line_number":65,"context_line":"        self.assertEqual(self.port[\u0027uuid\u0027], port_show[\u0027uuid\u0027])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_port_update(self):"},{"line_number":68,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_d6943038","line":65,"updated":"2016-05-26 13:19:09.000000000","message":"Is this test sufficient? what if the port-show doesn\u0027t return all the info about the port that we\u0027re expecting? Or is that not part of a smoke test?","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5bc580d20433fd9ca1ae5a7b7df454a967233ea","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        3) check that port-show returns the same port UUID as port-create"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        port_show \u003d self.show_port(self.port[\u0027uuid\u0027])"},{"line_number":65,"context_line":"        self.assertEqual(self.port[\u0027uuid\u0027], port_show[\u0027uuid\u0027])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_port_update(self):"},{"line_number":68,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":41,"id":"9abb7d3a_cf47b41b","line":65,"in_reply_to":"9abb7d3a_22123363","updated":"2016-05-30 19:10:10.000000000","message":"ok","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"09d49ed68efe64f150bfff03920c83a3e00f6720","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        3) check that port-show returns the same port UUID as port-create"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        port_show \u003d self.show_port(self.port[\u0027uuid\u0027])"},{"line_number":65,"context_line":"        self.assertEqual(self.port[\u0027uuid\u0027], port_show[\u0027uuid\u0027])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_port_update(self):"},{"line_number":68,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":41,"id":"9abb7d3a_22123363","line":65,"in_reply_to":"bab6814e_d6943038","updated":"2016-05-27 11:34:36.000000000","message":"I\u0027d like to keep this patch for very basic smoke tests, and later create patch with more comprehensive tests for \"port-show\" command.","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"}],"ironicclient/tests/functional/test_port_ironicclient.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"9cc1cca09d503367c5b776e401840973ccf8f505","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from ironicclient.tests.functional import base"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class PortSanityTestIrovicClient(base.FunctionalTestBase):"},{"line_number":17,"context_line":"    \"\"\"Sanity tests for testing actions with Chassis"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Smoke test for the Ironic CLI commands which checks basic actions with"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_06f02390","line":16,"updated":"2015-11-02 17:49:34.000000000","message":"Typo: \"Irovic\" should be \"Ironic\".","commit_id":"d2eda7d6f2a98bc42416210078b0ad153b3ac3c3"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"9cc1cca09d503367c5b776e401840973ccf8f505","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\"Test scenario:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        1) create port"},{"line_number":38,"context_line":"        2) check that port exists in shassis-show object"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        port \u003d self.create_port()"},{"line_number":41,"context_line":"        port_show \u003d self.show_port(port[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_0647c3bc","line":38,"updated":"2015-11-02 17:49:34.000000000","message":"\"shassis\" should be \"chassis\". But shouldn\u0027t it be \"port-show\" anyway?","commit_id":"d2eda7d6f2a98bc42416210078b0ad153b3ac3c3"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"9cc1cca09d503367c5b776e401840973ccf8f505","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027port-update\u0027, params\u003d\u0027{0} replace node_uuid\u003d{1}\u0027"},{"line_number":69,"context_line":"            .format(port[\u0027uuid\u0027], node[\u0027uuid\u0027]))"},{"line_number":70,"context_line":"        updated_port \u003d self.get_dict_from_output(updated_port)"},{"line_number":71,"context_line":"        self.assertNotEqual(port[\u0027node_uuid\u0027],"},{"line_number":72,"context_line":"                            updated_port[\u0027node_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_064ca3c6","line":71,"updated":"2015-11-02 17:49:34.000000000","message":"Perhaps also test that updated_port[\u0027node_uuid\u0027] \u003d\u003d node[\u0027uuid\u0027]?","commit_id":"d2eda7d6f2a98bc42416210078b0ad153b3ac3c3"}],"ironicclient/tests/functional/utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9fbdb29792f1cf7cd4beecc54c0a22fc16b9b05d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import random"},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":"import uuid"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_5af89b7c","line":15,"updated":"2015-11-23 13:35:55.000000000","message":"Should be:\n\n import random\n import uuid\n\n import six","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9fbdb29792f1cf7cd4beecc54c0a22fc16b9b05d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def get_dict_from_output(output):"},{"line_number":21,"context_line":"    \"\"\"Create a dictionary from an output."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    :param output: the output of the cmd"},{"line_number":24,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_ba37474c","line":21,"updated":"2015-11-23 13:35:55.000000000","message":"It\u0027s better to update it in parent patch :)","commit_id":"9969529f6128c1d3f157db6a8d5d7ca78fca406f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2b8061d106ccd749113863794d11506db90a1067","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def generate_mac_address():"},{"line_number":52,"context_line":"    \"\"\"Genetate mac address.\"\"\""},{"line_number":53,"context_line":"    return \u0027:\u0027.join(random.choice(\u00270123456789abcdef\u0027) * 2 for x in range(6))"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_8bd433bd","line":53,"updated":"2015-11-26 15:35:27.000000000","message":"This may be fine for testing, but this function will generate macs with each of 6 sections containing 2 equal values, like 11:22:aa:22:11:ff. Might be good to come up with function that will generate truly random mac.","commit_id":"485e0685ebc064cf0c4c3c0a5839f3f479b4e254"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6ab737383157d340ea57df6b9e0ddd4d72731790","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import random"},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":"import uuid"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a7b0d38_6a7780d3","line":15,"updated":"2015-12-28 15:32:32.000000000","message":"should be:\n\n import random\n import uuid\n\n import six","commit_id":"693a1e1b27f3658a16f5ec80932f629b440ce8cc"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"02ac3d82136726ebf22e2b1248fba77a3076aae9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import random"},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":"import uuid"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa69d971_0cd3053a","line":15,"in_reply_to":"1a7b0d38_6a7780d3","updated":"2015-12-30 09:40:03.000000000","message":"Done","commit_id":"693a1e1b27f3658a16f5ec80932f629b440ce8cc"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"d0f0be77f70ecd823b42ef0de822421849501bb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"3afc51ec_05445872","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"updated":"2016-03-11 11:54:13.000000000","message":"you shouldn\u0027t update existing copyright","commit_id":"86d5dbc0ba163466bc6e7b1588175861bb3458b6"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"2a110b20516f19f31e2d558f0439b5208a394c2d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"3afc51ec_54e8c27c","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"in_reply_to":"3afc51ec_05445872","updated":"2016-03-11 16:21:12.000000000","message":"Anton, as far as i concerned it is not violation of copyright. It`s valid procedure to update year number in copyright marks.","commit_id":"86d5dbc0ba163466bc6e7b1588175861bb3458b6"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"936660377deff72d8cff79e975a3ba3608971879","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"1af94dfe_0e462e23","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"in_reply_to":"3afc51ec_05445872","updated":"2016-03-15 15:16:22.000000000","message":"Done","commit_id":"86d5dbc0ba163466bc6e7b1588175861bb3458b6"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"936660377deff72d8cff79e975a3ba3608971879","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":32,"id":"1af94dfe_2e416a0c","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"in_reply_to":"3afc51ec_54e8c27c","updated":"2016-03-15 15:16:22.000000000","message":"Done","commit_id":"86d5dbc0ba163466bc6e7b1588175861bb3458b6"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"bae8af236111fd870735694d103f446c0c2b5e23","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def generate_mac_address():"},{"line_number":53,"context_line":"    \"\"\"Genetate mac address.\"\"\""},{"line_number":54,"context_line":"    mac \u003d []"},{"line_number":55,"context_line":"    for _ in range(6):"},{"line_number":56,"context_line":"        mac.append(format(random.randint(0x00, 0xff), \u002702x\u0027))"}],"source_content_type":"text/x-python","patch_set":32,"id":"3afc51ec_2e310ced","line":53,"range":{"start_line":53,"start_character":7,"end_line":53,"end_character":15},"updated":"2016-03-14 18:16:04.000000000","message":"Generate","commit_id":"86d5dbc0ba163466bc6e7b1588175861bb3458b6"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"648f49c8047cd50d3338ce9dade75b04ab88a46b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return \"{0}-{1}\".format(prefix, suffix)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def generate_mac_address():"},{"line_number":53,"context_line":"    \"\"\"Genetate mac address.\"\"\""},{"line_number":54,"context_line":"    mac \u003d []"},{"line_number":55,"context_line":"    for _ in range(6):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a122d0e_1e5edf11","line":52,"updated":"2016-04-19 16:19:17.000000000","message":"It seems that we can simply use already written method from tempest_lib:\nhttps://github.com/openstack/tempest-lib/blob/master/tempest_lib/common/utils/data_utils.py#L105","commit_id":"7ffc4a30cc0f6ca3c6a6fd68ad636bdbcb51fc69"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"7ba57a9d7e053d46113b1d8e39f48c2162bfd3dc","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return \"{0}-{1}\".format(prefix, suffix)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def generate_mac_address():"},{"line_number":53,"context_line":"    \"\"\"Genetate mac address.\"\"\""},{"line_number":54,"context_line":"    mac \u003d []"},{"line_number":55,"context_line":"    for _ in range(6):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a122d0e_c8cc76bd","line":52,"in_reply_to":"1a122d0e_1e5edf11","updated":"2016-04-20 14:37:07.000000000","message":"Better to take it from tempest, because tempest_lib is  deprecated.\nhttps://github.com/openstack/tempest/blob/master/tempest/lib/common/utils/data_utils.py","commit_id":"7ffc4a30cc0f6ca3c6a6fd68ad636bdbcb51fc69"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8b0724e772086c9421dcc8cc346278e9111f4254","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_a6db627b","line":1,"updated":"2016-05-25 20:18:02.000000000","message":"We don\u0027t tend to update the copyright. Why did you do it? (I thought it was best to have the copyright date as the earlier date, not the date that you update the file.)","commit_id":"1331937773bb170be2cdfd125577f3d72e504896"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"32683e2445c6150ab0f97a706d2b36b4cd275190","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_02b67af8","line":1,"in_reply_to":"bab6814e_a6db627b","updated":"2016-05-26 11:57:58.000000000","message":"Done","commit_id":"1331937773bb170be2cdfd125577f3d72e504896"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8b0724e772086c9421dcc8cc346278e9111f4254","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def get_dict_from_output(output):"},{"line_number":21,"context_line":"    \"\"\"Create a dictionary from an output."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    :param output: list of dictionaries"},{"line_number":24,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_06534ee3","line":21,"updated":"2016-05-25 20:18:02.000000000","message":"Odd, it seems like I commented about this on another patch -- do you know which I am referring to? I prefer the original comment.","commit_id":"1331937773bb170be2cdfd125577f3d72e504896"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"32683e2445c6150ab0f97a706d2b36b4cd275190","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def get_dict_from_output(output):"},{"line_number":21,"context_line":"    \"\"\"Create a dictionary from an output."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    :param output: list of dictionaries"},{"line_number":24,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":40,"id":"bab6814e_3f5c774a","line":21,"in_reply_to":"bab6814e_06534ee3","updated":"2016-05-26 11:57:58.000000000","message":"Thanks, I understand which patch you are referring. Done","commit_id":"1331937773bb170be2cdfd125577f3d72e504896"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"92ea77f106202664f2d3d8b2b62f07ab52715197","unresolved":false,"context_lines":[{"line_number":20,"context_line":"def get_dict_from_output(output):"},{"line_number":21,"context_line":"    \"\"\"Parse list of dictionaries from output and return a dictionary."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    :param output: list of dictionaries with \u0027Property\u0027 and \u0027Value\u0027 as keys"},{"line_number":24,"context_line":"    \"\"\""},{"line_number":25,"context_line":"    obj \u003d {}"},{"line_number":26,"context_line":"    for item in output:"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_5675e0c8","line":23,"updated":"2016-05-26 13:19:09.000000000","message":"Since you have another patch that actually changes it to this, it is better if you just left this alone. Unless you have patches that are dependent on other patches.\n\nAlso, changing it here is a bit odd since it doesn\u0027t seem relevant to the rest of the patch.","commit_id":"03eddc6aa944a1c59943f3ab02cf65caa17da7c9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9fef4090d76b8640e134c5326947f0ae6a98b012","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def get_dict_from_output(output):"},{"line_number":22,"context_line":"    \"\"\"Create a dictionary from an output."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    :param output: list of dictionaries"},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":44,"id":"9abb7d3a_2f1c8011","line":22,"updated":"2016-05-30 19:09:47.000000000","message":"Why was this changed?","commit_id":"5d890e32b3c40d50bb56aa80c7831289a7bdad75"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9fef4090d76b8640e134c5326947f0ae6a98b012","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def generate_mac_address():"},{"line_number":53,"context_line":"    \"\"\"Genetate mac address.\"\"\""},{"line_number":54,"context_line":"    mac \u003d []"},{"line_number":55,"context_line":"    for _ in range(6):"},{"line_number":56,"context_line":"        mac.append(format(random.randint(0x00, 0xff), \u002702x\u0027))"}],"source_content_type":"text/x-python","patch_set":44,"id":"9abb7d3a_6f2de845","line":53,"updated":"2016-05-30 19:09:47.000000000","message":"s/Genetate/Generate/","commit_id":"5d890e32b3c40d50bb56aa80c7831289a7bdad75"}]}
