)]}'
{"ironicclient/v1/node_shell.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"5826c27eba22ad6292f582748bcd3bf708ebd0e1","unresolved":false,"context_lines":[{"line_number":345,"context_line":"@cliutils.arg(\u0027node\u0027,"},{"line_number":346,"context_line":"              metavar\u003d\u0027\u003cnode\u003e\u0027,"},{"line_number":347,"context_line":"              nargs\u003d\u0027+\u0027,"},{"line_number":348,"context_line":"              help\u003d\"Name or UUID of the node.\")"},{"line_number":349,"context_line":"@cliutils.arg("},{"line_number":350,"context_line":"    \u0027maintenance_mode\u0027,"},{"line_number":351,"context_line":"    metavar\u003d\u0027\u003cmaintenance-mode\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_f9c6fd66","line":348,"updated":"2015-11-06 10:26:33.000000000","message":"looks like a better help message is needed now","commit_id":"0c268b8e8d1454e7853dc0554613ab3acca577c2"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ba2700a5af1424732335e85e16eb8c35a9a56501","unresolved":false,"context_lines":[{"line_number":345,"context_line":"@cliutils.arg(\u0027node\u0027,"},{"line_number":346,"context_line":"              metavar\u003d\u0027\u003cnode\u003e\u0027,"},{"line_number":347,"context_line":"              nargs\u003d\u0027+\u0027,"},{"line_number":348,"context_line":"              help\u003d\"Name or UUID of the node.\")"},{"line_number":349,"context_line":"@cliutils.arg("},{"line_number":350,"context_line":"    \u0027maintenance_mode\u0027,"},{"line_number":351,"context_line":"    metavar\u003d\u0027\u003cmaintenance-mode\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_5c9a0e16","line":348,"in_reply_to":"fa80f949_f9c6fd66","updated":"2015-11-09 03:09:16.000000000","message":"Good point, will address with next patch.","commit_id":"0c268b8e8d1454e7853dc0554613ab3acca577c2"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"5826c27eba22ad6292f582748bcd3bf708ebd0e1","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    if args.reason and not maintenance_mode:"},{"line_number":364,"context_line":"        raise exceptions.CommandError(_(\u0027Cannot set \"reason\" when turning off \u0027"},{"line_number":365,"context_line":"                                        \u0027maintenance mode.\u0027))"},{"line_number":366,"context_line":"    for n in args.node:"},{"line_number":367,"context_line":"        cc.node.set_maintenance(args.node, maintenance_mode,"},{"line_number":368,"context_line":"                                maint_reason\u003dargs.reason)"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_99b331e9","line":366,"updated":"2015-11-06 10:26:33.000000000","message":"So you make n requests to API here if I\u0027m right,  it isn\u0027t good from performance side, could we send all nodes in one request?","commit_id":"0c268b8e8d1454e7853dc0554613ab3acca577c2"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ba2700a5af1424732335e85e16eb8c35a9a56501","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    if args.reason and not maintenance_mode:"},{"line_number":364,"context_line":"        raise exceptions.CommandError(_(\u0027Cannot set \"reason\" when turning off \u0027"},{"line_number":365,"context_line":"                                        \u0027maintenance mode.\u0027))"},{"line_number":366,"context_line":"    for n in args.node:"},{"line_number":367,"context_line":"        cc.node.set_maintenance(args.node, maintenance_mode,"},{"line_number":368,"context_line":"                                maint_reason\u003dargs.reason)"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_fcb5027e","line":366,"in_reply_to":"fa80f949_99b331e9","updated":"2015-11-09 03:09:16.000000000","message":"Yes, good idea, but ironic does not support bulk-api so far, so just call api for each node here, and will address this performance issue once bulk-api is ready, thanks.","commit_id":"0c268b8e8d1454e7853dc0554613ab3acca577c2"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"702537b8104bdd69c03751427c1c834708835e79","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":319,"context_line":"    default\u003d[],"},{"line_number":320,"context_line":"    help\u003d\"One or more port fields. Only these fields will be fetched from \""},{"line_number":321,"context_line":"         \"the server. an not be used when \u0027--detail\u0027 is specified.\")"},{"line_number":322,"context_line":"def do_node_port_list(cc, args):"},{"line_number":323,"context_line":"    \"\"\"List the ports associated with a node.\"\"\""},{"line_number":324,"context_line":"    if args.detail:"}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_dc69158d","line":321,"updated":"2015-11-09 09:02:55.000000000","message":"misspell？","commit_id":"c3e5995e48df05ac3d52d95ac2ec47f6f221d375"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"702537b8104bdd69c03751427c1c834708835e79","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        raise exceptions.CommandError(_(\u0027Cannot set \"reason\" when turning off \u0027"},{"line_number":365,"context_line":"                                        \u0027maintenance mode.\u0027))"},{"line_number":366,"context_line":"    for n in args.node:"},{"line_number":367,"context_line":"        cc.node.set_maintenance(args.node, maintenance_mode,"},{"line_number":368,"context_line":"                                maint_reason\u003dargs.reason)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_5ca44556","line":367,"updated":"2015-11-09 09:02:55.000000000","message":"s/args.node/n/","commit_id":"c3e5995e48df05ac3d52d95ac2ec47f6f221d375"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"2a91d6470141dcb6007f463683d959d3095aa550","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        raise exceptions.CommandError(_(\u0027Cannot set \"reason\" when turning off \u0027"},{"line_number":365,"context_line":"                                        \u0027maintenance mode.\u0027))"},{"line_number":366,"context_line":"    for n in args.node:"},{"line_number":367,"context_line":"        cc.node.set_maintenance(args.node, maintenance_mode,"},{"line_number":368,"context_line":"                                maint_reason\u003dargs.reason)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_c74b7e58","line":367,"in_reply_to":"da85f559_5ca44556","updated":"2015-11-09 09:09:16.000000000","message":"args.node is a list of nodes and can no be recognized by Ironic API","commit_id":"c3e5995e48df05ac3d52d95ac2ec47f6f221d375"}]}