)]}'
{"ironicclient/v1/node_shell.py":[{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"461b53c098920d4464b805bae6ec4bc738e6ceba","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    \u0027node\u0027,"},{"line_number":439,"context_line":"    metavar\u003d\u0027\u003cnode\u003e\u0027,"},{"line_number":440,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":441,"context_line":"    help\u003d\"One or more Name/UUID of the node(s).\")"},{"line_number":442,"context_line":"@cliutils.arg("},{"line_number":443,"context_line":"    \u0027device\u0027,"},{"line_number":444,"context_line":"    metavar\u003d\u0027\u003cboot-device\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_d0c44660","line":441,"updated":"2015-11-18 05:17:03.000000000","message":"Better to indicate the separator of this \u0027node\u0027 argument, such as space or comma.\n\nBesides this help information about \u0027node\u0027 arguments, the help information of command \u0027node-set-boot-device\u0027, which is \u0027Set the boot device for a node.\u0027 should also be changed.","commit_id":"712d74a24025a40da588d4121932fa81575f1632"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"4396891ff81b25114d2459c661a5a7bd057a6255","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    \u0027node\u0027,"},{"line_number":439,"context_line":"    metavar\u003d\u0027\u003cnode\u003e\u0027,"},{"line_number":440,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":441,"context_line":"    help\u003d\"One or more Name/UUID of the node(s).\")"},{"line_number":442,"context_line":"@cliutils.arg("},{"line_number":443,"context_line":"    \u0027device\u0027,"},{"line_number":444,"context_line":"    metavar\u003d\u0027\u003cboot-device\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_3db48acf","line":441,"in_reply_to":"ba8a016a_d0c44660","updated":"2015-11-18 07:07:31.000000000","message":"By default, we take space as the command arguments separator, the command should be as below format:\n\nironic node-set-boot-device \u003cnode\u003e [\u003cnode\u003e ...] ...\n\nSo it should be clear with default space as the separator.\n\nAnd for the help message, you are right, it need to be synced, thanks for the good comments.","commit_id":"712d74a24025a40da588d4121932fa81575f1632"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"461b53c098920d4464b805bae6ec4bc738e6ceba","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    help\u003d\"Make changes persistent for all future boots.\")"},{"line_number":453,"context_line":"def do_node_set_boot_device(cc, args):"},{"line_number":454,"context_line":"    \"\"\"Set the boot device for each node.\"\"\""},{"line_number":455,"context_line":"    for n in args.node:"},{"line_number":456,"context_line":"        cc.node.set_boot_device(n, args.device, args.persistent)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_b0c9827a","line":455,"updated":"2015-11-18 05:17:03.000000000","message":"nit: maybe change \u0027n\u0027 to \u0027node\u0027 is more readable.","commit_id":"712d74a24025a40da588d4121932fa81575f1632"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"4396891ff81b25114d2459c661a5a7bd057a6255","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    help\u003d\"Make changes persistent for all future boots.\")"},{"line_number":453,"context_line":"def do_node_set_boot_device(cc, args):"},{"line_number":454,"context_line":"    \"\"\"Set the boot device for each node.\"\"\""},{"line_number":455,"context_line":"    for n in args.node:"},{"line_number":456,"context_line":"        cc.node.set_boot_device(n, args.device, args.persistent)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_9dc5763d","line":455,"in_reply_to":"ba8a016a_b0c9827a","updated":"2015-11-18 07:07:31.000000000","message":"ok, looks better:)","commit_id":"712d74a24025a40da588d4121932fa81575f1632"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7f057087d58be44bc86c3d4ecdd6bef81f28dd90","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    \u0027node\u0027,"},{"line_number":439,"context_line":"    metavar\u003d\u0027\u003cnode\u003e\u0027,"},{"line_number":440,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":441,"context_line":"    help\u003d\"One or more Name/UUID of the node(s).\")"},{"line_number":442,"context_line":"@cliutils.arg("},{"line_number":443,"context_line":"    \u0027device\u0027,"},{"line_number":444,"context_line":"    metavar\u003d\u0027\u003cboot-device\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_f81618a6","line":441,"updated":"2016-03-01 17:38:42.000000000","message":"lower case name","commit_id":"15d1a0204bd843e379c6657191234e7cdf1c6db4"}]}