)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"9e0ba0db7cf1848d68020211c769ac7da7b0ba8a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lin Tan \u003clin.tan@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-17 14:48:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027--node\u0027 to port-list to support list port with this node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027--node\u0027 parameter to port-list. This will only list all nodes"},{"line_number":10,"context_line":"bind to the node, which can be name or UUID of this node."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_5b7c3672","line":7,"updated":"2015-11-17 07:20:48.000000000","message":"This title is longer than 50.","commit_id":"9919de217a85288facef58400fc91946caf1bc75"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"9e0ba0db7cf1848d68020211c769ac7da7b0ba8a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027--node\u0027 to port-list to support list port with this node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027--node\u0027 parameter to port-list. This will only list all nodes"},{"line_number":10,"context_line":"bind to the node, which can be name or UUID of this node."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iad7c87aed7aa2c41a8174a97dfce9633e6266627"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_9b829e51","line":9,"updated":"2015-11-17 07:20:48.000000000","message":"all ports?","commit_id":"9919de217a85288facef58400fc91946caf1bc75"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"090ad5f677867d8a6e969a49ffb6fca68bbc6da7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027--node\u0027 to port-list to support list port with this node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027--node\u0027 parameter to port-list. This will only list all nodes"},{"line_number":10,"context_line":"bind to the node, which can be name or UUID of this node."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iad7c87aed7aa2c41a8174a97dfce9633e6266627"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_1923e106","line":9,"in_reply_to":"ba8a016a_9b829e51","updated":"2015-11-18 02:31:00.000000000","message":"Thanks","commit_id":"9919de217a85288facef58400fc91946caf1bc75"}],"ironicclient/tests/unit/v1/test_port.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9454e8b9ab7b498a2deca4f3f9bc73edeae676ba","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            (\u0027GET\u0027, \u0027/v1/ports/detail?node\u003d%s\u0027 % PORT[\u0027node_uuid\u0027], {}, None),"},{"line_number":217,"context_line":"        ]"},{"line_number":218,"context_line":"        self.assertEqual(expect, self.api.calls)"},{"line_number":219,"context_line":"        self.assertEqual(2, len(ports))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_port_list_fields(self):"},{"line_number":222,"context_line":"        ports \u003d self.mgr.list(fields\u003d[\u0027uuid\u0027, \u0027address\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_5b3bd6eb","line":219,"updated":"2015-11-17 07:41:12.000000000","message":"Can we add more negative case code to cover invalid node_uuid case?","commit_id":"9919de217a85288facef58400fc91946caf1bc75"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"e5b4343f28aa74d4f432a3883e3f9f7196dc356e","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        self.assertEqual(expect, self.api.calls)"},{"line_number":203,"context_line":"        self.assertEqual(1, len(ports))"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def test_ports_list_by_node(self):"},{"line_number":206,"context_line":"        ports \u003d self.mgr.list(node\u003dPORT[\u0027node_uuid\u0027])"},{"line_number":207,"context_line":"        expect \u003d ["},{"line_number":208,"context_line":"            (\u0027GET\u0027, \u0027/v1/ports/?node\u003d%s\u0027 % PORT[\u0027node_uuid\u0027], {}, None),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_a02131fd","line":205,"updated":"2015-11-18 07:20:49.000000000","message":"As your another patch adding new test cases about the \u0027node_name\u0027 about \u0027node-port-list\u0027 command, maybe also need add name related tests here too.","commit_id":"3c262855439e223ca37280a26d6b45598844f5f9"}],"ironicclient/v1/port.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"757b58ad8c3d86964c750483157d06ea3830f38b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                       fields)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if node is not None:"},{"line_number":83,"context_line":"            filters.append(\u0027node\u003d%s\u0027 % node)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if address is not None:"},{"line_number":86,"context_line":"            filters.append(\u0027address\u003d%s\u0027 % address)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_689ff203","line":83,"updated":"2015-11-17 07:12:46.000000000","message":"concern: should we also add logic to check if the input node uuid is valid/existing here, and how about the expected behavior for such wrong node uuid case, will return nothing or nod not found error message?","commit_id":"9919de217a85288facef58400fc91946caf1bc75"}]}