)]}'
{"id":"openstack%2Fpython-ironicclient~246216","triplet_id":"openstack%2Fpython-ironicclient~master~Iad7c87aed7aa2c41a8174a97dfce9633e6266627","project":"openstack/python-ironicclient","branch":"master","topic":"port_list","hashtags":[],"change_id":"Iad7c87aed7aa2c41a8174a97dfce9633e6266627","subject":"Add \u0027--node\u0027 to port-list","status":"ABANDONED","created":"2015-11-17 06:58:51.000000000","updated":"2016-02-16 06:48:50.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"126e58c676363d254c4017f7b43915252d4af5ac","_number":246216,"virtual_id_number":246216,"owner":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":1,"date":"2015-11-18 03:13:24.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},{"value":-1,"date":"2015-11-18 07:20:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-17 07:12:46.000000000","updated_by":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"reviewer":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"state":"REVIEWER"},{"updated":"2015-11-17 07:20:48.000000000","updated_by":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"reviewer":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"state":"REVIEWER"},{"updated":"2015-11-18 03:13:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-11-18 07:20:49.000000000","updated_by":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"reviewer":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"state":"REVIEWER"}],"messages":[{"id":"5657d6f68c361dd22129241dc6aa1605877e6efd","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-11-17 06:58:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"757b58ad8c3d86964c750483157d06ea3830f38b","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2015-11-17 07:12:46.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nTan, thanks for your patch, left concern inline.","accounts_in_message":[],"_revision_number":1},{"id":"9e0ba0db7cf1848d68020211c769ac7da7b0ba8a","author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"date":"2015-11-17 07:20:48.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nTwo comments on the commit message.","accounts_in_message":[],"_revision_number":1},{"id":"9454e8b9ab7b498a2deca4f3f9bc73edeae676ba","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2015-11-17 07:41:12.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ec6849f90c64824c555dca49cafa69170e1be56a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-17 07:53:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python26 http://logs.openstack.org/16/246216/1/check/gate-python-ironicclient-python26/bc8247d/ : SUCCESS in 1m 20s\n- gate-python-ironicclient-python34 http://logs.openstack.org/16/246216/1/check/gate-python-ironicclient-python34/3ce6209/ : SUCCESS in 1m 34s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/16/246216/1/check/gate-python-ironicclient-pep8/674f488/ : SUCCESS in 1m 08s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/16/246216/1/check/gate-python-ironicclient-docs/cd28977//doc/build/html/ : SUCCESS in 1m 17s\n- gate-python-ironicclient-python27 http://logs.openstack.org/16/246216/1/check/gate-python-ironicclient-python27/7b3ae7e/ : SUCCESS in 1m 18s\n- gate-python-ironicclient-pypy http://logs.openstack.org/16/246216/1/check/gate-python-ironicclient-pypy/5adf5fe/ : SUCCESS in 2m 11s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/16/246216/1/check/gate-tempest-dsvm-python-ironicclient-src/cace8b8/ : SUCCESS in 46m 48s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/16/246216/1/check/gate-ironicclient-dsvm-functional/91cb1aa/ : SUCCESS in 21m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"090ad5f677867d8a6e969a49ffb6fca68bbc6da7","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-11-18 02:31:00.000000000","message":"Patch Set 1:\n\n(1 comment)\n\ngood point Haomeng, but If node is non-existing or invalid, Ironic service will validate or return `Node could not be found` exception. It seems a little duplicate effort to do here.\n\nMeanwhile, node could be UUID or logical_name. There is a non-trivial logical to validate the node_name with different API version. If we add this in ironicclient, it will be a little wired from my opinion. So I prefer to pass what users input to Ironic service and let Ironic service do validation.","accounts_in_message":[],"_revision_number":1},{"id":"1b8649d67c14d1229b9214be1c2237170c5d3b68","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-11-18 02:31:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1e041eb57d838e0b06aa2fad47a84df39fe518d5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-18 03:13:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/16/246216/2/check/gate-python-ironicclient-python34/2f02029/ : SUCCESS in 1m 09s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/16/246216/2/check/gate-python-ironicclient-pep8/ef50cf0/ : SUCCESS in 57s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/16/246216/2/check/gate-python-ironicclient-docs/6398539//doc/build/html/ : SUCCESS in 55s\n- gate-python-ironicclient-python27 http://logs.openstack.org/16/246216/2/check/gate-python-ironicclient-python27/4b436b8/ : SUCCESS in 46s\n- gate-python-ironicclient-pypy http://logs.openstack.org/16/246216/2/check/gate-python-ironicclient-pypy/b63294f/ : SUCCESS in 1m 26s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/16/246216/2/check/gate-tempest-dsvm-python-ironicclient-src/d828197/ : SUCCESS in 35m 02s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/16/246216/2/check/gate-ironicclient-dsvm-functional/1ca9418/ : SUCCESS in 22m 30s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e5b4343f28aa74d4f432a3883e3f9f7196dc356e","author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"date":"2015-11-18 07:20:49.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nThanks for the patch. A comment inline, please check.\n\nBesides, I wonder if the user feels confused when he or she facing \u0027node-port-list\u0027 and \u0027port-list --node\u0027 these two commands with the same functionality.","accounts_in_message":[],"_revision_number":2},{"id":"c85823c0ff1dbae55ed234f9f88ddd723d6e4e1f","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2016-02-16 06:48:50.000000000","message":"Abandoned\n\nthe endpoint is already supported by cli","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3c262855439e223ca37280a26d6b45598844f5f9","revisions":{"9919de217a85288facef58400fc91946caf1bc75":{"kind":"REWORK","_number":1,"created":"2015-11-17 06:58:51.000000000","uploader":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"ref":"refs/changes/16/246216/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/16/246216/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/16/246216/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/16/246216/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/16/246216/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/16/246216/1"}}},"commit":{"parents":[{"commit":"1ced89b9e99ddefbc1e77495f1a430f4e7de6e84","subject":"Introduce tempest-lib to functional tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/1ced89b9e99ddefbc1e77495f1a430f4e7de6e84"}]}],"author":{"name":"Lin Tan","email":"lin.tan@intel.com","date":"2015-11-17 06:48:36.000000000","tz":480},"committer":{"name":"Lin Tan","email":"lin.tan@intel.com","date":"2015-11-17 06:48:36.000000000","tz":480},"subject":"Add \u0027--node\u0027 to port-list to support list port with this node","message":"Add \u0027--node\u0027 to port-list to support list port with this node\n\nAdd \u0027--node\u0027 parameter to port-list. This will only list all nodes\nbind to the node, which can be name or UUID of this node.\n\nChange-Id: Iad7c87aed7aa2c41a8174a97dfce9633e6266627\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/9919de217a85288facef58400fc91946caf1bc75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/9919de217a85288facef58400fc91946caf1bc75"}]},"branch":"refs/heads/master"},"3c262855439e223ca37280a26d6b45598844f5f9":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-11-18 02:31:32.000000000","uploader":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"ref":"refs/changes/16/246216/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/16/246216/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/16/246216/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/16/246216/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/16/246216/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/16/246216/2"}}},"commit":{"parents":[{"commit":"1ced89b9e99ddefbc1e77495f1a430f4e7de6e84","subject":"Introduce tempest-lib to functional tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/1ced89b9e99ddefbc1e77495f1a430f4e7de6e84"}]}],"author":{"name":"Lin Tan","email":"lin.tan@intel.com","date":"2015-11-17 06:48:36.000000000","tz":480},"committer":{"name":"Lin Tan","email":"lin.tan@intel.com","date":"2015-11-18 02:11:09.000000000","tz":480},"subject":"Add \u0027--node\u0027 to port-list","message":"Add \u0027--node\u0027 to port-list\n\nAdd \u0027--node\u0027 parameter to port-list. This will only list ports\nbind to the node. `node` can be name or UUID of this node.\n\nThis seems a duplicate functionality to node-port-list, but as\nIronic service provides both of them: \u0027/v1/nodes/%(node)s/ports\u0027\nand \u0027/v1/ports/?node\u003d%(node)s\u0027, it is better to explore both\nand let users choose by themselfs.\n\nChange-Id: Iad7c87aed7aa2c41a8174a97dfce9633e6266627\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/3c262855439e223ca37280a26d6b45598844f5f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/3c262855439e223ca37280a26d6b45598844f5f9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}