)]}'
{"id":"openstack%2Fpython-ironicclient~246732","triplet_id":"openstack%2Fpython-ironicclient~master~I27793a7d3360eeb48b2ab628e3772458cc232a65","project":"openstack/python-ironicclient","branch":"master","topic":"clituils","hashtags":[],"change_id":"I27793a7d3360eeb48b2ab628e3772458cc232a65","subject":"Add more unit tests for clituils","status":"MERGED","created":"2015-11-18 03:25:56.000000000","updated":"2015-11-25 16:42:05.000000000","submitted":"2015-11-25 16:42:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"842d04ed267aed095c25b725ed3b5f01bbe931ee","_number":246732,"virtual_id_number":246732,"owner":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-11-19 08:16:08.000000000","_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":2,"date":"2015-11-25 16:42:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"recommended":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"all":[{"value":0,"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-11-24 09:02:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":2,"date":"2015-11-25 15:53:16.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":1,"date":"2015-11-18 06:29:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"value":2,"date":"2015-11-23 17:51:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":1,"date":"2015-11-25 15:53:16.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-18 06:29:40.000000000","updated_by":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"reviewer":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"state":"REVIEWER"},{"updated":"2015-11-23 17:51:00.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2015-11-24 09:02:45.000000000","updated_by":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"reviewer":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"state":"REVIEWER"},{"updated":"2015-11-25 15:53:16.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2015-11-25 16:42:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ec0bf2509361bb75a50e8910f8bb3099ec3e1d41","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-11-18 03:25:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f648ed4791588630d8d01a534451d0e9a441da33","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-18 04:18:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/32/246732/1/check/gate-python-ironicclient-python34/e5ca3ad/ : SUCCESS in 1m 52s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/32/246732/1/check/gate-python-ironicclient-pep8/c3b948a/ : SUCCESS in 1m 09s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/32/246732/1/check/gate-python-ironicclient-docs/dcaf3cc//doc/build/html/ : SUCCESS in 1m 38s\n- gate-python-ironicclient-python27 http://logs.openstack.org/32/246732/1/check/gate-python-ironicclient-python27/0849ac9/ : SUCCESS in 1m 22s\n- gate-python-ironicclient-pypy http://logs.openstack.org/32/246732/1/check/gate-python-ironicclient-pypy/2f54334/ : SUCCESS in 1m 45s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/32/246732/1/check/gate-tempest-dsvm-python-ironicclient-src/5c439b6/ : SUCCESS in 46m 59s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/32/246732/1/check/gate-ironicclient-dsvm-functional/c5b7d0a/ : SUCCESS in 24m 10s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"51f9c7943ea57c7988372aeaad2124321bfa23a9","author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"date":"2015-11-18 06:29:40.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nThanks for the patch. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"68c73490b71624f22aebfd31c8fa83ba0cce097a","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-11-18 12:18:00.000000000","message":"Patch Set 1: Code-Review-1\n\nWhy do we need unit test for oslo-incubator utils? Look like oslo-incubator has them already: https://github.com/openstack/oslo-incubator/blob/master/tests/unit/test_cliutils.py\n\nIf you want to increase test coverage, you should add missing to incubator tests, imo we should delete duplicating tests, not add new one.","accounts_in_message":[],"_revision_number":1},{"id":"ed840f8a4330c0a961611c2f1bd57f90a74aafae","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-11-19 08:16:08.000000000","message":"Patch Set 1:\n\nHi Anton, we recently make a local copy of clituils in ironicclient because clituils will be removed from oslo-incubator. We have to maintain it by ourselfs. So that\u0027s why I add unit tests here.","accounts_in_message":[],"_revision_number":1},{"id":"67d4cc0c5c0844b6b139e6cce4b70c528a1da22c","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-11-19 08:41:15.000000000","message":"Patch Set 1: -Code-Review\n\nTan Lin, thanks for clarification, so they just remove it w/o moving to some oslo namespace?","accounts_in_message":[],"_revision_number":1},{"id":"9b48302eea100a0211c706f4fc808c435f4df034","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-11-23 17:51:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a7715652db4b536ab96c02856877bef8ec4b518e","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-11-24 09:02:45.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"065a4bb87bb8b3913b39b1d2656e9b97f949b1ce","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-11-25 15:53:16.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThanks Tan Lin :)","accounts_in_message":[],"_revision_number":1},{"id":"b8e52b2930ba955b8e1544873b8483c14ce325ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 15:53:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3332db6ebf6aab26371e1deedc888b07bc335b52","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 16:42:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/32/246732/1/gate/gate-python-ironicclient-python34/f31e89c/ : SUCCESS in 2m 24s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/32/246732/1/gate/gate-python-ironicclient-docs/a4d4163//doc/build/html/ : SUCCESS in 1m 57s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/32/246732/1/gate/gate-python-ironicclient-pep8/6641c9f/ : SUCCESS in 1m 11s\n- gate-python-ironicclient-python27 http://logs.openstack.org/32/246732/1/gate/gate-python-ironicclient-python27/b2233e8/ : SUCCESS in 1m 12s\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/32/246732/1/gate/gate-tempest-dsvm-python-ironicclient-src/7c83810/ : SUCCESS in 37m 53s","accounts_in_message":[],"_revision_number":1},{"id":"2a25bc1659fef9fa3bff53d3fbed44da4fb7b63b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 16:42:05.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0a7f17908f65964b32bdd5f5d15b7647d5198578","revisions":{"0a7f17908f65964b32bdd5f5d15b7647d5198578":{"kind":"REWORK","_number":1,"created":"2015-11-18 03:25:56.000000000","uploader":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"ref":"refs/changes/32/246732/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/32/246732/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/32/246732/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/32/246732/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/32/246732/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/32/246732/1"}}},"commit":{"parents":[{"commit":"1073a5469bf0407fd46ce39a9e384bfc0aa1ae1a","subject":"Merge \"Use keystoneclient.exception directly\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/1073a5469bf0407fd46ce39a9e384bfc0aa1ae1a"}]}],"author":{"name":"Lin Tan","email":"lin.tan@intel.com","date":"2015-11-18 03:18:07.000000000","tz":480},"committer":{"name":"Lin Tan","email":"lin.tan@intel.com","date":"2015-11-18 03:23:12.000000000","tz":480},"subject":"Add more unit tests for clituils","message":"Add more unit tests for clituils\n\nAdd more unit tests for clituils after add new functionality.\n\nChange-Id: I27793a7d3360eeb48b2ab628e3772458cc232a65\nDepends-On: be5e26a176f039faf1169cff63af4c6f1ebb2e9e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/0a7f17908f65964b32bdd5f5d15b7647d5198578"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/0a7f17908f65964b32bdd5f5d15b7647d5198578"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}