)]}'
{"ironicclient/common/apiclient/base.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0ae786590b4baa26f2e243d523b200edf57d1114","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        if not isinstance(other, self.__class__):"},{"line_number":506,"context_line":"            return False"},{"line_number":507,"context_line":"        if hasattr(self, \u0027id\u0027) and hasattr(other, \u0027id\u0027):"},{"line_number":508,"context_line":"            return self.id \u003d\u003d other.id"},{"line_number":509,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def is_loaded(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_5be17e99","side":"PARENT","line":508,"updated":"2015-12-05 03:53:53.000000000","message":"It seems like this test should still be here, but if they differ it should return false. And if they are equal continue on to the next line.\n\nBut I could be wrong!","commit_id":"861b1f4b8e00d9cbc70be182fc362124903cb5d3"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"2626e3d0cd74e68674a589638e68178dccfa10ed","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        if not isinstance(other, self.__class__):"},{"line_number":506,"context_line":"            return False"},{"line_number":507,"context_line":"        if hasattr(self, \u0027id\u0027) and hasattr(other, \u0027id\u0027):"},{"line_number":508,"context_line":"            return self.id \u003d\u003d other.id"},{"line_number":509,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def is_loaded(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_62ea6911","side":"PARENT","line":508,"in_reply_to":"7a740942_5be17e99","updated":"2015-12-07 10:05:06.000000000","message":"I am wondering where is the self.id come from? From getid() function, see line 50, It looks like obj.id is the id index in DB. So if two objects have the same id, they are identical obviously. So there is no problem with the old logical I think.","commit_id":"861b1f4b8e00d9cbc70be182fc362124903cb5d3"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"387f45ceae7898e70ffd30c5b2144a43f3271efa","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        if not isinstance(other, self.__class__):"},{"line_number":506,"context_line":"            return False"},{"line_number":507,"context_line":"        if hasattr(self, \u0027id\u0027) and hasattr(other, \u0027id\u0027):"},{"line_number":508,"context_line":"            return self.id \u003d\u003d other.id"},{"line_number":509,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def is_loaded(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_b83084e9","side":"PARENT","line":508,"in_reply_to":"7a740942_62ea6911","updated":"2015-12-07 10:21:28.000000000","message":"Two resources have same id, that don\u0027t mean they are same(self.__eq__() return True), please see the bug description.\n\nhttps://bugs.launchpad.net/oslo-incubator/+bug/1499369","commit_id":"861b1f4b8e00d9cbc70be182fc362124903cb5d3"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"ac71f2d058ed7bd0d963187eee23483b074644a7","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        if not isinstance(other, self.__class__):"},{"line_number":506,"context_line":"            return False"},{"line_number":507,"context_line":"        if hasattr(self, \u0027id\u0027) and hasattr(other, \u0027id\u0027):"},{"line_number":508,"context_line":"            return self.id \u003d\u003d other.id"},{"line_number":509,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def is_loaded(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_8ff7c3f4","side":"PARENT","line":508,"in_reply_to":"7a740942_b83084e9","updated":"2015-12-10 07:35:15.000000000","message":"OK, I get it. Thanks.","commit_id":"861b1f4b8e00d9cbc70be182fc362124903cb5d3"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"387f45ceae7898e70ffd30c5b2144a43f3271efa","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            return False"},{"line_number":507,"context_line":"        if hasattr(self, \u0027id\u0027) and hasattr(other, \u0027id\u0027):"},{"line_number":508,"context_line":"            return self.id \u003d\u003d other.id"},{"line_number":509,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def is_loaded(self):"},{"line_number":512,"context_line":"        return self._loaded"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_559cc9bf","side":"PARENT","line":509,"updated":"2015-12-07 10:21:28.000000000","message":"If the two resources have different \u0027id\u0027, False return at here. So I think we can remove the above logic.","commit_id":"861b1f4b8e00d9cbc70be182fc362124903cb5d3"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"ac71f2d058ed7bd0d963187eee23483b074644a7","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            return False"},{"line_number":507,"context_line":"        if hasattr(self, \u0027id\u0027) and hasattr(other, \u0027id\u0027):"},{"line_number":508,"context_line":"            return self.id \u003d\u003d other.id"},{"line_number":509,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def is_loaded(self):"},{"line_number":512,"context_line":"        return self._loaded"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_cfbe2bd4","side":"PARENT","line":509,"in_reply_to":"7a740942_559cc9bf","updated":"2015-12-10 07:35:15.000000000","message":"But I think you could save some efforts to check the id attribute only rather than compare the dictionary(_info). Not quite sure if this is necessary.","commit_id":"861b1f4b8e00d9cbc70be182fc362124903cb5d3"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"fade9c5dd5a88020bedb065d448956e303168795","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            return False"},{"line_number":507,"context_line":"        if hasattr(self, \u0027id\u0027) and hasattr(other, \u0027id\u0027):"},{"line_number":508,"context_line":"            return self.id \u003d\u003d other.id"},{"line_number":509,"context_line":"        return self._info \u003d\u003d other._info"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def is_loaded(self):"},{"line_number":512,"context_line":"        return self._loaded"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_3dc6db9a","side":"PARENT","line":509,"in_reply_to":"7a740942_cfbe2bd4","updated":"2015-12-16 07:51:24.000000000","message":"I prefer less logic, we can get the same return value from \"self._info \u003d\u003d other._info\", so I think redundant code isn\u0027t necessary.","commit_id":"861b1f4b8e00d9cbc70be182fc362124903cb5d3"}]}