)]}'
{"id":"openstack%2Fpython-ironicclient~252150","triplet_id":"openstack%2Fpython-ironicclient~master~Ic77a86196d5bcd956f0a3ae517200824a4d70aa8","project":"openstack/python-ironicclient","branch":"master","topic":"refactoring-base-manager","hashtags":[],"change_id":"Ic77a86196d5bcd956f0a3ae517200824a4d70aa8","subject":"Refactoring and removing duplicate code of \"base.Manager\" heirs without changing the API","status":"MERGED","created":"2015-12-02 02:33:46.000000000","updated":"2015-12-13 02:00:44.000000000","submitted":"2015-12-13 02:00:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":21,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2c477cc4e934b5bd32c1cba05804afce51280a90","_number":252150,"virtual_id_number":252150,"owner":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-12-13 02:00:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"recommended":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":1,"date":"2015-12-11 14:36:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2015-12-11 13:16:04.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":2,"date":"2015-12-13 01:24:07.000000000","_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},{"value":2,"date":"2015-12-11 20:32:41.000000000","_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":1,"date":"2015-12-13 01:24:07.000000000","_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-07 17:13:32.000000000","updated_by":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"reviewer":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"state":"REVIEWER"},{"updated":"2015-12-09 09:44:51.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2015-12-11 13:16:04.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2015-12-11 14:36:45.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2015-12-11 20:32:41.000000000","updated_by":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"reviewer":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"state":"REVIEWER"},{"updated":"2015-12-13 01:24:07.000000000","updated_by":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"reviewer":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"state":"REVIEWER"},{"updated":"2015-12-13 02:00:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4c8ecd5f0c74100c125d913d5fde59fe53f5181c","author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"date":"2015-12-02 02:33:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d7d6ab5083e0354f58751762834754687d89bac4","author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"date":"2015-12-02 02:34:20.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"03ef884deb0523c08b0f4386c3482ffbfb5c6383","author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"date":"2015-12-02 02:40:14.000000000","message":"Patch Set 3: Commit message was updated","accounts_in_message":[],"_revision_number":3},{"id":"591ce2e7485aa7700051a8461b3415907ea6ccd8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-02 03:33:15.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/50/252150/3/check/gate-python-ironicclient-python34/244b5df/ : SUCCESS in 1m 49s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/50/252150/3/check/gate-python-ironicclient-pep8/1347a5e/ : SUCCESS in 1m 10s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/50/252150/3/check/gate-python-ironicclient-docs/2335042//doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-ironicclient-python27 http://logs.openstack.org/50/252150/3/check/gate-python-ironicclient-python27/bd3cb1f/ : SUCCESS in 1m 16s\n- gate-python-ironicclient-pypy http://logs.openstack.org/50/252150/3/check/gate-python-ironicclient-pypy/ee25dae/ : SUCCESS in 2m 08s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/50/252150/3/check/gate-tempest-dsvm-python-ironicclient-src/991bd78/ : SUCCESS in 46m 24s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/50/252150/3/check/gate-ironicclient-dsvm-functional/91f72f5/ : SUCCESS in 19m 52s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6fc66731cccc67d54d30155c801e44bccfacc114","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-12-05 21:28:24.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"8b57283395f32ff456f80c7be0df768b88815539","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-12-06 04:06:16.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b81b75d93b2c4e1c6459d0ddc5dcfe3910ec4f19","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2015-12-07 17:13:32.000000000","message":"Patch Set 3:\n\nHi Sinval, does it make sense to move the stuff from this change https://review.openstack.org/#/c/254246/ here? If so I\u0027ll abandon that one. Or you could rebase on top.","accounts_in_message":[],"_revision_number":3},{"id":"288e44cb949c12050747664562910183ba642bd7","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2015-12-07 17:14:44.000000000","message":"Patch Set 3:\n\nOh, nevermind, Dmitry is now happy with it :)","accounts_in_message":[],"_revision_number":3},{"id":"ed29ba4aefc8efe5e8111336630b5073125f1531","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2015-12-07 18:43:38.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"ea9a7ed26b75854242633e217219aca1b1bf55a8","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-12-07 18:59:55.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"3bf1c540c813ec5b8da52cdbb70c2d36bbd38ab9","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-12-07 19:01:48.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"ec773c4a9a6f9375311f23d0d589040cf85f8879","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-12-07 19:04:18.000000000","message":"Patch Set 3: Code-Review-1","accounts_in_message":[],"_revision_number":3},{"id":"6b9b61ab1b585af85c093bd4117e70152b3431d8","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2015-12-07 19:06:34.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"5ba17473c368138d6ca400650caffe79d955413a","author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"date":"2015-12-08 18:26:12.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"b587da1461e433d1e98ec82db718a003e0af39cb","author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"date":"2015-12-08 18:39:38.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"6c3cee3eaca82916c1767814627d80cdde5954d5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-08 21:08:31.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/50/252150/4/check/gate-python-ironicclient-python34/dc49fc2/ : SUCCESS in 1m 59s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/50/252150/4/check/gate-python-ironicclient-pep8/eaecdc1/ : SUCCESS in 1m 22s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/50/252150/4/check/gate-python-ironicclient-docs/68c980b//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-ironicclient-python27 http://logs.openstack.org/50/252150/4/check/gate-python-ironicclient-python27/9b19ad6/ : SUCCESS in 1m 23s\n- gate-python-ironicclient-pypy http://logs.openstack.org/50/252150/4/check/gate-python-ironicclient-pypy/b6ac88e/ : SUCCESS in 2m 35s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/50/252150/4/check/gate-tempest-dsvm-python-ironicclient-src/b2825a5/ : SUCCESS in 43m 10s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/50/252150/4/check/gate-ironicclient-dsvm-functional/ba5d4c9/ : SUCCESS in 26m 06s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"a7ed442c5fbb42b50a146009388e7b0c2638d28a","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-12-09 03:58:46.000000000","message":"Patch Set 4: Code-Review+2\n\nSinval, this looks good to me. The API is maintained.\n\nThanks for the patch.","accounts_in_message":[],"_revision_number":4},{"id":"0cbfa383cdfabcee5606e2d485ee278d5abb5fc6","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-12-09 09:44:51.000000000","message":"Patch Set 4: Code-Review+1\n\n(4 comments)\n\nsome comments inline, not sure if we want them to be fixed in this revision","accounts_in_message":[],"_revision_number":4},{"id":"1595aa43510acd19b8b54b6f12a7469bdb087f4d","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-12-09 12:07:35.000000000","message":"Patch Set 4: -Code-Review\n\nDmitry has made me change my mind, so changing vote :)","accounts_in_message":[],"_revision_number":4},{"id":"5e81d6be9b0707993b9f6d1a829e69b2cd5ff97b","author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"date":"2015-12-09 22:31:31.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"7932cb7919a69fb9ffb45c8f6ef995d9afa45699","author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"date":"2015-12-09 22:32:00.000000000","message":"Patch Set 4:\n\n(4 comments)\n\nThanks Dmitry","accounts_in_message":[],"_revision_number":4},{"id":"b6a6f08bfd7308c435c8fdf133bd3079c9cf2455","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-09 23:47:29.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/50/252150/5/check/gate-python-ironicclient-python34/f32d483/ : SUCCESS in 1m 56s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/50/252150/5/check/gate-python-ironicclient-pep8/5a69112/ : SUCCESS in 1m 12s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/50/252150/5/check/gate-python-ironicclient-docs/cd1ebce//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-ironicclient-python27 http://logs.openstack.org/50/252150/5/check/gate-python-ironicclient-python27/e85ddc1/ : SUCCESS in 1m 33s\n- gate-python-ironicclient-pypy http://logs.openstack.org/50/252150/5/check/gate-python-ironicclient-pypy/905c503/ : SUCCESS in 2m 13s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/50/252150/5/check/gate-tempest-dsvm-python-ironicclient-src/0c9ca74/ : SUCCESS in 47m 58s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/50/252150/5/check/gate-ironicclient-dsvm-functional/2bb80ca/ : SUCCESS in 24m 57s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"22fbc202be8509816279330688f6e847cc6c43ac","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-12-11 13:16:04.000000000","message":"Patch Set 5: Code-Review+2\n\nThanks Sinval","accounts_in_message":[],"_revision_number":5},{"id":"5023df4c87a14aab4d2d92f7ba9fb360d6e70f5b","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2015-12-11 14:36:45.000000000","message":"Patch Set 5: Code-Review+1\n\nLooks good to me.  Additionally we have a canary revision in bifrost that is dependent upon this revision which as of a few days ago was passing CI testing without any issues.  I\u0027ve gone ahead and rechecked it this morning, but I expect it to pass after reviewing the code.","accounts_in_message":[],"_revision_number":5},{"id":"94f1e01e432e1070c524e473d18ae563a0a311fc","author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"date":"2015-12-11 20:32:41.000000000","message":"Patch Set 5: Code-Review+2\n\nThank you Sinval. LGTM... holding +a for a bit, so other reviewers can verify their concerns have been addressed.","accounts_in_message":[],"_revision_number":5},{"id":"d40e5292f6c9fe474c88e44d75ea284715e5e147","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2015-12-13 01:24:07.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nThanks Sinval.","accounts_in_message":[],"_revision_number":5},{"id":"e465fba91a802b177e0ce11e696e067a1f294e17","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-13 01:24:14.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"1173e5b8cea395530679eb8bbfc27c12ea039cb9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-13 02:00:43.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/50/252150/5/gate/gate-python-ironicclient-python34/0468d7a/ : SUCCESS in 1m 55s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/50/252150/5/gate/gate-python-ironicclient-docs/d776e64//doc/build/html/ : SUCCESS in 1m 46s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/50/252150/5/gate/gate-python-ironicclient-pep8/b255869/ : SUCCESS in 1m 12s\n- gate-python-ironicclient-python27 http://logs.openstack.org/50/252150/5/gate/gate-python-ironicclient-python27/b8af887/ : SUCCESS in 1m 09s\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/50/252150/5/gate/gate-tempest-dsvm-python-ironicclient-src/381a01c/ : SUCCESS in 36m 28s","accounts_in_message":[],"_revision_number":5},{"id":"fba31e9510938d6346cc0123b9ab4b193e594939","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-13 02:00:44.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"20cefcf0bd6f9cd0fe3e77a27ac68160152b2150","revisions":{"9099795d1e1af859d9d15c6c5a0f71bcd245e02e":{"kind":"REWORK","_number":1,"created":"2015-12-02 02:33:46.000000000","uploader":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"ref":"refs/changes/50/252150/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/50/252150/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/1"}}},"commit":{"parents":[{"commit":"ada67331a934ec18647b529cf3b2b8d9d16cf01e","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ada67331a934ec18647b529cf3b2b8d9d16cf01e"}]}],"author":{"name":"Sinval Vieira","email":"sinvalneto01@gmail.com","date":"2015-12-02 02:30:04.000000000","tz":-180},"committer":{"name":"Sinval Vieira","email":"sinvalneto01@gmail.com","date":"2015-12-02 02:33:42.000000000","tz":-180},"subject":"Refactoring and removing duplicate code of \"base.Manager\" heirs without changing the API","message":"Refactoring and removing duplicate code of \"base.Manager\" heirs\nwithout changing the API\n\nThis commit does refactoring regarding the base.Manager and the\nspecific managers that inherit from it (Chassis, Node, Port and\nDriver).\n\nThe specific managers had a lot of duplicate code in methods like:\nget, create and vendor_passthru, they were literally equal, what does\nnot make sense once we already had the base.Manager inheritance to\navoid this type of problem.\n\nThis change moves the duplicate code to the parent (base.Manager) and\nmake the specific managers simpler by making the base.Manager more\nuseful regarding code reuse for these methods.\n\nChange-Id: Ic77a86196d5bcd956f0a3ae517200824a4d70aa8\nCloses-Bug: #1517631\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/9099795d1e1af859d9d15c6c5a0f71bcd245e02e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/9099795d1e1af859d9d15c6c5a0f71bcd245e02e"}]},"branch":"refs/heads/master"},"b002335ffb106376fc8bcd5fb1c9f5eee4c321b9":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-12-02 02:34:20.000000000","uploader":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"ref":"refs/changes/50/252150/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/50/252150/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/2"}}},"commit":{"parents":[{"commit":"ada67331a934ec18647b529cf3b2b8d9d16cf01e","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ada67331a934ec18647b529cf3b2b8d9d16cf01e"}]}],"author":{"name":"Sinval Vieira","email":"sinvalneto01@gmail.com","date":"2015-12-02 02:30:04.000000000","tz":-180},"committer":{"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","date":"2015-12-02 02:34:20.000000000","tz":0},"subject":"Refactoring and removing duplicate code of \"base.Manager\" heirs without changing the API","message":"Refactoring and removing duplicate code of \"base.Manager\" heirs without changing the API\n\nThis commit does refactoring regarding the base.Manager and the\nspecific managers that inherit from it (Chassis, Node, Port and\nDriver).\n\nThe specific managers had a lot of duplicate code in methods like:\nget, create and vendor_passthru, they were literally equal, what does\nnot make sense once we already had the base.Manager inheritance to\navoid this type of problem.\n\nThis change moves the duplicate code to the parent (base.Manager) and\nmake the specific managers simpler by making the base.Manager more\nuseful regarding code reuse for these methods.\n\nChange-Id: Ic77a86196d5bcd956f0a3ae517200824a4d70aa8\nCloses-Bug: #1517631\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/b002335ffb106376fc8bcd5fb1c9f5eee4c321b9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/b002335ffb106376fc8bcd5fb1c9f5eee4c321b9"}]},"branch":"refs/heads/master"},"d9d0b1551193447610ceb80f219215e5a1b7f818":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-12-02 02:40:14.000000000","uploader":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"ref":"refs/changes/50/252150/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/50/252150/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/3"}}},"commit":{"parents":[{"commit":"ada67331a934ec18647b529cf3b2b8d9d16cf01e","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ada67331a934ec18647b529cf3b2b8d9d16cf01e"}]}],"author":{"name":"Sinval Vieira","email":"sinvalneto01@gmail.com","date":"2015-12-02 02:30:04.000000000","tz":-180},"committer":{"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","date":"2015-12-02 02:40:14.000000000","tz":0},"subject":"Refactoring and removing duplicate code of \"base.Manager\" heirs","message":"Refactoring and removing duplicate code of \"base.Manager\" heirs\n\nThis commit does refactoring regarding the base.Manager and the\nspecific managers that inherit from it (Chassis, Node, Port and\nDriver).\n\nThe specific managers had a lot of duplicate code in methods like:\nget, create and vendor_passthru, they were literally equal, what does\nnot make sense once we already had the base.Manager inheritance to\navoid this type of problem.\n\nThis change moves the duplicate code to the parent (base.Manager) and\nmake the specific managers simpler by making the base.Manager more\nuseful regarding code reuse for these methods.\n\nChange-Id: Ic77a86196d5bcd956f0a3ae517200824a4d70aa8\nCloses-Bug: #1517631\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/d9d0b1551193447610ceb80f219215e5a1b7f818"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/d9d0b1551193447610ceb80f219215e5a1b7f818"}]},"branch":"refs/heads/master"},"282412eab072cb58cbdef97a26a4c32a340d9a7c":{"kind":"REWORK","_number":4,"created":"2015-12-08 18:39:38.000000000","uploader":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"ref":"refs/changes/50/252150/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/50/252150/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/4"}}},"commit":{"parents":[{"commit":"ada67331a934ec18647b529cf3b2b8d9d16cf01e","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ada67331a934ec18647b529cf3b2b8d9d16cf01e"}]}],"author":{"name":"Sinval Vieira","email":"sinvalneto01@gmail.com","date":"2015-12-02 02:30:04.000000000","tz":-180},"committer":{"name":"Sinval Vieira","email":"sinvalneto01@gmail.com","date":"2015-12-08 18:38:51.000000000","tz":-180},"subject":"Refactoring and removing duplicate code of \"base.Manager\" heirs without changing the API","message":"Refactoring and removing duplicate code of \"base.Manager\" heirs\nwithout changing the API\n\nThis commit does refactoring regarding the base.Manager and the\nspecific managers that inherit from it (Chassis, Node, Port and\nDriver).\n\nThe specific managers had a lot of duplicate code in methods like:\nget, create, delete and update, they were literally equal, what does\nnot make sense once we already had the base.Manager inheritance to\navoid this type of problem.\n\nThis change moves the duplicate code to the parent (base.Manager) and\nmake the specific managers simpler by making the base.Manager more\nuseful regarding code reuse for these methods.\n\nChange-Id: Ic77a86196d5bcd956f0a3ae517200824a4d70aa8\nCloses-Bug: #1517631\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/282412eab072cb58cbdef97a26a4c32a340d9a7c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/282412eab072cb58cbdef97a26a4c32a340d9a7c"}]},"branch":"refs/heads/master"},"20cefcf0bd6f9cd0fe3e77a27ac68160152b2150":{"kind":"REWORK","_number":5,"created":"2015-12-09 22:31:31.000000000","uploader":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"ref":"refs/changes/50/252150/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/50/252150/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/50/252150/5"}}},"commit":{"parents":[{"commit":"ada67331a934ec18647b529cf3b2b8d9d16cf01e","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ada67331a934ec18647b529cf3b2b8d9d16cf01e"}]}],"author":{"name":"Sinval Vieira","email":"sinvalneto01@gmail.com","date":"2015-12-02 02:30:04.000000000","tz":-180},"committer":{"name":"Sinval Vieira","email":"sinvalneto01@gmail.com","date":"2015-12-09 22:31:20.000000000","tz":-180},"subject":"Refactoring and removing duplicate code of \"base.Manager\" heirs without changing the API","message":"Refactoring and removing duplicate code of \"base.Manager\" heirs\nwithout changing the API\n\nThis commit does refactoring regarding the base.Manager and the\nspecific managers that inherit from it (Chassis, Node, Port and\nDriver).\n\nThe specific managers had a lot of duplicate code in methods like:\nget, create, delete and update, they were literally equal, what does\nnot make sense once we already had the base.Manager inheritance to\navoid this type of problem.\n\nThis change moves the duplicate code to the parent (base.Manager) and\nmake the specific managers simpler by making the base.Manager more\nuseful regarding code reuse for these methods.\n\nChange-Id: Ic77a86196d5bcd956f0a3ae517200824a4d70aa8\nCloses-Bug: #1517631\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/20cefcf0bd6f9cd0fe3e77a27ac68160152b2150"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/20cefcf0bd6f9cd0fe3e77a27ac68160152b2150"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
