)]}'
{"id":"openstack%2Fpython-ironicclient~252769","triplet_id":"openstack%2Fpython-ironicclient~master~I4f8a15bb78919ffea14f745e5d0e9657c028752d","project":"openstack/python-ironicclient","branch":"master","topic":"node-create-chassis","hashtags":[],"change_id":"I4f8a15bb78919ffea14f745e5d0e9657c028752d","subject":"Make node-create --chassis_uuid required","status":"ABANDONED","created":"2015-12-03 06:28:49.000000000","updated":"2015-12-10 06:36:27.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"584b681a45a445624fa6e6754a62edebc61bb2e6","_number":252769,"virtual_id_number":252769,"owner":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-12-03 06:47:27.000000000","_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":-1,"date":"2015-12-03 07:14:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-12-03 15:01:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"all":[{"value":-1,"date":"2015-12-04 00:58:21.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-03 07:14:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-12-03 15:01:07.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"}],"messages":[{"id":"125089c6689b7d7f0cac283bddeb4649f0b0eb99","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-12-03 06:28:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a8bd32ef0bd1bd4491ef86fadcadf3141a9f8be","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-12-03 06:47:27.000000000","message":"Patch Set 1:\n\nShould we make chassis_uuid required or remove it from mandatory_attrs? I wonder the necessary of keep chassis_uuid as a must at the moment?","accounts_in_message":[],"_revision_number":1},{"id":"2d1470860862007aef55ccddf08bb5870b20215c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 07:14:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/69/252769/1/check/gate-python-ironicclient-python34/83fac7a/ : SUCCESS in 1m 47s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/69/252769/1/check/gate-python-ironicclient-pep8/c0377ae/ : SUCCESS in 1m 03s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/69/252769/1/check/gate-python-ironicclient-docs/6dd1b78//doc/build/html/ : SUCCESS in 1m 41s\n- gate-python-ironicclient-python27 http://logs.openstack.org/69/252769/1/check/gate-python-ironicclient-python27/474518c/ : SUCCESS in 1m 11s\n- gate-python-ironicclient-pypy http://logs.openstack.org/69/252769/1/check/gate-python-ironicclient-pypy/db96d32/ : SUCCESS in 2m 26s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/69/252769/1/check/gate-tempest-dsvm-python-ironicclient-src/c7ece54/ : FAILURE in 41m 00s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/69/252769/1/check/gate-ironicclient-dsvm-functional/912cfe5/ : FAILURE in 27m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f79d652b5313470d26cbf333dd5b5e92759e9d09","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-12-03 15:01:07.000000000","message":"Patch Set 1: Code-Review-1\n\nI missed something. Where do you see that chassis UUID is mandatory? I have been creating nodes w/o chassis, so if you see that it is mandatory somewhere we should fix it.\n\nAlso, even if we were to do this -- it would break backwards compatibility since I was able to create nodes before w/o specifying this. Which should warrant some discussion and a bug!","accounts_in_message":[],"_revision_number":1},{"id":"9853dd9002efe4a4e90594a04caecaaea0449814","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-12-04 00:57:53.000000000","message":"Patch Set 1:\n\nOK, sorry for my old master. chassis_uuid was a mandatory attribute several days before \n*https://github.com/openstack/ironic/commit/34b3589ea3c9e87b8ba370f122a37ac4eb2d9afd\nNow it was only a _extra_non_removable_attrs \"not required for object creation, but should not be removable if they are set\"","accounts_in_message":[],"_revision_number":1},{"id":"4858717035c9ebe0b4e5a0a6a00bb20acb1bf944","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-12-04 00:58:21.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"21c6bf4765a60019760ab86e77d44808380d45e2","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2015-12-10 06:36:27.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7ac6b7d52456f3b3c1a256fa3cbfae290f2c54d8","revisions":{"7ac6b7d52456f3b3c1a256fa3cbfae290f2c54d8":{"kind":"REWORK","_number":1,"created":"2015-12-03 06:28:49.000000000","uploader":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"ref":"refs/changes/69/252769/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/69/252769/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/69/252769/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/69/252769/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/69/252769/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/69/252769/1"}}},"commit":{"parents":[{"commit":"ada67331a934ec18647b529cf3b2b8d9d16cf01e","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ada67331a934ec18647b529cf3b2b8d9d16cf01e"}]}],"author":{"name":"Lin Tan","email":"lin.tan@intel.com","date":"2015-12-03 06:22:47.000000000","tz":480},"committer":{"name":"Lin Tan","email":"lin.tan@intel.com","date":"2015-12-03 06:22:47.000000000","tz":480},"subject":"Make node-create --chassis_uuid required","message":"Make node-create --chassis_uuid required\n\nchassis_uuid should be required as well as driver because both\nof them are mandatory_attrs in Ironic API, which means they cannot\nbe empty.\n\nChange-Id: I4f8a15bb78919ffea14f745e5d0e9657c028752d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7ac6b7d52456f3b3c1a256fa3cbfae290f2c54d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/7ac6b7d52456f3b3c1a256fa3cbfae290f2c54d8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}