)]}'
{"ironicclient/common/apiclient/exceptions.py":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"d4389bc3b1f79302272ca538761738d22adddc44","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    except KeyError:"},{"line_number":460,"context_line":"        if http_client.INTERNAL_SERVER_ERROR \u003c\u003d response.status_code \u003c 600:"},{"line_number":461,"context_line":"            cls \u003d HttpServerError"},{"line_number":462,"context_line":"        elif (http_client.BAD_REQUEST \u003c\u003d response.status_code \u003c"},{"line_number":463,"context_line":"                http_client.INTERNAL_SERVER_ERROR):"},{"line_number":464,"context_line":"            cls \u003d HTTPClientError"},{"line_number":465,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_9f825293","line":462,"updated":"2015-12-07 09:36:50.000000000","message":"use \u0027magic numbers\u0027 here is more readable, I think.","commit_id":"67cb23c3190cbb7d1704bddd35a03ae2ea71a83b"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"ee9a70da18b76e7ad1ede3b3e0013e2360cde23c","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    except KeyError:"},{"line_number":460,"context_line":"        if http_client.INTERNAL_SERVER_ERROR \u003c\u003d response.status_code \u003c 600:"},{"line_number":461,"context_line":"            cls \u003d HttpServerError"},{"line_number":462,"context_line":"        elif (http_client.BAD_REQUEST \u003c\u003d response.status_code \u003c"},{"line_number":463,"context_line":"                http_client.INTERNAL_SERVER_ERROR):"},{"line_number":464,"context_line":"            cls \u003d HTTPClientError"},{"line_number":465,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_7ba80b78","line":462,"in_reply_to":"7a740942_6499111f","updated":"2015-12-10 13:03:31.000000000","message":"Well, it\u0027s a trade off, I don\u0027t have any problem having the numbers here, but at least for me it is not more readable than it would be inconsistent with the rest of the code, so, I\u0027ll vote for the consistency approach.","commit_id":"67cb23c3190cbb7d1704bddd35a03ae2ea71a83b"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"1df1f2dd44f6254b55244b9738ac7cd3473eb374","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    except KeyError:"},{"line_number":460,"context_line":"        if http_client.INTERNAL_SERVER_ERROR \u003c\u003d response.status_code \u003c 600:"},{"line_number":461,"context_line":"            cls \u003d HttpServerError"},{"line_number":462,"context_line":"        elif (http_client.BAD_REQUEST \u003c\u003d response.status_code \u003c"},{"line_number":463,"context_line":"                http_client.INTERNAL_SERVER_ERROR):"},{"line_number":464,"context_line":"            cls \u003d HTTPClientError"},{"line_number":465,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_d871db45","line":462,"in_reply_to":"7a740942_7ba80b78","updated":"2015-12-11 02:38:07.000000000","message":"I think adding a comment here to show the \u0027magic number\u0027 according to the http state maybe a trade off solution, which will be consistent as well as readable.","commit_id":"67cb23c3190cbb7d1704bddd35a03ae2ea71a83b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a86715774f678a5899bfa1f13ae5129b809b8d7d","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    except KeyError:"},{"line_number":460,"context_line":"        if http_client.INTERNAL_SERVER_ERROR \u003c\u003d response.status_code \u003c 600:"},{"line_number":461,"context_line":"            cls \u003d HttpServerError"},{"line_number":462,"context_line":"        elif (http_client.BAD_REQUEST \u003c\u003d response.status_code \u003c"},{"line_number":463,"context_line":"                http_client.INTERNAL_SERVER_ERROR):"},{"line_number":464,"context_line":"            cls \u003d HTTPClientError"},{"line_number":465,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_6499111f","line":462,"in_reply_to":"7a740942_9f825293","updated":"2015-12-07 11:49:07.000000000","message":"I\u0027m not sure I agree. But even if I did, t I think consistency is preferred. But others may disagree with me :)","commit_id":"67cb23c3190cbb7d1704bddd35a03ae2ea71a83b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6db9d3c43bfc3314694c6ba74ece0c6a199dde53","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        cls \u003d _code_map[response.status_code]"},{"line_number":459,"context_line":"    except KeyError:"},{"line_number":460,"context_line":"        # 5XX status codes are server errors"},{"line_number":461,"context_line":"        if http_client.INTERNAL_SERVER_ERROR \u003c\u003d response.status_code \u003c 600:"},{"line_number":462,"context_line":"            cls \u003d HttpServerError"},{"line_number":463,"context_line":"        # 4XX status codes are client request errors"},{"line_number":464,"context_line":"        elif (http_client.BAD_REQUEST \u003c\u003d response.status_code \u003c"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_a9816491","line":461,"updated":"2015-12-15 11:25:38.000000000","message":"I wonder if we could just say\n\n if response.status_code \u003e\u003d http_client.INTERNAL_SERVER_ERROR","commit_id":"026f484ea9b2bca7f6976e719de8301880643c6e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"375840d5c5e54daebc4dba0c1d85a1672ea131ba","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        cls \u003d _code_map[response.status_code]"},{"line_number":459,"context_line":"    except KeyError:"},{"line_number":460,"context_line":"        # 5XX status codes are server errors"},{"line_number":461,"context_line":"        if http_client.INTERNAL_SERVER_ERROR \u003c\u003d response.status_code \u003c 600:"},{"line_number":462,"context_line":"            cls \u003d HttpServerError"},{"line_number":463,"context_line":"        # 4XX status codes are client request errors"},{"line_number":464,"context_line":"        elif (http_client.BAD_REQUEST \u003c\u003d response.status_code \u003c"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_edb6863c","line":461,"in_reply_to":"5a710552_a9816491","updated":"2015-12-15 16:03:39.000000000","message":"I had to rebase the patch, so done :)","commit_id":"026f484ea9b2bca7f6976e719de8301880643c6e"}],"ironicclient/common/http.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6db9d3c43bfc3314694c6ba74ece0c6a199dde53","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        else:"},{"line_number":349,"context_line":"            self.log_http_response(resp)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if http_client.BAD_REQUEST \u003c\u003d resp.status \u003c 600:"},{"line_number":352,"context_line":"            LOG.warning(_LW(\"Request returned failure status\"))"},{"line_number":353,"context_line":"            error_json \u003d _extract_error_json(body_str)"},{"line_number":354,"context_line":"            raise exc.from_response("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_e9776cd2","line":351,"updated":"2015-12-15 11:25:38.000000000","message":"ditto","commit_id":"026f484ea9b2bca7f6976e719de8301880643c6e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"375840d5c5e54daebc4dba0c1d85a1672ea131ba","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        else:"},{"line_number":349,"context_line":"            self.log_http_response(resp)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if http_client.BAD_REQUEST \u003c\u003d resp.status \u003c 600:"},{"line_number":352,"context_line":"            LOG.warning(_LW(\"Request returned failure status\"))"},{"line_number":353,"context_line":"            error_json \u003d _extract_error_json(body_str)"},{"line_number":354,"context_line":"            raise exc.from_response("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_6d81364a","line":351,"in_reply_to":"5a710552_e9776cd2","updated":"2015-12-15 16:03:39.000000000","message":"I had to rebase the patch, so done :)","commit_id":"026f484ea9b2bca7f6976e719de8301880643c6e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6db9d3c43bfc3314694c6ba74ece0c6a199dde53","unresolved":false,"context_lines":[{"line_number":505,"context_line":"            kwargs[\u0027headers\u0027][\u0027X-OpenStack-Ironic-API-Version\u0027] \u003d ("},{"line_number":506,"context_line":"                negotiated_ver)"},{"line_number":507,"context_line":"            return self._http_request(url, method, **kwargs)"},{"line_number":508,"context_line":"        if http_client.BAD_REQUEST \u003c\u003d resp.status_code \u003c 600:"},{"line_number":509,"context_line":"            error_json \u003d _extract_error_json(resp.content)"},{"line_number":510,"context_line":"            raise exc.from_response(resp, error_json.get(\u0027faultstring\u0027),"},{"line_number":511,"context_line":"                                    error_json.get(\u0027debuginfo\u0027), method, url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_097518ca","line":508,"updated":"2015-12-15 11:25:38.000000000","message":"ditto","commit_id":"026f484ea9b2bca7f6976e719de8301880643c6e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"375840d5c5e54daebc4dba0c1d85a1672ea131ba","unresolved":false,"context_lines":[{"line_number":505,"context_line":"            kwargs[\u0027headers\u0027][\u0027X-OpenStack-Ironic-API-Version\u0027] \u003d ("},{"line_number":506,"context_line":"                negotiated_ver)"},{"line_number":507,"context_line":"            return self._http_request(url, method, **kwargs)"},{"line_number":508,"context_line":"        if http_client.BAD_REQUEST \u003c\u003d resp.status_code \u003c 600:"},{"line_number":509,"context_line":"            error_json \u003d _extract_error_json(resp.content)"},{"line_number":510,"context_line":"            raise exc.from_response(resp, error_json.get(\u0027faultstring\u0027),"},{"line_number":511,"context_line":"                                    error_json.get(\u0027debuginfo\u0027), method, url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_ed8d267c","line":508,"in_reply_to":"5a710552_097518ca","updated":"2015-12-15 16:03:39.000000000","message":"I had to rebase the patch, so done :)","commit_id":"026f484ea9b2bca7f6976e719de8301880643c6e"}]}