)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"e82197eaf8f8abc5af922ec452ea843ef0402ed2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Turivnyi \u003csturivnyi@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-22 12:01:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with port."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":10,"context_line":"port-show, port-update and port-delete using them either without"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"da0c15f0_04043c15","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":45},"updated":"2016-03-25 12:30:53.000000000","message":"btw, point is not necessary at end of commit message header.","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Turivnyi \u003csturivnyi@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-22 12:01:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with port."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":10,"context_line":"port-show, port-update and port-delete using them either without"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba0121b8_07bf5961","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":45},"in_reply_to":"ba0121b8_15afbf2a","updated":"2016-04-01 12:56:11.000000000","message":"Done","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"181020742ef41a241a9800f1911a8c526f2dd4b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Turivnyi \u003csturivnyi@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-22 12:01:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with port."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":10,"context_line":"port-show, port-update and port-delete using them either without"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba0121b8_15afbf2a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":45},"in_reply_to":"da0c15f0_04043c15","updated":"2016-03-31 12:02:43.000000000","message":"++, not sure why pep8 passes.","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Turivnyi \u003csturivnyi@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-22 12:01:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with port."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":10,"context_line":"port-show, port-update and port-delete using them either without"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba0121b8_a78dcdd4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":45},"in_reply_to":"da0c15f0_04043c15","updated":"2016-04-01 12:56:11.000000000","message":"Done","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"181020742ef41a241a9800f1911a8c526f2dd4b4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Negative tests for testing actions with port."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":10,"context_line":"port-show, port-update and port-delete using them either without"},{"line_number":11,"context_line":"arguments or with incorrect arguments."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6a265f6c73da4a7b14e89ec869832abc26d81cb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba0121b8_15885fc4","line":10,"updated":"2016-03-31 12:02:43.000000000","message":"ditto, I don\u0027t see any port-update tests.","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Negative tests for testing actions with port."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":10,"context_line":"port-show, port-update and port-delete using them either without"},{"line_number":11,"context_line":"arguments or with incorrect arguments."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6a265f6c73da4a7b14e89ec869832abc26d81cb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba0121b8_e7c185e5","line":10,"in_reply_to":"ba0121b8_15885fc4","updated":"2016-04-01 12:56:11.000000000","message":"Done","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e38872aaea8db46a0248e55131288ac1dc919f97","unresolved":false,"context_lines":[{"line_number":11,"context_line":"arguments or with incorrect arguments."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6a265f6c73da4a7b14e89ec869832abc26d81cb9"},{"line_number":14,"context_line":"Closes-Bug: #1527521"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba0121b8_b6509ad5","line":14,"updated":"2016-03-31 12:20:33.000000000","message":"Also, are you sure that after this is merged the bug is closed completely? Maybe partial-bug?","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"arguments or with incorrect arguments."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6a265f6c73da4a7b14e89ec869832abc26d81cb9"},{"line_number":14,"context_line":"Closes-Bug: #1527521"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba0121b8_27b89d74","line":14,"in_reply_to":"ba0121b8_b6509ad5","updated":"2016-04-01 12:56:11.000000000","message":"yes","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"897f38ffb48b8fa6268330ae69417d0185b10ea6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Turivnyi \u003csturivnyi@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-01 08:55:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":8,"context_line":"port-show, and port-delete using them either without arguments or"},{"line_number":9,"context_line":"with incorrect arguments."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"9a061dce_b1ba10bf","line":7,"updated":"2016-04-04 09:57:39.000000000","message":"Please fix the commit message. Every line should be no longer than 72 characters and commit message header preferably to be less than 50 characters.","commit_id":"a3893a45128174fc601670337beee935d1c09e13"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1a5bef690b7289809e918a88a7b4cc1109fd68da","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Negative tests for port-related commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tests which check port-create, port-show, and port-delete"},{"line_number":10,"context_line":"using them either without arguments or with incorrect arguments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527521"},{"line_number":13,"context_line":"Change-Id: I6a265f6c73da4a7b14e89ec869832abc26d81cb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"3ac371cc_8690ff44","line":10,"updated":"2016-08-16 16:02:49.000000000","message":"I found this hard to parse/understand. See test_port.py for suggestions.","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"c4f3d1d79dc25101658b9a717258998e44b89e96","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Negative tests for port-related commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tests which check port-create, port-show, and port-delete"},{"line_number":10,"context_line":"using them either without arguments or with incorrect arguments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527521"},{"line_number":13,"context_line":"Change-Id: I6a265f6c73da4a7b14e89ec869832abc26d81cb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"1ac06dbe_5880728b","line":10,"in_reply_to":"3ac371cc_8690ff44","updated":"2016-08-23 07:24:49.000000000","message":"Done","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"c4f3d1d79dc25101658b9a717258998e44b89e96","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Negative tests for port-related commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tests which check port-create, port-show, and port-delete"},{"line_number":10,"context_line":"using them either without arguments or with incorrect arguments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527521"},{"line_number":13,"context_line":"Change-Id: I6a265f6c73da4a7b14e89ec869832abc26d81cb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"1ac06dbe_b3cd49b9","line":10,"in_reply_to":"3ac371cc_8690ff44","updated":"2016-08-23 07:24:49.000000000","message":"Done","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1a5bef690b7289809e918a88a7b4cc1109fd68da","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Tests which check port-create, port-show, and port-delete"},{"line_number":10,"context_line":"using them either without arguments or with incorrect arguments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527521"},{"line_number":13,"context_line":"Change-Id: I6a265f6c73da4a7b14e89ec869832abc26d81cb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"3ac371cc_862c7f03","line":12,"updated":"2016-08-16 16:02:49.000000000","message":"How does this close the bug? I see other patches with negative functional tests still. Or maybe the bug needs to be updated -- is this bug for port-related commands only?","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"c4f3d1d79dc25101658b9a717258998e44b89e96","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Tests which check port-create, port-show, and port-delete"},{"line_number":10,"context_line":"using them either without arguments or with incorrect arguments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1527521"},{"line_number":13,"context_line":"Change-Id: I6a265f6c73da4a7b14e89ec869832abc26d81cb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"1ac06dbe_53bdf500","line":12,"in_reply_to":"3ac371cc_862c7f03","updated":"2016-08-23 07:24:49.000000000","message":"Done","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"}],"ironicclient/tests/functional/base.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"f67fd221bd1cb08262a1c45be2f05e2c666e2683","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            params\u003d\u0027{0} {1} {2}\u0027.format(chassis_id, operation, params))"},{"line_number":289,"context_line":"        return utils.get_dict_from_output(updated_chassis)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def delete_port(self, port_id, check\u003d\u0027True\u0027):"},{"line_number":292,"context_line":"        if check \u003d\u003d \u0027True\u0027:"},{"line_number":293,"context_line":"            port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":294,"context_line":"            if port_id in port_list_uuid:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bae84128_522555ac","line":291,"range":{"start_line":291,"start_character":42,"end_line":291,"end_character":46},"updated":"2016-02-25 10:54:06.000000000","message":"to bool, please make it consistency with node-delete","commit_id":"f1b5fe55f3069a9a99470834710c774a7e6a1267"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bb58c5b86e0acf06909b9a16ab97900613e78619","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            params\u003d\u0027{0} {1} {2}\u0027.format(chassis_id, operation, params))"},{"line_number":289,"context_line":"        return utils.get_dict_from_output(updated_chassis)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def delete_port(self, port_id, check\u003d\u0027True\u0027):"},{"line_number":292,"context_line":"        if check \u003d\u003d \u0027True\u0027:"},{"line_number":293,"context_line":"            port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":294,"context_line":"            if port_id in port_list_uuid:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_2dcb3974","line":291,"range":{"start_line":291,"start_character":42,"end_line":291,"end_character":46},"in_reply_to":"bae84128_522555ac","updated":"2016-03-01 12:01:52.000000000","message":"Done","commit_id":"f1b5fe55f3069a9a99470834710c774a7e6a1267"}],"ironicclient/tests/functional/test_port.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2adfc3d900c4e920067cfc802acc167b160b93bf","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        super(PortNegativeTestIronicClient, self).setUp()"},{"line_number":98,"context_line":"        self.node \u003d self.create_node()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _delete_port(self, port_id):"},{"line_number":101,"context_line":"        self.ironic(\u0027port-delete\u0027, params\u003dport_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_1e24750b","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":36},"updated":"2015-12-23 10:01:04.000000000","message":"Why do you need one more method for port deleting, looks like it\u0027s reduntand?","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bf3dbea3ba84a7b6016fffc4e3c4fc66ec20be8f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        super(PortNegativeTestIronicClient, self).setUp()"},{"line_number":98,"context_line":"        self.node \u003d self.create_node()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _delete_port(self, port_id):"},{"line_number":101,"context_line":"        self.ironic(\u0027port-delete\u0027, params\u003dport_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_4203fb73","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":36},"in_reply_to":"1a7b0d38_1e24750b","updated":"2015-12-23 13:22:32.000000000","message":"I implemented it for negative tests. Base method delete_port() has many checks so you can\u0027t delete port in negative tests using base method.","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"53d42693c2e8973416cbecb95fa1fc473b58cac5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        super(PortNegativeTestIronicClient, self).setUp()"},{"line_number":98,"context_line":"        self.node \u003d self.create_node()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _delete_port(self, port_id):"},{"line_number":101,"context_line":"        self.ironic(\u0027port-delete\u0027, params\u003dport_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_a0b7c9f3","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":36},"in_reply_to":"1a7b0d38_4203fb73","updated":"2015-12-28 16:29:23.000000000","message":"Maybe it\u0027s worth changing base delete_port instead? E.g. consider that if it is called, port should exist (implemented as it is in this function)? And apply the same for port. And the extra checks can be done in tests where needed.","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"448754b05eea9a9d9a593d74668fd73d2d6041d1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        super(PortNegativeTestIronicClient, self).setUp()"},{"line_number":98,"context_line":"        self.node \u003d self.create_node()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _delete_port(self, port_id):"},{"line_number":101,"context_line":"        self.ironic(\u0027port-delete\u0027, params\u003dport_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_68cb3b73","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":36},"in_reply_to":"1a7b0d38_a0b7c9f3","updated":"2016-01-04 17:09:02.000000000","message":"Done","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2adfc3d900c4e920067cfc802acc167b160b93bf","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        1) try create port without node uuid"},{"line_number":111,"context_line":"        2) check that exception has been resed"},{"line_number":112,"context_line":"        \"\"\""},{"line_number":113,"context_line":"        self.assertRaises(exceptions.CommandFailed, self.create_port, \u0027\u0027)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_port_create_without_mac_address(self):"},{"line_number":116,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_be06811e","line":113,"range":{"start_line":113,"start_character":13,"end_line":113,"end_character":25},"updated":"2015-12-23 10:01:04.000000000","message":"maybe we could using assertRaisesRegexp, for matching which error is happened?","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"448754b05eea9a9d9a593d74668fd73d2d6041d1","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        1) try create port without node uuid"},{"line_number":111,"context_line":"        2) check that exception has been resed"},{"line_number":112,"context_line":"        \"\"\""},{"line_number":113,"context_line":"        self.assertRaises(exceptions.CommandFailed, self.create_port, \u0027\u0027)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_port_create_without_mac_address(self):"},{"line_number":116,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_a52aae7c","line":113,"range":{"start_line":113,"start_character":13,"end_line":113,"end_character":25},"in_reply_to":"1a7b0d38_20a9997b","updated":"2016-01-04 17:09:02.000000000","message":"Done","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"53d42693c2e8973416cbecb95fa1fc473b58cac5","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        1) try create port without node uuid"},{"line_number":111,"context_line":"        2) check that exception has been resed"},{"line_number":112,"context_line":"        \"\"\""},{"line_number":113,"context_line":"        self.assertRaises(exceptions.CommandFailed, self.create_port, \u0027\u0027)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_port_create_without_mac_address(self):"},{"line_number":116,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_20a9997b","line":113,"range":{"start_line":113,"start_character":13,"end_line":113,"end_character":25},"in_reply_to":"1a7b0d38_225a6f84","updated":"2015-12-28 16:29:23.000000000","message":"I\u0027m fine with either way :) But yeah, as long as all commands raise CommandFailed, it makes sense to check that the message contains some specific bits.","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bf3dbea3ba84a7b6016fffc4e3c4fc66ec20be8f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        1) try create port without node uuid"},{"line_number":111,"context_line":"        2) check that exception has been resed"},{"line_number":112,"context_line":"        \"\"\""},{"line_number":113,"context_line":"        self.assertRaises(exceptions.CommandFailed, self.create_port, \u0027\u0027)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_port_create_without_mac_address(self):"},{"line_number":116,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_225a6f84","line":113,"range":{"start_line":113,"start_character":13,"end_line":113,"end_character":25},"in_reply_to":"1a7b0d38_be06811e","updated":"2015-12-23 13:22:32.000000000","message":"Maybe, we should discuss it with Vladyslav Drok","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"53d42693c2e8973416cbecb95fa1fc473b58cac5","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        1) create node"},{"line_number":119,"context_line":"        2) try create port without node MAC address"},{"line_number":120,"context_line":"        3) check that exception has been resed"},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        self.assertRaises(exceptions.CommandFailed,"},{"line_number":123,"context_line":"                          self.create_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_60ca4150","line":120,"updated":"2015-12-28 16:29:23.000000000","message":"raised","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"448754b05eea9a9d9a593d74668fd73d2d6041d1","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        1) create node"},{"line_number":119,"context_line":"        2) try create port without node MAC address"},{"line_number":120,"context_line":"        3) check that exception has been resed"},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        self.assertRaises(exceptions.CommandFailed,"},{"line_number":123,"context_line":"                          self.create_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_48975748","line":120,"in_reply_to":"1a7b0d38_60ca4150","updated":"2016-01-04 17:09:02.000000000","message":"Done","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"53d42693c2e8973416cbecb95fa1fc473b58cac5","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        1) create node"},{"line_number":131,"context_line":"        2) try create port with incorrect node uuid"},{"line_number":132,"context_line":"        3) check that exception has been resed"},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        self.assertRaises(exceptions.CommandFailed,"},{"line_number":135,"context_line":"                          self.create_port, node_id\u003dself.node[\u0027uuid\u0027][1:])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_40cdc564","line":132,"updated":"2015-12-28 16:29:23.000000000","message":"raised","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"448754b05eea9a9d9a593d74668fd73d2d6041d1","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        1) create node"},{"line_number":131,"context_line":"        2) try create port with incorrect node uuid"},{"line_number":132,"context_line":"        3) check that exception has been resed"},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        self.assertRaises(exceptions.CommandFailed,"},{"line_number":135,"context_line":"                          self.create_port, node_id\u003dself.node[\u0027uuid\u0027][1:])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6879fb2e","line":132,"in_reply_to":"1a7b0d38_40cdc564","updated":"2016-01-04 17:09:02.000000000","message":"Done","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"53d42693c2e8973416cbecb95fa1fc473b58cac5","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        1) create node"},{"line_number":141,"context_line":"        2) create port"},{"line_number":142,"context_line":"        3) check that port-show command without arguments triggers"},{"line_number":143,"context_line":"        to an exception"},{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"        self.create_port(self.node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_20d759ee","line":142,"updated":"2015-12-28 16:29:23.000000000","message":"%s/triggers to an exception/raises an exception/g","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"448754b05eea9a9d9a593d74668fd73d2d6041d1","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        1) create node"},{"line_number":141,"context_line":"        2) create port"},{"line_number":142,"context_line":"        3) check that port-show command without arguments triggers"},{"line_number":143,"context_line":"        to an exception"},{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"        self.create_port(self.node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_28aa2371","line":142,"in_reply_to":"1a7b0d38_20d759ee","updated":"2016-01-04 17:09:02.000000000","message":"Done","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2adfc3d900c4e920067cfc802acc167b160b93bf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        3) check that port-show command with incorrect port uuid triggers"},{"line_number":154,"context_line":"        to an exception"},{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":"        port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.CommandFailed, self.show_port,"},{"line_number":158,"context_line":"                          port[\u0027uuid\u0027][1:])"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_c962b9d8","line":156,"range":{"start_line":156,"start_character":20,"end_line":156,"end_character":31},"updated":"2015-12-23 10:01:04.000000000","message":"looks like we don\u0027t need to create port for this test case","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"448754b05eea9a9d9a593d74668fd73d2d6041d1","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        3) check that port-show command with incorrect port uuid triggers"},{"line_number":154,"context_line":"        to an exception"},{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":"        port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.CommandFailed, self.show_port,"},{"line_number":158,"context_line":"                          port[\u0027uuid\u0027][1:])"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_08c63f48","line":156,"range":{"start_line":156,"start_character":20,"end_line":156,"end_character":31},"in_reply_to":"1a7b0d38_c962b9d8","updated":"2016-01-04 17:09:02.000000000","message":"Done","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2adfc3d900c4e920067cfc802acc167b160b93bf","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        3) check that port-delete command with incorrect port uuid triggers"},{"line_number":177,"context_line":"        to an exception"},{"line_number":178,"context_line":"        \"\"\""},{"line_number":179,"context_line":"        port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":180,"context_line":"        self.assertRaises(exceptions.CommandFailed, self._delete_port,"},{"line_number":181,"context_line":"                          port[\u0027uuid\u0027][1:])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_a9a08df5","line":179,"range":{"start_line":179,"start_character":20,"end_line":179,"end_character":31},"updated":"2015-12-23 10:01:04.000000000","message":"ditto","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"448754b05eea9a9d9a593d74668fd73d2d6041d1","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        3) check that port-delete command with incorrect port uuid triggers"},{"line_number":177,"context_line":"        to an exception"},{"line_number":178,"context_line":"        \"\"\""},{"line_number":179,"context_line":"        port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":180,"context_line":"        self.assertRaises(exceptions.CommandFailed, self._delete_port,"},{"line_number":181,"context_line":"                          port[\u0027uuid\u0027][1:])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_c8dee710","line":179,"range":{"start_line":179,"start_character":20,"end_line":179,"end_character":31},"in_reply_to":"1a7b0d38_a9a08df5","updated":"2016-01-04 17:09:02.000000000","message":"Done","commit_id":"49be76fa999fb63aac6db4e27ee55d0f43ddb3e7"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"7abd124236e8821669a42c3b05bff84c8ac3a7f0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":60,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], port_list_uuid)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.delete_port(self.port[\u0027uuid\u0027])"},{"line_number":63,"context_line":"        port_list_uuid \u003d self.get_port_uuids_from_port_list()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertNotIn(self.port[\u0027uuid\u0027], port_list_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_a32da996","line":62,"range":{"start_line":62,"start_character":13,"end_line":62,"end_character":24},"updated":"2016-02-05 09:30:31.000000000","message":"nit: check\u003dFalse","commit_id":"2a23420c23ce08d945ed547a2f834ccdac59a656"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"7abd124236e8821669a42c3b05bff84c8ac3a7f0","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def setUp(self):"},{"line_number":95,"context_line":"        super(PortNegativeTestIronicClient, self).setUp()"},{"line_number":96,"context_line":"        self.node \u003d self.create_node()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_port_create_without_node_uuid(self):"},{"line_number":99,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_48ae5282","line":96,"range":{"start_line":96,"start_character":25,"end_line":96,"end_character":36},"updated":"2016-02-05 09:30:31.000000000","message":"you don\u0027t need create node in a half test cases","commit_id":"2a23420c23ce08d945ed547a2f834ccdac59a656"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"fae5dde1d1474584f8dc972e11bfa3c7824740de","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def setUp(self):"},{"line_number":95,"context_line":"        super(PortNegativeTestIronicClient, self).setUp()"},{"line_number":96,"context_line":"        self.node \u003d self.create_node()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_port_create_without_node_uuid(self):"},{"line_number":99,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_c0a1e595","line":96,"range":{"start_line":96,"start_character":25,"end_line":96,"end_character":36},"in_reply_to":"5a5ae5dd_48ae5282","updated":"2016-02-18 10:55:00.000000000","message":"Done","commit_id":"2a23420c23ce08d945ed547a2f834ccdac59a656"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"f67fd221bd1cb08262a1c45be2f05e2c666e2683","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    or with incorrect arguments."},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def setUp(self):"},{"line_number":95,"context_line":"        super(PortNegativeTestIronicClient, self).setUp()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_port_create_without_node_uuid(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bae84128_32d7f124","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":13},"updated":"2016-02-25 10:54:06.000000000","message":"nit: not needed","commit_id":"f1b5fe55f3069a9a99470834710c774a7e6a1267"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bb58c5b86e0acf06909b9a16ab97900613e78619","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    or with incorrect arguments."},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def setUp(self):"},{"line_number":95,"context_line":"        super(PortNegativeTestIronicClient, self).setUp()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_port_create_without_node_uuid(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_ede15100","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":13},"in_reply_to":"bae84128_32d7f124","updated":"2016-03-01 12:01:52.000000000","message":"Done","commit_id":"f1b5fe55f3069a9a99470834710c774a7e6a1267"},{"author":{"_account_id":15784,"name":"Igor Pukha","email":"ipukha@mirantis.com","username":"ingwarr"},"change_message_id":"2a4c790634b507bbc50e7d9172ee3e21230b5aad","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \"\"\"Test steps:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        1) try to create port without node uuid"},{"line_number":100,"context_line":"        2) check that exception has been resed"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        ex_text \u003d \u0027argument -n/--node/--node_uuid: expected one argument\u0027"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_98b0a6df","line":100,"range":{"start_line":100,"start_character":41,"end_line":100,"end_character":46},"updated":"2016-03-01 21:29:37.000000000","message":"Perhaps you meant raised","commit_id":"1ed06f23cb844f5277002dd834719aab0d7b70f8"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"7176107161ffefff031d93f9e7c106a79eabd92a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \"\"\"Test steps:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        1) try to create port without node uuid"},{"line_number":100,"context_line":"        2) check that exception has been resed"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        ex_text \u003d \u0027argument -n/--node/--node_uuid: expected one argument\u0027"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_29274dcb","line":100,"range":{"start_line":100,"start_character":41,"end_line":100,"end_character":46},"in_reply_to":"7af24918_98b0a6df","updated":"2016-03-02 15:54:44.000000000","message":"Done","commit_id":"1ed06f23cb844f5277002dd834719aab0d7b70f8"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"5a96ab9a730a144b59c362636283105809f44ffa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        port_show \u003d self.show_port(self.port[\u0027uuid\u0027])"},{"line_number":50,"context_line":"        self.assertEqual(self.port[\u0027uuid\u0027], port_show[\u0027uuid\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_port_delete(self):"},{"line_number":53,"context_line":"        \"\"\"Test steps:"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        1) create node in setUp()"}],"source_content_type":"text/x-python","patch_set":14,"id":"1af94dfe_11c1bc54","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":24},"updated":"2016-03-17 12:05:16.000000000","message":"this test duplicates port_delete from based test, please rebase","commit_id":"a4c2af020dbcc50d81b1837039e88e52213bdb68"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"181020742ef41a241a9800f1911a8c526f2dd4b4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"\"\"Negative tests for testing actions with port."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":92,"context_line":"    port-show, port-update and port-delete using them either without arguments"},{"line_number":93,"context_line":"    or with incorrect arguments."},{"line_number":94,"context_line":"    \"\"\""},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_b52c1303","line":92,"updated":"2016-03-31 12:02:43.000000000","message":"I don\u0027t see any tests for port-update, please either add them or remove it from the docstring.","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"\"\"Negative tests for testing actions with port."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":92,"context_line":"    port-show, port-update and port-delete using them either without arguments"},{"line_number":93,"context_line":"    or with incorrect arguments."},{"line_number":94,"context_line":"    \"\"\""},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_c18d54d4","line":92,"in_reply_to":"ba0121b8_b52c1303","updated":"2016-04-01 12:56:11.000000000","message":"Done","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1162c11388e8d414439ac17b1606d0855fcd5008","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                                ex_text,"},{"line_number":106,"context_line":"                                self.create_port, \u0027\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_port_create_without_mac_address(self):"},{"line_number":109,"context_line":"        \"\"\"Test steps:"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        1) create node"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_966f562a","line":108,"updated":"2016-03-31 12:26:19.000000000","message":"incorrect address too?","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                                ex_text,"},{"line_number":106,"context_line":"                                self.create_port, \u0027\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_port_create_without_mac_address(self):"},{"line_number":109,"context_line":"        \"\"\"Test steps:"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        1) create node"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_135afff1","line":108,"in_reply_to":"ba0121b8_966f562a","updated":"2016-04-01 12:56:11.000000000","message":"Done","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"181020742ef41a241a9800f1911a8c526f2dd4b4","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        1) create node"},{"line_number":143,"context_line":"        2) create port"},{"line_number":144,"context_line":"        3) check that port-show command without arguments triggers"},{"line_number":145,"context_line":"        to an exception"},{"line_number":146,"context_line":"        \"\"\""},{"line_number":147,"context_line":"        node \u003d self.create_node()"},{"line_number":148,"context_line":"        self.create_port(node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_d58547cf","line":145,"updated":"2016-03-31 12:02:43.000000000","message":"s/to an/an/","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        1) create node"},{"line_number":143,"context_line":"        2) create port"},{"line_number":144,"context_line":"        3) check that port-show command without arguments triggers"},{"line_number":145,"context_line":"        to an exception"},{"line_number":146,"context_line":"        \"\"\""},{"line_number":147,"context_line":"        node \u003d self.create_node()"},{"line_number":148,"context_line":"        self.create_port(node[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_f32e6b41","line":145,"in_reply_to":"ba0121b8_d58547cf","updated":"2016-04-01 12:56:11.000000000","message":"Done","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"181020742ef41a241a9800f1911a8c526f2dd4b4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        \"\"\"Test steps:"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        1) check that port-delete command without arguments triggers"},{"line_number":174,"context_line":"        to an exception"},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        ex_text \u003d \u0027too few arguments\u0027"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_3556435c","line":174,"updated":"2016-03-31 12:02:43.000000000","message":"ditto","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        \"\"\"Test steps:"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        1) check that port-delete command without arguments triggers"},{"line_number":174,"context_line":"        to an exception"},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        ex_text \u003d \u0027too few arguments\u0027"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_d331a7a3","line":174,"in_reply_to":"ba0121b8_3556435c","updated":"2016-04-01 12:56:11.000000000","message":"Done","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"181020742ef41a241a9800f1911a8c526f2dd4b4","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    def test_port_delete_with_incorrect_port_uuid(self):"},{"line_number":183,"context_line":"        \"\"\"Test steps:"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        1) check that port-delete command with incorrect port uuid triggers"},{"line_number":186,"context_line":"        to an exception"},{"line_number":187,"context_line":"        \"\"\""},{"line_number":188,"context_line":"        ex_text \u003d r\"Invalid input for field/attribute port_uuid. Value: \" \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_357923c9","line":185,"updated":"2016-03-31 12:02:43.000000000","message":"ditto","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    def test_port_delete_with_incorrect_port_uuid(self):"},{"line_number":183,"context_line":"        \"\"\"Test steps:"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        1) check that port-delete command with incorrect port uuid triggers"},{"line_number":186,"context_line":"        to an exception"},{"line_number":187,"context_line":"        \"\"\""},{"line_number":188,"context_line":"        ex_text \u003d r\"Invalid input for field/attribute port_uuid. Value: \" \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_13283f32","line":185,"in_reply_to":"ba0121b8_357923c9","updated":"2016-04-01 12:56:11.000000000","message":"Done","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"181020742ef41a241a9800f1911a8c526f2dd4b4","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    def test_delete_non_exist_port(self):"},{"line_number":196,"context_line":"        \"\"\"Test steps:"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        1) check that deleting non-exist port triggers to an exception"},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        ex_text \u003d r\"Port 00000000-0000-0000-C000-000000000046 \" \\"},{"line_number":201,"context_line":"            r\"could not be found. \\(HTTP 404\\)\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_15769fd6","line":198,"updated":"2016-03-31 12:02:43.000000000","message":"ditto","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"bbbad43513ed8afc15a8fa19a1e0825ad27d694a","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    def test_delete_non_exist_port(self):"},{"line_number":196,"context_line":"        \"\"\"Test steps:"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        1) check that deleting non-exist port triggers to an exception"},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        ex_text \u003d r\"Port 00000000-0000-0000-C000-000000000046 \" \\"},{"line_number":201,"context_line":"            r\"could not be found. \\(HTTP 404\\)\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_d3bfe7cd","line":198,"in_reply_to":"ba0121b8_15769fd6","updated":"2016-04-01 12:56:11.000000000","message":"Done","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"181020742ef41a241a9800f1911a8c526f2dd4b4","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        1) check that deleting non-exist port triggers to an exception"},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        ex_text \u003d r\"Port 00000000-0000-0000-C000-000000000046 \" \\"},{"line_number":201,"context_line":"            r\"could not be found. \\(HTTP 404\\)\""},{"line_number":202,"context_line":"        self.assertRaisesRegexp(exceptions.CommandFailed,"},{"line_number":203,"context_line":"                                ex_text,"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_55713743","line":200,"updated":"2016-03-31 12:02:43.000000000","message":"Might be good to add such test for port show too.","commit_id":"465846a15e2e89ae74c9f7d8c06f50bada22f427"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"897f38ffb48b8fa6268330ae69417d0185b10ea6","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        an exception"},{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        ex_text \u003d r\"Invalid input for field/attribute port_uuid. Value: \" \\"},{"line_number":180,"context_line":"            r\"\u00270-000-000-0\u0027. unable to convert to uuid \\(HTTP 400\\)\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        self.assertRaisesRegexp(exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_d1ed0490","line":179,"updated":"2016-04-04 09:57:39.000000000","message":"\\ line continuation is not pep8 compliant, you could wrap it in parenthesis instead.","commit_id":"a3893a45128174fc601670337beee935d1c09e13"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"897f38ffb48b8fa6268330ae69417d0185b10ea6","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        1) check that port-delete command with incorrect port uuid triggers"},{"line_number":203,"context_line":"        an exception"},{"line_number":204,"context_line":"        \"\"\""},{"line_number":205,"context_line":"        ex_text \u003d r\"Invalid input for field/attribute port_uuid. Value: \" \\"},{"line_number":206,"context_line":"            r\"\u00270-000-000-0\u0027. unable to convert to uuid \\(HTTP 400\\)\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertRaisesRegexp(exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_719078ed","line":205,"updated":"2016-04-04 09:57:39.000000000","message":"ditto","commit_id":"a3893a45128174fc601670337beee935d1c09e13"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"897f38ffb48b8fa6268330ae69417d0185b10ea6","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        1) check that deleting non-exist port triggers an exception"},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":"        ex_text \u003d r\"Port 00000000-0000-0000-C000-000000000046 \" \\"},{"line_number":218,"context_line":"            r\"could not be found. \\(HTTP 404\\)\""},{"line_number":219,"context_line":"        self.assertRaisesRegexp(exceptions.CommandFailed,"},{"line_number":220,"context_line":"                                ex_text,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_b1c050e2","line":217,"updated":"2016-04-04 09:57:39.000000000","message":"ditto","commit_id":"a3893a45128174fc601670337beee935d1c09e13"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"4045b926f7b7302ddbd75cceea25230a1dd667dc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        2) try create port without node MAC address"},{"line_number":102,"context_line":"        3) check that exception has been raised"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        node \u003d self.create_node()"},{"line_number":105,"context_line":"        ex_text \u003d \u0027argument -a/--address: expected one argument\u0027"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.assertRaisesRegexp(exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_c43ca2ca","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":33},"updated":"2016-06-07 15:18:19.000000000","message":"I wonder if the node shouldn\u0027t be created in a setup function (like what is done for PortSanityTestIronicClient)? It would avoid creating nodes in different method.","commit_id":"a16833c14f6e227402b33b9c4f58eb39b643a3e8"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"a5d0e8a5b0ef2d4028afda4fee71349ceb7aef56","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        2) try create port without node MAC address"},{"line_number":102,"context_line":"        3) check that exception has been raised"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        node \u003d self.create_node()"},{"line_number":105,"context_line":"        ex_text \u003d \u0027argument -a/--address: expected one argument\u0027"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.assertRaisesRegexp(exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_923f7c86","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":33},"in_reply_to":"7aa08908_877a9c75","updated":"2016-06-07 15:42:54.000000000","message":"Ok, thanks for the explanation, Kyrylo!","commit_id":"a16833c14f6e227402b33b9c4f58eb39b643a3e8"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"cdd8d71377b6c79aff78bc854da31ebfe2c6542c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        2) try create port without node MAC address"},{"line_number":102,"context_line":"        3) check that exception has been raised"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        node \u003d self.create_node()"},{"line_number":105,"context_line":"        ex_text \u003d \u0027argument -a/--address: expected one argument\u0027"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.assertRaisesRegexp(exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_877a9c75","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":33},"in_reply_to":"7aa08908_c43ca2ca","updated":"2016-06-07 15:28:54.000000000","message":"Hello, Aline! That is done by such way because half of testcases in this class do not require any nodes or ports created.","commit_id":"a16833c14f6e227402b33b9c4f58eb39b643a3e8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98766bf0c82dd8b2cb6b9ec26eb7d2b5e3316bad","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        3) check that exception has been raised"},{"line_number":145,"context_line":"        \"\"\""},{"line_number":146,"context_line":"        node \u003d self.create_node()"},{"line_number":147,"context_line":"        ex_text \u003d r\u0027Expected a uuid but received (\\w|\\d|-){35}. \\(HTTP 400\\)\u0027"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"},{"line_number":150,"context_line":"                              ex_text,"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_81ec6e2a","line":147,"updated":"2016-07-25 15:28:30.000000000","message":"I don\u0027t see the need for having an expression this complicated. Just \u0027Expected a uuid but received\u0027 would suffice. And having written this, it should be UUID not uuid. If https://review.openstack.org/346883 merges, this will break.\n\nAlso, wrt the value received, it is node[\u0027uuid\u0027][1:], so why not just use that string instead of your (\\w|]d|-){35}?","commit_id":"796755572f3b189770ec2b8dbeb3c3239bc91812"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"3bfe448801208521ced07b16ee5a87d0a71b701c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        3) check that exception has been raised"},{"line_number":145,"context_line":"        \"\"\""},{"line_number":146,"context_line":"        node \u003d self.create_node()"},{"line_number":147,"context_line":"        ex_text \u003d r\u0027Expected a uuid but received (\\w|\\d|-){35}. \\(HTTP 400\\)\u0027"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"},{"line_number":150,"context_line":"                              ex_text,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9ad45d7e_a7e0b8cd","line":147,"in_reply_to":"dada55a8_81ec6e2a","updated":"2016-08-09 14:47:22.000000000","message":"Done","commit_id":"796755572f3b189770ec2b8dbeb3c3239bc91812"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98766bf0c82dd8b2cb6b9ec26eb7d2b5e3316bad","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        \"\"\""},{"line_number":161,"context_line":"        node \u003d self.create_node()"},{"line_number":162,"context_line":"        ex_text \u003d (r\"Expected a MAC address but received \""},{"line_number":163,"context_line":"                   r\"(\\w|\\d|:){14}. \\(HTTP 400\\)\")"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"},{"line_number":166,"context_line":"                              ex_text,"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_6104dabf","line":163,"updated":"2016-07-25 15:28:30.000000000","message":"ditto","commit_id":"796755572f3b189770ec2b8dbeb3c3239bc91812"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"3bfe448801208521ced07b16ee5a87d0a71b701c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        \"\"\""},{"line_number":161,"context_line":"        node \u003d self.create_node()"},{"line_number":162,"context_line":"        ex_text \u003d (r\"Expected a MAC address but received \""},{"line_number":163,"context_line":"                   r\"(\\w|\\d|:){14}. \\(HTTP 400\\)\")"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"},{"line_number":166,"context_line":"                              ex_text,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9ad45d7e_07e8a4b3","line":163,"in_reply_to":"dada55a8_6104dabf","updated":"2016-08-09 14:47:22.000000000","message":"Done","commit_id":"796755572f3b189770ec2b8dbeb3c3239bc91812"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98766bf0c82dd8b2cb6b9ec26eb7d2b5e3316bad","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        1) check that deleting non-exist port triggers an exception"},{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":"        ex_text \u003d (r\"Port 00000000-0000-0000-C000-000000000046 \""},{"line_number":233,"context_line":"                   r\"could not be found. \\(HTTP 404\\)\")"},{"line_number":234,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"},{"line_number":235,"context_line":"                              ex_text,"},{"line_number":236,"context_line":"                              self.delete_port,"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_814d8e9b","line":233,"updated":"2016-07-25 15:28:30.000000000","message":"I don\u0027t like checking against strings. I\u0027m OK if we check against a few keywords/substrings. Although there are some that don\u0027t like checking strings at all, and others that like checking the entire string. I don\u0027t think there is any community agreement on this.","commit_id":"796755572f3b189770ec2b8dbeb3c3239bc91812"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"3bfe448801208521ced07b16ee5a87d0a71b701c","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        1) check that deleting non-exist port triggers an exception"},{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":"        ex_text \u003d (r\"Port 00000000-0000-0000-C000-000000000046 \""},{"line_number":233,"context_line":"                   r\"could not be found. \\(HTTP 404\\)\")"},{"line_number":234,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"},{"line_number":235,"context_line":"                              ex_text,"},{"line_number":236,"context_line":"                              self.delete_port,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9ad45d7e_47d29c01","line":233,"in_reply_to":"dada55a8_814d8e9b","updated":"2016-08-09 14:47:22.000000000","message":"Done","commit_id":"796755572f3b189770ec2b8dbeb3c3239bc91812"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1a5bef690b7289809e918a88a7b4cc1109fd68da","unresolved":false,"context_lines":[{"line_number":103,"context_line":"class PortNegativeTestIronicClient(base.FunctionalTestBase):"},{"line_number":104,"context_line":"    \"\"\"Negative tests for testing actions with port."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":107,"context_line":"    port-show, and port-delete using them either without arguments"},{"line_number":108,"context_line":"    or with incorrect arguments."},{"line_number":109,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"3ac371cc_26c5cb5a","line":106,"updated":"2016-08-16 16:02:49.000000000","message":"s/ which checks/. This tests/","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"37be3a40518be10d10298900079a68e4eec10bf0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"class PortNegativeTestIronicClient(base.FunctionalTestBase):"},{"line_number":104,"context_line":"    \"\"\"Negative tests for testing actions with port."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":107,"context_line":"    port-show, and port-delete using them either without arguments"},{"line_number":108,"context_line":"    or with incorrect arguments."},{"line_number":109,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"1ac06dbe_424a45ad","line":106,"in_reply_to":"3ac371cc_26c5cb5a","updated":"2016-08-23 07:13:24.000000000","message":"Done","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1a5bef690b7289809e918a88a7b4cc1109fd68da","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    \"\"\"Negative tests for testing actions with port."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":107,"context_line":"    port-show, and port-delete using them either without arguments"},{"line_number":108,"context_line":"    or with incorrect arguments."},{"line_number":109,"context_line":"    \"\"\""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3ac371cc_0697ef48","line":107,"updated":"2016-08-16 16:02:49.000000000","message":"s/port-delete/port-delete: /","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"37be3a40518be10d10298900079a68e4eec10bf0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    \"\"\"Negative tests for testing actions with port."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    Negative tests for the Ironic CLI commands which checks port-create,"},{"line_number":107,"context_line":"    port-show, and port-delete using them either without arguments"},{"line_number":108,"context_line":"    or with incorrect arguments."},{"line_number":109,"context_line":"    \"\"\""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"1ac06dbe_82cefd2b","line":107,"in_reply_to":"3ac371cc_0697ef48","updated":"2016-08-23 07:13:24.000000000","message":"Done","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1a5bef690b7289809e918a88a7b4cc1109fd68da","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        an exception"},{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        node \u003d self.create_node()"},{"line_number":179,"context_line":"        self.create_port(node[\u0027uuid\u0027])"},{"line_number":180,"context_line":"        ex_text \u003d \u0027too few arguments\u0027"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3ac371cc_c6595700","line":179,"updated":"2016-08-16 16:02:49.000000000","message":"I don\u0027t see why you create a node and port. If you invoke this command w/o arguments, it doesn\u0027t matter.\n\nYou don\u0027t do a similar thing in test_port_show_with_incorrect_port_uuid() or the test_port* ones.","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"37be3a40518be10d10298900079a68e4eec10bf0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        an exception"},{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        node \u003d self.create_node()"},{"line_number":179,"context_line":"        self.create_port(node[\u0027uuid\u0027])"},{"line_number":180,"context_line":"        ex_text \u003d \u0027too few arguments\u0027"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":25,"id":"1ac06dbe_381656f1","line":179,"in_reply_to":"3ac371cc_c6595700","updated":"2016-08-23 07:13:24.000000000","message":"Done","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ec5fa0bf51907f3f3605c329e4c0b7e7e47ce6c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                              ex_text,"},{"line_number":222,"context_line":"                              self.delete_port, \u00270-000-000-0\u0027)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_delete_non_exist_port(self):"},{"line_number":225,"context_line":"        \"\"\"Test steps:"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        1) check that deleting non-exist port triggers an exception"}],"source_content_type":"text/x-python","patch_set":25,"id":"9ad45d7e_b13029ea","line":224,"updated":"2016-08-12 16:13:32.000000000","message":"nit: non_existent","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"37be3a40518be10d10298900079a68e4eec10bf0","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                              ex_text,"},{"line_number":222,"context_line":"                              self.delete_port, \u00270-000-000-0\u0027)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_delete_non_exist_port(self):"},{"line_number":225,"context_line":"        \"\"\"Test steps:"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        1) check that deleting non-exist port triggers an exception"}],"source_content_type":"text/x-python","patch_set":25,"id":"1ac06dbe_18ea7adb","line":224,"in_reply_to":"9ad45d7e_b13029ea","updated":"2016-08-23 07:13:24.000000000","message":"Done","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ec5fa0bf51907f3f3605c329e4c0b7e7e47ce6c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    def test_delete_non_exist_port(self):"},{"line_number":225,"context_line":"        \"\"\"Test steps:"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        1) check that deleting non-exist port triggers an exception"},{"line_number":228,"context_line":"        \"\"\""},{"line_number":229,"context_line":"        ex_text \u003d r\u0027could not be found\u0027"},{"line_number":230,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":25,"id":"9ad45d7e_114c9575","line":227,"updated":"2016-08-12 16:13:32.000000000","message":"ditto","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"37be3a40518be10d10298900079a68e4eec10bf0","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    def test_delete_non_exist_port(self):"},{"line_number":225,"context_line":"        \"\"\"Test steps:"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        1) check that deleting non-exist port triggers an exception"},{"line_number":228,"context_line":"        \"\"\""},{"line_number":229,"context_line":"        ex_text \u003d r\u0027could not be found\u0027"},{"line_number":230,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":25,"id":"1ac06dbe_58f072c9","line":227,"in_reply_to":"9ad45d7e_114c9575","updated":"2016-08-23 07:13:24.000000000","message":"Done","commit_id":"884f0e31ee04be0bd51ef60b8878cc0052f78cc5"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"a60979ae952f4b75514f6237ffc9962a2d174517","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def test_port_show_without_arguments(self):"},{"line_number":171,"context_line":"        \"\"\"Test steps:"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        1) create node"},{"line_number":174,"context_line":"        2) create port"},{"line_number":175,"context_line":"        3) check that port-show command without arguments triggers"},{"line_number":176,"context_line":"        an exception"},{"line_number":177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":27,"id":"7a8ec9b2_76d64250","line":174,"range":{"start_line":173,"start_character":8,"end_line":174,"end_character":22},"updated":"2016-09-21 14:53:32.000000000","message":"These 2 steps don\u0027t seem to be in this test.","commit_id":"6c000dba524feb5720fce8300138529021446df0"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e93b86229db182e1dedeef97bd46163b49a491c1","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        2) try create port with incorrect node uuid"},{"line_number":163,"context_line":"        3) check that exception has been raised"},{"line_number":164,"context_line":"        \"\"\""},{"line_number":165,"context_line":"        node \u003d self.create_node()"},{"line_number":166,"context_line":"        ex_text \u003d r\u0027Expected a UUID\u0027"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":29,"id":"3a461143_5d49ce8d","line":165,"updated":"2017-02-02 18:15:03.000000000","message":"Do you actually need to create_node for this? You could just pass node_id\u003d\u0027ab*c\u0026\u0027","commit_id":"6ffe7e1c73a1c5b89b65078643de40712833ddf3"},{"author":{"_account_id":15784,"name":"Igor Pukha","email":"ipukha@mirantis.com","username":"ingwarr"},"change_message_id":"995ffd3e412a953457df0dedbe5419cae0bebb03","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        2) try create port with incorrect node uuid"},{"line_number":163,"context_line":"        3) check that exception has been raised"},{"line_number":164,"context_line":"        \"\"\""},{"line_number":165,"context_line":"        node \u003d self.create_node()"},{"line_number":166,"context_line":"        ex_text \u003d r\u0027Expected a UUID\u0027"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a430d35_b27e84ac","line":165,"in_reply_to":"3a461143_5d49ce8d","updated":"2017-02-03 13:10:38.000000000","message":"I think it is true way for current case, or it should be named as test_port_create_without_node :)","commit_id":"6ffe7e1c73a1c5b89b65078643de40712833ddf3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e93b86229db182e1dedeef97bd46163b49a491c1","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def test_port_show_without_arguments(self):"},{"line_number":190,"context_line":"        \"\"\"Test steps:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        1) create node"},{"line_number":193,"context_line":"        2) create port"},{"line_number":194,"context_line":"        3) check that port-show command without arguments triggers"},{"line_number":195,"context_line":"        an exception"},{"line_number":196,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":29,"id":"3a461143_3d2c02ab","line":193,"range":{"start_line":192,"start_character":8,"end_line":193,"end_character":22},"updated":"2017-02-02 18:15:03.000000000","message":"Does not happen","commit_id":"6ffe7e1c73a1c5b89b65078643de40712833ddf3"}]}
