)]}'
{"ironicclient/tests/functional/base.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"279fb1aada9a29c732175e12fa5f83c24e9b09a9","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        \"\"\""},{"line_number":186,"context_line":"        self.assertNotIn(\u0027False\u0027, [x[\u0027Result\u0027] for x in node_validate])"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _assertEqualDict(self, params, object_params):"},{"line_number":189,"context_line":"        \"\"\"Assert that input params equals object params."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param params: input params"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_16da7078","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":24},"updated":"2016-03-30 10:22:26.000000000","message":"Please, w/o underscore","commit_id":"2fd68721630aa60e8bf145e6d8af399384487351"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"926d7e2a7fa12cf4f3479aaabffd7c1e0555e207","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        \"\"\""},{"line_number":186,"context_line":"        self.assertNotIn(\u0027False\u0027, [x[\u0027Result\u0027] for x in node_validate])"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _assertEqualDict(self, params, object_params):"},{"line_number":189,"context_line":"        \"\"\"Assert that input params equals object params."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param params: input params"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_7174d59b","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":24},"in_reply_to":"ba0121b8_16da7078","updated":"2016-06-06 15:48:29.000000000","message":"Done","commit_id":"2fd68721630aa60e8bf145e6d8af399384487351"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e91b9b18d2df1ed9188242af37ea4af4cb775c4","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        \"\"\"Assert that input params equals object params."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param params: input params"},{"line_number":192,"context_line":"        :type key_value_pair: dict"},{"line_number":193,"context_line":"        :param object_params: object params"},{"line_number":194,"context_line":"        :type object_params: string"},{"line_number":195,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_5ce5dfd9","line":192,"updated":"2016-03-31 13:05:15.000000000","message":"type params","commit_id":"2fd68721630aa60e8bf145e6d8af399384487351"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"279fb1aada9a29c732175e12fa5f83c24e9b09a9","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        :param object_params: object params"},{"line_number":194,"context_line":"        :type object_params: string"},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        object_params \u003d ast.literal_eval(object_params)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        self.assertEqual(0, cmp(params, object_params))"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_d65c78ef","line":196,"range":{"start_line":196,"start_character":28,"end_line":196,"end_character":40},"updated":"2016-03-30 10:22:26.000000000","message":"Why do you eval object params?","commit_id":"2fd68721630aa60e8bf145e6d8af399384487351"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e91b9b18d2df1ed9188242af37ea4af4cb775c4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        :param object_params: object params"},{"line_number":194,"context_line":"        :type object_params: string"},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        object_params \u003d ast.literal_eval(object_params)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        self.assertEqual(0, cmp(params, object_params))"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_fc31535b","line":196,"range":{"start_line":196,"start_character":28,"end_line":196,"end_character":40},"in_reply_to":"ba0121b8_d65c78ef","updated":"2016-03-31 13:05:15.000000000","message":"++ I\u0027d prefer json.loads","commit_id":"2fd68721630aa60e8bf145e6d8af399384487351"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e91b9b18d2df1ed9188242af37ea4af4cb775c4","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        object_params \u003d ast.literal_eval(object_params)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        self.assertEqual(0, cmp(params, object_params))"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def delete_node(self, node_ident, ignore_exceptions\u003dFalse):"},{"line_number":201,"context_line":"        \"\"\"Delete node method works only with fake driver."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_df1ba171","line":198,"updated":"2016-03-31 13:05:15.000000000","message":"you can just do assertEqual(params, object_params)","commit_id":"2fd68721630aa60e8bf145e6d8af399384487351"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a0ac2a6e845eb7b381f476210274db0170217e14","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        :type object_params: string"},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        object_params \u003d ast.literal_eval(object_params)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        self.assertEqual(params, object_params)"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_d5d82b20","line":197,"updated":"2016-04-04 21:14:29.000000000","message":"So, I get the problem now. The table output of ironic CLI is not fully json, as it encloses strings in single quotes instead of double quotes, and it seems that it is a behavior of prettytable that does the output formatting, not client itself. json.loads cannot parse that as it is not a valid json. So it should be left as is, or you could use --json CLI option to get a valid json.","commit_id":"c63dabef94b8a03b6a23642cd564c771cf90950a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"501a319f5af29190b558bd7b2b86513cb11ed2ce","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        \"\"\"Assert that input params equals object params."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        :param params: input params"},{"line_number":195,"context_line":"        :type key_value_pair: dict"},{"line_number":196,"context_line":"        :param object_params: object params"},{"line_number":197,"context_line":"        :type object_params: string"},{"line_number":198,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_3665ae1d","line":195,"range":{"start_line":195,"start_character":14,"end_line":195,"end_character":28},"updated":"2016-06-08 08:57:39.000000000","message":"s/key_value_pair/params/","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"27870275e53fbadc1dd0b430794dd9fde61c67de","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        \"\"\"Assert that input params equals object params."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        :param params: input params"},{"line_number":195,"context_line":"        :type key_value_pair: dict"},{"line_number":196,"context_line":"        :param object_params: object params"},{"line_number":197,"context_line":"        :type object_params: string"},{"line_number":198,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_7a6c3435","line":195,"range":{"start_line":195,"start_character":14,"end_line":195,"end_character":28},"in_reply_to":"7aa08908_3665ae1d","updated":"2016-06-08 10:20:00.000000000","message":"Done","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"23cb608370982dadb87eca534462f665e45c14dc","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        object_params \u003d ast.literal_eval(object_params)"},{"line_number":200,"context_line":"        self.assertEqual(params, object_params)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def delete_node(self, node_id, params\u003d\u0027\u0027):"},{"line_number":203,"context_line":"        \"\"\"Delete node method works only with fake driver."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        :param node_id: node uuid"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa7ab95a_397680a4","line":202,"range":{"start_line":202,"start_character":35,"end_line":202,"end_character":44},"updated":"2016-08-29 12:25:34.000000000","message":"This is not used anywhere.","commit_id":"1cf10d6dfeaae2c592a187c5e86bd49880ea5e87"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"790ff1855dd35438d61ad4aa41b7546aed1e5c6d","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        object_params \u003d ast.literal_eval(object_params)"},{"line_number":200,"context_line":"        self.assertEqual(params, object_params)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def delete_node(self, node_id, params\u003d\u0027\u0027):"},{"line_number":203,"context_line":"        \"\"\"Delete node method works only with fake driver."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        :param node_id: node uuid"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a74a57a_0e1a5f7d","line":202,"range":{"start_line":202,"start_character":35,"end_line":202,"end_character":44},"in_reply_to":"fa7ab95a_397680a4","updated":"2016-11-25 14:58:56.000000000","message":"Done","commit_id":"1cf10d6dfeaae2c592a187c5e86bd49880ea5e87"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1d3713a613db10ed1169571d362d1deba376522f","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        :param params: input params"},{"line_number":195,"context_line":"        :type params: dict"},{"line_number":196,"context_line":"        :param object_params: object params"},{"line_number":197,"context_line":"        :type object_params: string"},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        object_params \u003d ast.literal_eval(object_params)"},{"line_number":200,"context_line":"        self.assertEqual(params, object_params)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_bc86a312","line":197,"updated":"2017-11-01 19:24:31.000000000","message":"Sigh. I honestly don\u0027t know how people that aren\u0027t familiar with this code, can just look at this and understand what is going on.\n\nIf this is a helper function, it seems to me that it should be obvious what it does, and it isn\u0027t to me :-(\n\nIt looks like you\u0027re assuming that object_params is a dictionary in string representation?","commit_id":"5e6fb13993ce2a547507575c56ae5012be52a8ca"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"87765ea4a0a218c668686ab6b7679fe151774fdf","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        :param object_params: object params"},{"line_number":197,"context_line":"        :type object_params: string"},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        object_params \u003d ast.literal_eval(object_params)"},{"line_number":200,"context_line":"        self.assertEqual(params, object_params)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def delete_node(self, node_id):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_bc6fc3fa","line":199,"updated":"2017-11-01 19:25:54.000000000","message":"I could be wrong -- it seems to me that it would have been better to modify utils.get_dict_from_output() to convert all dictionaries encountered, at that time. Is there a need to only convert the \u0027top level\u0027 dictionaries, but leave the other ones as strings? Cuz then you have to do this and it seems ugly.","commit_id":"5e6fb13993ce2a547507575c56ae5012be52a8ca"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1d3713a613db10ed1169571d362d1deba376522f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                                   params\u003d\u0027{0} {1}\u0027.format(node_id, params))"},{"line_number":246,"context_line":"        return utils.get_dict_from_output(updated_node)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def get_nodes_uuids(self):"},{"line_number":249,"context_line":"        node_list \u003d self.list_nodes()"},{"line_number":250,"context_line":"        return [x[\u0027UUID\u0027] for x in node_list]"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_dcff1f65","line":248,"updated":"2017-11-01 19:24:31.000000000","message":"i suspect it is more grammatical as \u0027get_node_uuids\u0027, but if you\u0027ve been using this syntax, I guess it is ok to leave as is.","commit_id":"5e6fb13993ce2a547507575c56ae5012be52a8ca"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1d3713a613db10ed1169571d362d1deba376522f","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        show_node_states \u003d self.ironic(\u0027node-show-states\u0027, params\u003dnode_id)"},{"line_number":254,"context_line":"        return utils.get_dict_from_output(show_node_states)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def get_nodes_uuids_chassis(self, chassis_uuid):"},{"line_number":257,"context_line":"        chassis_node_list \u003d self.list_node_chassis(chassis_uuid)"},{"line_number":258,"context_line":"        return [x[\u0027UUID\u0027] for x in chassis_node_list]"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_fcbadbbd","line":256,"updated":"2017-11-01 19:24:31.000000000","message":"it is probably clearer as \u0027get_nodes_uuids_from_chassis\u0027","commit_id":"5e6fb13993ce2a547507575c56ae5012be52a8ca"}],"ironicclient/tests/functional/test_node_create.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"275ef23394ff352b42e25b62d6092a5280f41361","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        1) create node with specific uuid using -u argument"},{"line_number":52,"context_line":"        2) check that node with specific uuid has been successfully created"},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        node_uuid \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":55,"context_line":"        node \u003d self.create_node(params\u003d\u0027-u {0}\u0027.format(node_uuid))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.assertEqual(node[\u0027uuid\u0027], node_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_44585b56","line":54,"range":{"start_line":54,"start_character":20,"end_line":54,"end_character":58},"updated":"2016-03-10 09:27:45.000000000","message":"nites: it is better that we did not hard-code the uuid to avoid potential conflict if the test cases are run on parallel.","commit_id":"d8b10757c05b65dfec6d6db8633342f911c2cc70"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"0fafe47f0005fe07b57d7a145bd6600e1140534e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        1) create node with specific uuid using -u argument"},{"line_number":52,"context_line":"        2) check that node with specific uuid has been successfully created"},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        node_uuid \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":55,"context_line":"        node \u003d self.create_node(params\u003d\u0027-u {0}\u0027.format(node_uuid))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.assertEqual(node[\u0027uuid\u0027], node_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_9df1166e","line":54,"range":{"start_line":54,"start_character":20,"end_line":54,"end_character":58},"in_reply_to":"5aef4532_44585b56","updated":"2016-03-10 10:21:53.000000000","message":"Done","commit_id":"d8b10757c05b65dfec6d6db8633342f911c2cc70"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"275ef23394ff352b42e25b62d6092a5280f41361","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        1) create node with specific uuid using --uuid argument"},{"line_number":63,"context_line":"        2) check that node with specific uuid has been successfully created"},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        node_uuid \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":66,"context_line":"        node \u003d self.create_node(params\u003d\u0027--uuid {0}\u0027.format(node_uuid))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.assertEqual(node[\u0027uuid\u0027], node_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_0429339e","line":65,"range":{"start_line":65,"start_character":19,"end_line":65,"end_character":58},"updated":"2016-03-10 09:27:45.000000000","message":"ditto","commit_id":"d8b10757c05b65dfec6d6db8633342f911c2cc70"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"0fafe47f0005fe07b57d7a145bd6600e1140534e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        1) create node with specific uuid using --uuid argument"},{"line_number":63,"context_line":"        2) check that node with specific uuid has been successfully created"},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        node_uuid \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":66,"context_line":"        node \u003d self.create_node(params\u003d\u0027--uuid {0}\u0027.format(node_uuid))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.assertEqual(node[\u0027uuid\u0027], node_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_7df40a5a","line":65,"range":{"start_line":65,"start_character":19,"end_line":65,"end_character":58},"in_reply_to":"5aef4532_0429339e","updated":"2016-03-10 10:21:53.000000000","message":"Done","commit_id":"d8b10757c05b65dfec6d6db8633342f911c2cc70"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e91b9b18d2df1ed9188242af37ea4af4cb775c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        node_name \u003d utils.generate_name()"},{"line_number":33,"context_line":"        node \u003d self.create_node(params\u003d\u0027-n {0}\u0027.format(node_name))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.assertEqual(node[\u0027name\u0027], node_name)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_node_create_specific_name_name_arg(self):"},{"line_number":38,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_9f43e941","line":35,"updated":"2016-03-31 13:05:15.000000000","message":"please reverse the order in assert, ditto in other places.","commit_id":"2fd68721630aa60e8bf145e6d8af399384487351"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"501a319f5af29190b558bd7b2b86513cb11ed2ce","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        node_name \u003d data_utils.rand_name()"},{"line_number":35,"context_line":"        node \u003d self.create_node(params\u003d\u0027-n {0}\u0027.format(node_name))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.assertEqual(node[\u0027name\u0027], node_name)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_node_create_specific_name_name_arg(self):"},{"line_number":40,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_bf5df116","line":37,"range":{"start_line":37,"start_character":25,"end_line":37,"end_character":47},"updated":"2016-06-08 08:57:39.000000000","message":"The order of arguments should be \nself.assertEqual(expected, actual)\nas the convention.\n\nWe can find the convention in unit test code.\n\n$ git grep expected\n...\ndb/test_conductor.py:        expected \u003d {}\ndb/test_conductor.py:        self.assertEqual(expected, result)\ndb/test_conductor.py:        expected \u003d {d: set([h])}\ndb/test_conductor.py:        self.assertEqual(expected, result)\n...","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"27870275e53fbadc1dd0b430794dd9fde61c67de","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        node_name \u003d data_utils.rand_name()"},{"line_number":35,"context_line":"        node \u003d self.create_node(params\u003d\u0027-n {0}\u0027.format(node_name))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.assertEqual(node[\u0027name\u0027], node_name)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_node_create_specific_name_name_arg(self):"},{"line_number":40,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_1af09066","line":37,"range":{"start_line":37,"start_character":25,"end_line":37,"end_character":47},"in_reply_to":"7aa08908_bf5df116","updated":"2016-06-08 10:20:00.000000000","message":"Done","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"501a319f5af29190b558bd7b2b86513cb11ed2ce","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        node_name \u003d data_utils.rand_name()"},{"line_number":46,"context_line":"        node \u003d self.create_node(params\u003d\u0027--name {0}\u0027.format(node_name))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.assertEqual(node[\u0027name\u0027], node_name)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_node_create_specific_uuid_u_arg(self):"},{"line_number":51,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_ff881973","line":48,"range":{"start_line":48,"start_character":25,"end_line":48,"end_character":48},"updated":"2016-06-08 08:57:39.000000000","message":"ditto","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"27870275e53fbadc1dd0b430794dd9fde61c67de","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        node_name \u003d data_utils.rand_name()"},{"line_number":46,"context_line":"        node \u003d self.create_node(params\u003d\u0027--name {0}\u0027.format(node_name))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.assertEqual(node[\u0027name\u0027], node_name)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_node_create_specific_uuid_u_arg(self):"},{"line_number":51,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_fa9b0416","line":48,"range":{"start_line":48,"start_character":25,"end_line":48,"end_character":48},"in_reply_to":"7aa08908_ff881973","updated":"2016-06-08 10:20:00.000000000","message":"Done","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"501a319f5af29190b558bd7b2b86513cb11ed2ce","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        node_uuid \u003d data_utils.rand_uuid()"},{"line_number":57,"context_line":"        node \u003d self.create_node(params\u003d\u0027-u {0}\u0027.format(node_uuid))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.assertEqual(node[\u0027uuid\u0027], node_uuid)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_node_create_specific_uuid_uuid_arg(self):"},{"line_number":62,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_df8efd77","line":59,"range":{"start_line":59,"start_character":25,"end_line":59,"end_character":48},"updated":"2016-06-08 08:57:39.000000000","message":"ditto","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"27870275e53fbadc1dd0b430794dd9fde61c67de","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        node_uuid \u003d data_utils.rand_uuid()"},{"line_number":57,"context_line":"        node \u003d self.create_node(params\u003d\u0027-u {0}\u0027.format(node_uuid))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.assertEqual(node[\u0027uuid\u0027], node_uuid)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_node_create_specific_uuid_uuid_arg(self):"},{"line_number":62,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_baf7bc57","line":59,"range":{"start_line":59,"start_character":25,"end_line":59,"end_character":48},"in_reply_to":"7aa08908_df8efd77","updated":"2016-06-08 10:20:00.000000000","message":"Done","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"501a319f5af29190b558bd7b2b86513cb11ed2ce","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        node_uuid \u003d data_utils.rand_uuid()"},{"line_number":68,"context_line":"        node \u003d self.create_node(params\u003d\u0027--uuid {0}\u0027.format(node_uuid))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.assertEqual(node[\u0027uuid\u0027], node_uuid)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_node_create_driver_info_short_arg(self):"},{"line_number":73,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_3ff621f9","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":48},"updated":"2016-06-08 08:57:39.000000000","message":"ditto","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"27870275e53fbadc1dd0b430794dd9fde61c67de","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        node_uuid \u003d data_utils.rand_uuid()"},{"line_number":68,"context_line":"        node \u003d self.create_node(params\u003d\u0027--uuid {0}\u0027.format(node_uuid))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.assertEqual(node[\u0027uuid\u0027], node_uuid)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_node_create_driver_info_short_arg(self):"},{"line_number":73,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_fa6944fa","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":48},"in_reply_to":"7aa08908_3ff621f9","updated":"2016-06-08 10:20:00.000000000","message":"Done","commit_id":"3d16b8a736d926fe958892df2dde4cb4afa17f20"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"80b183b98ab2f151f94a077a0438281e5dd83471","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    command."},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_node_create_specific_name_n_arg(self):"},{"line_number":29,"context_line":"        \"\"\"Test steps:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        1) create node with specific name using -n argument"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_5a7094dc","line":28,"range":{"start_line":28,"start_character":39,"end_line":28,"end_character":44},"updated":"2016-06-29 10:58:25.000000000","message":"Maybe you could use \"short_arg\" and \"full_arg\" so that all functions are named in a consistent way?","commit_id":"9d45f5083228ceb488c4052cf5c2f71d8dccb6c1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"50974e47a6676dae4f949eaefcbfb64f9490c30f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    command."},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_node_create_specific_name_n_arg(self):"},{"line_number":29,"context_line":"        \"\"\"Test steps:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        1) create node with specific name using -n argument"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_2d439414","line":28,"range":{"start_line":28,"start_character":39,"end_line":28,"end_character":44},"in_reply_to":"3aaa91ec_5a7094dc","updated":"2016-06-30 11:49:21.000000000","message":"Done","commit_id":"9d45f5083228ceb488c4052cf5c2f71d8dccb6c1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"e2b66dcee95c5dfe96452b9741cef5dbe84b66f3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    command."},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_node_create_specific_name_n_arg(self):"},{"line_number":29,"context_line":"        \"\"\"Test steps:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        1) create node with specific name using -n argument"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_39df5a3b","line":28,"range":{"start_line":28,"start_character":39,"end_line":28,"end_character":44},"in_reply_to":"3aaa91ec_5a7094dc","updated":"2016-06-30 10:50:04.000000000","message":"Thanks, good idea.","commit_id":"9d45f5083228ceb488c4052cf5c2f71d8dccb6c1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fd11bd8530dce213ff8ffaad482fb4504c13e90e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \"\"\"Test steps:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        1) create nodes using --driver-info and -i argument"},{"line_number":60,"context_line":"        with solitary and multiple driver-info sets"},{"line_number":61,"context_line":"        2) check that nodes has been successfully created"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        driver_info_list \u003d [{\u0027support_ssh\u0027: \u0027yes\u0027},"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_7b8046f8","line":60,"updated":"2016-07-14 11:53:55.000000000","message":"I see the solitary but not the multiple driver-info being tested","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ee915b668686d20577ecd453d92c7b3f2a3d88ce","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \"\"\"Test steps:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        1) create nodes using --driver-info and -i argument"},{"line_number":60,"context_line":"        with solitary and multiple driver-info sets"},{"line_number":61,"context_line":"        2) check that nodes has been successfully created"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        driver_info_list \u003d [{\u0027support_ssh\u0027: \u0027yes\u0027},"}],"source_content_type":"text/x-python","patch_set":21,"id":"dada55a8_795df3e8","line":60,"in_reply_to":"1aa78d24_7b8046f8","updated":"2016-07-18 15:15:50.000000000","message":"Hi, Ruby. Here we call generate_params() method to divide driver_info with several key-value pairs into sequence of \"-i key\u003dvalue\", for example:  --driver-info boot\u003dno --driver-info schedule\u003denable --driver-info power\u003dVCC","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fd11bd8530dce213ff8ffaad482fb4504c13e90e","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        1) create nodes using --driver-info and -i argument"},{"line_number":60,"context_line":"        with solitary and multiple driver-info sets"},{"line_number":61,"context_line":"        2) check that nodes has been successfully created"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        driver_info_list \u003d [{\u0027support_ssh\u0027: \u0027yes\u0027},"},{"line_number":64,"context_line":"                            {\u0027boot\u0027: \u0027no\u0027, \u0027schedule\u0027: \u0027enable\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_5b7f4a66","line":61,"updated":"2016-07-14 11:53:55.000000000","message":"nit s/has/have/","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ee915b668686d20577ecd453d92c7b3f2a3d88ce","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        1) create nodes using --driver-info and -i argument"},{"line_number":60,"context_line":"        with solitary and multiple driver-info sets"},{"line_number":61,"context_line":"        2) check that nodes has been successfully created"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        driver_info_list \u003d [{\u0027support_ssh\u0027: \u0027yes\u0027},"},{"line_number":64,"context_line":"                            {\u0027boot\u0027: \u0027no\u0027, \u0027schedule\u0027: \u0027enable\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"dada55a8_b9e48b0d","line":61,"in_reply_to":"1aa78d24_5b7f4a66","updated":"2016-07-18 15:15:50.000000000","message":"Done","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fd11bd8530dce213ff8ffaad482fb4504c13e90e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            for arg in args:"},{"line_number":69,"context_line":"                params \u003d utils.generate_params(arg, driver_info)"},{"line_number":70,"context_line":"                node \u003d self.create_node(params\u003dparams)"},{"line_number":71,"context_line":"                self.assertEqualDict(driver_info, node[\u0027driver_info\u0027])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_properties(self):"},{"line_number":74,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_bbf74ed3","line":71,"updated":"2016-07-14 11:53:55.000000000","message":"--driver-info can be specified one or more times. What about adding a test for 4 times.","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fd11bd8530dce213ff8ffaad482fb4504c13e90e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Test steps:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        1) create nodes using --properties and -p argument"},{"line_number":77,"context_line":"        with solitary and multiple properties sets"},{"line_number":78,"context_line":"        2) check that nodes has been successfully created"},{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        prop_list \u003d [{\u0027cpu_arch\u0027: \u0027x86_64\u0027},"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_bb7aae23","line":77,"updated":"2016-07-14 11:53:55.000000000","message":"ditto","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fd11bd8530dce213ff8ffaad482fb4504c13e90e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"\"\"Test steps:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        1) create nodes using --extra and -e argument"},{"line_number":93,"context_line":"        with solitary and multiple extras sets"},{"line_number":94,"context_line":"        2) check that nodes has been successfully created"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        extras \u003d [{\u0027cores\u0027: 16},"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_fb743637","line":93,"updated":"2016-07-14 11:53:55.000000000","message":"ditto","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fd11bd8530dce213ff8ffaad482fb4504c13e90e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        node \u003d self.ironic(\u0027node-create\u0027, params\u003d\u0027-d fake\u0027)"},{"line_number":129,"context_line":"        node \u003d utils.get_dict_from_output(node)"},{"line_number":130,"context_line":"        self.addCleanup(self.delete_node, node[\u0027uuid\u0027])"},{"line_number":131,"context_line":"        self.assertIn(node[\u0027uuid\u0027], self.get_nodes_uuids_from_node_list())"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_1b666229","line":131,"updated":"2016-07-14 11:53:55.000000000","message":"it seems to me that if you also passed in a UUID to the node-create, you could assert on that here. Otherwise, this line looks like you are testing the created node against the created node (ie against itself).\n\nThe other thing is that since you are using -d argument, maybe you want to check that the driver value is correct. So maybe don\u0027t use \u0027fake\u0027 (although maybe that\u0027s the only driver available) and check that node.driver is the expected value?","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ee915b668686d20577ecd453d92c7b3f2a3d88ce","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        node \u003d self.ironic(\u0027node-create\u0027, params\u003d\u0027-d fake\u0027)"},{"line_number":129,"context_line":"        node \u003d utils.get_dict_from_output(node)"},{"line_number":130,"context_line":"        self.addCleanup(self.delete_node, node[\u0027uuid\u0027])"},{"line_number":131,"context_line":"        self.assertIn(node[\u0027uuid\u0027], self.get_nodes_uuids_from_node_list())"}],"source_content_type":"text/x-python","patch_set":21,"id":"dada55a8_1482be94","line":131,"in_reply_to":"1aa78d24_1b666229","updated":"2016-07-18 15:15:50.000000000","message":"OK, added assertion of driver. It was discussed previously that we can rely only on fake driver in tests.","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"3897813ca241bf508420c3a5b5e1e45a405cfe80","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        node \u003d self.ironic(\u0027node-create\u0027, params\u003d\u0027-d {0}\u0027.format(driver))"},{"line_number":130,"context_line":"        node \u003d utils.get_dict_from_output(node)"},{"line_number":131,"context_line":"        self.addCleanup(self.delete_node, node[\u0027uuid\u0027])"},{"line_number":132,"context_line":"        self.assertIn(node[\u0027uuid\u0027], self.get_nodes_uuids_from_node_list())"},{"line_number":133,"context_line":"        self.assertEqual(node[\u0027driver\u0027], driver)"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_6359028e","line":132,"range":{"start_line":132,"start_character":41,"end_line":132,"end_character":73},"updated":"2016-07-21 16:16:02.000000000","message":"this should be rebased on top of https://review.openstack.org/#/c/251458/ which renames this function.","commit_id":"4cb63b596e4287d4a2a838c8fb095f7b81f32b03"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"23cb608370982dadb87eca534462f665e45c14dc","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        1) create node using -d argument"},{"line_number":125,"context_line":"        2) check that node with -d argument has been successfully created"},{"line_number":126,"context_line":"        Full driver argument is used each time in setUp()."},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        driver \u003d \u0027fake\u0027"},{"line_number":129,"context_line":"        node \u003d self.ironic(\u0027node-create\u0027, params\u003d\u0027-d {0}\u0027.format(driver))"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa7ab95a_f9f09893","line":126,"updated":"2016-08-29 12:25:34.000000000","message":"there is no setUp in this class, I think it should be not setUp, but create_node instead.","commit_id":"1cf10d6dfeaae2c592a187c5e86bd49880ea5e87"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"790ff1855dd35438d61ad4aa41b7546aed1e5c6d","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        1) create node using -d argument"},{"line_number":125,"context_line":"        2) check that node with -d argument has been successfully created"},{"line_number":126,"context_line":"        Full driver argument is used each time in setUp()."},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        driver \u003d \u0027fake\u0027"},{"line_number":129,"context_line":"        node \u003d self.ironic(\u0027node-create\u0027, params\u003d\u0027-d {0}\u0027.format(driver))"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a74a57a_4e39b7f1","line":126,"in_reply_to":"fa7ab95a_f9f09893","updated":"2016-11-25 14:58:56.000000000","message":"Done","commit_id":"1cf10d6dfeaae2c592a187c5e86bd49880ea5e87"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1d3713a613db10ed1169571d362d1deba376522f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            for arg in args:"},{"line_number":69,"context_line":"                params \u003d utils.generate_params(arg, driver_info)"},{"line_number":70,"context_line":"                node \u003d self.create_node(params\u003dparams)"},{"line_number":71,"context_line":"                self.assertEqualDict(driver_info, node[\u0027driver_info\u0027])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_properties(self):"},{"line_number":74,"context_line":"        \"\"\"Test steps:"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_9c03e742","line":71,"updated":"2017-11-01 19:24:31.000000000","message":"what information/type is node[\u0027driver_info\u0027]? It looks like self.create_node() returns a dictionary representation of a node; does utils.get_dict_from_output() recurse so that node[\u0027driver_info\u0027] is also a dictionary?\n\nI took a look at utils.get_dict_from_output() and the docstring is wrong :-( \n\n/me cries.","commit_id":"5e6fb13993ce2a547507575c56ae5012be52a8ca"}],"ironicclient/tests/functional/utils.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"275ef23394ff352b42e25b62d6092a5280f41361","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def generate_params(argument, params):"},{"line_number":69,"context_line":"    \"\"\"Return param string\"\"\""},{"line_number":70,"context_line":"    params_str \u003d \u0027\u0027"},{"line_number":71,"context_line":"    for key, value in params.iteritems():"},{"line_number":72,"context_line":"        params_str +\u003d \u0027 {0} {1}\u003d{2}\u0027.format(argument, key, value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_04101356","line":69,"range":{"start_line":69,"start_character":7,"end_line":69,"end_character":13},"updated":"2016-03-10 09:27:45.000000000","message":"s/Return/Generate ?","commit_id":"d8b10757c05b65dfec6d6db8633342f911c2cc70"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"0fafe47f0005fe07b57d7a145bd6600e1140534e","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def generate_params(argument, params):"},{"line_number":69,"context_line":"    \"\"\"Return param string\"\"\""},{"line_number":70,"context_line":"    params_str \u003d \u0027\u0027"},{"line_number":71,"context_line":"    for key, value in params.iteritems():"},{"line_number":72,"context_line":"        params_str +\u003d \u0027 {0} {1}\u003d{2}\u0027.format(argument, key, value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_dde71eaa","line":69,"range":{"start_line":69,"start_character":7,"end_line":69,"end_character":13},"in_reply_to":"5aef4532_04101356","updated":"2016-03-10 10:21:53.000000000","message":"Done","commit_id":"d8b10757c05b65dfec6d6db8633342f911c2cc70"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e91b9b18d2df1ed9188242af37ea4af4cb775c4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    return params_str"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def generate_uuid():"},{"line_number":77,"context_line":"    \"\"\"Generate uuid\"\"\""},{"line_number":78,"context_line":"    some_uuid \u003d uuid.uuid4()"},{"line_number":79,"context_line":"    return str(some_uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_bcd6bbee","line":76,"updated":"2016-03-31 13:05:15.000000000","message":"Please use oslo_utils.uuidutils.generate_uuid()","commit_id":"2fd68721630aa60e8bf145e6d8af399384487351"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fd11bd8530dce213ff8ffaad482fb4504c13e90e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def generate_params(argument, params):"},{"line_number":41,"context_line":"    \"\"\"Generate param string.\"\"\""},{"line_number":42,"context_line":"    params_str \u003d \u0027\u0027"},{"line_number":43,"context_line":"    for key, value in params.iteritems():"},{"line_number":44,"context_line":"        params_str +\u003d \u0027 {0} {1}\u003d{2}\u0027.format(argument, key, value)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_d87ce0b7","line":41,"updated":"2016-07-14 11:53:55.000000000","message":"It would be nice to know what the method parameters are. Please add \u0027:param argument: ... \u0027\n\nWhat is a \u0027param string\u0027?","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ee915b668686d20577ecd453d92c7b3f2a3d88ce","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def generate_params(argument, params):"},{"line_number":41,"context_line":"    \"\"\"Generate param string.\"\"\""},{"line_number":42,"context_line":"    params_str \u003d \u0027\u0027"},{"line_number":43,"context_line":"    for key, value in params.iteritems():"},{"line_number":44,"context_line":"        params_str +\u003d \u0027 {0} {1}\u003d{2}\u0027.format(argument, key, value)"}],"source_content_type":"text/x-python","patch_set":21,"id":"dada55a8_14a0fe9e","line":41,"in_reply_to":"1aa78d24_d87ce0b7","updated":"2016-07-18 15:15:50.000000000","message":"Done","commit_id":"4508419aa1c8fcf58d23b652c5da249ad752e193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a20a185707fdb2c72705375a09aff57ab6583c00","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def generate_params(argument, params):"},{"line_number":41,"context_line":"    \"\"\"Generate param string."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    :param argument: optional argument"},{"line_number":44,"context_line":"    :param params: value passed with argument"},{"line_number":45,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_b7a7dc0b","line":42,"updated":"2017-11-01 19:32:49.000000000","message":"How about \u0027Generates a parameter string in the form: \u0027 \u003cargument\u003e \u003ckey1\u003e\u003d\u003cvalue1\u003e \u003ckey2\u003e\u003d\u003cvalue2\u003e\u0027\n\nWhy does the returned string have a leading blank space?\n\nThis is a parameter string formatted for use with ironic CLI commands. (I\u0027m guessing this, if so, would be useful to put here.)","commit_id":"5e6fb13993ce2a547507575c56ae5012be52a8ca"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"ec39880697533780864d8fcc5bb0e5f1ac8bba30","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def generate_params(argument, params):"},{"line_number":41,"context_line":"    \"\"\"Generate param string."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    :param argument: optional argument"},{"line_number":44,"context_line":"    :param params: value passed with argument"},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    params_str \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_66e60e18","line":43,"range":{"start_line":43,"start_character":21,"end_line":43,"end_character":29},"updated":"2016-11-29 22:25:26.000000000","message":"seems odd to have this as the first param.","commit_id":"5e6fb13993ce2a547507575c56ae5012be52a8ca"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"770705cc5371af48f541986e3547d9c68b4e7bc2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def generate_params(argument, params):"},{"line_number":41,"context_line":"    \"\"\"Generate param string."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    :param argument: optional argument"},{"line_number":44,"context_line":"    :param params: value passed with argument"},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    params_str \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_ebf21706","line":43,"range":{"start_line":43,"start_character":21,"end_line":43,"end_character":29},"in_reply_to":"5a74a57a_66e60e18","updated":"2017-11-01 17:19:28.000000000","message":"yeah I guess it is not optional, I\u0027d say it is something like CLI parameter name. it is a nit tho","commit_id":"5e6fb13993ce2a547507575c56ae5012be52a8ca"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a20a185707fdb2c72705375a09aff57ab6583c00","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \"\"\"Generate param string."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    :param argument: optional argument"},{"line_number":44,"context_line":"    :param params: value passed with argument"},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    params_str \u003d \u0027\u0027"},{"line_number":47,"context_line":"    for key, value in params.iteritems():"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_17ffd001","line":44,"updated":"2017-11-01 19:32:49.000000000","message":"I see the code iterating on params at L47, so it would be useful to describe more, what this is. It isn\u0027t just one \u0027value\u0027?","commit_id":"5e6fb13993ce2a547507575c56ae5012be52a8ca"}]}
