)]}'
{"id":"openstack%2Fpython-ironicclient~263822","triplet_id":"openstack%2Fpython-ironicclient~master~Iaf8aef795782b5c4608f3a2be6887d0429176250","project":"openstack/python-ironicclient","branch":"master","topic":"bug/1530972","hashtags":[],"change_id":"Iaf8aef795782b5c4608f3a2be6887d0429176250","subject":"Do not log secrets","status":"MERGED","created":"2016-01-05 17:39:33.000000000","updated":"2016-01-06 17:09:55.000000000","submitted":"2016-01-06 17:09:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d711f03f8bfa564bb2c16dfd049b30e160539eee","_number":263822,"virtual_id_number":263822,"owner":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":2,"date":"2016-01-06 17:09:55.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"all":[{"value":2,"date":"2016-01-06 16:37:43.000000000","_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2016-01-06 16:04:43.000000000","_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"all":[{"value":1,"date":"2016-01-06 16:37:43.000000000","_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-05 21:33:02.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-01-06 16:04:43.000000000","updated_by":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"reviewer":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"state":"REVIEWER"},{"updated":"2016-01-06 16:37:43.000000000","updated_by":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"reviewer":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"state":"REVIEWER"},{"updated":"2016-01-06 17:09:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f746f3d99fc320a2bad6a3726e9af9490f60de7c","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-01-05 17:39:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"32cf27441a59f1b912900aef3af10d982969bd00","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-05 19:44:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/22/263822/1/check/gate-python-ironicclient-python34/8707ce3/ : SUCCESS in 1m 40s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/22/263822/1/check/gate-python-ironicclient-pep8/564f190/ : SUCCESS in 1m 28s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/22/263822/1/check/gate-python-ironicclient-docs/b915bc9//doc/build/html/ : SUCCESS in 1m 19s\n- gate-python-ironicclient-python27 http://logs.openstack.org/22/263822/1/check/gate-python-ironicclient-python27/fa01098/ : SUCCESS in 1m 25s\n- gate-python-ironicclient-pypy http://logs.openstack.org/22/263822/1/check/gate-python-ironicclient-pypy/ca9dec1/ : SUCCESS in 2m 01s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/22/263822/1/check/gate-tempest-dsvm-python-ironicclient-src/cec24d0/ : SUCCESS in 37m 53s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/22/263822/1/check/gate-ironicclient-dsvm-functional/d1b7ee7/ : FAILURE in 15m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7885f0df3e7ac78e350bdbd220c14168b18cfc14","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-01-05 21:33:02.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)\n\nLooks good, a couple of nits inline. -1 is because we already have test_http for common.http in another place","accounts_in_message":[],"_revision_number":1},{"id":"41402f24396185f40bd4e36497c9b205da4a913d","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-01-06 14:16:46.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"fe93162b906826ba7c699a22bd2c36338f01e0d0","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-01-06 14:21:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"67309300f0f5039752bf7862a88d26b5afc80f42","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-06 15:30:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/22/263822/2/check/gate-python-ironicclient-python34/ec75bbb/ : SUCCESS in 1m 46s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/22/263822/2/check/gate-python-ironicclient-pep8/612fa83/ : SUCCESS in 1m 05s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/22/263822/2/check/gate-python-ironicclient-docs/0ea8979//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-ironicclient-python27 http://logs.openstack.org/22/263822/2/check/gate-python-ironicclient-python27/28e0b90/ : SUCCESS in 1m 14s\n- gate-python-ironicclient-pypy http://logs.openstack.org/22/263822/2/check/gate-python-ironicclient-pypy/c185aa7/ : SUCCESS in 2m 10s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/22/263822/2/check/gate-tempest-dsvm-python-ironicclient-src/dba1e4a/ : SUCCESS in 37m 17s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/22/263822/2/check/gate-ironicclient-dsvm-functional/8bbb1a9/ : FAILURE in 17m 41s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2c0a889f3cd1bf1994f7a3507920987da377b67a","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2016-01-06 16:04:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9caffb6dd2017799f5a00c1937b9c7d9f8ae9db7","author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"date":"2016-01-06 16:37:43.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThank you Lucas, LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"22fa5dcd5492f26239fb47cbec25b7d90a0be486","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-06 16:37:49.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"eb9558b2213401c4e8c484b97cc58cd318870995","date":"2016-01-06 17:09:55.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"26ba7226fe5a26351d7b35cb45183b30e1ddb7b7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-06 17:09:55.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/22/263822/2/gate/gate-python-ironicclient-python34/a6f773f/ : SUCCESS in 2m 48s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/22/263822/2/gate/gate-python-ironicclient-docs/87f7867//doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/22/263822/2/gate/gate-python-ironicclient-pep8/bfd0e0a/ : SUCCESS in 58s\n- gate-python-ironicclient-python27 http://logs.openstack.org/22/263822/2/gate/gate-python-ironicclient-python27/dc1e92d/ : SUCCESS in 1m 15s\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/22/263822/2/gate/gate-tempest-dsvm-python-ironicclient-src/59be3ac/ : SUCCESS in 31m 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"eeb327b590b489a7f6b0e2176b288f7201de6aa9","revisions":{"c18a93aa6075370a0f4c8b84abc9577fe06776c6":{"kind":"REWORK","_number":1,"created":"2016-01-05 17:39:33.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/22/263822/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/22/263822/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/22/263822/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/22/263822/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/22/263822/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/22/263822/1"}}},"commit":{"parents":[{"commit":"e489e3b2fb30e0e75333ddadcdadc900c317bffa","subject":"Merge \"Add first reno-based release note\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e489e3b2fb30e0e75333ddadcdadc900c317bffa"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-01-05 17:37:00.000000000","tz":0},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-01-05 17:37:00.000000000","tz":0},"subject":"Do not log secrets","message":"Do not log secrets\n\nWhen logging the curl command or the http response we should obfuscate\nthe secrets.\n\nChange-Id: Iaf8aef795782b5c4608f3a2be6887d0429176250\nDepends-On: I10f9f37ff635f9a2dddfd7f7aaaac7d4fe6244b9\nPartial-Bug: 1530972\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/c18a93aa6075370a0f4c8b84abc9577fe06776c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/c18a93aa6075370a0f4c8b84abc9577fe06776c6"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"e489e3b2fb30e0e75333ddadcdadc900c317bffa","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"eeb327b590b489a7f6b0e2176b288f7201de6aa9":{"kind":"REWORK","_number":2,"created":"2016-01-06 14:21:31.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/22/263822/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/22/263822/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/22/263822/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/22/263822/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/22/263822/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/22/263822/2"}}},"commit":{"parents":[{"commit":"e489e3b2fb30e0e75333ddadcdadc900c317bffa","subject":"Merge \"Add first reno-based release note\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e489e3b2fb30e0e75333ddadcdadc900c317bffa"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-01-05 17:37:00.000000000","tz":0},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-01-06 14:20:55.000000000","tz":0},"subject":"Do not log secrets","message":"Do not log secrets\n\nWhen logging the curl command or the http response we should obfuscate\nthe secrets.\n\nChange-Id: Iaf8aef795782b5c4608f3a2be6887d0429176250\nPartial-Bug: 1530972\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/eeb327b590b489a7f6b0e2176b288f7201de6aa9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/eeb327b590b489a7f6b0e2176b288f7201de6aa9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"e489e3b2fb30e0e75333ddadcdadc900c317bffa","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}