)]}'
{"ironicclient/osc/plugin.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2fbe574115d665bf6cb0ebfef3de9abc3d94125b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \u00271.12\u0027: \u0027ironicclient.osc.client\u0027,"},{"line_number":38,"context_line":"    \u00271.13\u0027: \u0027ironicclient.osc.client\u0027,"},{"line_number":39,"context_line":"    \u00271.14\u0027: \u0027ironicclient.osc.client\u0027,"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def make_client(instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_b086a763","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":1},"updated":"2016-01-18 10:42:00.000000000","message":"I think we should just do\n\n LAST_KNOWN_VERSION \u003d 14\n API_VERSIONS \u003d {\n   \u00271.%d\u0027 % i: \u0027ironicclient.osc.client\u0027\n   for i in range(1, LAST_KNOWN_VERSION + 1)\n }\n API_VERSIONS[\u00271\u0027] \u003d API_VERSIONS[DEFAULT_BAREMETAL_API_VERSION]","commit_id":"e70eaa2f03f3372389cf01f88d310121d360d9e9"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"0b099d15e9eb5e02b94f9d7d270f44bc45c7fdf1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \u00271.12\u0027: \u0027ironicclient.osc.client\u0027,"},{"line_number":38,"context_line":"    \u00271.13\u0027: \u0027ironicclient.osc.client\u0027,"},{"line_number":39,"context_line":"    \u00271.14\u0027: \u0027ironicclient.osc.client\u0027,"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def make_client(instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_0b3f4226","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":1},"in_reply_to":"da6ed579_1089b3ca","updated":"2016-01-18 11:05:28.000000000","message":"I assumed that versions 1.1-1.4 and 1.7-1.8 had been left out for some reason, but I\u0027ve changed it to use a comprehension anyway.","commit_id":"e70eaa2f03f3372389cf01f88d310121d360d9e9"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"cb5d2760b52891f9cb86cc09b49782ac66b63d75","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \u00271.12\u0027: \u0027ironicclient.osc.client\u0027,"},{"line_number":38,"context_line":"    \u00271.13\u0027: \u0027ironicclient.osc.client\u0027,"},{"line_number":39,"context_line":"    \u00271.14\u0027: \u0027ironicclient.osc.client\u0027,"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def make_client(instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_1089b3ca","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":1},"in_reply_to":"da6ed579_b086a763","updated":"2016-01-18 10:56:00.000000000","message":"not sure why, but there are couple of versions missing; generating this through comprehension would introduce those. Or do I miss something?","commit_id":"e70eaa2f03f3372389cf01f88d310121d360d9e9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"378025ffb2077cdcd0ff1af1f0d1e91add40013d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"API_VERSIONS \u003d {"},{"line_number":31,"context_line":"    \u00271.%d\u0027 % i: \u0027ironicclient.osc.client\u0027"},{"line_number":32,"context_line":"    for i in range(1, ironic_client.LAST_KNOWN_API_VERSION + 1)"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":"API_VERSIONS[\u00271\u0027] \u003d API_VERSIONS[DEFAULT_BAREMETAL_API_VERSION]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_179524e3","line":33,"updated":"2016-01-18 12:49:26.000000000","message":"let\u0027s move this constant to client.py, so that we don\u0027t calculate it in 2 places","commit_id":"a22aaaaf41af9ecd22c82afd8fa7056cada2a793"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"1833d570ba3f1239e230575ec8e95e3102daaf06","unresolved":false,"context_lines":[{"line_number":30,"context_line":"API_VERSIONS \u003d {"},{"line_number":31,"context_line":"    \u00271.%d\u0027 % i: \u0027ironicclient.osc.client\u0027"},{"line_number":32,"context_line":"    for i in range(1, ironic_client.LAST_KNOWN_API_VERSION + 1)"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":"API_VERSIONS[\u00271\u0027] \u003d API_VERSIONS[DEFAULT_BAREMETAL_API_VERSION]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_df20f6b2","line":33,"in_reply_to":"da6ed579_179524e3","updated":"2016-01-18 15:56:56.000000000","message":"Do you mean the list of supported versions? The two dicts aren\u0027t quite the same - they have the same keys, but different values.","commit_id":"a22aaaaf41af9ecd22c82afd8fa7056cada2a793"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"75b3b15e9593d4569dea7b81fd3e87fc2b7c7df9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"API_VERSIONS \u003d {"},{"line_number":31,"context_line":"    \u00271.%d\u0027 % i: \u0027ironicclient.osc.client\u0027"},{"line_number":32,"context_line":"    for i in range(1, ironic_client.LAST_KNOWN_API_VERSION + 1)"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":"API_VERSIONS[\u00271\u0027] \u003d API_VERSIONS[DEFAULT_BAREMETAL_API_VERSION]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_1dd3d805","line":33,"in_reply_to":"da6ed579_82e22200","updated":"2016-01-20 10:26:48.000000000","message":"Done - see patch set 5.","commit_id":"a22aaaaf41af9ecd22c82afd8fa7056cada2a793"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"e9fd857d8648bef7ea9d4943f847e7e9113da50a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"API_VERSIONS \u003d {"},{"line_number":31,"context_line":"    \u00271.%d\u0027 % i: \u0027ironicclient.osc.client\u0027"},{"line_number":32,"context_line":"    for i in range(1, ironic_client.LAST_KNOWN_API_VERSION + 1)"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":"API_VERSIONS[\u00271\u0027] \u003d API_VERSIONS[DEFAULT_BAREMETAL_API_VERSION]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_82e22200","line":33,"in_reply_to":"da6ed579_df20f6b2","updated":"2016-01-18 16:18:31.000000000","message":"I\u0027ve changed this to generate the dict from one in client.py. Though actually the use in client.py is weird - I don\u0027t see what the extra levels of indirection are buying us.","commit_id":"a22aaaaf41af9ecd22c82afd8fa7056cada2a793"}],"releasenotes/notes/add_api_versions-a59e5b6899833c33.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"32490f396c788219df9ab23b52fc4c81af6d89ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for all Ironic API versions of the form 1.x, up to the latest"},{"line_number":4,"context_line":"    known minor version."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a68dd71_d8504261","line":3,"updated":"2016-01-26 15:04:53.000000000","message":"This is only for OSC, the regular CLI supports all versions. Can you add something to clarify that please? :)","commit_id":"2c3fcc923b2c3416545092c902bc9115b077f9c7"}]}