)]}'
{"ironicclient/common/http.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"a694f7c67e93e74eb287e014cff0de1a36723e8d","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            raise exc.EndpointException()"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _process_header(self, name, value):"},{"line_number":252,"context_line":"        if name in SENSITIVE_HEADERS:"},{"line_number":253,"context_line":"            v \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":254,"context_line":"            h \u003d hashlib.sha1(v)"},{"line_number":255,"context_line":"            d \u003d h.hexdigest()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_4315e699","line":252,"range":{"start_line":252,"start_character":8,"end_line":252,"end_character":37},"updated":"2016-02-24 05:46:24.000000000","message":"nits: \n\nif name \u003d\u003d SENSITIVE_HEADERS:  \n\nmake sense?","commit_id":"096ff540733dce347c440cfd0814b2e486bdd0ca"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"56d1fbc4ad9d0dbdc513af3f6850eb682aee1433","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        except six.moves.http_client.InvalidURL:"},{"line_number":249,"context_line":"            raise exc.EndpointException()"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _process_header(self, name, value):"},{"line_number":252,"context_line":"        if name in SENSITIVE_HEADERS:"},{"line_number":253,"context_line":"            v \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":254,"context_line":"            h \u003d hashlib.sha1(v)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_bc7b417a","line":251,"range":{"start_line":251,"start_character":4,"end_line":251,"end_character":43},"updated":"2016-02-23 21:52:02.000000000","message":"would like to see the DOC string that was included in the original version of this patch:\nhttps://review.openstack.org/#/c/162517/7/ironicclient/common/http.py\n\nplease add if another version is pushed up.","commit_id":"78f62e86a110f0158a6606cdd68fabe3caca9742"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bf03e493709e132ca71c6d1591b3048101bcc20c","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                         or the safe encoding format of name"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        \"\"\""},{"line_number":265,"context_line":"        if name \u003d\u003d SENSITIVE_HEADERS:"},{"line_number":266,"context_line":"            v \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":267,"context_line":"            h \u003d hashlib.sha1(v)"},{"line_number":268,"context_line":"            d \u003d h.hexdigest()"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_e4e3f903","line":265,"updated":"2016-02-25 14:54:51.000000000","message":"did you mean \"name in SENSITIVE_HEADERS\"?","commit_id":"ddc07dd06ff842e6da2e556a898ab07dd92ba4e2"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"27a26adda2302c0afa7d8d9d1c38fccbc32d1a3c","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                         or the safe encoding format of name"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        \"\"\""},{"line_number":265,"context_line":"        if name \u003d\u003d SENSITIVE_HEADERS:"},{"line_number":266,"context_line":"            v \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":267,"context_line":"            h \u003d hashlib.sha1(v)"},{"line_number":268,"context_line":"            d \u003d h.hexdigest()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_e8f787f3","line":265,"in_reply_to":"bae84128_e4e3f903","updated":"2016-02-25 17:38:02.000000000","message":"both in and \u003d\u003d works. But i feel in will better option if some new headers are added to tuple in future.","commit_id":"ddc07dd06ff842e6da2e556a898ab07dd92ba4e2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bf03e493709e132ca71c6d1591b3048101bcc20c","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            v \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":267,"context_line":"            h \u003d hashlib.sha1(v)"},{"line_number":268,"context_line":"            d \u003d h.hexdigest()"},{"line_number":269,"context_line":"            return encodeutils.safe_decode(name), \"{SHA1}%s\" % d"},{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            return (name, value)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_44f105cd","line":269,"updated":"2016-02-25 14:54:51.000000000","message":"why do you need safe_decode here? we don\u0027t use it on \"else\" branch","commit_id":"ddc07dd06ff842e6da2e556a898ab07dd92ba4e2"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"27a26adda2302c0afa7d8d9d1c38fccbc32d1a3c","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            v \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":267,"context_line":"            h \u003d hashlib.sha1(v)"},{"line_number":268,"context_line":"            d \u003d h.hexdigest()"},{"line_number":269,"context_line":"            return encodeutils.safe_decode(name), \"{SHA1}%s\" % d"},{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            return (name, value)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_a803bf0c","line":269,"in_reply_to":"bae84128_44f105cd","updated":"2016-02-25 17:38:02.000000000","message":"Because we are encoding incoming text/bytes string inside if branch we need to decode it before returning. \nElse branch dont need it i guess as we are just returning same values.","commit_id":"ddc07dd06ff842e6da2e556a898ab07dd92ba4e2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1b1984c52137dae23e6c6fe0a932fa246b6180d","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"DEFAULT_MAX_RETRIES \u003d 5"},{"line_number":58,"context_line":"DEFAULT_RETRY_INTERVAL \u003d 2"},{"line_number":59,"context_line":"SENSITIVE_HEADERS \u003d (\u0027X-Auth-Token\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _trim_endpoint_api_version(url):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_931d1e76","line":59,"range":{"start_line":59,"start_character":35,"end_line":59,"end_character":36},"updated":"2016-02-26 11:14:57.000000000","message":"a comma is required to make it a tuple\n\n (\u0027X-Auth-Token\u0027,)","commit_id":"d3885532371b1fe1cf88dc36306f86ff97fcb902"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"d71c869d513413dd55045ca5662c4e3a206dd603","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"DEFAULT_MAX_RETRIES \u003d 5"},{"line_number":58,"context_line":"DEFAULT_RETRY_INTERVAL \u003d 2"},{"line_number":59,"context_line":"SENSITIVE_HEADERS \u003d (\u0027X-Auth-Token\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _trim_endpoint_api_version(url):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_99a406a7","line":59,"range":{"start_line":59,"start_character":35,"end_line":59,"end_character":36},"in_reply_to":"9aed3d3a_931d1e76","updated":"2016-02-26 17:08:20.000000000","message":"Done","commit_id":"d3885532371b1fe1cf88dc36306f86ff97fcb902"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1b1984c52137dae23e6c6fe0a932fa246b6180d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            v \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":267,"context_line":"            h \u003d hashlib.sha1(v)"},{"line_number":268,"context_line":"            d \u003d h.hexdigest()"},{"line_number":269,"context_line":"            return encodeutils.safe_decode(name), \"{SHA1}%s\" % d"},{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            return (name, value)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_73597a5a","line":269,"range":{"start_line":269,"start_character":18,"end_line":269,"end_character":49},"updated":"2016-02-26 11:14:57.000000000","message":"I\u0027m still confused why we decode name here, but not on line 271. We don\u0027t seem to do anything with name on lines 266-268","commit_id":"d3885532371b1fe1cf88dc36306f86ff97fcb902"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"d71c869d513413dd55045ca5662c4e3a206dd603","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            v \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":267,"context_line":"            h \u003d hashlib.sha1(v)"},{"line_number":268,"context_line":"            d \u003d h.hexdigest()"},{"line_number":269,"context_line":"            return encodeutils.safe_decode(name), \"{SHA1}%s\" % d"},{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            return (name, value)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_599a7e64","line":269,"range":{"start_line":269,"start_character":18,"end_line":269,"end_character":49},"in_reply_to":"9aed3d3a_73597a5a","updated":"2016-02-26 17:08:20.000000000","message":"Done","commit_id":"d3885532371b1fe1cf88dc36306f86ff97fcb902"}]}