)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"dbe74a3f33c311fc56bdf2349384da982b0191ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":"* openstack baremetal set -\u003e openstack baremetal node set"},{"line_number":16,"context_line":"* openstack baremetal show -\u003e openstack baremetal node show"},{"line_number":17,"context_line":"* openstack baremetal unset -\u003e openstack baremetal node unset"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2f3e51973d26c968beae96ecf4447f66841f6155"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7af24918_acf04b92","line":18,"updated":"2016-03-03 11:51:19.000000000","message":"Please, add Partial-Bug: xxxxxxx or Related-Bug: xxxxxxx \n\nhttps://bugs.launchpad.net/python-ironicclient/+bug/1526479","commit_id":"4e5e779c4794ea82228fc5890d81a55d0b5c01ea"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"64f8577de6573a1f3ecfe4d14f73669fdf81682b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"* openstack baremetal set -\u003e openstack baremetal node set"},{"line_number":16,"context_line":"* openstack baremetal show -\u003e openstack baremetal node show"},{"line_number":17,"context_line":"* openstack baremetal unset -\u003e openstack baremetal node unset"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2f3e51973d26c968beae96ecf4447f66841f6155"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7af24918_daae0d2d","line":18,"in_reply_to":"7af24918_acf04b92","updated":"2016-03-03 18:43:44.000000000","message":"Done","commit_id":"4e5e779c4794ea82228fc5890d81a55d0b5c01ea"}],"ironicclient/osc/plugin.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f21da0212fa005504e16f0b6dfdf261b956f0b6","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_BAREMETAL_API_VERSION \u003d \u00271.14\u0027"},{"line_number":24,"context_line":"API_VERSION_OPTION \u003d \u0027os_baremetal_api_version\u0027"},{"line_number":25,"context_line":"API_NAME \u003d \u0027baremetal\u0027"},{"line_number":26,"context_line":"LAST_KNOWN_API_VERSION \u003d 14"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_4d25cea9","line":23,"updated":"2016-03-07 15:44:04.000000000","message":"please don\u0027t bump this. we agreed that after 1.6 (1.9 for the old client), we\u0027re requiring users to explicitly opt-in API versions","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"46f6a2e73dd9647c9556a075db799af14b4e45eb","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_BAREMETAL_API_VERSION \u003d \u00271.14\u0027"},{"line_number":24,"context_line":"API_VERSION_OPTION \u003d \u0027os_baremetal_api_version\u0027"},{"line_number":25,"context_line":"API_NAME \u003d \u0027baremetal\u0027"},{"line_number":26,"context_line":"LAST_KNOWN_API_VERSION \u003d 14"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_6096914d","line":23,"in_reply_to":"5aef4532_42739de7","updated":"2016-03-08 17:02:45.000000000","message":"because it might bring in breaking changes (actually it will)","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ffd91aeef5d8592e4357fb6dd6f7f49431c6ef44","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_BAREMETAL_API_VERSION \u003d \u00271.14\u0027"},{"line_number":24,"context_line":"API_VERSION_OPTION \u003d \u0027os_baremetal_api_version\u0027"},{"line_number":25,"context_line":"API_NAME \u003d \u0027baremetal\u0027"},{"line_number":26,"context_line":"LAST_KNOWN_API_VERSION \u003d 14"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_42739de7","line":23,"in_reply_to":"5aef4532_4d25cea9","updated":"2016-03-08 16:45:40.000000000","message":"I\u0027m not sure I understand the reason for this. This code uses an API later than 1.6. In fact, it now *can\u0027t* be used with 1.6. So, why wouldn\u0027t it default to that?","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"}],"ironicclient/osc/v1/baremetal.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8d09ebf0590280777ed86b846d382c0d4d2c7011","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        return super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def take_action(self, parsed_args):"},{"line_number":105,"context_line":"        self.log.warn(\u0027This command is deprecated\u0027)"},{"line_number":106,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c1e500a9","line":105,"updated":"2016-02-25 16:20:48.000000000","message":"please suggest what should be used instead","commit_id":"05e19323feb5cc22a475e2f5326886840cac535c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"1948c4846158121ec7b2320cfb2132dfca681b7c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        return super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def take_action(self, parsed_args):"},{"line_number":105,"context_line":"        self.log.warn(\u0027This command is deprecated\u0027)"},{"line_number":106,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_d98340cb","line":105,"in_reply_to":"bae84128_c1e500a9","updated":"2016-02-26 15:33:21.000000000","message":"Done","commit_id":"05e19323feb5cc22a475e2f5326886840cac535c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8d09ebf0590280777ed86b846d382c0d4d2c7011","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        return super(DeleteBaremetal, self).get_parser(prog_name)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def take_action(self, parsed_args):"},{"line_number":144,"context_line":"        self.log.warn(\u0027This command is deprecated.\u0027)"},{"line_number":145,"context_line":"        super(DeleteBaremetal, self).take_action(parsed_args)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_a1e0bc97","line":144,"updated":"2016-02-25 16:20:48.000000000","message":"ditto","commit_id":"05e19323feb5cc22a475e2f5326886840cac535c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"1948c4846158121ec7b2320cfb2132dfca681b7c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        return super(DeleteBaremetal, self).get_parser(prog_name)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def take_action(self, parsed_args):"},{"line_number":144,"context_line":"        self.log.warn(\u0027This command is deprecated.\u0027)"},{"line_number":145,"context_line":"        super(DeleteBaremetal, self).take_action(parsed_args)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_b988fce8","line":144,"in_reply_to":"bae84128_a1e0bc97","updated":"2016-02-26 15:33:21.000000000","message":"Done","commit_id":"05e19323feb5cc22a475e2f5326886840cac535c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8d09ebf0590280777ed86b846d382c0d4d2c7011","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        return super(ListBaremetal, self).get_parser(prog_name)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def take_action(self, parsed_args):"},{"line_number":278,"context_line":"        self.log.warn(\u0027This command is deprecated.\u0027)"},{"line_number":279,"context_line":"        return super(ListBaremetal, self).take_action(parsed_args)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_01eec88a","line":278,"updated":"2016-02-25 16:20:48.000000000","message":"ditto","commit_id":"05e19323feb5cc22a475e2f5326886840cac535c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"1948c4846158121ec7b2320cfb2132dfca681b7c","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        return super(ListBaremetal, self).get_parser(prog_name)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def take_action(self, parsed_args):"},{"line_number":278,"context_line":"        self.log.warn(\u0027This command is deprecated.\u0027)"},{"line_number":279,"context_line":"        return super(ListBaremetal, self).take_action(parsed_args)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_196e482f","line":278,"in_reply_to":"bae84128_01eec88a","updated":"2016-02-26 15:33:21.000000000","message":"Done","commit_id":"05e19323feb5cc22a475e2f5326886840cac535c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8d09ebf0590280777ed86b846d382c0d4d2c7011","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        return super(SetBaremetal, self).get_parser(prog_name)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def take_action(self, parsed_args):"},{"line_number":357,"context_line":"        self.log.warn(\u0027This command is deprecated.\u0027)"},{"line_number":358,"context_line":"        return super(SetBaremetal, self).take_action(parsed_args)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e1f00469","line":357,"updated":"2016-02-25 16:20:48.000000000","message":"ditto","commit_id":"05e19323feb5cc22a475e2f5326886840cac535c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"1948c4846158121ec7b2320cfb2132dfca681b7c","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        return super(SetBaremetal, self).get_parser(prog_name)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def take_action(self, parsed_args):"},{"line_number":357,"context_line":"        self.log.warn(\u0027This command is deprecated.\u0027)"},{"line_number":358,"context_line":"        return super(SetBaremetal, self).take_action(parsed_args)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_f96a8419","line":357,"in_reply_to":"bae84128_e1f00469","updated":"2016-02-26 15:33:21.000000000","message":"Done","commit_id":"05e19323feb5cc22a475e2f5326886840cac535c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def take_action(self, parsed_args):"},{"line_number":105,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":106,"context_line":"                      \u0027openstack baremetal node create\u0027)"},{"line_number":107,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_14aac1d4","line":106,"updated":"2016-03-01 13:53:45.000000000","message":"nit: string formatting is not needed here","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def take_action(self, parsed_args):"},{"line_number":105,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":106,"context_line":"                      \u0027openstack baremetal node create\u0027)"},{"line_number":107,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_4355581b","line":106,"in_reply_to":"7af24918_14aac1d4","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def take_action(self, parsed_args):"},{"line_number":145,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":146,"context_line":"                      \u0027openstack baremetal node delete\u0027)"},{"line_number":147,"context_line":"        super(DeleteBaremetal, self).take_action(parsed_args)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_74afc5e3","line":146,"updated":"2016-03-01 13:53:45.000000000","message":"ditto","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def take_action(self, parsed_args):"},{"line_number":145,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":146,"context_line":"                      \u0027openstack baremetal node delete\u0027)"},{"line_number":147,"context_line":"        super(DeleteBaremetal, self).take_action(parsed_args)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_8335a0f8","line":146,"in_reply_to":"7af24918_74afc5e3","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            help\u003d\"List only nodes associated with an instance.\""},{"line_number":192,"context_line":"        )"},{"line_number":193,"context_line":"        parser.add_argument("},{"line_number":194,"context_line":"            \u0027--chassis\u0027,"},{"line_number":195,"context_line":"            dest\u003d\u0027chassis\u0027,"},{"line_number":196,"context_line":"            metavar\u003d\u0027\u003cchassis\u003e\u0027,"},{"line_number":197,"context_line":"            help\u003d\u0027Chassis UUID to limit node list\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_54ac49ed","line":194,"updated":"2016-03-01 13:53:45.000000000","message":"we\u0027ve missed it from the spec, but we probably need to make it consistent with --chassis-uuid in the create call. as we already have chassis-uuid there, we probably need the same here","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            help\u003d\"List only nodes associated with an instance.\""},{"line_number":192,"context_line":"        )"},{"line_number":193,"context_line":"        parser.add_argument("},{"line_number":194,"context_line":"            \u0027--chassis\u0027,"},{"line_number":195,"context_line":"            dest\u003d\u0027chassis\u0027,"},{"line_number":196,"context_line":"            metavar\u003d\u0027\u003cchassis\u003e\u0027,"},{"line_number":197,"context_line":"            help\u003d\u0027Chassis UUID to limit node list\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_e33c64e4","line":194,"in_reply_to":"7af24918_54ac49ed","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        if parsed_args.maintenance:"},{"line_number":242,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":243,"context_line":"        if parsed_args.chassis:"},{"line_number":244,"context_line":"            params[\u0027chassis\u0027] \u003d parsed_args.chassis"},{"line_number":245,"context_line":"        if parsed_args.provision_state:"},{"line_number":246,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"},{"line_number":247,"context_line":"        if parsed_args.long:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_b4b94d31","line":244,"updated":"2016-03-01 13:53:45.000000000","message":"looks like chassis_uuid is accepted, not chassis: https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L1091","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        if parsed_args.maintenance:"},{"line_number":242,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":243,"context_line":"        if parsed_args.chassis:"},{"line_number":244,"context_line":"            params[\u0027chassis\u0027] \u003d parsed_args.chassis"},{"line_number":245,"context_line":"        if parsed_args.provision_state:"},{"line_number":246,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"},{"line_number":247,"context_line":"        if parsed_args.long:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_c33fa8d4","line":244,"in_reply_to":"7af24918_b4b94d31","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def take_action(self, parsed_args):"},{"line_number":280,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":281,"context_line":"                      \u0027openstack baremetal node list\u0027)"},{"line_number":282,"context_line":"        return super(ListBaremetal, self).take_action(parsed_args)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_94b6d13b","line":281,"updated":"2016-03-01 13:53:45.000000000","message":"ditto about formatting","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def take_action(self, parsed_args):"},{"line_number":280,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":281,"context_line":"                      \u0027openstack baremetal node list\u0027)"},{"line_number":282,"context_line":"        return super(ListBaremetal, self).take_action(parsed_args)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_23276ccb","line":281,"in_reply_to":"7af24918_94b6d13b","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":323,"context_line":"            help\u003d\u0027Instance info to set on this baremetal host \u0027"},{"line_number":324,"context_line":"                 \u0027(repeat option to set multiple instance infos)\u0027,"},{"line_number":325,"context_line":"        )"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return parser"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_f481154f","line":325,"updated":"2016-03-01 13:53:45.000000000","message":"--instance-uuid is missing (present in the spec)","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":323,"context_line":"            help\u003d\u0027Instance info to set on this baremetal host \u0027"},{"line_number":324,"context_line":"                 \u0027(repeat option to set multiple instance infos)\u0027,"},{"line_number":325,"context_line":"        )"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return parser"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_63317405","line":325,"in_reply_to":"7af24918_f481154f","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def take_action(self, parsed_args):"},{"line_number":360,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":361,"context_line":"                      \u0027openstack baremetal node set\u0027)"},{"line_number":362,"context_line":"        return super(SetBaremetal, self).take_action(parsed_args)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_d4869964","line":361,"updated":"2016-03-01 13:53:45.000000000","message":"ditto about formatting","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def take_action(self, parsed_args):"},{"line_number":360,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":361,"context_line":"                      \u0027openstack baremetal node set\u0027)"},{"line_number":362,"context_line":"        return super(SetBaremetal, self).take_action(parsed_args)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_831c8078","line":361,"in_reply_to":"7af24918_d4869964","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        display_group \u003d parser.add_mutually_exclusive_group(required\u003dFalse)"},{"line_number":392,"context_line":"        display_group.add_argument("},{"line_number":393,"context_line":"            \u0027--long\u0027,"},{"line_number":394,"context_line":"            default\u003dFalse,"},{"line_number":395,"context_line":"            action\u003d\u0027store_true\u0027)"},{"line_number":396,"context_line":"        display_group.add_argument("},{"line_number":397,"context_line":"            \u0027--fields\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_347c1d72","line":394,"updated":"2016-03-01 13:53:45.000000000","message":"help is missing","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        display_group \u003d parser.add_mutually_exclusive_group(required\u003dFalse)"},{"line_number":392,"context_line":"        display_group.add_argument("},{"line_number":393,"context_line":"            \u0027--long\u0027,"},{"line_number":394,"context_line":"            default\u003dFalse,"},{"line_number":395,"context_line":"            action\u003d\u0027store_true\u0027)"},{"line_number":396,"context_line":"        display_group.add_argument("},{"line_number":397,"context_line":"            \u0027--fields\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_e313c464","line":394,"in_reply_to":"7af24918_347c1d72","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def take_action(self, parsed_args):"},{"line_number":438,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":439,"context_line":"                      \u0027openstack baremetal node show\u0027)"},{"line_number":440,"context_line":"        return super(ShowBaremetal, self).take_action(parsed_args)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_1481214b","line":439,"updated":"2016-03-01 13:53:45.000000000","message":"ditto about formatting","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def take_action(self, parsed_args):"},{"line_number":438,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":439,"context_line":"                      \u0027openstack baremetal node show\u0027)"},{"line_number":440,"context_line":"        return super(ShowBaremetal, self).take_action(parsed_args)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_c3168854","line":439,"in_reply_to":"7af24918_1481214b","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":479,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":480,"context_line":"            help\u003d\u0027Instance info to unset on this baremetal host \u0027"},{"line_number":481,"context_line":"                 \u0027(repeat option to unset multiple instance infos)\u0027,"},{"line_number":482,"context_line":"        )"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        return parser"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_7496a595","line":482,"updated":"2016-03-01 13:53:45.000000000","message":"--instance-uuid is missing","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":479,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":480,"context_line":"            help\u003d\u0027Instance info to unset on this baremetal host \u0027"},{"line_number":481,"context_line":"                 \u0027(repeat option to unset multiple instance infos)\u0027,"},{"line_number":482,"context_line":"        )"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        return parser"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_ceceafb3","line":482,"in_reply_to":"7af24918_7496a595","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"514b6dc5fc347944853109e1bd3efb84067b49e3","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def take_action(self, parsed_args):"},{"line_number":519,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":520,"context_line":"                      \u0027openstack baremetal node unset\u0027)"},{"line_number":521,"context_line":"        super(UnsetBaremetal, self).take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_5493a9a3","line":520,"updated":"2016-03-01 13:53:45.000000000","message":"ditto about formatting","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7508c337c4e44d710a3ed589ccba122ed6c7bf49","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def take_action(self, parsed_args):"},{"line_number":519,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \u0027%s\u0027\" %"},{"line_number":520,"context_line":"                      \u0027openstack baremetal node unset\u0027)"},{"line_number":521,"context_line":"        super(UnsetBaremetal, self).take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_6ec03b7c","line":520,"in_reply_to":"7af24918_5493a9a3","updated":"2016-03-02 15:35:00.000000000","message":"Done","commit_id":"7227a45b78757b61b2a81b6b963792a367cbb760"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"dbe74a3f33c311fc56bdf2349384da982b0191ac","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        return super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def take_action(self, parsed_args):"},{"line_number":105,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \""},{"line_number":106,"context_line":"                      \"\u0027openstack baremetal node create\u0027\")"},{"line_number":107,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_b20a6c88","line":105,"range":{"start_line":105,"start_character":17,"end_line":105,"end_character":21},"updated":"2016-03-03 11:51:19.000000000","message":"please, warn-\u003ewarning, warn is deprecated","commit_id":"4e5e779c4794ea82228fc5890d81a55d0b5c01ea"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"64f8577de6573a1f3ecfe4d14f73669fdf81682b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        return super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def take_action(self, parsed_args):"},{"line_number":105,"context_line":"        self.log.warn(\"This command is deprecated. Instead, use \""},{"line_number":106,"context_line":"                      \"\u0027openstack baremetal node create\u0027\")"},{"line_number":107,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_5a695df8","line":105,"in_reply_to":"7af24918_b20a6c88","updated":"2016-03-03 18:43:44.000000000","message":"Done","commit_id":"4e5e779c4794ea82228fc5890d81a55d0b5c01ea"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"dbe74a3f33c311fc56bdf2349384da982b0191ac","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        for node in parsed_args.nodes:"},{"line_number":131,"context_line":"            the_node \u003d oscutils.find_resource(baremetal_client.node,"},{"line_number":132,"context_line":"                                              node)"},{"line_number":133,"context_line":"            baremetal_client.node.delete(the_node.uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_cca797bb","line":130,"range":{"start_line":130,"start_character":7,"end_line":130,"end_character":38},"updated":"2016-03-03 11:51:19.000000000","message":"It would be nice to fix next bug as in ironic cli, I think in follow up:\nhttps://review.openstack.org/#/c/262393/\nhttps://review.openstack.org/#/c/287177/","commit_id":"4e5e779c4794ea82228fc5890d81a55d0b5c01ea"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"64f8577de6573a1f3ecfe4d14f73669fdf81682b","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        for node in parsed_args.nodes:"},{"line_number":131,"context_line":"            the_node \u003d oscutils.find_resource(baremetal_client.node,"},{"line_number":132,"context_line":"                                              node)"},{"line_number":133,"context_line":"            baremetal_client.node.delete(the_node.uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_9a6f65fb","line":130,"in_reply_to":"7af24918_cca797bb","updated":"2016-03-03 18:43:44.000000000","message":"Done","commit_id":"4e5e779c4794ea82228fc5890d81a55d0b5c01ea"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f21da0212fa005504e16f0b6dfdf261b956f0b6","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetal\")"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_parser(self, prog_name):"},{"line_number":102,"context_line":"        return super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def take_action(self, parsed_args):"},{"line_number":105,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_ed1dba67","line":102,"updated":"2016-03-07 15:44:04.000000000","message":"this is not needed","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ffd91aeef5d8592e4357fb6dd6f7f49431c6ef44","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetal\")"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_parser(self, prog_name):"},{"line_number":102,"context_line":"        return super(CreateBaremetal, self).get_parser(prog_name)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def take_action(self, parsed_args):"},{"line_number":105,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_85476f4a","line":102,"in_reply_to":"5aef4532_ed1dba67","updated":"2016-03-08 16:45:40.000000000","message":"Done","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f21da0212fa005504e16f0b6dfdf261b956f0b6","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    log \u003d logging.getLogger(__name__ + \".DeleteBaremetal\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def get_parser(self, prog_name):"},{"line_number":149,"context_line":"        return super(DeleteBaremetal, self).get_parser(prog_name)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def take_action(self, parsed_args):"},{"line_number":152,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_cd1a7e6e","line":149,"updated":"2016-03-07 15:44:04.000000000","message":"this is not needed","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ffd91aeef5d8592e4357fb6dd6f7f49431c6ef44","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    log \u003d logging.getLogger(__name__ + \".DeleteBaremetal\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def get_parser(self, prog_name):"},{"line_number":149,"context_line":"        return super(DeleteBaremetal, self).get_parser(prog_name)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def take_action(self, parsed_args):"},{"line_number":152,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_e574739d","line":149,"in_reply_to":"5aef4532_cd1a7e6e","updated":"2016-03-08 16:45:40.000000000","message":"Done","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f21da0212fa005504e16f0b6dfdf261b956f0b6","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    log \u003d logging.getLogger(__name__ + \".ListBaremetal\")"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def get_parser(self, prog_name):"},{"line_number":284,"context_line":"        return super(ListBaremetal, self).get_parser(prog_name)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def take_action(self, parsed_args):"},{"line_number":287,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_2d2682ba","line":284,"updated":"2016-03-07 15:44:04.000000000","message":"this is not needed","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ffd91aeef5d8592e4357fb6dd6f7f49431c6ef44","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    log \u003d logging.getLogger(__name__ + \".ListBaremetal\")"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def get_parser(self, prog_name):"},{"line_number":284,"context_line":"        return super(ListBaremetal, self).get_parser(prog_name)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def take_action(self, parsed_args):"},{"line_number":287,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_656983be","line":284,"in_reply_to":"5aef4532_2d2682ba","updated":"2016-03-08 16:45:40.000000000","message":"Done","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f21da0212fa005504e16f0b6dfdf261b956f0b6","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    log \u003d logging.getLogger(__name__ + \".ShowBaremetal\")"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    def get_parser(self, prog_name):"},{"line_number":451,"context_line":"        return super(ShowBaremetal, self).get_parser(prog_name)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def take_action(self, parsed_args):"},{"line_number":454,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_0d2bc683","line":451,"updated":"2016-03-07 15:44:04.000000000","message":"ditto","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ffd91aeef5d8592e4357fb6dd6f7f49431c6ef44","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    log \u003d logging.getLogger(__name__ + \".ShowBaremetal\")"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    def get_parser(self, prog_name):"},{"line_number":451,"context_line":"        return super(ShowBaremetal, self).get_parser(prog_name)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def take_action(self, parsed_args):"},{"line_number":454,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_a5638bdb","line":451,"in_reply_to":"5aef4532_0d2bc683","updated":"2016-03-08 16:45:40.000000000","message":"Done","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f21da0212fa005504e16f0b6dfdf261b956f0b6","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    log \u003d logging.getLogger(__name__ + \".UnsetBaremetal\")"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def get_parser(self, prog_name):"},{"line_number":541,"context_line":"        return super(UnsetBaremetal, self).get_parser(prog_name)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def take_action(self, parsed_args):"},{"line_number":544,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_6d208a9c","line":541,"updated":"2016-03-07 15:44:04.000000000","message":"ditto","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ffd91aeef5d8592e4357fb6dd6f7f49431c6ef44","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    log \u003d logging.getLogger(__name__ + \".UnsetBaremetal\")"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def get_parser(self, prog_name):"},{"line_number":541,"context_line":"        return super(UnsetBaremetal, self).get_parser(prog_name)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def take_action(self, parsed_args):"},{"line_number":544,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_855e4f10","line":541,"in_reply_to":"5aef4532_6d208a9c","updated":"2016-03-08 16:45:40.000000000","message":"Done","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def take_action(self, parsed_args):"},{"line_number":104,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""},{"line_number":105,"context_line":"                         \"\u0027openstack baremetal node create\u0027\")"},{"line_number":106,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_0fcae11a","line":105,"updated":"2016-04-21 00:07:46.000000000","message":"nit, missing period at the end of this sentence.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def take_action(self, parsed_args):"},{"line_number":104,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""},{"line_number":105,"context_line":"                         \"\u0027openstack baremetal node create\u0027\")"},{"line_number":106,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_28c04f7c","line":105,"in_reply_to":"1a122d0e_0fcae11a","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            \"nodes\","},{"line_number":118,"context_line":"            metavar\u003d\"\u003cnode\u003e\","},{"line_number":119,"context_line":"            nargs\u003d\"+\","},{"line_number":120,"context_line":"            help\u003d\"Node(s) to delete (name or ID)\")"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        return parser"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_b25cf219","line":120,"updated":"2016-04-21 00:07:46.000000000","message":"if you don\u0027t mind making this change, it should be s/ID/UUID/.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            \"nodes\","},{"line_number":118,"context_line":"            metavar\u003d\"\u003cnode\u003e\","},{"line_number":119,"context_line":"            nargs\u003d\"+\","},{"line_number":120,"context_line":"            help\u003d\"Node(s) to delete (name or ID)\")"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        return parser"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_2847af1e","line":120,"in_reply_to":"1a122d0e_b25cf219","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def take_action(self, parsed_args):"},{"line_number":148,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""},{"line_number":149,"context_line":"                         \"\u0027openstack baremetal node delete\u0027\")"},{"line_number":150,"context_line":"        super(DeleteBaremetal, self).take_action(parsed_args)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_0fbf8161","line":149,"updated":"2016-04-21 00:07:46.000000000","message":"ditto about missing period at end. (And everywhere else in this file, I won\u0027t point them all out.)","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def take_action(self, parsed_args):"},{"line_number":148,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""},{"line_number":149,"context_line":"                         \"\u0027openstack baremetal node delete\u0027\")"},{"line_number":150,"context_line":"        super(DeleteBaremetal, self).take_action(parsed_args)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_a861ffaa","line":149,"in_reply_to":"1a122d0e_0fbf8161","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def take_action(self, parsed_args):"},{"line_number":148,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""},{"line_number":149,"context_line":"                         \"\u0027openstack baremetal node delete\u0027\")"},{"line_number":150,"context_line":"        super(DeleteBaremetal, self).take_action(parsed_args)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class ListBaremetalNode(lister.Lister):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_4fb5f97b","line":150,"updated":"2016-04-21 00:07:46.000000000","message":"I suppose we don\u0027t care that this deprecated command has been enhanced to delete more than one node.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def take_action(self, parsed_args):"},{"line_number":148,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""},{"line_number":149,"context_line":"                         \"\u0027openstack baremetal node delete\u0027\")"},{"line_number":150,"context_line":"        super(DeleteBaremetal, self).take_action(parsed_args)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class ListBaremetalNode(lister.Lister):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_28d96f84","line":150,"in_reply_to":"1a122d0e_4fb5f97b","updated":"2016-04-26 17:38:34.000000000","message":"Not really, no. If we were removing that capability, that would be one thing.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        parser.add_argument("},{"line_number":176,"context_line":"            \u0027--sort\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":178,"context_line":"            help\u003d\u0027Sort output by selected keys and directions(asc or desc) \u0027"},{"line_number":179,"context_line":"                 \u0027(default: asc), multiple keys and directions can be \u0027"},{"line_number":180,"context_line":"                 \u0027specified separated by comma\u0027,"},{"line_number":181,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_92cd7668","line":178,"updated":"2016-04-21 00:07:46.000000000","message":"how about s/selected key/specified node field/\n\ns/directions/direction /","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        parser.add_argument("},{"line_number":176,"context_line":"            \u0027--sort\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":178,"context_line":"            help\u003d\u0027Sort output by selected keys and directions(asc or desc) \u0027"},{"line_number":179,"context_line":"                 \u0027(default: asc), multiple keys and directions can be \u0027"},{"line_number":180,"context_line":"                 \u0027specified separated by comma\u0027,"},{"line_number":181,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_c8ba7b71","line":178,"in_reply_to":"1a122d0e_92cd7668","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":178,"context_line":"            help\u003d\u0027Sort output by selected keys and directions(asc or desc) \u0027"},{"line_number":179,"context_line":"                 \u0027(default: asc), multiple keys and directions can be \u0027"},{"line_number":180,"context_line":"                 \u0027specified separated by comma\u0027,"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_12e046cc","line":180,"updated":"2016-04-21 00:07:46.000000000","message":"It can? I didn\u0027t know that worked.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":178,"context_line":"            help\u003d\u0027Sort output by selected keys and directions(asc or desc) \u0027"},{"line_number":179,"context_line":"                 \u0027(default: asc), multiple keys and directions can be \u0027"},{"line_number":180,"context_line":"                 \u0027specified separated by comma\u0027,"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_283b2f3a","line":180,"in_reply_to":"1a122d0e_12e046cc","updated":"2016-04-26 17:38:34.000000000","message":"Yes it does.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            help\u003d\"List only nodes associated with an instance.\""},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":"        parser.add_argument("},{"line_number":197,"context_line":"            \u0027--chassis-uuid\u0027,"},{"line_number":198,"context_line":"            dest\u003d\u0027chassis_uuid\u0027,"},{"line_number":199,"context_line":"            metavar\u003d\u0027\u003cchassis\u003e\u0027,"},{"line_number":200,"context_line":"            help\u003d\u0027Chassis UUID to limit node list\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_f5e2d4d3","line":197,"updated":"2016-04-21 00:07:46.000000000","message":"Hmm. Odd, I see this in the spec, and I see this in the ironic code, but I don\u0027t see this in the other client API. I suppose it is fine to leave this here. Someone could add it to the other API later.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            \u0027--chassis-uuid\u0027,"},{"line_number":198,"context_line":"            dest\u003d\u0027chassis_uuid\u0027,"},{"line_number":199,"context_line":"            metavar\u003d\u0027\u003cchassis\u003e\u0027,"},{"line_number":200,"context_line":"            help\u003d\u0027Chassis UUID to limit node list\u0027)"},{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":203,"context_line":"            dest\u003d\u0027provision_state\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_b5ecdcbb","line":200,"updated":"2016-04-21 00:07:46.000000000","message":"how about \u0027List nodes with this chassis UUID.\u0027","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            \u0027--chassis-uuid\u0027,"},{"line_number":198,"context_line":"            dest\u003d\u0027chassis_uuid\u0027,"},{"line_number":199,"context_line":"            metavar\u003d\u0027\u003cchassis\u003e\u0027,"},{"line_number":200,"context_line":"            help\u003d\u0027Chassis UUID to limit node list\u0027)"},{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":203,"context_line":"            dest\u003d\u0027provision_state\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_c861db13","line":200,"in_reply_to":"1a122d0e_b5ecdcbb","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            metavar\u003d\u0027\u003cfield\u003e\u0027,"},{"line_number":221,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":222,"context_line":"            default\u003d[],"},{"line_number":223,"context_line":"            help\u003d\"One of more node fields. Only these fileds will be fetched \""},{"line_number":224,"context_line":"                 \"from the server. Can not be used when \u0027--long\u0027 is \""},{"line_number":225,"context_line":"                 \"specified.\")"},{"line_number":226,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_725c1a4b","line":223,"updated":"2016-04-21 00:07:46.000000000","message":"s/of/or/\n\ns/fileds/fields/","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            metavar\u003d\u0027\u003cfield\u003e\u0027,"},{"line_number":221,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":222,"context_line":"            default\u003d[],"},{"line_number":223,"context_line":"            help\u003d\"One of more node fields. Only these fileds will be fetched \""},{"line_number":224,"context_line":"                 \"from the server. Can not be used when \u0027--long\u0027 is \""},{"line_number":225,"context_line":"                 \"specified.\")"},{"line_number":226,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_48766bd9","line":223,"in_reply_to":"1a122d0e_725c1a4b","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        parser.add_argument("},{"line_number":299,"context_line":"            \"--instance-uuid\","},{"line_number":300,"context_line":"            metavar\u003d\"\u003cuuid\u003e\","},{"line_number":301,"context_line":"            help\u003d\"Set instance uuid of node to \u003cuuid\u003e\""},{"line_number":302,"context_line":"        )"},{"line_number":303,"context_line":"        parser.add_argument("},{"line_number":304,"context_line":"            \"--property\","}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_553aa8e7","line":301,"updated":"2016-04-21 00:07:46.000000000","message":"s/uuid/UUID/","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        parser.add_argument("},{"line_number":299,"context_line":"            \"--instance-uuid\","},{"line_number":300,"context_line":"            metavar\u003d\"\u003cuuid\u003e\","},{"line_number":301,"context_line":"            help\u003d\"Set instance uuid of node to \u003cuuid\u003e\""},{"line_number":302,"context_line":"        )"},{"line_number":303,"context_line":"        parser.add_argument("},{"line_number":304,"context_line":"            \"--property\","}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_c82f1ba6","line":301,"in_reply_to":"1a122d0e_553aa8e7","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        )"},{"line_number":303,"context_line":"        parser.add_argument("},{"line_number":304,"context_line":"            \"--property\","},{"line_number":305,"context_line":"            metavar\u003d\"\u003cpath\u003dvalue\u003e\","},{"line_number":306,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":307,"context_line":"            help\u003d\u0027Property to set on this baremetal host \u0027"},{"line_number":308,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_587bfd7a","line":305,"updated":"2016-04-21 00:07:46.000000000","message":"why is this \u0027path\u0027 and the others below are \u0027key\u0027?","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        )"},{"line_number":303,"context_line":"        parser.add_argument("},{"line_number":304,"context_line":"            \"--property\","},{"line_number":305,"context_line":"            metavar\u003d\"\u003cpath\u003dvalue\u003e\","},{"line_number":306,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":307,"context_line":"            help\u003d\u0027Property to set on this baremetal host \u0027"},{"line_number":308,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_1c083428","line":305,"in_reply_to":"1a122d0e_587bfd7a","updated":"2016-04-26 17:38:34.000000000","message":"Because the property can be a path, whereas the others have an implicit path. If you want it to all be path, or all be key, just let me know. I don\u0027t have a strong preference one way or the other.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            \"--property\","},{"line_number":305,"context_line":"            metavar\u003d\"\u003cpath\u003dvalue\u003e\","},{"line_number":306,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":307,"context_line":"            help\u003d\u0027Property to set on this baremetal host \u0027"},{"line_number":308,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":309,"context_line":"        )"},{"line_number":310,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_58081d28","line":307,"updated":"2016-04-21 00:07:46.000000000","message":"for this and the others below, why are we using \u0027baremetal host\u0027 instead of \u0027node\u0027?","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            \"--property\","},{"line_number":305,"context_line":"            metavar\u003d\"\u003cpath\u003dvalue\u003e\","},{"line_number":306,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":307,"context_line":"            help\u003d\u0027Property to set on this baremetal host \u0027"},{"line_number":308,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":309,"context_line":"        )"},{"line_number":310,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_5c390cd8","line":307,"in_reply_to":"1a122d0e_58081d28","updated":"2016-04-26 17:38:34.000000000","message":"Oversight. Will s/host/node/","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            \"--driver-info\","},{"line_number":319,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":320,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":321,"context_line":"            help\u003d\u0027Driver info key to set on this baremetal host \u0027"},{"line_number":322,"context_line":"                 \u0027(repeat option to set multiple driver infos)\u0027,"},{"line_number":323,"context_line":"        )"},{"line_number":324,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_b845f143","line":321,"updated":"2016-04-21 00:07:46.000000000","message":"We should use abbreviations.\n\ns/info/information/\n\nDo we need the word \u0027key\u0027?","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            \"--driver-info\","},{"line_number":319,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":320,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":321,"context_line":"            help\u003d\u0027Driver info key to set on this baremetal host \u0027"},{"line_number":322,"context_line":"                 \u0027(repeat option to set multiple driver infos)\u0027,"},{"line_number":323,"context_line":"        )"},{"line_number":324,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_7c5e8813","line":321,"in_reply_to":"1a122d0e_b845f143","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":320,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":321,"context_line":"            help\u003d\u0027Driver info key to set on this baremetal host \u0027"},{"line_number":322,"context_line":"                 \u0027(repeat option to set multiple driver infos)\u0027,"},{"line_number":323,"context_line":"        )"},{"line_number":324,"context_line":"        parser.add_argument("},{"line_number":325,"context_line":"            \"--instance-info\","}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_1877c5a0","line":322,"updated":"2016-04-21 00:07:46.000000000","message":"s/infos/information/","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":320,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":321,"context_line":"            help\u003d\u0027Driver info key to set on this baremetal host \u0027"},{"line_number":322,"context_line":"                 \u0027(repeat option to set multiple driver infos)\u0027,"},{"line_number":323,"context_line":"        )"},{"line_number":324,"context_line":"        parser.add_argument("},{"line_number":325,"context_line":"            \"--instance-info\","}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_1ca4b406","line":322,"in_reply_to":"1a122d0e_1877c5a0","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":327,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":328,"context_line":"            help\u003d\u0027Instance info to set on this baremetal host \u0027"},{"line_number":329,"context_line":"                 \u0027(repeat option to set multiple instance infos)\u0027,"},{"line_number":330,"context_line":"        )"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_7866b9ed","line":329,"updated":"2016-04-21 00:07:46.000000000","message":"ditto about \u0027info\u0027 and \u0027infos\u0027.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":327,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":328,"context_line":"            help\u003d\u0027Instance info to set on this baremetal host \u0027"},{"line_number":329,"context_line":"                 \u0027(repeat option to set multiple instance infos)\u0027,"},{"line_number":330,"context_line":"        )"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_ff80bd4b","line":329,"in_reply_to":"1a122d0e_7866b9ed","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":328,"context_line":"            help\u003d\u0027Instance info to set on this baremetal host \u0027"},{"line_number":329,"context_line":"                 \u0027(repeat option to set multiple instance infos)\u0027,"},{"line_number":330,"context_line":"        )"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        return parser"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_b8e1712c","line":330,"updated":"2016-04-21 00:07:46.000000000","message":"the spec also has \u0027--name\u0027, \u0027--driver\u0027","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":328,"context_line":"            help\u003d\u0027Instance info to set on this baremetal host \u0027"},{"line_number":329,"context_line":"                 \u0027(repeat option to set multiple instance infos)\u0027,"},{"line_number":330,"context_line":"        )"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        return parser"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_df85015a","line":330,"in_reply_to":"1a122d0e_b8e1712c","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            help\u003d\u0027\u003cnode\u003e is an instance UUID.\u0027)"},{"line_number":397,"context_line":"        display_group \u003d parser.add_mutually_exclusive_group(required\u003dFalse)"},{"line_number":398,"context_line":"        display_group.add_argument("},{"line_number":399,"context_line":"            \u0027--long\u0027,"},{"line_number":400,"context_line":"            default\u003dFalse,"},{"line_number":401,"context_line":"            action\u003d\u0027store_true\u0027)"},{"line_number":402,"context_line":"        display_group.add_argument("}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_84c25083","line":399,"updated":"2016-04-21 00:07:46.000000000","message":"so \u0027ironic node-show\u0027 doesn\u0027t have detailed and non-detailed  versions; it just shows everything unless you specify the desired set of fields.\n\nHow did we decide for osc, that we\u0027d show (or not show) LONG_FIELDS, and what those actual fields would be? Maybe instead of using LONG_FIELDS, you should use res_fields.NODE_RESOURCE.fields for the not-long version.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            help\u003d\u0027\u003cnode\u003e is an instance UUID.\u0027)"},{"line_number":397,"context_line":"        display_group \u003d parser.add_mutually_exclusive_group(required\u003dFalse)"},{"line_number":398,"context_line":"        display_group.add_argument("},{"line_number":399,"context_line":"            \u0027--long\u0027,"},{"line_number":400,"context_line":"            default\u003dFalse,"},{"line_number":401,"context_line":"            action\u003d\u0027store_true\u0027)"},{"line_number":402,"context_line":"        display_group.add_argument("}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_ffcefdb5","line":399,"in_reply_to":"1a122d0e_84c25083","updated":"2016-04-26 17:38:34.000000000","message":"This is an OSC convention. To have a --long.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            metavar\u003d\u0027\u003cfield\u003e\u0027,"},{"line_number":407,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":408,"context_line":"            default\u003d[],"},{"line_number":409,"context_line":"            help\u003d\"One of more node fields. Only these fileds will be fetched \""},{"line_number":410,"context_line":"                 \"from the server. Can not be used when \u0027--long\u0027 is \""},{"line_number":411,"context_line":"                 \"specified.\")"},{"line_number":412,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_8411b054","line":409,"updated":"2016-04-21 00:07:46.000000000","message":"s/of/or/\n\ns/fileds/fields/","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            metavar\u003d\u0027\u003cfield\u003e\u0027,"},{"line_number":407,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":408,"context_line":"            default\u003d[],"},{"line_number":409,"context_line":"            help\u003d\"One of more node fields. Only these fileds will be fetched \""},{"line_number":410,"context_line":"                 \"from the server. Can not be used when \u0027--long\u0027 is \""},{"line_number":411,"context_line":"                 \"specified.\")"},{"line_number":412,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_8fdf5b39","line":409,"in_reply_to":"1a122d0e_8411b054","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            help\u003d\"One of more node fields. Only these fileds will be fetched \""},{"line_number":410,"context_line":"                 \"from the server. Can not be used when \u0027--long\u0027 is \""},{"line_number":411,"context_line":"                 \"specified.\")"},{"line_number":412,"context_line":"        return parser"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def take_action(self, parsed_args):"},{"line_number":415,"context_line":"        self.log.debug(\"take_action(%s)\", parsed_args)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_24d6dc27","line":412,"updated":"2016-04-21 00:07:46.000000000","message":"the spec also shows a --states argument. I think that was the equivalent to the \u0027ironic node-show-states\u0027 command.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            help\u003d\"One of more node fields. Only these fileds will be fetched \""},{"line_number":410,"context_line":"                 \"from the server. Can not be used when \u0027--long\u0027 is \""},{"line_number":411,"context_line":"                 \"specified.\")"},{"line_number":412,"context_line":"        return parser"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def take_action(self, parsed_args):"},{"line_number":415,"context_line":"        self.log.debug(\"take_action(%s)\", parsed_args)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_ef96cf4a","line":412,"in_reply_to":"1a122d0e_24d6dc27","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":459,"context_line":"            \u0027--instance-uuid\u0027,"},{"line_number":460,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":461,"context_line":"            default\u003dFalse,"},{"line_number":462,"context_line":"            help\u003d\u0027Unset instance uuid on this baremetal host\u0027"},{"line_number":463,"context_line":"        )"},{"line_number":464,"context_line":"        parser.add_argument("},{"line_number":465,"context_line":"            \u0027--property\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_04c0004f","line":462,"updated":"2016-04-21 00:07:46.000000000","message":"s/uuid/UUID/\n\nwhy \u0027baremetal host\u0027 instead of \u0027node\u0027? (same for below help strings too)","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":459,"context_line":"            \u0027--instance-uuid\u0027,"},{"line_number":460,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":461,"context_line":"            default\u003dFalse,"},{"line_number":462,"context_line":"            help\u003d\u0027Unset instance uuid on this baremetal host\u0027"},{"line_number":463,"context_line":"        )"},{"line_number":464,"context_line":"        parser.add_argument("},{"line_number":465,"context_line":"            \u0027--property\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_0f150be4","line":462,"in_reply_to":"1a122d0e_04c0004f","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        )"},{"line_number":464,"context_line":"        parser.add_argument("},{"line_number":465,"context_line":"            \u0027--property\u0027,"},{"line_number":466,"context_line":"            metavar\u003d\u0027\u003cpath\u003e\u0027,"},{"line_number":467,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":468,"context_line":"            help\u003d\u0027Property to unset on this baremetal host \u0027"},{"line_number":469,"context_line":"                 \u0027(repeat option to unset multiple properties)\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_c4be08ad","line":466,"updated":"2016-04-21 00:07:46.000000000","message":"path? \u0027key\u0027 is used below.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        )"},{"line_number":464,"context_line":"        parser.add_argument("},{"line_number":465,"context_line":"            \u0027--property\u0027,"},{"line_number":466,"context_line":"            metavar\u003d\u0027\u003cpath\u003e\u0027,"},{"line_number":467,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":468,"context_line":"            help\u003d\u0027Property to unset on this baremetal host \u0027"},{"line_number":469,"context_line":"                 \u0027(repeat option to unset multiple properties)\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_6fd47f1f","line":466,"in_reply_to":"1a122d0e_c4be08ad","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"839e49c3d1763c54b73860a86fb462eb8fabb7df","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            metavar\u003d\"\u003ckey\u003e\","},{"line_number":488,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":489,"context_line":"            help\u003d\u0027Instance info to unset on this baremetal host \u0027"},{"line_number":490,"context_line":"                 \u0027(repeat option to unset multiple instance infos)\u0027,"},{"line_number":491,"context_line":"        )"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_a4d14c25","line":490,"updated":"2016-04-21 00:07:46.000000000","message":"\u0027info\u0027 and \u0027infos\u0027 should be \u0027information\u0027.","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"e4a221fe24f82a961944a04f2a931b8c637231b6","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            metavar\u003d\"\u003ckey\u003e\","},{"line_number":488,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":489,"context_line":"            help\u003d\u0027Instance info to unset on this baremetal host \u0027"},{"line_number":490,"context_line":"                 \u0027(repeat option to unset multiple instance infos)\u0027,"},{"line_number":491,"context_line":"        )"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_af097786","line":490,"in_reply_to":"1a122d0e_a4d14c25","updated":"2016-04-26 17:38:34.000000000","message":"Done","commit_id":"edddc38b03f5e4f5ad183abe836b1fa8a5d2b204"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7ce7b054e67b25907a7236525f2194ec6020e6f0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def take_action(self, parsed_args):"},{"line_number":104,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""},{"line_number":105,"context_line":"                         \"\u0027openstack baremetal node create\u0027.\")"},{"line_number":106,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class DeleteBaremetalNode(command.Command):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_465b8486","line":106,"updated":"2016-05-04 19:55:47.000000000","message":"Should we add a unit test to make sure this is being logged?","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6ee48cf8c9588cf0342bab5d8a48202b9ac71a08","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def take_action(self, parsed_args):"},{"line_number":104,"context_line":"        self.log.warning(\"This command is deprecated. Instead, use \""},{"line_number":105,"context_line":"                         \"\u0027openstack baremetal node create\u0027.\")"},{"line_number":106,"context_line":"        return super(CreateBaremetal, self).take_action(parsed_args)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class DeleteBaremetalNode(command.Command):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_11703fa3","line":106,"in_reply_to":"1a122d0e_465b8486","updated":"2016-05-23 17:33:46.000000000","message":"Not sure I see the point of that.","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7ce7b054e67b25907a7236525f2194ec6020e6f0","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":178,"context_line":"            help\u003d\u0027Sort output by specified node fields and directions \u0027"},{"line_number":179,"context_line":"                 \u0027(asc or desc) (default: asc), multiple fields and \u0027"},{"line_number":180,"context_line":"                 \u0027directions can be specified, seperated by comma\u0027,"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_a3252ac3","line":180,"updated":"2016-05-04 19:55:47.000000000","message":"Maybe s/, multiple/. Multiple/\n\nyou can\u0027t specify multiple directions, just one direction, right?\n\ns/seperated/separated/","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"778e3432b44cbe8db56a129ffa20d5b058c84f53","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":178,"context_line":"            help\u003d\u0027Sort output by specified node fields and directions \u0027"},{"line_number":179,"context_line":"                 \u0027(asc or desc) (default: asc), multiple fields and \u0027"},{"line_number":180,"context_line":"                 \u0027directions can be specified, seperated by comma\u0027,"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_d19c495f","line":180,"in_reply_to":"1a122d0e_a3252ac3","updated":"2016-05-10 13:21:40.000000000","message":"The sort is using this: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/common/utils.py#L217\n\nI see no such restriction.","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6ee48cf8c9588cf0342bab5d8a48202b9ac71a08","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":178,"context_line":"            help\u003d\u0027Sort output by specified node fields and directions \u0027"},{"line_number":179,"context_line":"                 \u0027(asc or desc) (default: asc), multiple fields and \u0027"},{"line_number":180,"context_line":"                 \u0027directions can be specified, seperated by comma\u0027,"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_b18fb373","line":180,"in_reply_to":"dab17558_93a7290a","updated":"2016-05-23 17:33:46.000000000","message":"Yes, I suppose they could. And I agree, it\u0027s something that should be fixed in OSC.","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4bec7f69e6436f692f96aa2c07b43586a0e9eb8c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":178,"context_line":"            help\u003d\u0027Sort output by specified node fields and directions \u0027"},{"line_number":179,"context_line":"                 \u0027(asc or desc) (default: asc), multiple fields and \u0027"},{"line_number":180,"context_line":"                 \u0027directions can be specified, seperated by comma\u0027,"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_93a7290a","line":180,"in_reply_to":"dab17558_d19c495f","updated":"2016-05-11 13:46:07.000000000","message":"So someone could do \u0027--sort thiskey:asc,thiskey:desc\u0027 ? SIGH. If it is fixed, it should be done in the openstackclient code so please just fix the grammatical issues. thx.","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7ce7b054e67b25907a7236525f2194ec6020e6f0","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            default\u003dFalse,"},{"line_number":214,"context_line":"            help\u003d\"Show detailed information about the nodes.\","},{"line_number":215,"context_line":"            action\u003d\u0027store_true\u0027)"},{"line_number":216,"context_line":"        display_group.add_argument("},{"line_number":217,"context_line":"            \u0027--fields\u0027,"},{"line_number":218,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":219,"context_line":"            dest\u003d\u0027fields\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_86ff5c33","line":216,"updated":"2016-05-04 19:55:47.000000000","message":"I didn\u0027t look to see if you had unit tests for the existing arguments. If you do, we should add tests for these arguments too.","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6ee48cf8c9588cf0342bab5d8a48202b9ac71a08","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            default\u003dFalse,"},{"line_number":214,"context_line":"            help\u003d\"Show detailed information about the nodes.\","},{"line_number":215,"context_line":"            action\u003d\u0027store_true\u0027)"},{"line_number":216,"context_line":"        display_group.add_argument("},{"line_number":217,"context_line":"            \u0027--fields\u0027,"},{"line_number":218,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":219,"context_line":"            dest\u003d\u0027fields\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_918a6f62","line":216,"in_reply_to":"1a122d0e_86ff5c33","updated":"2016-05-23 17:33:46.000000000","message":"Done","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7ce7b054e67b25907a7236525f2194ec6020e6f0","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            help\u003d\u0027Instance information to set on this baremetal node \u0027"},{"line_number":339,"context_line":"                 \u0027(repeat option to set multiple instance infos)\u0027,"},{"line_number":340,"context_line":"        )"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        return parser"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_c6a31442","line":341,"updated":"2016-05-04 19:55:47.000000000","message":"ditto about unit tests (or not) for these added arguments.","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6ee48cf8c9588cf0342bab5d8a48202b9ac71a08","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            help\u003d\u0027Instance information to set on this baremetal node \u0027"},{"line_number":339,"context_line":"                 \u0027(repeat option to set multiple instance infos)\u0027,"},{"line_number":340,"context_line":"        )"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        return parser"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_d1eeb720","line":341,"in_reply_to":"1a122d0e_c6a31442","updated":"2016-05-23 17:33:46.000000000","message":"Done","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7ce7b054e67b25907a7236525f2194ec6020e6f0","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            states \u003d baremetal_client.node.states(parsed_args.node)"},{"line_number":457,"context_line":"            node[\u0027states\u0027] \u003d states.to_dict()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        return zip(*sorted(node.items()))"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"class ShowBaremetal(ShowBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_c9b20549","line":459,"updated":"2016-05-04 19:55:47.000000000","message":"remind me what --long does. With the existing CLI, a node-show returns everything about a node (ie, \u0027long\u0027 is the default).\n\nI\u0027m not sure why we want --long here. Is it meant to be consistent with node-list, that only shows a subset of the node information?\n\nOh. I see you had --long in the original one. What was the default there? Sigh. I don\u0027t think we should have --long at all. IF we have it, the default should be True, unless you are saying that OSC dictates that it should default to false? I also don\u0027t think LONG_FIELDS should be hardcoded in here but maybe that should be addressed after we decide how to deal with --long.","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"778e3432b44cbe8db56a129ffa20d5b058c84f53","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            states \u003d baremetal_client.node.states(parsed_args.node)"},{"line_number":457,"context_line":"            node[\u0027states\u0027] \u003d states.to_dict()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        return zip(*sorted(node.items()))"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"class ShowBaremetal(ShowBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_b1338513","line":459,"in_reply_to":"1a122d0e_c9b20549","updated":"2016-05-10 13:21:40.000000000","message":"If you want --long to be the default, and just show all fields by default, that\u0027s fine. There is nothing in OSC that dictates how this must be. We can get rid of --long, make that the default, and support --fields for filtering.","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4bec7f69e6436f692f96aa2c07b43586a0e9eb8c","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            states \u003d baremetal_client.node.states(parsed_args.node)"},{"line_number":457,"context_line":"            node[\u0027states\u0027] \u003d states.to_dict()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        return zip(*sorted(node.items()))"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"class ShowBaremetal(ShowBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_b3e7cdaa","line":459,"in_reply_to":"dab17558_b1338513","updated":"2016-05-11 13:46:07.000000000","message":"--long is the default here, since the request is to show (all) the node\u0027s detail. I took a quick look at some of the OSC commands [1], and none of the \u0027X show\u0027 commands have a --long option so lets get rid of it.\n\n[1] http://docs.openstack.org/developer/python-openstackclient/command-list.html","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6ee48cf8c9588cf0342bab5d8a48202b9ac71a08","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            states \u003d baremetal_client.node.states(parsed_args.node)"},{"line_number":457,"context_line":"            node[\u0027states\u0027] \u003d states.to_dict()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        return zip(*sorted(node.items()))"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"class ShowBaremetal(ShowBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_51c2c785","line":459,"in_reply_to":"dab17558_b3e7cdaa","updated":"2016-05-23 17:33:46.000000000","message":"Done","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7ce7b054e67b25907a7236525f2194ec6020e6f0","unresolved":false,"context_lines":[{"line_number":486,"context_line":"            \u0027--instance-uuid\u0027,"},{"line_number":487,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":488,"context_line":"            default\u003dFalse,"},{"line_number":489,"context_line":"            help\u003d\u0027Unset instance uuid on this baremetal node\u0027"},{"line_number":490,"context_line":"        )"},{"line_number":491,"context_line":"        parser.add_argument("},{"line_number":492,"context_line":"            \"--name\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_466f04c4","line":489,"updated":"2016-05-04 19:55:47.000000000","message":"s/uuid/UUID/","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6ee48cf8c9588cf0342bab5d8a48202b9ac71a08","unresolved":false,"context_lines":[{"line_number":486,"context_line":"            \u0027--instance-uuid\u0027,"},{"line_number":487,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":488,"context_line":"            default\u003dFalse,"},{"line_number":489,"context_line":"            help\u003d\u0027Unset instance uuid on this baremetal node\u0027"},{"line_number":490,"context_line":"        )"},{"line_number":491,"context_line":"        parser.add_argument("},{"line_number":492,"context_line":"            \"--name\","}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_91b8af12","line":489,"in_reply_to":"1a122d0e_466f04c4","updated":"2016-05-23 17:33:46.000000000","message":"Done","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7ce7b054e67b25907a7236525f2194ec6020e6f0","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        parser.add_argument("},{"line_number":497,"context_line":"            \"--driver\","},{"line_number":498,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":499,"context_line":"            help\u003d\"Unset the driver for the node\""},{"line_number":500,"context_line":"        )"},{"line_number":501,"context_line":"        parser.add_argument("},{"line_number":502,"context_line":"            \u0027--property\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_c644b448","line":499,"updated":"2016-05-04 19:55:47.000000000","message":"I don\u0027t think we can delete the driver. It can be changed, not deleted/unset. (I don\u0027t have a working env right now so can\u0027t test it, but I\u0027d be surprised if it was allowed.)","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"778e3432b44cbe8db56a129ffa20d5b058c84f53","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        parser.add_argument("},{"line_number":497,"context_line":"            \"--driver\","},{"line_number":498,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":499,"context_line":"            help\u003d\"Unset the driver for the node\""},{"line_number":500,"context_line":"        )"},{"line_number":501,"context_line":"        parser.add_argument("},{"line_number":502,"context_line":"            \u0027--property\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_d13e09d9","line":499,"in_reply_to":"1a122d0e_c644b448","updated":"2016-05-10 13:21:40.000000000","message":"Done","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7ce7b054e67b25907a7236525f2194ec6020e6f0","unresolved":false,"context_lines":[{"line_number":559,"context_line":"                              [\u0027instance_info/\u0027 + x for x"},{"line_number":560,"context_line":"                               in parsed_args.instance_info]))"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"class UnsetBaremetal(UnsetBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_6978117f","line":562,"updated":"2016-05-04 19:55:47.000000000","message":"ditto about unit tests or not, for added arguments.","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6ee48cf8c9588cf0342bab5d8a48202b9ac71a08","unresolved":false,"context_lines":[{"line_number":559,"context_line":"                              [\u0027instance_info/\u0027 + x for x"},{"line_number":560,"context_line":"                               in parsed_args.instance_info]))"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"class UnsetBaremetal(UnsetBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_3140e306","line":562,"in_reply_to":"1a122d0e_6978117f","updated":"2016-05-23 17:33:46.000000000","message":"Done","commit_id":"912acbf3d472db05391a286bb34c50a0e3669c09"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fac5f84801bb03f4e484f9e264c410b7aa4b892b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":181,"context_line":"            help\u003d\u0027Sort output by specified node fields and directions \u0027"},{"line_number":182,"context_line":"                 \u0027(asc or desc) (default: asc). Multiple fields and \u0027"},{"line_number":183,"context_line":"                 \u0027directions can be specified, separated by comma\u0027,"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":"        parser.add_argument("},{"line_number":186,"context_line":"            \u0027--maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_d041063b","line":183,"updated":"2016-05-25 16:35:55.000000000","message":"nit, s/comma/comma./","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6dbf4417eee2d0f96e024f28ffd1cb6a810e1fb7","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":206,"context_line":"            dest\u003d\u0027provision_state\u0027,"},{"line_number":207,"context_line":"            metavar\u003d\u0027\u003cprovision state\u003e\u0027,"},{"line_number":208,"context_line":"            choices\u003d[\u0027active\u0027, \u0027deleted\u0027, \u0027rebuild\u0027, \u0027inspect\u0027, \u0027provide\u0027,"},{"line_number":209,"context_line":"                     \u0027manage\u0027, \u0027clean\u0027, \u0027abort\u0027],"},{"line_number":210,"context_line":"            help\u003d\"Limit list to nodes in \u003cprovision state\u003e. One of \u0027active\u0027, \""},{"line_number":211,"context_line":"                 \"\u0027deleted\u0027, \u0027rebuild\u0027, \u0027inspect\u0027, \u0027provide\u0027, \u0027manage\u0027, \""},{"line_number":212,"context_line":"                 \"\u0027clean\u0027, \u0027abort\u0027.\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_27ddfe70","line":209,"range":{"start_line":208,"start_character":22,"end_line":209,"end_character":46},"updated":"2016-05-24 15:30:24.000000000","message":"these are verbs, not states. anyway better don\u0027t hardcode possible states at all and let API do the validation","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fac5f84801bb03f4e484f9e264c410b7aa4b892b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":206,"context_line":"            dest\u003d\u0027provision_state\u0027,"},{"line_number":207,"context_line":"            metavar\u003d\u0027\u003cprovision state\u003e\u0027,"},{"line_number":208,"context_line":"            choices\u003d[\u0027active\u0027, \u0027deleted\u0027, \u0027rebuild\u0027, \u0027inspect\u0027, \u0027provide\u0027,"},{"line_number":209,"context_line":"                     \u0027manage\u0027, \u0027clean\u0027, \u0027abort\u0027],"},{"line_number":210,"context_line":"            help\u003d\"Limit list to nodes in \u003cprovision state\u003e. One of \u0027active\u0027, \""},{"line_number":211,"context_line":"                 \"\u0027deleted\u0027, \u0027rebuild\u0027, \u0027inspect\u0027, \u0027provide\u0027, \u0027manage\u0027, \""},{"line_number":212,"context_line":"                 \"\u0027clean\u0027, \u0027abort\u0027.\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_b06d629b","line":209,"range":{"start_line":208,"start_character":22,"end_line":209,"end_character":46},"in_reply_to":"bab6814e_27ddfe70","updated":"2016-05-25 16:35:55.000000000","message":"@Dmitry. The help string below lists the possible values and as such it seems to make sense to add choices so that the client can check instead of the server. Also, \u0027ironic node-set-provision-state\u0027 does this. Having said that, I don\u0027t think that the CLI is consistent wrt what it checks and what it lets the server check.\n\nAs far as the actual/allowed values being verbs vs states, that is a separate issue :-( Oh, unless we want to clean it up with the OSC.","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cfb3a6eeb8129159d5e52de4188ab7acf6fc8337","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":206,"context_line":"            dest\u003d\u0027provision_state\u0027,"},{"line_number":207,"context_line":"            metavar\u003d\u0027\u003cprovision state\u003e\u0027,"},{"line_number":208,"context_line":"            choices\u003d[\u0027active\u0027, \u0027deleted\u0027, \u0027rebuild\u0027, \u0027inspect\u0027, \u0027provide\u0027,"},{"line_number":209,"context_line":"                     \u0027manage\u0027, \u0027clean\u0027, \u0027abort\u0027],"},{"line_number":210,"context_line":"            help\u003d\"Limit list to nodes in \u003cprovision state\u003e. One of \u0027active\u0027, \""},{"line_number":211,"context_line":"                 \"\u0027deleted\u0027, \u0027rebuild\u0027, \u0027inspect\u0027, \u0027provide\u0027, \u0027manage\u0027, \""},{"line_number":212,"context_line":"                 \"\u0027clean\u0027, \u0027abort\u0027.\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_f35531c6","line":209,"range":{"start_line":208,"start_character":22,"end_line":209,"end_character":46},"in_reply_to":"bab6814e_b06d629b","updated":"2016-05-25 16:53:54.000000000","message":"If we avoid maintaining a fixed list of states, we won\u0027t have to change it every time we introduce a new one..","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"accd6f158458d0da9ac51d50536f18583aa2f807","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":206,"context_line":"            dest\u003d\u0027provision_state\u0027,"},{"line_number":207,"context_line":"            metavar\u003d\u0027\u003cprovision state\u003e\u0027,"},{"line_number":208,"context_line":"            choices\u003d[\u0027active\u0027, \u0027deleted\u0027, \u0027rebuild\u0027, \u0027inspect\u0027, \u0027provide\u0027,"},{"line_number":209,"context_line":"                     \u0027manage\u0027, \u0027clean\u0027, \u0027abort\u0027],"},{"line_number":210,"context_line":"            help\u003d\"Limit list to nodes in \u003cprovision state\u003e. One of \u0027active\u0027, \""},{"line_number":211,"context_line":"                 \"\u0027deleted\u0027, \u0027rebuild\u0027, \u0027inspect\u0027, \u0027provide\u0027, \u0027manage\u0027, \""},{"line_number":212,"context_line":"                 \"\u0027clean\u0027, \u0027abort\u0027.\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_409c1ec0","line":209,"range":{"start_line":208,"start_character":22,"end_line":209,"end_character":46},"in_reply_to":"bab6814e_f35531c6","updated":"2016-05-25 19:11:44.000000000","message":"That\u0027s true. The only problem being that the user doesn\u0027t know what the choices are unless we list them in the help string below. And if we list them in the help string, we will have to update this file so we might as well have the choices here too.\n\nIf we don\u0027t put choices here, someone later will come along and say that the CLI has it so this should too, so let\u0027s just leave it in. Unless OSC already has some consistency wrt these sort of things already. Brad, do you know? Do they suggest to check at the client or server side?","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6dbf4417eee2d0f96e024f28ffd1cb6a810e1fb7","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if parsed_args.maintenance:"},{"line_number":249,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":250,"context_line":"        if parsed_args.chassis_uuid:"},{"line_number":251,"context_line":"            params[\u0027chassis_uuid\u0027] \u003d parsed_args.chassis_uuid"},{"line_number":252,"context_line":"        if parsed_args.provision_state:"},{"line_number":253,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"},{"line_number":254,"context_line":"        if parsed_args.long:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_e7b3f608","line":251,"range":{"start_line":251,"start_character":12,"end_line":251,"end_character":61},"updated":"2016-05-24 15:30:24.000000000","message":"there is no such parameter in node.list. in this case you should use chassis.list_nodes (or maybe add such parameter, dunno)","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"accd6f158458d0da9ac51d50536f18583aa2f807","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if parsed_args.maintenance:"},{"line_number":249,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":250,"context_line":"        if parsed_args.chassis_uuid:"},{"line_number":251,"context_line":"            params[\u0027chassis_uuid\u0027] \u003d parsed_args.chassis_uuid"},{"line_number":252,"context_line":"        if parsed_args.provision_state:"},{"line_number":253,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"},{"line_number":254,"context_line":"        if parsed_args.long:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_02bfbd60","line":251,"range":{"start_line":251,"start_character":12,"end_line":251,"end_character":61},"in_reply_to":"bab6814e_735821fb","updated":"2016-05-25 19:11:44.000000000","message":"SIGH. Ok, let\u0027s just delete this for now. We\u0027ll need to sync the CLI, OSC, and API later when we\u0027ve got all the OSC done, to make sure we aren\u0027t missing anything.","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cfb3a6eeb8129159d5e52de4188ab7acf6fc8337","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if parsed_args.maintenance:"},{"line_number":249,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":250,"context_line":"        if parsed_args.chassis_uuid:"},{"line_number":251,"context_line":"            params[\u0027chassis_uuid\u0027] \u003d parsed_args.chassis_uuid"},{"line_number":252,"context_line":"        if parsed_args.provision_state:"},{"line_number":253,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"},{"line_number":254,"context_line":"        if parsed_args.long:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_735821fb","line":251,"range":{"start_line":251,"start_character":12,"end_line":251,"end_character":61},"in_reply_to":"bab6814e_8b82b3fe","updated":"2016-05-25 16:53:54.000000000","message":"I know, but the node.list call does not.","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fac5f84801bb03f4e484f9e264c410b7aa4b892b","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if parsed_args.maintenance:"},{"line_number":249,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":250,"context_line":"        if parsed_args.chassis_uuid:"},{"line_number":251,"context_line":"            params[\u0027chassis_uuid\u0027] \u003d parsed_args.chassis_uuid"},{"line_number":252,"context_line":"        if parsed_args.provision_state:"},{"line_number":253,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"},{"line_number":254,"context_line":"        if parsed_args.long:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_8b82b3fe","line":251,"range":{"start_line":251,"start_character":12,"end_line":251,"end_character":61},"in_reply_to":"bab6814e_e7b3f608","updated":"2016-05-25 16:35:55.000000000","message":"@Dmitry. The API allows for filtering on chassis_uuid (http://docs.openstack.org/developer/ironic/webapi/v1.html#nodes).","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6dbf4417eee2d0f96e024f28ffd1cb6a810e1fb7","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"},{"line_number":254,"context_line":"        if parsed_args.long:"},{"line_number":255,"context_line":"            params[\u0027detail\u0027] \u003d parsed_args.long"},{"line_number":256,"context_line":"            columns \u003d res_fields.NODE_DETAILED_RESOURCE.fields"},{"line_number":257,"context_line":"            labels \u003d res_fields.NODE_DETAILED_RESOURCE.labels"},{"line_number":258,"context_line":"        elif parsed_args.fields:"},{"line_number":259,"context_line":"            params[\u0027detail\u0027] \u003d False"},{"line_number":260,"context_line":"            fields \u003d itertools.chain.from_iterable(parsed_args.fields)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_878caa36","line":257,"range":{"start_line":256,"start_character":0,"end_line":257,"end_character":61},"updated":"2016-05-24 15:30:24.000000000","message":"this ends up in an unreadable mess by default. not sure what to do about it, maybe nothing","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"609634b96af43bff7c002ae77f9fb857c5775bfb","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        if parsed_args.long:"},{"line_number":255,"context_line":"            params[\u0027detail\u0027] \u003d parsed_args.long"},{"line_number":256,"context_line":"            columns \u003d res_fields.NODE_DETAILED_RESOURCE.fields"},{"line_number":257,"context_line":"            labels \u003d res_fields.NODE_DETAILED_RESOURCE.labels"},{"line_number":258,"context_line":"        elif parsed_args.fields:"},{"line_number":259,"context_line":"            params[\u0027detail\u0027] \u003d False"},{"line_number":260,"context_line":"            fields \u003d itertools.chain.from_iterable(parsed_args.fields)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_73f3010b","line":257,"in_reply_to":"bab6814e_878caa36","updated":"2016-05-27 14:43:06.000000000","message":"Due to the sheer number of fields, I\u0027m not sure we can do much about that display. However, there is some utility to this param. If one used it for one of the other formats (--format json|csv|yaml), it would have great utility as a shorthand for \"all fields\"","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6dbf4417eee2d0f96e024f28ffd1cb6a810e1fb7","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            properties.extend(utils.args_array_to_patch("},{"line_number":364,"context_line":"                \u0027add\u0027, driver))"},{"line_number":365,"context_line":"        if parsed_args.property:"},{"line_number":366,"context_line":"            properties.extend(utils.args_array_to_patch("},{"line_number":367,"context_line":"                \u0027add\u0027, parsed_args.property))"},{"line_number":368,"context_line":"        if parsed_args.extra:"},{"line_number":369,"context_line":"            properties.extend(utils.args_array_to_patch("}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_c71072ab","line":366,"updated":"2016-05-24 15:30:24.000000000","message":"missing \u0027/properties/\u0027 prefix","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"609634b96af43bff7c002ae77f9fb857c5775bfb","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            properties.extend(utils.args_array_to_patch("},{"line_number":364,"context_line":"                \u0027add\u0027, driver))"},{"line_number":365,"context_line":"        if parsed_args.property:"},{"line_number":366,"context_line":"            properties.extend(utils.args_array_to_patch("},{"line_number":367,"context_line":"                \u0027add\u0027, parsed_args.property))"},{"line_number":368,"context_line":"        if parsed_args.extra:"},{"line_number":369,"context_line":"            properties.extend(utils.args_array_to_patch("}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_a0a18a96","line":366,"in_reply_to":"bab6814e_c71072ab","updated":"2016-05-27 14:43:06.000000000","message":"Done","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fac5f84801bb03f4e484f9e264c410b7aa4b892b","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            properties.extend(utils.args_array_to_patch("},{"line_number":364,"context_line":"                \u0027add\u0027, driver))"},{"line_number":365,"context_line":"        if parsed_args.property:"},{"line_number":366,"context_line":"            properties.extend(utils.args_array_to_patch("},{"line_number":367,"context_line":"                \u0027add\u0027, parsed_args.property))"},{"line_number":368,"context_line":"        if parsed_args.extra:"},{"line_number":369,"context_line":"            properties.extend(utils.args_array_to_patch("}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_6bf66ffa","line":366,"in_reply_to":"bab6814e_c71072ab","updated":"2016-05-25 16:35:55.000000000","message":"OH. Did this ever work? If not, we should open a bug for it and fix it in a separate patch.","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6dbf4417eee2d0f96e024f28ffd1cb6a810e1fb7","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":417,"context_line":"            default\u003dFalse,"},{"line_number":418,"context_line":"            help\u003d\u0027\u003cnode\u003e is an instance UUID.\u0027)"},{"line_number":419,"context_line":"        parser.add_argument("},{"line_number":420,"context_line":"            \u0027--states\u0027,"},{"line_number":421,"context_line":"            dest\u003d\u0027states\u0027,"},{"line_number":422,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":423,"context_line":"            default\u003dFalse,"},{"line_number":424,"context_line":"            help\u003d\u0027Also show the states for the node\u0027)"},{"line_number":425,"context_line":"        parser.add_argument("},{"line_number":426,"context_line":"            \u0027--fields\u0027,"},{"line_number":427,"context_line":"            nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_e7e776aa","line":424,"range":{"start_line":419,"start_character":0,"end_line":424,"end_character":53},"updated":"2016-05-24 15:30:24.000000000","message":"all the states are shown by default, so I don\u0027t see point in this flag","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"609634b96af43bff7c002ae77f9fb857c5775bfb","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            dest\u003d\u0027states\u0027,"},{"line_number":422,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":423,"context_line":"            default\u003dFalse,"},{"line_number":424,"context_line":"            help\u003d\u0027Also show the states for the node\u0027)"},{"line_number":425,"context_line":"        parser.add_argument("},{"line_number":426,"context_line":"            \u0027--fields\u0027,"},{"line_number":427,"context_line":"            nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_40b7fed7","line":424,"in_reply_to":"bab6814e_1d63a642","updated":"2016-05-27 14:43:06.000000000","message":"I\u0027m for removing it tbh.","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fac5f84801bb03f4e484f9e264c410b7aa4b892b","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":417,"context_line":"            default\u003dFalse,"},{"line_number":418,"context_line":"            help\u003d\u0027\u003cnode\u003e is an instance UUID.\u0027)"},{"line_number":419,"context_line":"        parser.add_argument("},{"line_number":420,"context_line":"            \u0027--states\u0027,"},{"line_number":421,"context_line":"            dest\u003d\u0027states\u0027,"},{"line_number":422,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":423,"context_line":"            default\u003dFalse,"},{"line_number":424,"context_line":"            help\u003d\u0027Also show the states for the node\u0027)"},{"line_number":425,"context_line":"        parser.add_argument("},{"line_number":426,"context_line":"            \u0027--fields\u0027,"},{"line_number":427,"context_line":"            nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_1d63a642","line":424,"range":{"start_line":419,"start_character":0,"end_line":424,"end_character":53},"in_reply_to":"bab6814e_e7e776aa","updated":"2016-05-25 16:35:55.000000000","message":"I\u0027m trying to remember why we have this. I think it was to mimic \u0027ironic node-show-states\u0027 which *only* shows the node\u0027s states. This information is a subset of the information from the node. So I think --states is meant to *only* show the states. I actually wonder if we need this. Now that there is --fields, someone could just specify the desired fields.\n\nShould we just get rid of --states and not have an equivalent in OSC for \u0027ironic node-show-states\u0027? (and/or punt on this and add it later if anyone asks?) Or we could just put it in.","commit_id":"7bf0cd26b40a8f92062cab8813419b86b70382ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1fc30264df13f157924b5615c9a9064e15db4937","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            params[\u0027associated\u0027] \u003d parsed_args.associated"},{"line_number":249,"context_line":"        if parsed_args.maintenance:"},{"line_number":250,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":251,"context_line":"        if parsed_args.chassis_uuid:"},{"line_number":252,"context_line":"            params[\u0027chassis_uuid\u0027] \u003d parsed_args.chassis_uuid"},{"line_number":253,"context_line":"        if parsed_args.provision_state:"},{"line_number":254,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"}],"source_content_type":"text/x-python","patch_set":15,"id":"9abb7d3a_d8a14aab","line":251,"updated":"2016-05-30 13:19:07.000000000","message":"This param needs to be removed (see Dmitry\u0027s comment in revision 14). It won\u0027t work because node.list [1] doesn\u0027t support it. Which means the CLI doesn\u0027t support it yet so best to just remove this for now.\n\n[1] https://github.com/openstack/python-ironicclient/blob/b93184e7dffc39347bcec7a39bab714fbaa9e814/ironicclient/v1/node.py#L43","commit_id":"363f09b90284c8bb71f39c68910053781d8b122f"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"301f423bdddc676f69757935aa9b6ec43ea31a79","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            params[\u0027associated\u0027] \u003d parsed_args.associated"},{"line_number":249,"context_line":"        if parsed_args.maintenance:"},{"line_number":250,"context_line":"            params[\u0027maintenance\u0027] \u003d parsed_args.maintenance"},{"line_number":251,"context_line":"        if parsed_args.chassis_uuid:"},{"line_number":252,"context_line":"            params[\u0027chassis_uuid\u0027] \u003d parsed_args.chassis_uuid"},{"line_number":253,"context_line":"        if parsed_args.provision_state:"},{"line_number":254,"context_line":"            params[\u0027provision_state\u0027] \u003d parsed_args.provision_state"}],"source_content_type":"text/x-python","patch_set":15,"id":"9abb7d3a_81eba177","line":251,"in_reply_to":"9abb7d3a_d8a14aab","updated":"2016-05-31 12:06:10.000000000","message":"Done","commit_id":"363f09b90284c8bb71f39c68910053781d8b122f"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"c8d29cf90ed9539456ea2d7c3bff69c78a2906f5","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            help\u003d\"List only nodes associated with an instance.\""},{"line_number":201,"context_line":"        )"},{"line_number":202,"context_line":"        parser.add_argument("},{"line_number":203,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":204,"context_line":"            dest\u003d\u0027provision_state\u0027,"},{"line_number":205,"context_line":"            metavar\u003d\u0027\u003cprovision state\u003e\u0027,"},{"line_number":206,"context_line":"            choices\u003dself.PROVISION_STATES,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_fb728daf","line":203,"updated":"2016-06-02 14:00:37.000000000","message":"I don\u0027t like the way this commit combines \"deprecate old subcommands\" with \"add new parameters\", but I guess you are following the approved spec. Could you make it more explicit in the commit message that you\u0027re adding functionality?","commit_id":"36b9bfb509959ed4700cf174b76dd4a692cd54c5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"751355be203da6ff29b8d5f07046fef5f6eed7a6","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            help\u003d\"List only nodes associated with an instance.\""},{"line_number":201,"context_line":"        )"},{"line_number":202,"context_line":"        parser.add_argument("},{"line_number":203,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":204,"context_line":"            dest\u003d\u0027provision_state\u0027,"},{"line_number":205,"context_line":"            metavar\u003d\u0027\u003cprovision state\u003e\u0027,"},{"line_number":206,"context_line":"            choices\u003dself.PROVISION_STATES,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_b6a93c27","line":203,"in_reply_to":"9abb7d3a_fb728daf","updated":"2016-06-02 14:19:05.000000000","message":"I had brought it up before. It seems like too much work to try to message this correctly or to prevent the deprecated command from having new functionality.","commit_id":"36b9bfb509959ed4700cf174b76dd4a692cd54c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a832de9e28829c6d8d6d818f94ec36b293eee0a8","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            help\u003d\"List only nodes associated with an instance.\""},{"line_number":201,"context_line":"        )"},{"line_number":202,"context_line":"        parser.add_argument("},{"line_number":203,"context_line":"            \u0027--provision-state\u0027,"},{"line_number":204,"context_line":"            dest\u003d\u0027provision_state\u0027,"},{"line_number":205,"context_line":"            metavar\u003d\u0027\u003cprovision state\u003e\u0027,"},{"line_number":206,"context_line":"            choices\u003dself.PROVISION_STATES,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_bba92527","line":203,"in_reply_to":"9abb7d3a_fb728daf","updated":"2016-06-02 14:03:15.000000000","message":"Well, the summary does not imply only deprecations, it talks about bringing the code inline with the spec.","commit_id":"36b9bfb509959ed4700cf174b76dd4a692cd54c5"}],"releasenotes/notes/osc-plugin-ff0d897d8441a9e1.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f21da0212fa005504e16f0b6dfdf261b956f0b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Bring the OpenstackClient plugin work to be in line"},{"line_number":4,"context_line":"    with the approved spec."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - openstack baremetal node create"},{"line_number":7,"context_line":"  - openstack baremetal node delete"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_ad3a92cb","line":4,"updated":"2016-03-07 15:44:04.000000000","message":"This is not done yet, this note should come with the last patch","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ffd91aeef5d8592e4357fb6dd6f7f49431c6ef44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Bring the OpenstackClient plugin work to be in line"},{"line_number":4,"context_line":"    with the approved spec."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - openstack baremetal node create"},{"line_number":7,"context_line":"  - openstack baremetal node delete"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_65b06344","line":4,"in_reply_to":"5aef4532_ad3a92cb","updated":"2016-03-08 16:45:40.000000000","message":"Done","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f21da0212fa005504e16f0b6dfdf261b956f0b6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Bring the OpenstackClient plugin work to be in line"},{"line_number":4,"context_line":"    with the approved spec."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - openstack baremetal node create"},{"line_number":7,"context_line":"  - openstack baremetal node delete"},{"line_number":8,"context_line":"  - openstack baremetal node list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_8d37d6e2","line":5,"updated":"2016-03-07 15:44:04.000000000","message":"this won\u0027t look very nice when interleaved with other notes (as soon as we have them). I think it should be something like\n\n - |\n   Extend the OpenStackClient plugin with the following new commands:\n\n   * ...\n   * ...\n\n(formatting from http://docs.openstack.org/developer/reno/usage.html#formatting)","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ab89ed7fa2d862ff706095f0ea9040e6b4bb4085","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Bring the OpenstackClient plugin work to be in line"},{"line_number":4,"context_line":"    with the approved spec."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - openstack baremetal node create"},{"line_number":7,"context_line":"  - openstack baremetal node delete"},{"line_number":8,"context_line":"  - openstack baremetal node list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_a56d4b9a","line":5,"in_reply_to":"5aef4532_8d37d6e2","updated":"2016-03-08 16:46:08.000000000","message":"Done","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f21da0212fa005504e16f0b6dfdf261b956f0b6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  - openstack baremetal node set"},{"line_number":10,"context_line":"  - openstack baremetal node show"},{"line_number":11,"context_line":"  - openstack baremetal node unset"},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - openstack baremetal create"},{"line_number":14,"context_line":"  - openstack baremetal delete"},{"line_number":15,"context_line":"  - openstack baremetal list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_ed349adf","line":12,"updated":"2016-03-07 15:44:04.000000000","message":"ditto","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ab89ed7fa2d862ff706095f0ea9040e6b4bb4085","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  - openstack baremetal node set"},{"line_number":10,"context_line":"  - openstack baremetal node show"},{"line_number":11,"context_line":"  - openstack baremetal node unset"},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - openstack baremetal create"},{"line_number":14,"context_line":"  - openstack baremetal delete"},{"line_number":15,"context_line":"  - openstack baremetal list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_e50593c2","line":12,"in_reply_to":"5aef4532_ed349adf","updated":"2016-03-08 16:46:08.000000000","message":"Done","commit_id":"3d900a49eabdd57cf91f405e8f315d95beb25d9c"}]}