)]}'
{"ironicclient/v1/node_shell.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"6eeefe6a82e4fcae20e1624f8e58fa8213b333bf","unresolved":false,"context_lines":[{"line_number":259,"context_line":"              nargs\u003d\u0027+\u0027,"},{"line_number":260,"context_line":"              help\u003d\"Name or UUID of the node.\")"},{"line_number":261,"context_line":"def do_node_delete(cc, args):"},{"line_number":262,"context_line":"    \"\"\"Unregister node(s) from the Ironic service.\"\"\""},{"line_number":263,"context_line":"    failures \u003d []"},{"line_number":264,"context_line":"    for n in args.node:"},{"line_number":265,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_a32d0700","line":262,"range":{"start_line":262,"start_character":4,"end_line":262,"end_character":53},"updated":"2016-03-03 07:49:38.000000000","message":"docstring :raises: is missing.","commit_id":"cad695c5cf833e27f79668e3cfbea6e7a64f547d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1aca027e410c83bc75e28608a2ad76df44d25649","unresolved":false,"context_lines":[{"line_number":261,"context_line":"def do_node_delete(cc, args):"},{"line_number":262,"context_line":"    \"\"\"Unregister node(s) from the Ironic service."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    :raises: ClientException, if error happens during the delete"},{"line_number":265,"context_line":"    \"\"\""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    failures \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_2ea401b8","line":264,"range":{"start_line":264,"start_character":4,"end_line":264,"end_character":64},"updated":"2016-03-04 00:43:29.000000000","message":"Thanks for the consideration.\nNaohiro","commit_id":"6a59a3096195fd7194fe8fe7a0baa06565054c23"}],"releasenotes/notes/not-ignore-delete-failtures-0783d33a606ed6f1.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6698152bdb29a91bb8d8815e333692c00baa66bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Deleting nodes ignore failures and just prints the results which nodes are"},{"line_number":4,"context_line":"    deleted and which are failed, as result node-delete always return 0 code."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7af24918_49a7394f","line":4,"updated":"2016-03-02 15:52:58.000000000","message":"This makes it sound to me as if this will *now* always return 0, rather than that is what it fixes. Can we reword this to:\n\nFixes an issue where deleting nodes ignore failures and just prints the results which nodes are deleted and which are failed, always returning exit code of 0. This now will return a non-zero exit code if at least one node-delete fails.","commit_id":"ebd530e7b205d7bb8f51b45996d3ad014ab5f8a0"}]}