)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"27ebd4866d25d234cbd3e7a1ca17aaa06c54fa49","unresolved":false,"context_lines":[{"line_number":10,"context_line":"node-list, port-list, driver-list, chassis-list,"},{"line_number":11,"context_line":"node-show, port-show, driver-show, chassis-show,"},{"line_number":12,"context_line":"test_node_validate, test_node_show_states, test_driver_properties."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I1a1447d81c28af21b054e9cd4c35f94b39ac0244"},{"line_number":15,"context_line":"Change-Id: Id1ebff7cedb6e5b9f657d869d71f49de270a5ef3"},{"line_number":16,"context_line":"Closes-Bug: #1555680"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa0719c6_5920e69b","line":13,"updated":"2016-03-21 12:58:40.000000000","message":"what about create and update cmds?","commit_id":"985eb38db0b60f16717aad25869dabd66a2e86f7"}],"ironicclient/tests/functional/base.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"db5eb4aa4dfebde057f543bac571133ed54b0626","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        output \u003d self._ironic(action\u003daction, flags\u003dflags, params\u003dparams)"},{"line_number":157,"context_line":"        return self.parser.listing(output)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def ironic_json(self, action, flags\u003d\u0027--json\u0027, params\u003d\u0027\u0027):"},{"line_number":160,"context_line":"        \"\"\"Execute ironic command for the given action with --json flag.\"\"\""},{"line_number":161,"context_line":"        output \u003d self._ironic(action\u003daction, flags\u003dflags, params\u003dparams)"},{"line_number":162,"context_line":"        return output"}],"source_content_type":"text/x-python","patch_set":21,"id":"3aaa91ec_45f6a55d","line":159,"range":{"start_line":159,"start_character":35,"end_line":159,"end_character":50},"updated":"2016-06-30 16:45:09.000000000","message":"would be better make empty by default \u0027\u0027 and\nflags +\u003d \u0027--json\u0027\nThis will allow add more flags in tests if needed","commit_id":"591e7628b318dff310d6405f61c8ed27f233168d"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"887b4b2a11d475b962e9431933603e904c51f48d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        output \u003d self._ironic(action\u003daction, flags\u003dflags, params\u003dparams)"},{"line_number":157,"context_line":"        return self.parser.listing(output)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def ironic_json(self, action, flags\u003d\u0027--json\u0027, params\u003d\u0027\u0027):"},{"line_number":160,"context_line":"        \"\"\"Execute ironic command for the given action with --json flag.\"\"\""},{"line_number":161,"context_line":"        output \u003d self._ironic(action\u003daction, flags\u003dflags, params\u003dparams)"},{"line_number":162,"context_line":"        return output"}],"source_content_type":"text/x-python","patch_set":21,"id":"3aaa91ec_3b3f03b7","line":159,"range":{"start_line":159,"start_character":35,"end_line":159,"end_character":50},"in_reply_to":"3aaa91ec_45f6a55d","updated":"2016-07-01 14:51:48.000000000","message":"Reworked in another way, please look.","commit_id":"591e7628b318dff310d6405f61c8ed27f233168d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"91f2cc19373d1d81031d26ea7d890fd7662dcfce","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            return self.client.cmd_with_auth(\u0027ironic\u0027,"},{"line_number":144,"context_line":"                                             action, flags, params)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def ironic(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, parse\u003dTrue):"},{"line_number":147,"context_line":"        \"\"\"Return parsed list of dicts with basic item info."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param action: the cli command to run using Ironic"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_eea7574d","line":146,"updated":"2016-07-18 14:43:25.000000000","message":"I\u0027m fine with \"parse\" tbh, boolean values are a bit more straightforward","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"21ea649dda37ffb377ae971439c254b62c0f6071","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            return self.client.cmd_with_auth(\u0027ironic\u0027,"},{"line_number":144,"context_line":"                                             action, flags, params)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def ironic(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, parse\u003dTrue):"},{"line_number":147,"context_line":"        \"\"\"Return parsed list of dicts with basic item info."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param action: the cli command to run using Ironic"}],"source_content_type":"text/x-python","patch_set":23,"id":"1aa78d24_78b971e9","line":146,"range":{"start_line":146,"start_character":50,"end_line":146,"end_character":61},"updated":"2016-07-04 08:27:57.000000000","message":"nit: I\u0027d prefer something like output_format \u003d [raw ,json] or something like this, not critical though","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"21ea649dda37ffb377ae971439c254b62c0f6071","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        :type parse: bool"},{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        output \u003d self._ironic(action\u003daction, flags\u003dflags, params\u003dparams)"},{"line_number":159,"context_line":"        if not parse:"},{"line_number":160,"context_line":"            return output"},{"line_number":161,"context_line":"        return self.parser.listing(output)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_table_headers(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027):"},{"line_number":164,"context_line":"        output \u003d self._ironic(action\u003daction, flags\u003dflags, params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1aa78d24_18c5cd3b","line":161,"range":{"start_line":159,"start_character":0,"end_line":161,"end_character":42},"updated":"2016-07-04 08:27:57.000000000","message":"nit: return self.parser.listing(output) if parse else output","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"14d898319c55791cb808871b79e025749a1b9321","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        :type parse: bool"},{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        output \u003d self._ironic(action\u003daction, flags\u003dflags, params\u003dparams)"},{"line_number":159,"context_line":"        if not parse:"},{"line_number":160,"context_line":"            return output"},{"line_number":161,"context_line":"        return self.parser.listing(output)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_table_headers(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027):"},{"line_number":164,"context_line":"        output \u003d self._ironic(action\u003daction, flags\u003dflags, params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_a7af8b7b","line":161,"range":{"start_line":159,"start_character":0,"end_line":161,"end_character":42},"in_reply_to":"1aa78d24_18c5cd3b","updated":"2016-07-21 14:52:56.000000000","message":"Done","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"4945692ab5e48c9f9e9e54fd1880399d57eff28f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            return self.client.cmd_with_auth(\u0027ironic\u0027,"},{"line_number":144,"context_line":"                                             action, flags, params)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def ironic(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, parse\u003dTrue):"},{"line_number":147,"context_line":"        \"\"\"Return parsed list of dicts with basic item info."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param action: the cli command to run using Ironic"}],"source_content_type":"text/x-python","patch_set":25,"id":"dada55a8_19c68016","line":146,"range":{"start_line":146,"start_character":56,"end_line":146,"end_character":60},"updated":"2016-07-22 16:04:20.000000000","message":"I think the default should be false to maintain current behavior.","commit_id":"6083eec58d0c3c11e357883597b99d11d9460a63"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ca30a5332671670791fb27ab3b374a7842b2e7dd","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            return self.client.cmd_with_auth(\u0027ironic\u0027,"},{"line_number":144,"context_line":"                                             action, flags, params)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def ironic(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, parse\u003dTrue):"},{"line_number":147,"context_line":"        \"\"\"Return parsed list of dicts with basic item info."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param action: the cli command to run using Ironic"}],"source_content_type":"text/x-python","patch_set":25,"id":"dada55a8_473d3d8e","line":146,"range":{"start_line":146,"start_character":56,"end_line":146,"end_character":60},"in_reply_to":"dada55a8_19c68016","updated":"2016-07-26 09:58:18.000000000","message":"Chris, currently in master this method returns parsed output self.parser.listing(output), so we need to keep parse\u003dTrue by default, otherwise we will break numerous existing tests.\nOnly for my JSON-related tests we will need unparsed raw output for further converting into JSON.","commit_id":"6083eec58d0c3c11e357883597b99d11d9460a63"}],"ironicclient/tests/functional/test_json_response.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"27ebd4866d25d234cbd3e7a1ca17aaa06c54fa49","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        super(TestJsonResponse, self).setUp()"},{"line_number":28,"context_line":"        self.node \u003d self.create_node()"},{"line_number":29,"context_line":"        self.chassis \u003d self.create_chassis()"},{"line_number":30,"context_line":"        # create_port() is in patch 240944 which is not merged"},{"line_number":31,"context_line":"        self.port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def is_json(self, json_response):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_9996fe92","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":62},"updated":"2016-03-21 12:58:40.000000000","message":"please, remove this comment","commit_id":"985eb38db0b60f16717aad25869dabd66a2e86f7"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"27ebd4866d25d234cbd3e7a1ca17aaa06c54fa49","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.node \u003d self.create_node()"},{"line_number":29,"context_line":"        self.chassis \u003d self.create_chassis()"},{"line_number":30,"context_line":"        # create_port() is in patch 240944 which is not merged"},{"line_number":31,"context_line":"        self.port \u003d self.create_port(self.node[\u0027uuid\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def is_json(self, json_response):"},{"line_number":34,"context_line":"        \"\"\"Verify JSON is valid.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_994b9e2b","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":17},"updated":"2016-03-21 12:58:40.000000000","message":"No need to create all resources(node, port, ...) for all test cases, you could split tests in separated classes","commit_id":"985eb38db0b60f16717aad25869dabd66a2e86f7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"303a297cbcac434109590e82fc717dd7d739bdad","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import ironicclient.tests.functional.utils as utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestJsonResponse(base.FunctionalTestBase):"},{"line_number":22,"context_line":"    \"\"\"Test JSON responses"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Flag \"--json\" for ironic client commands is introduced in"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_6d8cd935","line":21,"updated":"2016-05-19 16:54:07.000000000","message":"Not sure why you need a class for it. I\u0027d prefer an ordinary function.","commit_id":"7d4b01111a4e67857c5f4adf3f86f026597fd4f7"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"184aa1b2216aa6a4cbc70d7bfd9d2987d389e4a0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import ironicclient.tests.functional.utils as utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestJsonResponse(base.FunctionalTestBase):"},{"line_number":22,"context_line":"    \"\"\"Test JSON responses"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Flag \"--json\" for ironic client commands is introduced in"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_b90f1f87","line":21,"in_reply_to":"bab6814e_6d8cd935","updated":"2016-05-25 12:43:17.000000000","message":"Done","commit_id":"7d4b01111a4e67857c5f4adf3f86f026597fd4f7"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"231bb7d257f7a8b0f8f0728274d135007acb2c36","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def is_json(json_response):"},{"line_number":24,"context_line":"        \"\"\"Verify JSON is valid.\"\"\""},{"line_number":25,"context_line":"        try:"},{"line_number":26,"context_line":"            json.loads(json_response)"},{"line_number":27,"context_line":"        except ValueError:"},{"line_number":28,"context_line":"            return False"},{"line_number":29,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_aff503cc","line":26,"range":{"start_line":26,"start_character":17,"end_line":26,"end_character":22},"updated":"2016-05-31 05:40:33.000000000","message":"loads() makes sure just deserializable.\n\nIdeally it would be better to use jsonschema.validate() such as:\n\nhttps://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L570","commit_id":"3dfe2f29a0b56e599261fac50aa84d20fe7779ca"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"0ebf75f6f5880cf3c70d62e6babe3c9db9cce792","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def is_json(json_response):"},{"line_number":24,"context_line":"        \"\"\"Verify JSON is valid.\"\"\""},{"line_number":25,"context_line":"        try:"},{"line_number":26,"context_line":"            json.loads(json_response)"},{"line_number":27,"context_line":"        except ValueError:"},{"line_number":28,"context_line":"            return False"},{"line_number":29,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_d18840c9","line":26,"range":{"start_line":26,"start_character":17,"end_line":26,"end_character":22},"in_reply_to":"9abb7d3a_aff503cc","updated":"2016-06-02 16:50:21.000000000","message":"Naohiro, thank you for good advice. I tried to do this for one test-case yet. Please look, does it looks like what you meant?","commit_id":"3dfe2f29a0b56e599261fac50aa84d20fe7779ca"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"2e73f30b164f7cb00cad0ced072052227d8b90ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def is_json(json_response):"},{"line_number":24,"context_line":"        \"\"\"Verify JSON is valid.\"\"\""},{"line_number":25,"context_line":"        try:"},{"line_number":26,"context_line":"            json.loads(json_response)"},{"line_number":27,"context_line":"        except ValueError:"},{"line_number":28,"context_line":"            return False"},{"line_number":29,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_f291f053","line":26,"range":{"start_line":26,"start_character":17,"end_line":26,"end_character":22},"in_reply_to":"9abb7d3a_d18840c9","updated":"2016-06-03 00:15:23.000000000","message":"Yes, exactly! Thanks for the consideration, Kyrylo :-)","commit_id":"3dfe2f29a0b56e599261fac50aa84d20fe7779ca"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"231bb7d257f7a8b0f8f0728274d135007acb2c36","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                params\u003d\u0027{0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":48,"context_line":"        self.assertTrue(is_json(response))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @testtools.skip(\"LP1558688\")"},{"line_number":51,"context_line":"    def test_node_validate(self):"},{"line_number":52,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":53,"context_line":"        response \u003d self._ironic(\u0027node-validate\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_afc0637d","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":32},"updated":"2016-05-31 05:40:33.000000000","message":"It seems better to use skipTest(reason).\n\nhttp://testtools.readthedocs.io/en/latest/api.html\nskip(reason)\n\n    DEPRECATED: Use skipTest instead.","commit_id":"3dfe2f29a0b56e599261fac50aa84d20fe7779ca"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"af74f901c3b746912e0a0b6ad7dc2321d043db32","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                params\u003d\u0027{0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":48,"context_line":"        self.assertTrue(is_json(response))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @testtools.skip(\"LP1558688\")"},{"line_number":51,"context_line":"    def test_node_validate(self):"},{"line_number":52,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":53,"context_line":"        response \u003d self._ironic(\u0027node-validate\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_6d77c702","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":32},"in_reply_to":"9abb7d3a_afc0637d","updated":"2016-06-03 12:20:58.000000000","message":"Done","commit_id":"3dfe2f29a0b56e599261fac50aa84d20fe7779ca"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"231bb7d257f7a8b0f8f0728274d135007acb2c36","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                .format(self.node[\u0027uuid\u0027], node_name))"},{"line_number":75,"context_line":"        self.assertTrue(is_json(response))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @testtools.skip(\u0027LP1585609\u0027)"},{"line_number":78,"context_line":"    def test_node_delete_json(self):"},{"line_number":79,"context_line":"        \"\"\"Test JSON response for node delete.\"\"\""},{"line_number":80,"context_line":"        response \u003d self._ironic(\u0027node-delete\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_0fc08f7a","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":32},"updated":"2016-05-31 05:40:33.000000000","message":"It seems better to use skipTest(reason).\n\nhttp://testtools.readthedocs.io/en/latest/api.html\nskip(reason)\n\n    DEPRECATED: Use skipTest instead.","commit_id":"3dfe2f29a0b56e599261fac50aa84d20fe7779ca"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"af74f901c3b746912e0a0b6ad7dc2321d043db32","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                .format(self.node[\u0027uuid\u0027], node_name))"},{"line_number":75,"context_line":"        self.assertTrue(is_json(response))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @testtools.skip(\u0027LP1585609\u0027)"},{"line_number":78,"context_line":"    def test_node_delete_json(self):"},{"line_number":79,"context_line":"        \"\"\"Test JSON response for node delete.\"\"\""},{"line_number":80,"context_line":"        response \u003d self._ironic(\u0027node-delete\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_4d72c312","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":32},"in_reply_to":"9abb7d3a_0fc08f7a","updated":"2016-06-03 12:20:58.000000000","message":"Done","commit_id":"3dfe2f29a0b56e599261fac50aa84d20fe7779ca"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"231bb7d257f7a8b0f8f0728274d135007acb2c36","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                        \u0027add\u0027, \u0027description\u003dtest-chassis\u0027))"},{"line_number":114,"context_line":"        self.assertTrue(is_json(response))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @testtools.skip(\u0027LP1585609\u0027)"},{"line_number":117,"context_line":"    def test_chassis_delete_json(self):"},{"line_number":118,"context_line":"        \"\"\"Test JSON response for chassis delete.\"\"\""},{"line_number":119,"context_line":"        response \u003d self._ironic(\u0027chassis-delete\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_4f38d7a0","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":32},"updated":"2016-05-31 05:40:33.000000000","message":"It seems better to use skipTest(reason).\n\nhttp://testtools.readthedocs.io/en/latest/api.html\nskip(reason)\n\n    DEPRECATED: Use skipTest instead.","commit_id":"3dfe2f29a0b56e599261fac50aa84d20fe7779ca"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"af74f901c3b746912e0a0b6ad7dc2321d043db32","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                        \u0027add\u0027, \u0027description\u003dtest-chassis\u0027))"},{"line_number":114,"context_line":"        self.assertTrue(is_json(response))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @testtools.skip(\u0027LP1585609\u0027)"},{"line_number":117,"context_line":"    def test_chassis_delete_json(self):"},{"line_number":118,"context_line":"        \"\"\"Test JSON response for chassis delete.\"\"\""},{"line_number":119,"context_line":"        response \u003d self._ironic(\u0027chassis-delete\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_8d62eb3b","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":32},"in_reply_to":"9abb7d3a_4f38d7a0","updated":"2016-06-03 12:20:58.000000000","message":"Done","commit_id":"3dfe2f29a0b56e599261fac50aa84d20fe7779ca"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ed5a689fac64d1932ae8847d0b6afe9e87ec39bc","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    def test_node_update_json(self):"},{"line_number":152,"context_line":"        schema \u003d self.node_schema"},{"line_number":153,"context_line":"        \"\"\"Test JSON response for node update.\"\"\""},{"line_number":154,"context_line":"        node_name \u003d data_utils.generate_name(\u0027test\u0027)"},{"line_number":155,"context_line":"        response \u003d self._ironic(\u0027node-update\u0027, flags\u003d\u0027--json\u0027,"},{"line_number":156,"context_line":"                                params\u003d\u0027{0} add name\u003d{1}\u0027"},{"line_number":157,"context_line":"                                .format(self.node[\u0027uuid\u0027], node_name))"}],"source_content_type":"text/x-python","patch_set":13,"id":"7aa08908_320541c2","line":154,"updated":"2016-06-06 11:15:26.000000000","message":"It is called rand_name there.","commit_id":"04c7981f2a7deecafd6f2db51bd4fe20d1d8e727"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"f4f6cec7951dd57b91f846ec2a20413b00cebc86","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                params\u003d\u0027{0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":104,"context_line":"        self.assertTrue(is_json(response, schema))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_node_validate(self):"},{"line_number":107,"context_line":"        self.skipTest(\u0027Skip because of LaunchPad bug #1558688\u0027)"},{"line_number":108,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":109,"context_line":"        # TODO(kromanenko): check for schema after bug will be fixed"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_4cc01b7d","line":106,"updated":"2016-06-06 16:56:10.000000000","message":"Shouldn\u0027t this method be called test_node_validate_json, to be consistent with other *_json methods?","commit_id":"f30ca05ac52f2d78b010e01831044c8b07ac654c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"4077bd8ab877456feeef2c14d2d11b7e43a384d2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                params\u003d\u0027{0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":104,"context_line":"        self.assertTrue(is_json(response, schema))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_node_validate(self):"},{"line_number":107,"context_line":"        self.skipTest(\u0027Skip because of LaunchPad bug #1558688\u0027)"},{"line_number":108,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":109,"context_line":"        # TODO(kromanenko): check for schema after bug will be fixed"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_5664fd47","line":106,"in_reply_to":"7aa08908_4cc01b7d","updated":"2016-06-07 11:25:39.000000000","message":"Done","commit_id":"f30ca05ac52f2d78b010e01831044c8b07ac654c"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"f4f6cec7951dd57b91f846ec2a20413b00cebc86","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                params\u003d\u0027{0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":113,"context_line":"        self.assertTrue(is_json(response, schema))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_node_show_states(self):"},{"line_number":116,"context_line":"        \"\"\"Test JSON response for node show states.\"\"\""},{"line_number":117,"context_line":"        schema \u003d {"},{"line_number":118,"context_line":"            \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_cc3a4b98","line":115,"updated":"2016-06-06 16:56:10.000000000","message":"ditto","commit_id":"f30ca05ac52f2d78b010e01831044c8b07ac654c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"4077bd8ab877456feeef2c14d2d11b7e43a384d2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                params\u003d\u0027{0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":113,"context_line":"        self.assertTrue(is_json(response, schema))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_node_show_states(self):"},{"line_number":116,"context_line":"        \"\"\"Test JSON response for node show states.\"\"\""},{"line_number":117,"context_line":"        schema \u003d {"},{"line_number":118,"context_line":"            \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_d650ed60","line":115,"in_reply_to":"7aa08908_cc3a4b98","updated":"2016-06-07 11:25:39.000000000","message":"Done","commit_id":"f30ca05ac52f2d78b010e01831044c8b07ac654c"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"f4f6cec7951dd57b91f846ec2a20413b00cebc86","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                                    params\u003d\u0027{0}\u0027.format(driver))"},{"line_number":270,"context_line":"            self.assertTrue(is_json(response, schema))"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_driver_properties(self):"},{"line_number":273,"context_line":"        \"\"\"Test JSON response for driver properties.\"\"\""},{"line_number":274,"context_line":"        schema \u003d {"},{"line_number":275,"context_line":"            \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_6c4cf742","line":272,"updated":"2016-06-06 16:56:10.000000000","message":"ditto","commit_id":"f30ca05ac52f2d78b010e01831044c8b07ac654c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"4077bd8ab877456feeef2c14d2d11b7e43a384d2","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                                    params\u003d\u0027{0}\u0027.format(driver))"},{"line_number":270,"context_line":"            self.assertTrue(is_json(response, schema))"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_driver_properties(self):"},{"line_number":273,"context_line":"        \"\"\"Test JSON response for driver properties.\"\"\""},{"line_number":274,"context_line":"        schema \u003d {"},{"line_number":275,"context_line":"            \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_164b95b1","line":272,"in_reply_to":"7aa08908_6c4cf742","updated":"2016-06-07 11:25:39.000000000","message":"Done","commit_id":"f30ca05ac52f2d78b010e01831044c8b07ac654c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5dc9c600e34d9859ce5518de84c206920c5eafe3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ironicclient.tests.functional import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def is_json(json_response, schema):"},{"line_number":24,"context_line":"        \"\"\"Verify JSON is valid."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        :param json_response: JSON response from CLI"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_4c021f0d","line":23,"updated":"2016-06-27 12:10:26.000000000","message":"probably should be called is_valid_json as you also validate schema","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"5a303fa9344f25175e295e5944db3c61e6897c11","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ironicclient.tests.functional import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def is_json(json_response, schema):"},{"line_number":24,"context_line":"        \"\"\"Verify JSON is valid."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        :param json_response: JSON response from CLI"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_9af4bccf","line":23,"in_reply_to":"3aaa91ec_4c021f0d","updated":"2016-06-29 11:14:57.000000000","message":"Done","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5dc9c600e34d9859ce5518de84c206920c5eafe3","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def is_json(json_response, schema):"},{"line_number":24,"context_line":"        \"\"\"Verify JSON is valid."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        :param json_response: JSON response from CLI"},{"line_number":27,"context_line":"        :type json_response: string"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_affd750a","line":24,"updated":"2016-06-27 12:10:26.000000000","message":"excessive indentation","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"5a303fa9344f25175e295e5944db3c61e6897c11","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def is_json(json_response, schema):"},{"line_number":24,"context_line":"        \"\"\"Verify JSON is valid."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        :param json_response: JSON response from CLI"},{"line_number":27,"context_line":"        :type json_response: string"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_3a8f8824","line":24,"in_reply_to":"3aaa91ec_affd750a","updated":"2016-06-29 11:14:57.000000000","message":"Done","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5dc9c600e34d9859ce5518de84c206920c5eafe3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            json_response \u003d json.loads(json_response)"},{"line_number":33,"context_line":"            jsonschema.validate(json_response, schema)"},{"line_number":34,"context_line":"        except ValueError:"},{"line_number":35,"context_line":"            return False"},{"line_number":36,"context_line":"        return True"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_8f023908","line":34,"updated":"2016-06-27 12:10:26.000000000","message":"jsonschema raises its own ValidationError","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"5a303fa9344f25175e295e5944db3c61e6897c11","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            json_response \u003d json.loads(json_response)"},{"line_number":33,"context_line":"            jsonschema.validate(json_response, schema)"},{"line_number":34,"context_line":"        except ValueError:"},{"line_number":35,"context_line":"            return False"},{"line_number":36,"context_line":"        return True"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_b513895b","line":34,"in_reply_to":"3aaa91ec_8f023908","updated":"2016-06-29 11:14:57.000000000","message":"Done","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5dc9c600e34d9859ce5518de84c206920c5eafe3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \"created_at\": {\"type\": \"string\"},"},{"line_number":69,"context_line":"            \"driver_internal_info\": {\"type\": \"object\"},"},{"line_number":70,"context_line":"            \"chassis_uuid\": {\"type\": \"string\"},"},{"line_number":71,"context_line":"            \"instance_info\": {\"type\": \"object\"}"},{"line_number":72,"context_line":"            }"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_ef077d16","line":71,"updated":"2016-06-27 12:10:26.000000000","message":"just to clarify: I hope this test won\u0027t break every time we add new fields, will it?","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"5a303fa9344f25175e295e5944db3c61e6897c11","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \"created_at\": {\"type\": \"string\"},"},{"line_number":69,"context_line":"            \"driver_internal_info\": {\"type\": \"object\"},"},{"line_number":70,"context_line":"            \"chassis_uuid\": {\"type\": \"string\"},"},{"line_number":71,"context_line":"            \"instance_info\": {\"type\": \"object\"}"},{"line_number":72,"context_line":"            }"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_75d121cd","line":71,"in_reply_to":"3aaa91ec_ef077d16","updated":"2016-06-29 11:14:57.000000000","message":"It fails if some field missed. And it allows to pass when there are more fields returned than schema contains.","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"19b93a5b2a7b27d65e1026f4959272814962c90a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \"properties\": {"},{"line_number":84,"context_line":"                \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":85,"context_line":"                \"maintenance\": {\"type\": \"boolean\"},"},{"line_number":86,"context_line":"                \"links\": {"},{"line_number":87,"context_line":"                    \"type\": \"array\","},{"line_number":88,"context_line":"                    \"properties\": {"},{"line_number":89,"context_line":"                        \"href\": {\"type\": \"string\"},"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_ff1a407b","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":22},"updated":"2016-06-28 14:50:31.000000000","message":"The fix for bug #1558688 changes the schema (it returns the same fields as without the --json option), so \"links\" should be removed.","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"5a303fa9344f25175e295e5944db3c61e6897c11","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \"properties\": {"},{"line_number":84,"context_line":"                \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":85,"context_line":"                \"maintenance\": {\"type\": \"boolean\"},"},{"line_number":86,"context_line":"                \"links\": {"},{"line_number":87,"context_line":"                    \"type\": \"array\","},{"line_number":88,"context_line":"                    \"properties\": {"},{"line_number":89,"context_line":"                        \"href\": {\"type\": \"string\"},"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_959e4d52","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":22},"in_reply_to":"3aaa91ec_ff1a407b","updated":"2016-06-29 11:14:57.000000000","message":"Done","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"19b93a5b2a7b27d65e1026f4959272814962c90a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        self.assertTrue(is_json(response, schema))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_node_validate_json(self):"},{"line_number":107,"context_line":"        self.skipTest(\u0027Skip because of LaunchPad bug #1558688\u0027)"},{"line_number":108,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":109,"context_line":"        # TODO(kromanenko): check for schema after bug will be fixed"},{"line_number":110,"context_line":"        schema \u003d {\"type\": \"object\"}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_3f8688db","line":107,"updated":"2016-06-28 14:50:31.000000000","message":"A fix has been released, so you should be able to remove this skip.","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"5a303fa9344f25175e295e5944db3c61e6897c11","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        self.assertTrue(is_json(response, schema))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_node_validate_json(self):"},{"line_number":107,"context_line":"        self.skipTest(\u0027Skip because of LaunchPad bug #1558688\u0027)"},{"line_number":108,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":109,"context_line":"        # TODO(kromanenko): check for schema after bug will be fixed"},{"line_number":110,"context_line":"        schema \u003d {\"type\": \"object\"}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_9563eddc","line":107,"in_reply_to":"3aaa91ec_3f8688db","updated":"2016-06-29 11:14:57.000000000","message":"Done","commit_id":"9b61e8839ca4b249166abffadf0a91e9c70d3d3b"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"1e28e173ece3fe4b2c4c99421af60839adca2c4a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import json"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import jsonschema"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironicclient.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_1c752c97","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":17},"updated":"2016-06-30 11:03:22.000000000","message":"I don\u0027t see jsonschema in requirements, better to have explicit requirements list.","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"79117b971abe869df103a2c82863b2be8af157c6","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import json"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import jsonschema"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironicclient.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_e5f19102","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":17},"in_reply_to":"3aaa91ec_1c752c97","updated":"2016-06-30 16:36:20.000000000","message":"Done","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"1e28e173ece3fe4b2c4c99421af60839adca2c4a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                \"provision_state\": {\"type\": \"string\"},"},{"line_number":89,"context_line":"                \"uuid\": {\"type\": \"string\"}}"},{"line_number":90,"context_line":"        }"},{"line_number":91,"context_line":"        response \u003d self._ironic(\u0027node-list\u0027, flags\u003d\u0027--json\u0027, params\u003d\u0027\u0027)"},{"line_number":92,"context_line":"        self.assertTrue(is_valid_json(response, schema))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_node_show_json(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_fb902def","line":91,"range":{"start_line":91,"start_character":24,"end_line":91,"end_character":31},"updated":"2016-06-30 11:03:22.000000000","message":"please, drop underscore, or create new method with default json flag","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"79117b971abe869df103a2c82863b2be8af157c6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                \"provision_state\": {\"type\": \"string\"},"},{"line_number":89,"context_line":"                \"uuid\": {\"type\": \"string\"}}"},{"line_number":90,"context_line":"        }"},{"line_number":91,"context_line":"        response \u003d self._ironic(\u0027node-list\u0027, flags\u003d\u0027--json\u0027, params\u003d\u0027\u0027)"},{"line_number":92,"context_line":"        self.assertTrue(is_valid_json(response, schema))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_node_show_json(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_a5eb0912","line":91,"range":{"start_line":91,"start_character":24,"end_line":91,"end_character":31},"in_reply_to":"3aaa91ec_fb902def","updated":"2016-06-30 16:36:20.000000000","message":"Done","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"1e28e173ece3fe4b2c4c99421af60839adca2c4a","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_node_show_json(self):"},{"line_number":95,"context_line":"        \"\"\"Test JSON response for node show.\"\"\""},{"line_number":96,"context_line":"        schema \u003d self.node_schema"},{"line_number":97,"context_line":"        response \u003d self._ironic(\u0027node-show\u0027, flags\u003d\u0027--json\u0027,"},{"line_number":98,"context_line":"                                params\u003d\u0027{0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":99,"context_line":"        self.assertTrue(is_valid_json(response, schema))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_7b09dd83","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":33},"updated":"2016-06-30 11:03:22.000000000","message":"nit: redundant var","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"79117b971abe869df103a2c82863b2be8af157c6","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_node_show_json(self):"},{"line_number":95,"context_line":"        \"\"\"Test JSON response for node show.\"\"\""},{"line_number":96,"context_line":"        schema \u003d self.node_schema"},{"line_number":97,"context_line":"        response \u003d self._ironic(\u0027node-show\u0027, flags\u003d\u0027--json\u0027,"},{"line_number":98,"context_line":"                                params\u003d\u0027{0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":99,"context_line":"        self.assertTrue(is_valid_json(response, schema))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_9db58fee","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":33},"in_reply_to":"3aaa91ec_7b09dd83","updated":"2016-06-30 16:36:20.000000000","message":"Done","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"1e28e173ece3fe4b2c4c99421af60839adca2c4a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.assertTrue(is_valid_json(response, schema))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_node_update_json(self):"},{"line_number":151,"context_line":"        schema \u003d self.node_schema"},{"line_number":152,"context_line":"        \"\"\"Test JSON response for node update.\"\"\""},{"line_number":153,"context_line":"        node_name \u003d data_utils.rand_name(\u0027test\u0027)"},{"line_number":154,"context_line":"        response \u003d self._ironic(\u0027node-update\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_1b1ed96f","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":33},"updated":"2016-06-30 11:03:22.000000000","message":"nit: redundant var","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"79117b971abe869df103a2c82863b2be8af157c6","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.assertTrue(is_valid_json(response, schema))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_node_update_json(self):"},{"line_number":151,"context_line":"        schema \u003d self.node_schema"},{"line_number":152,"context_line":"        \"\"\"Test JSON response for node update.\"\"\""},{"line_number":153,"context_line":"        node_name \u003d data_utils.rand_name(\u0027test\u0027)"},{"line_number":154,"context_line":"        response \u003d self._ironic(\u0027node-update\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_bd24cb5f","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":33},"in_reply_to":"3aaa91ec_1b1ed96f","updated":"2016-06-30 16:36:20.000000000","message":"Done","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"1e28e173ece3fe4b2c4c99421af60839adca2c4a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    \"\"\"Test JSON responses for chassis commands.\"\"\""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    chassis_schema \u003d {"},{"line_number":164,"context_line":"        \"type\": [\"array\", \"object\"],"},{"line_number":165,"context_line":"        \"properties\": {"},{"line_number":166,"context_line":"            \"uuid\": {\"type\": \"string\"},"},{"line_number":167,"context_line":"            \"links\": {\"type\": \"array\"},"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_e72c0eae","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":36},"updated":"2016-06-30 11:03:22.000000000","message":"why does chassis array?","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"79117b971abe869df103a2c82863b2be8af157c6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    \"\"\"Test JSON responses for chassis commands.\"\"\""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    chassis_schema \u003d {"},{"line_number":164,"context_line":"        \"type\": [\"array\", \"object\"],"},{"line_number":165,"context_line":"        \"properties\": {"},{"line_number":166,"context_line":"            \"uuid\": {\"type\": \"string\"},"},{"line_number":167,"context_line":"            \"links\": {\"type\": \"array\"},"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_3d61fbd3","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":36},"in_reply_to":"3aaa91ec_e72c0eae","updated":"2016-06-30 16:36:20.000000000","message":"Done","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"1e28e173ece3fe4b2c4c99421af60839adca2c4a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        response \u003d self._ironic(\u0027chassis-create\u0027, flags\u003d\u0027--json\u0027, params\u003d\u0027\u0027)"},{"line_number":209,"context_line":"        self.assertTrue(is_valid_json(response, schema))"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_chassis_update_json(self):"},{"line_number":212,"context_line":"        \"\"\"Test JSON response for chassis update.\"\"\""},{"line_number":213,"context_line":"        schema \u003d self.chassis_schema"},{"line_number":214,"context_line":"        response \u003d self._ironic(\u0027chassis-update\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_1927feb6","line":211,"range":{"start_line":211,"start_character":9,"end_line":211,"end_character":32},"updated":"2016-06-30 11:03:22.000000000","message":"does update returns array?","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"79117b971abe869df103a2c82863b2be8af157c6","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        response \u003d self._ironic(\u0027chassis-create\u0027, flags\u003d\u0027--json\u0027, params\u003d\u0027\u0027)"},{"line_number":209,"context_line":"        self.assertTrue(is_valid_json(response, schema))"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_chassis_update_json(self):"},{"line_number":212,"context_line":"        \"\"\"Test JSON response for chassis update.\"\"\""},{"line_number":213,"context_line":"        schema \u003d self.chassis_schema"},{"line_number":214,"context_line":"        response \u003d self._ironic(\u0027chassis-update\u0027, flags\u003d\u0027--json\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_7d9d43bb","line":211,"range":{"start_line":211,"start_character":9,"end_line":211,"end_character":32},"in_reply_to":"3aaa91ec_1927feb6","updated":"2016-06-30 16:36:20.000000000","message":"Done","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"1e28e173ece3fe4b2c4c99421af60839adca2c4a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        \"\"\"Test JSON response for driver properties.\"\"\""},{"line_number":255,"context_line":"        schema \u003d {"},{"line_number":256,"context_line":"            \"type\": \"object\","},{"line_number":257,"context_line":"            \"items\": {\"type\": \"string\"}"},{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        drivers_names \u003d self.get_drivers_names()"},{"line_number":260,"context_line":"        for driver in drivers_names:"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_d9e4563d","line":257,"range":{"start_line":257,"start_character":29,"end_line":257,"end_character":38},"updated":"2016-06-30 11:03:22.000000000","message":"hmm, items is string","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"79117b971abe869df103a2c82863b2be8af157c6","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        \"\"\"Test JSON response for driver properties.\"\"\""},{"line_number":255,"context_line":"        schema \u003d {"},{"line_number":256,"context_line":"            \"type\": \"object\","},{"line_number":257,"context_line":"            \"items\": {\"type\": \"string\"}"},{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        drivers_names \u003d self.get_drivers_names()"},{"line_number":260,"context_line":"        for driver in drivers_names:"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_fa7939c9","line":257,"range":{"start_line":257,"start_character":29,"end_line":257,"end_character":38},"in_reply_to":"3aaa91ec_d9e4563d","updated":"2016-06-30 16:36:20.000000000","message":"Returns batch of strings: \nironic --json driver-properties fake\n{\n    \"A1\": \"A1 description. Required.\",\n    \"A2\": \"A2 description. Optional.\",\n    \"B1\": \"B1 description. Required.\",\n    \"B2\": \"B2 description. Required.\"\n}","commit_id":"db7346864b6d1056dde454de369d6650199eb9d1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"75c1f0d9f8491bab7486062bc5d68182ad373e29","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \"power_state\": {\"type\": [\"string\", \"null\"]},"},{"line_number":62,"context_line":"            \"driver\": {\"type\": \"string\"},"},{"line_number":63,"context_line":"            \"reservation\": {\"type\": [\"string\", \"null\"]},"},{"line_number":64,"context_line":"            \"properties\": {\"type\": [\"object\", \"array\"]},"},{"line_number":65,"context_line":"            \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":66,"context_line":"            \"name\": {\"type\": [\"string\", \"null\"]},"},{"line_number":67,"context_line":"            \"driver_info\": {\"type\": \"object\"},"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_842f1c87","line":64,"updated":"2016-07-20 16:27:49.000000000","message":"It can not be an array","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"14d898319c55791cb808871b79e025749a1b9321","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \"power_state\": {\"type\": [\"string\", \"null\"]},"},{"line_number":62,"context_line":"            \"driver\": {\"type\": \"string\"},"},{"line_number":63,"context_line":"            \"reservation\": {\"type\": [\"string\", \"null\"]},"},{"line_number":64,"context_line":"            \"properties\": {\"type\": [\"object\", \"array\"]},"},{"line_number":65,"context_line":"            \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":66,"context_line":"            \"name\": {\"type\": [\"string\", \"null\"]},"},{"line_number":67,"context_line":"            \"driver_info\": {\"type\": \"object\"},"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_2cfc203d","line":64,"in_reply_to":"dada55a8_842f1c87","updated":"2016-07-21 14:52:56.000000000","message":"Thanks!","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"75c1f0d9f8491bab7486062bc5d68182ad373e29","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test_node_list_json(self):"},{"line_number":80,"context_line":"        \"\"\"Test JSON response for nodes list.\"\"\""},{"line_number":81,"context_line":"        schema \u003d {"},{"line_number":82,"context_line":"            \"type\": [\"object\", \"array\"],"},{"line_number":83,"context_line":"            \"properties\": {"},{"line_number":84,"context_line":"                \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":85,"context_line":"                \"maintenance\": {\"type\": \"boolean\"},"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_245630ce","line":82,"updated":"2016-07-20 16:27:49.000000000","message":"It is always an array containing objects you\u0027ve described here.","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"14d898319c55791cb808871b79e025749a1b9321","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test_node_list_json(self):"},{"line_number":80,"context_line":"        \"\"\"Test JSON response for nodes list.\"\"\""},{"line_number":81,"context_line":"        schema \u003d {"},{"line_number":82,"context_line":"            \"type\": [\"object\", \"array\"],"},{"line_number":83,"context_line":"            \"properties\": {"},{"line_number":84,"context_line":"                \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":85,"context_line":"                \"maintenance\": {\"type\": \"boolean\"},"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_6c15789a","line":82,"in_reply_to":"dada55a8_245630ce","updated":"2016-07-21 14:52:56.000000000","message":"Done","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"75c1f0d9f8491bab7486062bc5d68182ad373e29","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def test_node_validate_json(self):"},{"line_number":102,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":103,"context_line":"        schema \u003d {"},{"line_number":104,"context_line":"            \"type\": [\"object\", \"array\"],"},{"line_number":105,"context_line":"            \"properties\": {"},{"line_number":106,"context_line":"                \"interface\": {\"type\": [\"string\", \"null\"]},"},{"line_number":107,"context_line":"                \"result\": {\"type\": \"boolean\"},"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_6422e853","line":104,"updated":"2016-07-20 16:27:49.000000000","message":"It is always an array containing objects you\u0027ve described here.","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"14d898319c55791cb808871b79e025749a1b9321","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def test_node_validate_json(self):"},{"line_number":102,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":103,"context_line":"        schema \u003d {"},{"line_number":104,"context_line":"            \"type\": [\"object\", \"array\"],"},{"line_number":105,"context_line":"            \"properties\": {"},{"line_number":106,"context_line":"                \"interface\": {\"type\": [\"string\", \"null\"]},"},{"line_number":107,"context_line":"                \"result\": {\"type\": \"boolean\"},"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_8cd38cd4","line":104,"in_reply_to":"dada55a8_6422e853","updated":"2016-07-21 14:52:56.000000000","message":"Done","commit_id":"f18814b3298b307999c184f65a6855c2d3a6b178"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"143735df7195708865412d881e0075c547bb3b41","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \"power_state\": {\"type\": [\"string\", \"null\"]},"},{"line_number":62,"context_line":"            \"driver\": {\"type\": \"string\"},"},{"line_number":63,"context_line":"            \"reservation\": {\"type\": [\"string\", \"null\"]},"},{"line_number":64,"context_line":"            \"properties\": {\"type\": [\"object\"]},"},{"line_number":65,"context_line":"            \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":66,"context_line":"            \"name\": {\"type\": [\"string\", \"null\"]},"},{"line_number":67,"context_line":"            \"driver_info\": {\"type\": \"object\"},"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_a2dc9946","line":64,"updated":"2016-07-21 15:05:20.000000000","message":"No need for [] here, just \"object\".","commit_id":"14e08321dc02e17d78978ef7d8d63b1c8ce73b37"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"6195f59cbc997fbcfc17c0263f5c1434d4c71b94","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \"power_state\": {\"type\": [\"string\", \"null\"]},"},{"line_number":62,"context_line":"            \"driver\": {\"type\": \"string\"},"},{"line_number":63,"context_line":"            \"reservation\": {\"type\": [\"string\", \"null\"]},"},{"line_number":64,"context_line":"            \"properties\": {\"type\": [\"object\"]},"},{"line_number":65,"context_line":"            \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":66,"context_line":"            \"name\": {\"type\": [\"string\", \"null\"]},"},{"line_number":67,"context_line":"            \"driver_info\": {\"type\": \"object\"},"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_40eaf474","line":64,"in_reply_to":"dada55a8_a2dc9946","updated":"2016-07-21 16:11:03.000000000","message":"Done","commit_id":"14e08321dc02e17d78978ef7d8d63b1c8ce73b37"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"143735df7195708865412d881e0075c547bb3b41","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test_node_list_json(self):"},{"line_number":80,"context_line":"        \"\"\"Test JSON response for nodes list.\"\"\""},{"line_number":81,"context_line":"        schema \u003d {"},{"line_number":82,"context_line":"            \"type\": [\"array\"],"},{"line_number":83,"context_line":"            \"properties\": {"},{"line_number":84,"context_line":"                \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":85,"context_line":"                \"maintenance\": {\"type\": \"boolean\"},"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_62a461b9","line":82,"updated":"2016-07-21 15:05:20.000000000","message":"This is incorrect, please see docs on jsonschema. It should be:\n\n {\n   \"type\": \"array\",\n   \"items\": {\n     \"type\": \"object\",\n     \"properties\": {\n       \"interface\": {\"type\": [\"string\", \"null\"]},\n       \"result\": {\"type\": \"boolean\"},\n       \"reason\": {\"type\": [\"string\", \"null\"]}\n     }\n   }\n }","commit_id":"14e08321dc02e17d78978ef7d8d63b1c8ce73b37"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"6195f59cbc997fbcfc17c0263f5c1434d4c71b94","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test_node_list_json(self):"},{"line_number":80,"context_line":"        \"\"\"Test JSON response for nodes list.\"\"\""},{"line_number":81,"context_line":"        schema \u003d {"},{"line_number":82,"context_line":"            \"type\": [\"array\"],"},{"line_number":83,"context_line":"            \"properties\": {"},{"line_number":84,"context_line":"                \"instance_uuid\": {\"type\": [\"string\", \"null\"]},"},{"line_number":85,"context_line":"                \"maintenance\": {\"type\": \"boolean\"},"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_43703ea4","line":82,"in_reply_to":"dada55a8_62a461b9","updated":"2016-07-21 16:11:03.000000000","message":"Thanks for example!","commit_id":"14e08321dc02e17d78978ef7d8d63b1c8ce73b37"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"143735df7195708865412d881e0075c547bb3b41","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def test_node_validate_json(self):"},{"line_number":102,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":103,"context_line":"        schema \u003d {"},{"line_number":104,"context_line":"            \"type\": [\"array\"],"},{"line_number":105,"context_line":"            \"properties\": {"},{"line_number":106,"context_line":"                \"interface\": {\"type\": [\"string\", \"null\"]},"},{"line_number":107,"context_line":"                \"result\": {\"type\": \"boolean\"},"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_82ad159d","line":104,"updated":"2016-07-21 15:05:20.000000000","message":"ditto","commit_id":"14e08321dc02e17d78978ef7d8d63b1c8ce73b37"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"6195f59cbc997fbcfc17c0263f5c1434d4c71b94","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def test_node_validate_json(self):"},{"line_number":102,"context_line":"        \"\"\"Test JSON response for node validation.\"\"\""},{"line_number":103,"context_line":"        schema \u003d {"},{"line_number":104,"context_line":"            \"type\": [\"array\"],"},{"line_number":105,"context_line":"            \"properties\": {"},{"line_number":106,"context_line":"                \"interface\": {\"type\": [\"string\", \"null\"]},"},{"line_number":107,"context_line":"                \"result\": {\"type\": \"boolean\"},"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_83ad16eb","line":104,"in_reply_to":"dada55a8_82ad159d","updated":"2016-07-21 16:11:03.000000000","message":"Done","commit_id":"14e08321dc02e17d78978ef7d8d63b1c8ce73b37"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"4945692ab5e48c9f9e9e54fd1880399d57eff28f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ironicclient.tests.functional import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def is_valid_json(json_response, schema):"},{"line_number":24,"context_line":"    \"\"\"Verify JSON is valid."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    :param json_response: JSON response from CLI"}],"source_content_type":"text/x-python","patch_set":25,"id":"dada55a8_2aecc08e","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":17},"updated":"2016-07-22 16:04:20.000000000","message":"nit: might be worth adding a \"_\" to this (_is_valid_json) as it looks like a private method.","commit_id":"6083eec58d0c3c11e357883597b99d11d9460a63"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ca30a5332671670791fb27ab3b374a7842b2e7dd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ironicclient.tests.functional import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def is_valid_json(json_response, schema):"},{"line_number":24,"context_line":"    \"\"\"Verify JSON is valid."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    :param json_response: JSON response from CLI"}],"source_content_type":"text/x-python","patch_set":25,"id":"dada55a8_eaad15ea","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":17},"in_reply_to":"dada55a8_2aecc08e","updated":"2016-07-26 09:58:18.000000000","message":"Done","commit_id":"6083eec58d0c3c11e357883597b99d11d9460a63"}],"test-requirements.txt":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"db5eb4aa4dfebde057f543bac571133ed54b0626","unresolved":false,"context_lines":[{"line_number":17,"context_line":"testtools\u003e\u003d1.4.0 # MIT"},{"line_number":18,"context_line":"tempest\u003e\u003d11.0.0 # Apache-2.0"},{"line_number":19,"context_line":"os-testr\u003e\u003d0.7.0 # Apache-2.0"},{"line_number":20,"context_line":"jsonschema\u003e\u003d2.5.1 # BSD"},{"line_number":21,"context_line":""}],"source_content_type":"text/plain","patch_set":21,"id":"3aaa91ec_258c39d9","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":23},"updated":"2016-06-30 16:45:09.000000000","message":"jsonschema\u003e\u003d2.0.0,\u003c3.0.0,!\u003d2.5.0 # MIT \nshould be","commit_id":"591e7628b318dff310d6405f61c8ed27f233168d"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"887b4b2a11d475b962e9431933603e904c51f48d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"testtools\u003e\u003d1.4.0 # MIT"},{"line_number":18,"context_line":"tempest\u003e\u003d11.0.0 # Apache-2.0"},{"line_number":19,"context_line":"os-testr\u003e\u003d0.7.0 # Apache-2.0"},{"line_number":20,"context_line":"jsonschema\u003e\u003d2.5.1 # BSD"},{"line_number":21,"context_line":""}],"source_content_type":"text/plain","patch_set":21,"id":"3aaa91ec_7bb7cb3a","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":23},"in_reply_to":"3aaa91ec_258c39d9","updated":"2016-07-01 14:51:48.000000000","message":"Done","commit_id":"591e7628b318dff310d6405f61c8ed27f233168d"}]}
