)]}'
{"id":"openstack%2Fpython-ironicclient~296552","triplet_id":"openstack%2Fpython-ironicclient~master~I7d7e34850a51b5d6846a4a1cfeaa0df23ad1a19c","project":"openstack/python-ironicclient","branch":"master","hashtags":[],"change_id":"I7d7e34850a51b5d6846a4a1cfeaa0df23ad1a19c","subject":"Code style fix according to flake8","status":"MERGED","created":"2016-03-23 15:45:37.000000000","updated":"2016-03-31 17:47:48.000000000","submitted":"2016-03-31 17:47:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6b406d09b84e594ef38bede78f5eae272c18de51","_number":296552,"virtual_id_number":296552,"owner":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-03-31 17:47:48.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"recommended":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-03-25 13:29:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},{"value":1,"date":"2016-03-28 07:26:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":2,"date":"2016-03-31 16:54:06.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"date":"2016-03-31 09:06:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":2,"date":"2016-03-31 10:04:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":1,"date":"2016-03-31 16:54:06.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-25 13:29:30.000000000","updated_by":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"reviewer":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"state":"REVIEWER"},{"updated":"2016-03-28 07:26:22.000000000","updated_by":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"reviewer":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"state":"REVIEWER"},{"updated":"2016-03-31 09:06:48.000000000","updated_by":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"reviewer":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"state":"REVIEWER"},{"updated":"2016-03-31 10:04:52.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-03-31 16:54:06.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2016-03-31 17:47:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ea1f8b08b34372bc9a97635c9f8f2a74d3de9260","author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"date":"2016-03-23 15:45:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d360fa44b6680dc9f659f919077e52edd4a6e395","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-03-23 16:01:45.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1bb78261134c542121ad0ec1df082a0e75c74963","author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"date":"2016-03-23 16:16:49.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"48d2a362c51cbe30709483d469294d6e8539f6c3","author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"date":"2016-03-23 16:17:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8ca8abf9d87c5ad10d47173e2d7830ab87120ef8","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-03-23 16:57:37.000000000","message":"Patch Set 2:\n\nThe change seems reasonable. But unsure of what is reporting the error as we aren\u0027t seeing any failures in:\n\n tox -vvv -epep8","accounts_in_message":[],"_revision_number":2},{"id":"424261f294f8191580592f15a3e8dcd9be3ce748","author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"date":"2016-03-23 17:51:53.000000000","message":"Patch Set 2:\n\nIt looks that check result can depend of automatic checker version.\nI have read in Python Docstring convention https://www.python.org/dev/peps/pep-0257/#one-line-docstrings that one-line docstrings should end with period symbol.","accounts_in_message":[],"_revision_number":2},{"id":"06e0d7871e4da989f9a63db6c70344a39b4e5ac8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-23 18:03:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/52/296552/2/check/gate-python-ironicclient-python34/064a0ef/ : SUCCESS in 2m 22s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/52/296552/2/check/gate-python-ironicclient-docs/4412b56//doc/build/html/ : SUCCESS in 3m 13s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/52/296552/2/check/gate-python-ironicclient-pep8/2a44f1f/ : SUCCESS in 2m 17s\n- gate-python-ironicclient-python27 http://logs.openstack.org/52/296552/2/check/gate-python-ironicclient-python27/721816d/ : SUCCESS in 3m 32s\n- gate-python-ironicclient-pypy http://logs.openstack.org/52/296552/2/check/gate-python-ironicclient-pypy/9b3de13/ : SUCCESS in 3m 25s (non-voting)\n- check-osc-plugins http://logs.openstack.org/52/296552/2/check/check-osc-plugins/78bd97f/ : FAILURE in 5m 27s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/52/296552/2/check/gate-tempest-dsvm-python-ironicclient-src/f69c1eb/ : SUCCESS in 43m 32s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/52/296552/2/check/gate-ironicclient-dsvm-functional/168bc84/ : SUCCESS in 11m 48s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f7d84b79f620e076bf2b8e46cc6940f5873d23a1","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2016-03-25 13:29:30.000000000","message":"Patch Set 2: Code-Review+1\n\nseems correct, I guess we don\u0027t use flake8-docstrings","accounts_in_message":[],"_revision_number":2},{"id":"528a991eae2abd9c5d738ba086961d259ced3c5b","author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"date":"2016-03-28 07:26:22.000000000","message":"Patch Set 2: Code-Review+1\n\nGood catch! LGTM\n\nAfter having installed flake8-docstrings, flake8 turned to report errors.","accounts_in_message":[],"_revision_number":2},{"id":"07be9dbde3fc87597aa26a01f9b22ca0a80ccb0e","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-03-28 17:58:51.000000000","message":"Patch Set 2:\n\nI\u0027m not sure the value of this patch, and I love pep8 checks :)\n\nIf I install \u0027flake8-docstrings\u0027 in the pep8 virtual env and then do:\n\n$ tox -epep8 | grep \u0027D[0-9][0-9]\u0027 | wc\n   1016    7378   93337\n\nSo there are 1000+ errors related to docstrings currently. And I don\u0027t think this is something we want to enforce.","accounts_in_message":[],"_revision_number":2},{"id":"99692c5a638a9075c1fc85abf58b2bc927e9ccce","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2016-03-31 09:02:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3999f37383eeee1e129d1a5c5ac05afab6189b48","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2016-03-31 09:06:48.000000000","message":"Patch Set 2: -Code-Review\n\nSo have concern about this fix, if we want to enforce such strict examination for the doc strings?","accounts_in_message":[],"_revision_number":2},{"id":"5b48ceab5173421b47955a371439ae215787a086","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-03-31 10:04:52.000000000","message":"Patch Set 2: Code-Review+2\n\nI\u0027m not against landing this, seems consitent with what we already do. Not sure if we want to enforce it, however.","accounts_in_message":[],"_revision_number":2},{"id":"2e7fe734aece02a28936484be4dd39f55f52e04d","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-03-31 16:54:06.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9065e12d380a54af01d880ce8272d2a9c318c08f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-31 16:54:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"262cffda55873789c3680bf787fb6679db694034","date":"2016-03-31 17:47:48.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"6b406d09b84e594ef38bede78f5eae272c18de51","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-31 17:47:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/52/296552/2/gate/gate-python-ironicclient-python34/aa3bb78/ : SUCCESS in 3m 13s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/52/296552/2/gate/gate-python-ironicclient-docs/8de38fa//doc/build/html/ : SUCCESS in 3m 06s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/52/296552/2/gate/gate-python-ironicclient-pep8/3bfa7ed/ : SUCCESS in 2m 51s\n- gate-python-ironicclient-python27 http://logs.openstack.org/52/296552/2/gate/gate-python-ironicclient-python27/f73e8ac/ : SUCCESS in 2m 06s\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/52/296552/2/gate/gate-tempest-dsvm-python-ironicclient-src/d31dbb6/ : SUCCESS in 50m 49s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3e3fe36e4325800ae813d381f11cf252f1f167c5","revisions":{"17fc824bf0d203707cdeabb7d2f6f423e4047316":{"kind":"REWORK","_number":1,"created":"2016-03-23 15:45:37.000000000","uploader":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"ref":"refs/changes/52/296552/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/52/296552/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/52/296552/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/52/296552/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/52/296552/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/52/296552/1"}}},"commit":{"parents":[{"commit":"585575eb8daaf8dc0b88d207e4f763c1d82fd3af","subject":"Merge \"Improve output of --json option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/585575eb8daaf8dc0b88d207e4f763c1d82fd3af"}]}],"author":{"name":"Kyrylo Romanenko","email":"kromanenko@mirantis.com","date":"2016-03-23 15:43:52.000000000","tz":120},"committer":{"name":"Kyrylo Romanenko","email":"kromanenko@mirantis.com","date":"2016-03-23 15:43:52.000000000","tz":120},"subject":"Code style fix according to flake8","message":"Code style fix according to flake8\n\nChange-Id: I7d7e34850a51b5d6846a4a1cfeaa0df23ad1a19c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/17fc824bf0d203707cdeabb7d2f6f423e4047316"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/17fc824bf0d203707cdeabb7d2f6f423e4047316"}]},"branch":"refs/heads/master"},"3e3fe36e4325800ae813d381f11cf252f1f167c5":{"kind":"REWORK","_number":2,"created":"2016-03-23 16:16:49.000000000","uploader":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"ref":"refs/changes/52/296552/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/52/296552/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/52/296552/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/52/296552/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/52/296552/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/52/296552/2"}}},"commit":{"parents":[{"commit":"585575eb8daaf8dc0b88d207e4f763c1d82fd3af","subject":"Merge \"Improve output of --json option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/585575eb8daaf8dc0b88d207e4f763c1d82fd3af"}]}],"author":{"name":"Kyrylo Romanenko","email":"kromanenko@mirantis.com","date":"2016-03-23 15:43:52.000000000","tz":120},"committer":{"name":"Kyrylo Romanenko","email":"kromanenko@mirantis.com","date":"2016-03-23 16:16:32.000000000","tz":0},"subject":"Code style fix according to flake8","message":"Code style fix according to flake8\n\nChange-Id: I7d7e34850a51b5d6846a4a1cfeaa0df23ad1a19c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/3e3fe36e4325800ae813d381f11cf252f1f167c5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/3e3fe36e4325800ae813d381f11cf252f1f167c5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}