)]}'
{"ironicclient/common/http.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f1919593558168101adaa106bacbf17c7d99c1fe","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        endpoint_filter.setdefault(\u0027region_name\u0027, self.region_name)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        resp \u003d self.session.request(url, method,"},{"line_number":526,"context_line":"                                    raise_exc\u003dFalse, **kwargs)"},{"line_number":527,"context_line":"        if resp.status_code \u003d\u003d http_client.NOT_ACCEPTABLE:"},{"line_number":528,"context_line":"            negotiated_ver \u003d self.negotiate_version(self.session, resp)"},{"line_number":529,"context_line":"            kwargs[\u0027headers\u0027][\u0027X-OpenStack-Ironic-API-Version\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_6ce90db7","line":526,"updated":"2016-06-01 13:43:25.000000000","message":"I\u0027d rather add connect retries here as keystoneauth is able to do retries by itself - https://github.com/openstack/keystoneauth/blob/118c9629e57f353aa49ba29c4b27e0e240788463/keystoneauth1/session.py#L522 and this exception is only possible in case of session client, WDYT?","commit_id":"2a8b73557bbad96181a3fe48844d235872864f07"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6d89d50aa2f226a9b94d6a6fb6bddc9075221e67","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        endpoint_filter.setdefault(\u0027region_name\u0027, self.region_name)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        resp \u003d self.session.request(url, method,"},{"line_number":526,"context_line":"                                    raise_exc\u003dFalse, **kwargs)"},{"line_number":527,"context_line":"        if resp.status_code \u003d\u003d http_client.NOT_ACCEPTABLE:"},{"line_number":528,"context_line":"            negotiated_ver \u003d self.negotiate_version(self.session, resp)"},{"line_number":529,"context_line":"            kwargs[\u0027headers\u0027][\u0027X-OpenStack-Ironic-API-Version\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_d3bd2803","line":526,"in_reply_to":"9abb7d3a_6ce90db7","updated":"2016-06-01 17:12:16.000000000","message":"I think it would be a good idea overall, and is ultimately release note worthy because it is a minor behavior change.","commit_id":"2a8b73557bbad96181a3fe48844d235872864f07"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8a7bf3dfda09e0ce7b40ae5482c7cf76df535ecf","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                    raise"},{"line_number":200,"context_line":"                else:"},{"line_number":201,"context_line":"                    LOG.debug(msg)"},{"line_number":202,"context_line":"                    time.sleep(self.conflict_retry_interval)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    return wrapper"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_15392242","line":202,"updated":"2016-06-02 13:35:57.000000000","message":"So it uses conflict_retry_interval, I wonder if we need to add a new field, like auth_retries or something. ditto for attempts.","commit_id":"11a3f12c3adb4835e92ec0e8aaff270e2c54ab29"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"82f42e157f0453c58c6d3b4c1febc4f7faf24548","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                    raise"},{"line_number":200,"context_line":"                else:"},{"line_number":201,"context_line":"                    LOG.debug(msg)"},{"line_number":202,"context_line":"                    time.sleep(self.conflict_retry_interval)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    return wrapper"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_00cb9d1f","line":202,"in_reply_to":"9abb7d3a_15392242","updated":"2016-06-02 14:54:08.000000000","message":"I agree, but we\u0027ve been using the same for e.g. ConnectionRefused.. so maybe it can go to a separate patch","commit_id":"11a3f12c3adb4835e92ec0e8aaff270e2c54ab29"}],"releasenotes/notes/retry-on-keystone-auth-retriable-failures-91c08b9f8bdab7f3.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eb5f94a4ce9d44f05ecf967c69c0940b798dc37b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The client will now retry on keystoneauth retriable connection failures if"},{"line_number":4,"context_line":"    retries are enabled for a particular request. This ensures that on a"},{"line_number":5,"context_line":"    temporary network outage to the keystone auth services a request we be"},{"line_number":6,"context_line":"    retried the requested number of times before raising an exception."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_5dad7587","line":4,"updated":"2016-06-02 21:13:33.000000000","message":"by default, they are enabled, right?","commit_id":"11a3f12c3adb4835e92ec0e8aaff270e2c54ab29"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eb5f94a4ce9d44f05ecf967c69c0940b798dc37b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The client will now retry on keystoneauth retriable connection failures if"},{"line_number":4,"context_line":"    retries are enabled for a particular request. This ensures that on a"},{"line_number":5,"context_line":"    temporary network outage to the keystone auth services a request we be"},{"line_number":6,"context_line":"    retried the requested number of times before raising an exception."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_9d4cfd77","line":5,"updated":"2016-06-02 21:13:33.000000000","message":"s/we/will/ ?","commit_id":"11a3f12c3adb4835e92ec0e8aaff270e2c54ab29"}]}
