)]}'
{"ironicclient/tests/functional/test_port.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"e7481219f2e729a86ae5a8a32f11c4442a7323ec","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        other_node \u003d self.create_node()"},{"line_number":108,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":109,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":110,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027] and other_port[\u0027uuid\u0027],"},{"line_number":111,"context_line":"                      [x[\u0027UUID\u0027] for x in port_list])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_6b62883f","line":110,"range":{"start_line":110,"start_character":22,"end_line":110,"end_character":63},"updated":"2016-06-14 14:14:14.000000000","message":"It\u0027s wrong check, it will assert only other_port.\n\nThe expression \"x and y\" first evaluates x; if x is false, its value is returned; otherwise, y is evaluated and the resulting value is returned.","commit_id":"57a01ded860aa43797b5ea0a409864c975a8276f"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"5567d1a252f735058cb5c6bfe974df7083fe8feb","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        other_node \u003d self.create_node()"},{"line_number":108,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":109,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":110,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027] and other_port[\u0027uuid\u0027],"},{"line_number":111,"context_line":"                      [x[\u0027UUID\u0027] for x in port_list])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_9094bfe2","line":110,"range":{"start_line":110,"start_character":22,"end_line":110,"end_character":63},"in_reply_to":"7aa08908_6b62883f","updated":"2016-06-21 13:10:50.000000000","message":"Done","commit_id":"57a01ded860aa43797b5ea0a409864c975a8276f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e664509a7f3e6490777fb99935750911d8258664","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":109,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":110,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], [x[\u0027UUID\u0027] for x in port_list])"},{"line_number":111,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], [x[\u0027UUID\u0027] for x in port_list])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_6f4a6d57","line":111,"updated":"2016-06-27 12:12:03.000000000","message":"nit:\n\n self.assertEqual({self.port[\u0027uuid\u0027], other_port[\u0027uuid\u0027]},\n                  {x[\u0027UUID\u0027] for x in port_list})\n\nI\u0027d also prefer more fields to be checked..","commit_id":"2c7e8bf48657ff8e037e5efb36e9aada62ca6b82"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d35fd48a9ebadb303ed1041a4b9cdde26934227d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":109,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":110,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], [x[\u0027UUID\u0027] for x in port_list])"},{"line_number":111,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], [x[\u0027UUID\u0027] for x in port_list])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_bb03c172","line":111,"in_reply_to":"3aaa91ec_3ed275d1","updated":"2016-07-04 14:10:51.000000000","message":"Done","commit_id":"2c7e8bf48657ff8e037e5efb36e9aada62ca6b82"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d35fd48a9ebadb303ed1041a4b9cdde26934227d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":109,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":110,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], [x[\u0027UUID\u0027] for x in port_list])"},{"line_number":111,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], [x[\u0027UUID\u0027] for x in port_list])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_dbe7ade2","line":111,"in_reply_to":"3aaa91ec_6f4a6d57","updated":"2016-07-04 14:10:51.000000000","message":"1) I tried to use such construction with assertIn(), but something i do wrong and get this result: http://paste.openstack.org/show/525613/\n\n2) Added check for MAC Address in port-list.","commit_id":"2c7e8bf48657ff8e037e5efb36e9aada62ca6b82"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fe2bd3712e5d4752d7d368570db88ffeba0044e5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":109,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":110,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], [x[\u0027UUID\u0027] for x in port_list])"},{"line_number":111,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], [x[\u0027UUID\u0027] for x in port_list])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3ed275d1","line":111,"in_reply_to":"3aaa91ec_6f4a6d57","updated":"2016-07-01 01:27:16.000000000","message":"Wow, it seems inefficient, even if it just a test, to be generating the list of port UUIDs twice.\n\nI\u0027d actually like it to be addressed; otherwise I\u0027m afraid that others will copy/paste this pattern.","commit_id":"2c7e8bf48657ff8e037e5efb36e9aada62ca6b82"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9cc22d26db839884405107231f65b8dd4a232aa4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        other_node \u003d self.create_node()"},{"line_number":109,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        uuids \u003d self.get_uuids_from_port_list()"},{"line_number":112,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], uuids)"},{"line_number":113,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], uuids)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_9f82f5fe","line":111,"updated":"2016-07-11 13:34:20.000000000","message":"You can do \n\n port_list \u003d self.list_ports()\n addresses \u003d [x[\u0027Address\u0027] for x in port_list]\n uuids \u003d [x[\u0027UUID\u0027] for x in port_list]\n\nand save one list ports call","commit_id":"cc1816853dcd917752cdc93fa26ddf2467e08cdc"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"b9c483faa9201b12702dd311946b5f30f1c24253","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        other_node \u003d self.create_node()"},{"line_number":109,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        uuids \u003d self.get_uuids_from_port_list()"},{"line_number":112,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], uuids)"},{"line_number":113,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], uuids)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_01651ee0","line":111,"in_reply_to":"1aa78d24_9f82f5fe","updated":"2016-07-19 15:31:07.000000000","message":"Done","commit_id":"cc1816853dcd917752cdc93fa26ddf2467e08cdc"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"72660122d33028201a8e714123324010f4e26da1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.assertEqual(node_to_replace[\u0027uuid\u0027], updated_port[\u0027node_uuid\u0027])"},{"line_number":98,"context_line":"        self.assertNotEqual(self.port[\u0027node_uuid\u0027], updated_port[\u0027node_uuid\u0027])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_port_list(self):"},{"line_number":101,"context_line":"        \"\"\"Test steps:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            1) create node and port in setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_666779e9","line":100,"range":{"start_line":100,"start_character":4,"end_line":100,"end_character":29},"updated":"2016-08-01 09:23:16.000000000","message":"If this patch covers only normal case, but not abnormal case, would it better to mention it into the commit message?\nBecause the commit message currently is empty. I just wondered why this patch adding only one normal test case.","commit_id":"1f2848296067322b7e10784c44a9e559f0bfeb4f"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"df04a2fc2f11353f98fd64ca36a8a53e90684589","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.assertEqual(node_to_replace[\u0027uuid\u0027], updated_port[\u0027node_uuid\u0027])"},{"line_number":98,"context_line":"        self.assertNotEqual(self.port[\u0027node_uuid\u0027], updated_port[\u0027node_uuid\u0027])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_port_list(self):"},{"line_number":101,"context_line":"        \"\"\"Test steps:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            1) create node and port in setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_c325705c","line":100,"range":{"start_line":100,"start_character":4,"end_line":100,"end_character":29},"in_reply_to":"bacf61ea_666779e9","updated":"2016-08-01 11:23:04.000000000","message":"Ok, i filled commit message.","commit_id":"1f2848296067322b7e10784c44a9e559f0bfeb4f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3396e2ea22e9ecbe20864352848c5a68f3c1d240","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":112,"context_line":"        uuids \u003d [x[\u0027UUID\u0027] for x in port_list]"},{"line_number":113,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], uuids)"},{"line_number":114,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], uuids)"},{"line_number":115,"context_line":"        addresses \u003d [x[\u0027Address\u0027] for x in port_list]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_76ace735","line":112,"updated":"2016-08-12 16:11:10.000000000","message":"better\n\n uuids \u003d {x[\u0027UUID\u0027] for x in port_list}\n self.assertEqual({self.port[\u0027uuid\u0027], other_port[\u0027uuid\u0027]}, uuids)","commit_id":"e38b66883359ec0af9974de8fb9fcc60b02d4512"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"83d8890793f99e64a0e2e905665b7331eb625526","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        other_port \u003d self.create_port(other_node[\u0027uuid\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":112,"context_line":"        uuids \u003d [x[\u0027UUID\u0027] for x in port_list]"},{"line_number":113,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027], uuids)"},{"line_number":114,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], uuids)"},{"line_number":115,"context_line":"        addresses \u003d [x[\u0027Address\u0027] for x in port_list]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_c5a98d7d","line":112,"in_reply_to":"9ad45d7e_76ace735","updated":"2016-08-12 20:41:35.000000000","message":"Thanks for example!","commit_id":"e38b66883359ec0af9974de8fb9fcc60b02d4512"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3396e2ea22e9ecbe20864352848c5a68f3c1d240","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], uuids)"},{"line_number":115,"context_line":"        addresses \u003d [x[\u0027Address\u0027] for x in port_list]"},{"line_number":116,"context_line":"        self.assertIn(self.port[\u0027address\u0027], addresses)"},{"line_number":117,"context_line":"        self.assertIn(other_port[\u0027address\u0027], addresses)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_d6a95326","line":117,"updated":"2016-08-12 16:11:10.000000000","message":"ditto","commit_id":"e38b66883359ec0af9974de8fb9fcc60b02d4512"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"83d8890793f99e64a0e2e905665b7331eb625526","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.assertIn(other_port[\u0027uuid\u0027], uuids)"},{"line_number":115,"context_line":"        addresses \u003d [x[\u0027Address\u0027] for x in port_list]"},{"line_number":116,"context_line":"        self.assertIn(self.port[\u0027address\u0027], addresses)"},{"line_number":117,"context_line":"        self.assertIn(other_port[\u0027address\u0027], addresses)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_25b509d0","line":117,"in_reply_to":"9ad45d7e_d6a95326","updated":"2016-08-12 20:41:35.000000000","message":"Done","commit_id":"e38b66883359ec0af9974de8fb9fcc60b02d4512"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a587e1247611e63a27bd97e30258ee06f2f9da46","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def test_port_list(self):"},{"line_number":101,"context_line":"        \"\"\"Test steps:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            1) create node and port in setUp()"},{"line_number":104,"context_line":"            2) create one more node and port explicitly"},{"line_number":105,"context_line":"            3) check that port-list contains UUIDs of created ports"},{"line_number":106,"context_line":"            4) check that port-list contains Addresses of created ports"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a77a97e_ea0ed639","line":103,"updated":"2016-11-17 14:19:35.000000000","message":"I think we may do not create a new port and use existed.","commit_id":"fe4fe017a047358930f3f01c0a5099dc641fc2a3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b79e98e03954c37afd38bdcf7d7853315c1e9545","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":112,"context_line":"        uuids \u003d {x[\u0027UUID\u0027] for x in port_list}"},{"line_number":113,"context_line":"        self.assertTrue({self.port[\u0027uuid\u0027],"},{"line_number":114,"context_line":"                         other_port[\u0027uuid\u0027]}.issubset(uuids))"},{"line_number":115,"context_line":"        addresses \u003d {x[\u0027Address\u0027] for x in port_list}"},{"line_number":116,"context_line":"        self.assertTrue({self.port[\u0027address\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a77a97e_eab4ba82","line":113,"updated":"2016-11-20 16:02:43.000000000","message":"nit: I\u0027d prefer we use assertIn(), it would give better error messages","commit_id":"fe4fe017a047358930f3f01c0a5099dc641fc2a3"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"27ed8d3f676ea58179d898e484d0b929c3d9411c","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":112,"context_line":"        uuids \u003d {x[\u0027UUID\u0027] for x in port_list}"},{"line_number":113,"context_line":"        self.assertTrue({self.port[\u0027uuid\u0027],"},{"line_number":114,"context_line":"                         other_port[\u0027uuid\u0027]}.issubset(uuids))"},{"line_number":115,"context_line":"        addresses \u003d {x[\u0027Address\u0027] for x in port_list}"},{"line_number":116,"context_line":"        self.assertTrue({self.port[\u0027address\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a77a97e_93678f24","line":113,"updated":"2016-11-16 17:22:54.000000000","message":"why not assert the sets are equal?","commit_id":"fe4fe017a047358930f3f01c0a5099dc641fc2a3"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"54b800c03e29a8c69c9db6388d8c1edd5eaba80d","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        port_list \u003d self.list_ports()"},{"line_number":112,"context_line":"        uuids \u003d {x[\u0027UUID\u0027] for x in port_list}"},{"line_number":113,"context_line":"        self.assertTrue({self.port[\u0027uuid\u0027],"},{"line_number":114,"context_line":"                         other_port[\u0027uuid\u0027]}.issubset(uuids))"},{"line_number":115,"context_line":"        addresses \u003d {x[\u0027Address\u0027] for x in port_list}"},{"line_number":116,"context_line":"        self.assertTrue({self.port[\u0027address\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a77a97e_aeb180e3","line":113,"in_reply_to":"7a77a97e_93678f24","updated":"2016-11-16 17:35:56.000000000","message":"In case of assertEqual() test will fail when environment contains several other nodes except of created in test.","commit_id":"fe4fe017a047358930f3f01c0a5099dc641fc2a3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b79e98e03954c37afd38bdcf7d7853315c1e9545","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.assertTrue({self.port[\u0027uuid\u0027],"},{"line_number":114,"context_line":"                         other_port[\u0027uuid\u0027]}.issubset(uuids))"},{"line_number":115,"context_line":"        addresses \u003d {x[\u0027Address\u0027] for x in port_list}"},{"line_number":116,"context_line":"        self.assertTrue({self.port[\u0027address\u0027],"},{"line_number":117,"context_line":"                         other_port[\u0027address\u0027]}.issubset(addresses))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a77a97e_0ab81674","line":116,"updated":"2016-11-20 16:02:43.000000000","message":"ditto","commit_id":"fe4fe017a047358930f3f01c0a5099dc641fc2a3"}]}
