)]}'
{"ironicclient/tests/functional/test_driver.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"156f9fd8757751fbf297d8eb4d5042620afb740b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        1) get list of drivers"},{"line_number":51,"context_line":"        2) check that list contains expected drivers"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        wanted_drivers \u003d {u\u0027fake\u0027, u\u0027agent_ipmitool\u0027}"},{"line_number":54,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":55,"context_line":"        for driver in wanted_drivers:"},{"line_number":56,"context_line":"            self.assertIn(driver, available_drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8b1c7014","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":53},"updated":"2016-06-23 14:08:30.000000000","message":"I won\u0027t do this, functional tests run against real deployment, you can\u0027t know available drivers","commit_id":"1365844a01fd7f2e8e216e721fcf71501fb378f8"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ca02392027d2ee636abf43cb22461a1e50b9efea","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        1) get list of drivers"},{"line_number":51,"context_line":"        2) check that list contains expected drivers"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        wanted_drivers \u003d {u\u0027fake\u0027, u\u0027agent_ipmitool\u0027}"},{"line_number":54,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":55,"context_line":"        for driver in wanted_drivers:"},{"line_number":56,"context_line":"            self.assertIn(driver, available_drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b0955088","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":53},"in_reply_to":"3aaa91ec_8b1c7014","updated":"2016-06-23 15:21:55.000000000","message":"Then i suppose we can expect at least only \u0027fake\u0027 driver on environment?","commit_id":"1365844a01fd7f2e8e216e721fcf71501fb378f8"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"7aec9ae919439405d6e8813ed923a497e4a8a919","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        1) get list of drivers"},{"line_number":51,"context_line":"        2) check that list contains expected drivers"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        wanted_drivers \u003d {u\u0027fake\u0027, u\u0027agent_ipmitool\u0027}"},{"line_number":54,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":55,"context_line":"        for driver in wanted_drivers:"},{"line_number":56,"context_line":"            self.assertIn(driver, available_drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_d0e9fce7","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":53},"in_reply_to":"3aaa91ec_b0955088","updated":"2016-06-23 15:24:47.000000000","message":"we can\u0027t guarantee this","commit_id":"1365844a01fd7f2e8e216e721fcf71501fb378f8"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"20d63506ee53a0984e67e6aaf8b6b4086e0b2bfe","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        wanted_drivers \u003d {u\u0027fake\u0027, u\u0027agent_ipmitool\u0027}"},{"line_number":54,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":55,"context_line":"        for driver in wanted_drivers:"},{"line_number":56,"context_line":"            self.assertIn(driver, available_drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_bfb55832","line":55,"updated":"2016-06-22 17:56:59.000000000","message":"I think you can just inline the variable wanted_drivers here.","commit_id":"1365844a01fd7f2e8e216e721fcf71501fb378f8"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"20d63506ee53a0984e67e6aaf8b6b4086e0b2bfe","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        wanted_drivers \u003d {u\u0027fake\u0027, u\u0027agent_ipmitool\u0027}"},{"line_number":54,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":55,"context_line":"        for driver in wanted_drivers:"},{"line_number":56,"context_line":"            self.assertIn(driver, available_drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1f83cc57","line":56,"updated":"2016-06-22 17:56:59.000000000","message":"You\u0027re testing that wanted_drivers \u003c available_drivers, but not that available_drivers \u003c wanted_drivers. Instead you could do `self.assertEqual(wanted_drivers, set(available_drivers))`.","commit_id":"1365844a01fd7f2e8e216e721fcf71501fb378f8"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"3aec06213ecf9a148788f3ca1d6dab17a7bf53f2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        wanted_drivers \u003d {u\u0027fake\u0027, u\u0027agent_ipmitool\u0027}"},{"line_number":54,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":55,"context_line":"        for driver in wanted_drivers:"},{"line_number":56,"context_line":"            self.assertIn(driver, available_drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_63833657","line":56,"in_reply_to":"3aaa91ec_1f83cc57","updated":"2016-06-23 11:37:30.000000000","message":"I suppose we need to check assertIn(), not assertEqual(), because testing environment may contain more other drivers than basic set of \u0027fake\u0027 and \u0027agent_ipmitool\u0027. Is it right?","commit_id":"1365844a01fd7f2e8e216e721fcf71501fb378f8"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"9d6babfef11236bb5a89c5d3fe3b1009cf8b1ef4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        wanted_drivers \u003d {u\u0027fake\u0027, u\u0027agent_ipmitool\u0027}"},{"line_number":54,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":55,"context_line":"        for driver in wanted_drivers:"},{"line_number":56,"context_line":"            self.assertIn(driver, available_drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_60968cf1","line":56,"in_reply_to":"3aaa91ec_1f83cc57","updated":"2016-06-23 11:31:01.000000000","message":"Thanks!","commit_id":"1365844a01fd7f2e8e216e721fcf71501fb378f8"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"1c9062af7cf87dc74d3acb79e55ccf9a3b64f1ec","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        wanted_drivers \u003d {u\u0027fake\u0027, u\u0027agent_ipmitool\u0027}"},{"line_number":54,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":55,"context_line":"        for driver in wanted_drivers:"},{"line_number":56,"context_line":"            self.assertIn(driver, available_drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_fbe5cd37","line":56,"in_reply_to":"3aaa91ec_5662243f","updated":"2016-06-24 10:53:17.000000000","message":"Then let\u0027s simply check that list of drivers is not empty.","commit_id":"1365844a01fd7f2e8e216e721fcf71501fb378f8"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"c505fae12a72816236b71c1fb761ad872a20de19","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        wanted_drivers \u003d {u\u0027fake\u0027, u\u0027agent_ipmitool\u0027}"},{"line_number":54,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":55,"context_line":"        for driver in wanted_drivers:"},{"line_number":56,"context_line":"            self.assertIn(driver, available_drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5662243f","line":56,"in_reply_to":"3aaa91ec_63833657","updated":"2016-06-23 15:48:57.000000000","message":"From what Anton is saying, we don\u0027t know *anything* about the set of available drivers in general :-(","commit_id":"1365844a01fd7f2e8e216e721fcf71501fb378f8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d6f2b626c226db6d14b1c5b6a917fbca71254273","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        2) check that list of drivers is not empty"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":54,"context_line":"        self.assertTrue(len(available_drivers) \u003e 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_2c25130a","line":54,"updated":"2016-06-27 12:05:31.000000000","message":"these tests assume that at least \u0027fake\u0027 is present, so we can check it here as well","commit_id":"75b0d57e11ed225f225778f0aec9ef5504f873eb"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ca0c125f057fca87408ab5fcb7e3baf27cd7a2ec","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        2) check that list of drivers is not empty"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        available_drivers \u003d self.get_drivers_names()"},{"line_number":54,"context_line":"        self.assertTrue(len(available_drivers) \u003e 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_77e8097d","line":54,"in_reply_to":"3aaa91ec_2c25130a","updated":"2016-06-29 10:33:26.000000000","message":"Thanks!","commit_id":"75b0d57e11ed225f225778f0aec9ef5504f873eb"}]}
