)]}'
{"ironicclient/tests/functional/osc/v1/test_baremetal_basic.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"35ba9ba886632306d03c42292ac567d2caee9c5f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        \"\"\"Check baremetal node reboot command."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        Test steps:"},{"line_number":118,"context_line":"        1) Create baremetal node in setUp."},{"line_number":119,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":120,"context_line":"        3) Check node Power State in node properties."},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        prop \u003d \"power_state\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_d6a72309","line":119,"range":{"start_line":118,"start_character":8,"end_line":119,"end_character":50},"updated":"2016-07-12 04:54:48.000000000","message":"This steps is the case that initial power state is \"off\" because the node is just created.\n\nWe need to consider the other case that initial power state is \"on\".\n\nSo reboot test cases should be 1)\"OFF\" -\u003e reboot \"ON\", and 2)\"ON\" -\u003e reboot -\u003e \"ON\".","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"6eeb7f9e6dc4d88b0ea2baa29e5c0324b17cb9e4","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        \"\"\"Check baremetal node reboot command."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        Test steps:"},{"line_number":118,"context_line":"        1) Create baremetal node in setUp."},{"line_number":119,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":120,"context_line":"        3) Check node Power State in node properties."},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        prop \u003d \"power_state\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_2ba355b3","line":119,"range":{"start_line":118,"start_character":8,"end_line":119,"end_character":50},"in_reply_to":"1aa78d24_c57bd0bc","updated":"2016-07-13 09:56:02.000000000","message":"Why don\u0027t we put the assertion for the fake driver?\n\nself.assertIn(\"None\",\n                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"c4519548e02ed8577ef3e49b49a97e161ae2ffd4","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        \"\"\"Check baremetal node reboot command."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        Test steps:"},{"line_number":118,"context_line":"        1) Create baremetal node in setUp."},{"line_number":119,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":120,"context_line":"        3) Check node Power State in node properties."},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        prop \u003d \"power_state\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_c57bd0bc","line":119,"range":{"start_line":118,"start_character":8,"end_line":119,"end_character":50},"in_reply_to":"1aa78d24_d6a72309","updated":"2016-07-12 14:20:57.000000000","message":"Should i set initial power states in test forcibly as it has None value after nodes creation?","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"35ba9ba886632306d03c42292ac567d2caee9c5f","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        3) Check node Power State in node properties."},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        prop \u003d \"power_state\""},{"line_number":137,"context_line":"        prop_value \u003d \"power on\""},{"line_number":138,"context_line":"        self.openstack(\u0027baremetal node power on {0}\u0027"},{"line_number":139,"context_line":"                       .format(self.node[\u0027uuid\u0027]))"},{"line_number":140,"context_line":"        self.assertIn(prop_value,"},{"line_number":141,"context_line":"                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_565053d4","line":139,"range":{"start_line":137,"start_character":7,"end_line":139,"end_character":50},"updated":"2016-07-12 04:54:48.000000000","message":"We would need to assert that the prop is \"power off\" before calling the power on cli.\n\n self.assertIn(\"power off\",\n                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"6eeb7f9e6dc4d88b0ea2baa29e5c0324b17cb9e4","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        3) Check node Power State in node properties."},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        prop \u003d \"power_state\""},{"line_number":137,"context_line":"        prop_value \u003d \"power on\""},{"line_number":138,"context_line":"        self.openstack(\u0027baremetal node power on {0}\u0027"},{"line_number":139,"context_line":"                       .format(self.node[\u0027uuid\u0027]))"},{"line_number":140,"context_line":"        self.assertIn(prop_value,"},{"line_number":141,"context_line":"                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_2b3995a4","line":139,"range":{"start_line":137,"start_character":7,"end_line":139,"end_character":50},"in_reply_to":"1aa78d24_565053d4","updated":"2016-07-13 09:56:02.000000000","message":"So the assertion should be the following for the fake driver, right?\n\nself.assertIn(\"None\",\n                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"35ba9ba886632306d03c42292ac567d2caee9c5f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Test steps:"},{"line_number":147,"context_line":"        1) Create baremetal node in setUp."},{"line_number":148,"context_line":"        2) Set power OFF for baremetal node."},{"line_number":149,"context_line":"        3) Check node Power State in node properties."},{"line_number":150,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_16952b86","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":42},"updated":"2016-07-12 04:54:48.000000000","message":"The node power state is \"OFF\" because the node is just created in setup().\nSo we need to power it on first, then call power off cli.","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3b68f2dccd3e04fe4902328cba09a1f46dcffe3e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Test steps:"},{"line_number":147,"context_line":"        1) Create baremetal node in setUp."},{"line_number":148,"context_line":"        2) Set power OFF for baremetal node."},{"line_number":149,"context_line":"        3) Check node Power State in node properties."},{"line_number":150,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_b3da2176","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":42},"in_reply_to":"1aa78d24_05667850","updated":"2016-07-13 08:25:40.000000000","message":"Yup, power state is always None for fake driver - FakePower.get_power_state just does return node.power_state which is None by default, and is not updated because what is returned by get_power_state matches what is in DB.","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"86d6afe56741aee43c9d9a9c69500d4132c1bf92","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Test steps:"},{"line_number":147,"context_line":"        1) Create baremetal node in setUp."},{"line_number":148,"context_line":"        2) Set power OFF for baremetal node."},{"line_number":149,"context_line":"        3) Check node Power State in node properties."},{"line_number":150,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_81ebca11","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":42},"in_reply_to":"1aa78d24_0939d33f","updated":"2016-07-15 12:47:07.000000000","message":"Done","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"61bdba311c257db841c6a3b8afcc5e4021c71f6a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Test steps:"},{"line_number":147,"context_line":"        1) Create baremetal node in setUp."},{"line_number":148,"context_line":"        2) Set power OFF for baremetal node."},{"line_number":149,"context_line":"        3) Check node Power State in node properties."},{"line_number":150,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_8610804f","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":42},"in_reply_to":"1aa78d24_0b0ad9d1","updated":"2016-07-13 10:14:24.000000000","message":"Naohiro,\n\nthe purpose of this functional tests are client testing, we don\u0027t test ironic fake driver itself, it\u0027s used as test environment background, and helps to verify that cli commands work.\n\nSo, we can make such asserts, but why? \nMore interesting would be negative test here, while node in diff states.","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"2e315fa08f923d9f89ca89d523dadfbb3be5cc46","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Test steps:"},{"line_number":147,"context_line":"        1) Create baremetal node in setUp."},{"line_number":148,"context_line":"        2) Set power OFF for baremetal node."},{"line_number":149,"context_line":"        3) Check node Power State in node properties."},{"line_number":150,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_05667850","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":42},"in_reply_to":"1aa78d24_16952b86","updated":"2016-07-12 14:17:51.000000000","message":"Hello, Naohiro. When i create new node i have power_state in None:\n$ openstack baremetal node create --driver fake --name new\n$ openstack baremetal node show -c power_state new                       \n+-------------+-------+\n| Field       | Value |\n+-------------+-------+\n| power_state | None  |\n+-------------+-------+","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"c2f4bebd479c25673af357c433da429142c7505f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Test steps:"},{"line_number":147,"context_line":"        1) Create baremetal node in setUp."},{"line_number":148,"context_line":"        2) Set power OFF for baremetal node."},{"line_number":149,"context_line":"        3) Check node Power State in node properties."},{"line_number":150,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_588f312e","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":42},"in_reply_to":"1aa78d24_3cf6c6f9","updated":"2016-07-14 21:44:06.000000000","message":"I think to omit initial \"None\" powerstate assertion because i`m not sure that it will be kept the same in future. \nBut i like to add tests with sequences OFF-reboot-ON, and ON-reboot-ON that you have proposed, because it is a realistic usecase.","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"4f7b441b50e32d900e2774c094f541cd9a22311b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Test steps:"},{"line_number":147,"context_line":"        1) Create baremetal node in setUp."},{"line_number":148,"context_line":"        2) Set power OFF for baremetal node."},{"line_number":149,"context_line":"        3) Check node Power State in node properties."},{"line_number":150,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_0939d33f","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":42},"in_reply_to":"1aa78d24_588f312e","updated":"2016-07-15 05:44:50.000000000","message":"Kyrylo,\n\n\u003e I think to omit initial \"None\" powerstate assertion because i`m not sure that it will be kept the same in future.\n\nOkay, I agree with you because I\u0027m not sure either :-)\n\n\u003e But i like to add tests with sequences OFF-reboot-ON, and ON-reboot-ON that you have proposed, because it is a realistic usecase.\n\nOkay, thanks for the consideration.\n\nBest regards,\nNaohiro","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f478b16bd3d5ee46ec71ce5006719aaec8f3539a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Test steps:"},{"line_number":147,"context_line":"        1) Create baremetal node in setUp."},{"line_number":148,"context_line":"        2) Set power OFF for baremetal node."},{"line_number":149,"context_line":"        3) Check node Power State in node properties."},{"line_number":150,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_3cf6c6f9","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":42},"in_reply_to":"1aa78d24_8610804f","updated":"2016-07-14 05:22:15.000000000","message":"Hi Anton,\n\nThanks for the comment.\n\n\u003e So, we can make such asserts, but why? \n\nThat\u0027s because the power state command changes the state from \u0027A\u0027 to \u0027B\u0027, so I simply thought that we would need to assert both pre state \u0027A\u0027 and post state \u0027B\u0027 beyond the cli execution regardless of driver.\n\nWDYT?\n\nBest regards,\nNaohiro","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"6eeb7f9e6dc4d88b0ea2baa29e5c0324b17cb9e4","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        Test steps:"},{"line_number":147,"context_line":"        1) Create baremetal node in setUp."},{"line_number":148,"context_line":"        2) Set power OFF for baremetal node."},{"line_number":149,"context_line":"        3) Check node Power State in node properties."},{"line_number":150,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_0b0ad9d1","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":42},"in_reply_to":"1aa78d24_b3da2176","updated":"2016-07-13 09:56:02.000000000","message":"Kyrylo, Vladyslav,\n\nThanks for the comments, Okay, I got how fake driver behaves.\n\npower on/off/reboot involve power state change, so why don\u0027t we insert\nthe assertion of \"None\" before calling the power cli?\n\nself.assertIn(\"None\",\n                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))\n\nBest regards,\nNaohiro","commit_id":"19945f99266f7d71214fddb7f4ae6a97c7c93cc4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"c1c97c32257d2189aeff904f92e758e9ecea1718","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        Test steps:"},{"line_number":118,"context_line":"        1) Create baremetal node in setUp."},{"line_number":119,"context_line":"        2) Set node Power State OFF as precondition."},{"line_number":120,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":121,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        prop \u003d \"power_state\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_25e16eff","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":9},"updated":"2016-07-19 05:47:27.000000000","message":"nit s/2/3/","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fd2e4d2a9510c4a0972d64b4a2e49897f62dba90","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        Test steps:"},{"line_number":118,"context_line":"        1) Create baremetal node in setUp."},{"line_number":119,"context_line":"        2) Set node Power State OFF as precondition."},{"line_number":120,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":121,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        prop \u003d \"power_state\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_79eace10","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":9},"in_reply_to":"dada55a8_25e16eff","updated":"2016-07-19 16:58:31.000000000","message":"Thanks for catch!","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"c1c97c32257d2189aeff904f92e758e9ecea1718","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        1) Create baremetal node in setUp."},{"line_number":119,"context_line":"        2) Set node Power State OFF as precondition."},{"line_number":120,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":121,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        prop \u003d \"power_state\""},{"line_number":124,"context_line":"        self.openstack(\u0027baremetal node power off {0}\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_a5ed5ef1","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":9},"updated":"2016-07-19 05:47:27.000000000","message":"nit s/3/4/","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fd2e4d2a9510c4a0972d64b4a2e49897f62dba90","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        1) Create baremetal node in setUp."},{"line_number":119,"context_line":"        2) Set node Power State OFF as precondition."},{"line_number":120,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":121,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        prop \u003d \"power_state\""},{"line_number":124,"context_line":"        self.openstack(\u0027baremetal node power off {0}\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_f9debe6b","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":9},"in_reply_to":"dada55a8_a5ed5ef1","updated":"2016-07-19 16:58:31.000000000","message":"Done","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"c1c97c32257d2189aeff904f92e758e9ecea1718","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        prop \u003d \"power_state\""},{"line_number":124,"context_line":"        self.openstack(\u0027baremetal node power off {0}\u0027"},{"line_number":125,"context_line":"                       .format(self.node[\u0027uuid\u0027]))"},{"line_number":126,"context_line":"        self.assertIn(\u0027power off\u0027,"},{"line_number":127,"context_line":"                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.openstack(\u0027baremetal node reboot {0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":130,"context_line":"        self.assertIn(\u0027power on\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_25396e42","line":127,"range":{"start_line":124,"start_character":8,"end_line":127,"end_character":69},"updated":"2016-07-19 05:47:27.000000000","message":"These codes are same as test_power_off().\nWouldn\u0027t it be just simpler to call test_power_off()?","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fd2e4d2a9510c4a0972d64b4a2e49897f62dba90","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        prop \u003d \"power_state\""},{"line_number":124,"context_line":"        self.openstack(\u0027baremetal node power off {0}\u0027"},{"line_number":125,"context_line":"                       .format(self.node[\u0027uuid\u0027]))"},{"line_number":126,"context_line":"        self.assertIn(\u0027power off\u0027,"},{"line_number":127,"context_line":"                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.openstack(\u0027baremetal node reboot {0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":130,"context_line":"        self.assertIn(\u0027power on\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_d9cada6d","line":127,"range":{"start_line":124,"start_character":8,"end_line":127,"end_character":69},"in_reply_to":"dada55a8_25396e42","updated":"2016-07-19 16:58:31.000000000","message":"Tests unlike to regular python functions are not to be called one from another, they should be run independently.","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"835145450a8a5655cde97575d590e38474c23cb7","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        prop \u003d \"power_state\""},{"line_number":124,"context_line":"        self.openstack(\u0027baremetal node power off {0}\u0027"},{"line_number":125,"context_line":"                       .format(self.node[\u0027uuid\u0027]))"},{"line_number":126,"context_line":"        self.assertIn(\u0027power off\u0027,"},{"line_number":127,"context_line":"                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.openstack(\u0027baremetal node reboot {0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":130,"context_line":"        self.assertIn(\u0027power on\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_592373a7","line":127,"range":{"start_line":124,"start_character":8,"end_line":127,"end_character":69},"in_reply_to":"dada55a8_d9cada6d","updated":"2016-07-20 04:36:22.000000000","message":"Oh I see, I understood, thanks.","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"c1c97c32257d2189aeff904f92e758e9ecea1718","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        Test steps:"},{"line_number":137,"context_line":"        1) Create baremetal node in setUp."},{"line_number":138,"context_line":"        2) Set node Power State ON as precondition."},{"line_number":139,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":140,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        prop \u003d \"power_state\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_05d42a1e","line":139,"range":{"start_line":139,"start_character":8,"end_line":139,"end_character":9},"updated":"2016-07-19 05:47:27.000000000","message":"nit: s/2/3/","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fd2e4d2a9510c4a0972d64b4a2e49897f62dba90","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        Test steps:"},{"line_number":137,"context_line":"        1) Create baremetal node in setUp."},{"line_number":138,"context_line":"        2) Set node Power State ON as precondition."},{"line_number":139,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":140,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        prop \u003d \"power_state\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_19e47239","line":139,"range":{"start_line":139,"start_character":8,"end_line":139,"end_character":9},"in_reply_to":"dada55a8_05d42a1e","updated":"2016-07-19 16:58:31.000000000","message":"Done","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"c1c97c32257d2189aeff904f92e758e9ecea1718","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        1) Create baremetal node in setUp."},{"line_number":138,"context_line":"        2) Set node Power State ON as precondition."},{"line_number":139,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":140,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        prop \u003d \"power_state\""},{"line_number":143,"context_line":"        self.openstack(\u0027baremetal node power on {0}\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_e5d63626","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":9},"updated":"2016-07-19 05:47:27.000000000","message":"nit s/3/4/","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fd2e4d2a9510c4a0972d64b4a2e49897f62dba90","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        1) Create baremetal node in setUp."},{"line_number":138,"context_line":"        2) Set node Power State ON as precondition."},{"line_number":139,"context_line":"        2) Call reboot command for baremetal node."},{"line_number":140,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        prop \u003d \"power_state\""},{"line_number":143,"context_line":"        self.openstack(\u0027baremetal node power on {0}\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_79d12e57","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":9},"in_reply_to":"dada55a8_e5d63626","updated":"2016-07-19 16:58:31.000000000","message":"Done","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"c1c97c32257d2189aeff904f92e758e9ecea1718","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        prop \u003d \"power_state\""},{"line_number":143,"context_line":"        self.openstack(\u0027baremetal node power on {0}\u0027"},{"line_number":144,"context_line":"                       .format(self.node[\u0027uuid\u0027]))"},{"line_number":145,"context_line":"        self.assertIn(\u0027power on\u0027,"},{"line_number":146,"context_line":"                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        self.openstack(\u0027baremetal node reboot {0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":149,"context_line":"        self.assertIn(\u0027power on\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_e5e0f6ce","line":146,"range":{"start_line":143,"start_character":8,"end_line":146,"end_character":69},"updated":"2016-07-19 05:47:27.000000000","message":"These codes are same as test_power_on().\nWouldn\u0027t it be just simpler to call test_power_on()?","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fd2e4d2a9510c4a0972d64b4a2e49897f62dba90","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        3) Check node Power State ON in node properties."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        prop \u003d \"power_state\""},{"line_number":143,"context_line":"        self.openstack(\u0027baremetal node power on {0}\u0027"},{"line_number":144,"context_line":"                       .format(self.node[\u0027uuid\u0027]))"},{"line_number":145,"context_line":"        self.assertIn(\u0027power on\u0027,"},{"line_number":146,"context_line":"                      self.baremetal_show(self.node[\u0027uuid\u0027], [prop]))"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        self.openstack(\u0027baremetal node reboot {0}\u0027.format(self.node[\u0027uuid\u0027]))"},{"line_number":149,"context_line":"        self.assertIn(\u0027power on\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_f9d23eff","line":146,"range":{"start_line":143,"start_character":8,"end_line":146,"end_character":69},"in_reply_to":"dada55a8_e5e0f6ce","updated":"2016-07-19 16:58:31.000000000","message":"Naohiro, please look my comment above.","commit_id":"bb38fbe297b55104da093b9fa3913d9924b888c1"}],"ironicclient/tests/functional/osc/v1/test_baremetal_node_power_states.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6aa4a8e1bd94e1047b18bac8b7132a83142590ab","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        show_prop \u003d self.node_show(self.node[\u0027uuid\u0027], [\u0027power_state\u0027])"},{"line_number":58,"context_line":"        self.assertEqual(\u0027power on\u0027, show_prop[\u0027power_state\u0027])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_power_on(self):"},{"line_number":61,"context_line":"        \"\"\"Check baremetal node power on command."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        Test steps:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_480d543d","line":60,"updated":"2016-11-24 15:22:12.000000000","message":"this is covered by test_on_reboot_on","commit_id":"ff9e0f8271aef53355af902ba5e418cb459571bc"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"0233c469150256c8fad35b3b2ebc780ba7b32250","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        show_prop \u003d self.node_show(self.node[\u0027uuid\u0027], [\u0027power_state\u0027])"},{"line_number":58,"context_line":"        self.assertEqual(\u0027power on\u0027, show_prop[\u0027power_state\u0027])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_power_on(self):"},{"line_number":61,"context_line":"        \"\"\"Check baremetal node power on command."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        Test steps:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_e377239d","line":60,"in_reply_to":"5a74a57a_480d543d","updated":"2016-11-24 15:25:53.000000000","message":"Thanks! I am removing these both excessive test cases.","commit_id":"ff9e0f8271aef53355af902ba5e418cb459571bc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6aa4a8e1bd94e1047b18bac8b7132a83142590ab","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        show_prop \u003d self.node_show(self.node[\u0027uuid\u0027], [\u0027power_state\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(\u0027power on\u0027, show_prop[\u0027power_state\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_power_off(self):"},{"line_number":73,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        Test steps:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_6808502e","line":72,"updated":"2016-11-24 15:22:12.000000000","message":"this is covered by test_off_reboot_on","commit_id":"ff9e0f8271aef53355af902ba5e418cb459571bc"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"0233c469150256c8fad35b3b2ebc780ba7b32250","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        show_prop \u003d self.node_show(self.node[\u0027uuid\u0027], [\u0027power_state\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(\u0027power on\u0027, show_prop[\u0027power_state\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_power_off(self):"},{"line_number":73,"context_line":"        \"\"\"Check baremetal node power off command."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        Test steps:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_2372fbad","line":72,"in_reply_to":"5a74a57a_6808502e","updated":"2016-11-24 15:25:53.000000000","message":"Done","commit_id":"ff9e0f8271aef53355af902ba5e418cb459571bc"}]}