)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a362578a52ea36f2873a3c585ce63c29104b47b9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Verify JSON response of chassis commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Test JSON response output to console for commands:"},{"line_number":10,"context_line":"chassis-list,"},{"line_number":11,"context_line":"chassis-show,"},{"line_number":12,"context_line":"chassis-create,"},{"line_number":13,"context_line":"chassis-update,"},{"line_number":14,"context_line":"chassis-node-list."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partial-Bug: #1555680"},{"line_number":17,"context_line":"Change-Id: Ib04d41a3f72af8c4783eff826641084774c927c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa7ab95a_0e82c800","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":17},"updated":"2016-08-26 03:06:58.000000000","message":"We need to add the followings to the list:\n\ndriver-list\ndriver-show\ndriver-properties","commit_id":"ed1255c57130b0d8f8a613a9014b3eae092cce2c"}],"ironicclient/tests/functional/test_json_response.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"2ba4338df331dcf9aefa4dd57a3dfee2b2c9fc03","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.assertTrue(is_valid_json(response, self.node_schema))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"class TestChassisJsonResponse(base.FunctionalTestBase):"},{"line_number":163,"context_line":"    \"\"\"Test JSON responses for chassis commands.\"\"\""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    chassis_schema \u003d {"},{"line_number":166,"context_line":"        \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a267d4e7","line":163,"range":{"start_line":162,"start_character":0,"end_line":163,"end_character":51},"updated":"2016-07-20 06:54:47.000000000","message":"According to the Ironic cli reference [1], it seems that\nchassis-delete and chassis-node-list are not covered here.\nEven if these two commands didn\u0027t support \u0027--json\u0027 flag, would it be\nbetter to assert their outputs such as error message?\n\n[1] http://docs.openstack.org/cli-reference/ironic.html\nironic chassis-create\nironic chassis-delete\nironic chassis-list\nironic chassis-node-list\nironic chassis-show\nironic chassis-update","commit_id":"3e727b739a72e4d68ca94e4ea1ea9c759f4ee865"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d38e313658bbff417b86994c5d08a5fcc6311220","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.assertTrue(is_valid_json(response, self.node_schema))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"class TestChassisJsonResponse(base.FunctionalTestBase):"},{"line_number":163,"context_line":"    \"\"\"Test JSON responses for chassis commands.\"\"\""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    chassis_schema \u003d {"},{"line_number":166,"context_line":"        \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_04cdecb6","line":163,"range":{"start_line":162,"start_character":0,"end_line":163,"end_character":51},"in_reply_to":"dada55a8_a267d4e7","updated":"2016-07-20 16:21:30.000000000","message":"Thanks for review!\n1) Commands which do not support JSON outputs simply ignore \"--json\" flag giving their usual output. Their usual work is covered in other CLI tests (some merged, some are on review).\n2) Thanks for reminding me about chassis-node-list, i`ll add it to this patch :)","commit_id":"3e727b739a72e4d68ca94e4ea1ea9c759f4ee865"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"16e3dd6cc58f5194df827c5ba4d1a2855fd72b8b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        \"properties\": {"},{"line_number":172,"context_line":"            \"uuid\": {\"type\": \"string\"},"},{"line_number":173,"context_line":"            \"updated_at\": {\"type\": [\"string\", \"null\"]},"},{"line_number":174,"context_line":"            \"created_at\": {\"type\": [\"string\", \"null\"]},"},{"line_number":175,"context_line":"            \"description\": {\"type\": [\"string\", \"null\"]},"},{"line_number":176,"context_line":"            \"extra\": {\"type\": \"object\"}}"},{"line_number":177,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_1877e302","line":174,"range":{"start_line":174,"start_character":46,"end_line":174,"end_character":52},"updated":"2016-08-01 15:59:32.000000000","message":"I don\u0027t think created_at can be null, if you can see the chassis, it was created :)","commit_id":"44269a2be2b3b7818c962f65c98db262014e193c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"8bd025a01dcac40669dbe781202385bc9371a75d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        \"properties\": {"},{"line_number":172,"context_line":"            \"uuid\": {\"type\": \"string\"},"},{"line_number":173,"context_line":"            \"updated_at\": {\"type\": [\"string\", \"null\"]},"},{"line_number":174,"context_line":"            \"created_at\": {\"type\": [\"string\", \"null\"]},"},{"line_number":175,"context_line":"            \"description\": {\"type\": [\"string\", \"null\"]},"},{"line_number":176,"context_line":"            \"extra\": {\"type\": \"object\"}}"},{"line_number":177,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_9a1d4c69","line":174,"range":{"start_line":174,"start_character":46,"end_line":174,"end_character":52},"in_reply_to":"bacf61ea_1877e302","updated":"2016-08-08 13:07:20.000000000","message":"Done","commit_id":"44269a2be2b3b7818c962f65c98db262014e193c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"16e3dd6cc58f5194df827c5ba4d1a2855fd72b8b","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def test_chassis_list_json(self):"},{"line_number":184,"context_line":"        \"\"\"Test JSON response for chassis list.\"\"\""},{"line_number":185,"context_line":"        schema \u003d {"},{"line_number":186,"context_line":"            \"type\": [\"array\", \"object\"],"},{"line_number":187,"context_line":"            \"properties\": {"},{"line_number":188,"context_line":"                \"uuid\": {\"type\": \"string\"},"},{"line_number":189,"context_line":"                \"description\": {\"type\": [\"null\", \"string\"]}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_98d0f3ca","line":186,"updated":"2016-08-01 15:59:32.000000000","message":"I\u0027ve posted this on some other change request, it is an array, containing objects. It should be changed this way.","commit_id":"44269a2be2b3b7818c962f65c98db262014e193c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"8bd025a01dcac40669dbe781202385bc9371a75d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def test_chassis_list_json(self):"},{"line_number":184,"context_line":"        \"\"\"Test JSON response for chassis list.\"\"\""},{"line_number":185,"context_line":"        schema \u003d {"},{"line_number":186,"context_line":"            \"type\": [\"array\", \"object\"],"},{"line_number":187,"context_line":"            \"properties\": {"},{"line_number":188,"context_line":"                \"uuid\": {\"type\": \"string\"},"},{"line_number":189,"context_line":"                \"description\": {\"type\": [\"null\", \"string\"]}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_fa5c48ef","line":186,"in_reply_to":"bacf61ea_98d0f3ca","updated":"2016-08-08 13:07:20.000000000","message":"Done","commit_id":"44269a2be2b3b7818c962f65c98db262014e193c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"16e3dd6cc58f5194df827c5ba4d1a2855fd72b8b","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                \"extra\": {\"type\": \"object\"}}"},{"line_number":209,"context_line":"        }"},{"line_number":210,"context_line":"        response \u003d self.ironic(\u0027chassis-create\u0027, flags\u003d\u0027--json\u0027, parse\u003dFalse)"},{"line_number":211,"context_line":"        self.assertTrue(_is_valid_json(response, schema))"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def test_chassis_update_json(self):"},{"line_number":214,"context_line":"        \"\"\"Test JSON response for chassis update.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_d88c2bdc","line":211,"range":{"start_line":211,"start_character":49,"end_line":211,"end_character":55},"updated":"2016-08-01 15:59:32.000000000","message":"Hm, IIRC you can use class level chassis schema?","commit_id":"44269a2be2b3b7818c962f65c98db262014e193c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"8bd025a01dcac40669dbe781202385bc9371a75d","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                \"extra\": {\"type\": \"object\"}}"},{"line_number":209,"context_line":"        }"},{"line_number":210,"context_line":"        response \u003d self.ironic(\u0027chassis-create\u0027, flags\u003d\u0027--json\u0027, parse\u003dFalse)"},{"line_number":211,"context_line":"        self.assertTrue(_is_valid_json(response, schema))"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def test_chassis_update_json(self):"},{"line_number":214,"context_line":"        \"\"\"Test JSON response for chassis update.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_3a926058","line":211,"range":{"start_line":211,"start_character":49,"end_line":211,"end_character":55},"in_reply_to":"bacf61ea_d88c2bdc","updated":"2016-08-08 13:07:20.000000000","message":"Thanks!","commit_id":"44269a2be2b3b7818c962f65c98db262014e193c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"627ed1234ef483b5cb1b8c8e610605cd7cc6d720","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    \"\"\"Test JSON responses for driver commands.\"\"\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_driver_list_json(self):"},{"line_number":170,"context_line":"        \"\"\"Test JSON response for drivers list.\"\"\""},{"line_number":171,"context_line":"        schema \u003d {"},{"line_number":172,"context_line":"            \"type\": \"array\","},{"line_number":173,"context_line":"            \"items\": {"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_2ef86ce5","line":170,"range":{"start_line":170,"start_character":34,"end_line":170,"end_character":41},"updated":"2016-08-26 02:59:24.000000000","message":"nit: s/drivers/driver/","commit_id":"ed1255c57130b0d8f8a613a9014b3eae092cce2c"}]}
