)]}'
{"ironicclient/tests/functional/test_json_response.py":[{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"32375596b0be71cf320892d9cd7795eff9c550e8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            \"properties\": {"},{"line_number":170,"context_line":"                \"name\": {\"type\": [\"string\", \"null\"]},"},{"line_number":171,"context_line":"                \"hosts\": {\"type\": [\"array\", \"string\"]},"},{"line_number":172,"context_line":"                \"links\": {\"type\": \"array\"},"},{"line_number":173,"context_line":"                \"properties\": {"},{"line_number":174,"context_line":"                    \"href\": {\"type\": \"string\"},"},{"line_number":175,"context_line":"                    \"rel\": {\"type\": \"string\"}}}"},{"line_number":176,"context_line":"        }"},{"line_number":177,"context_line":"        response \u003d self.ironic(\u0027driver-list\u0027, flags\u003d\u0027--json\u0027,"},{"line_number":178,"context_line":"                               params\u003d\u0027\u0027, parse\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_801ea809","line":175,"range":{"start_line":172,"start_character":16,"end_line":175,"end_character":47},"updated":"2016-07-07 13:19:21.000000000","message":"I don\u0027t think \"links\" is returned by the driver-list command.","commit_id":"efa47f0d93882ab37cda3dc610d896b2f00e56ec"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"794907bfde700dd0f70e8f3f7d4344c896b4f42f","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            \"properties\": {"},{"line_number":170,"context_line":"                \"name\": {\"type\": [\"string\", \"null\"]},"},{"line_number":171,"context_line":"                \"hosts\": {\"type\": [\"array\", \"string\"]},"},{"line_number":172,"context_line":"                \"links\": {\"type\": \"array\"},"},{"line_number":173,"context_line":"                \"properties\": {"},{"line_number":174,"context_line":"                    \"href\": {\"type\": \"string\"},"},{"line_number":175,"context_line":"                    \"rel\": {\"type\": \"string\"}}}"},{"line_number":176,"context_line":"        }"},{"line_number":177,"context_line":"        response \u003d self.ironic(\u0027driver-list\u0027, flags\u003d\u0027--json\u0027,"},{"line_number":178,"context_line":"                               params\u003d\u0027\u0027, parse\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_8ac7da94","line":175,"range":{"start_line":172,"start_character":16,"end_line":175,"end_character":47},"in_reply_to":"1aa78d24_801ea809","updated":"2016-07-07 15:33:07.000000000","message":"Done","commit_id":"efa47f0d93882ab37cda3dc610d896b2f00e56ec"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"32375596b0be71cf320892d9cd7795eff9c550e8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                    \"rel\": {\"type\": \"string\"}}}"},{"line_number":176,"context_line":"        }"},{"line_number":177,"context_line":"        response \u003d self.ironic(\u0027driver-list\u0027, flags\u003d\u0027--json\u0027,"},{"line_number":178,"context_line":"                               params\u003d\u0027\u0027, parse\u003dFalse)"},{"line_number":179,"context_line":"        self.assertTrue(is_valid_json(response, schema))"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_driver_show_json(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3db6fbf8","line":178,"range":{"start_line":178,"start_character":31,"end_line":178,"end_character":40},"updated":"2016-07-07 13:19:21.000000000","message":"nit: not needed since \u0027\u0027 is the default value for params.","commit_id":"efa47f0d93882ab37cda3dc610d896b2f00e56ec"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"794907bfde700dd0f70e8f3f7d4344c896b4f42f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                    \"rel\": {\"type\": \"string\"}}}"},{"line_number":176,"context_line":"        }"},{"line_number":177,"context_line":"        response \u003d self.ironic(\u0027driver-list\u0027, flags\u003d\u0027--json\u0027,"},{"line_number":178,"context_line":"                               params\u003d\u0027\u0027, parse\u003dFalse)"},{"line_number":179,"context_line":"        self.assertTrue(is_valid_json(response, schema))"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_driver_show_json(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_6ac26e86","line":178,"range":{"start_line":178,"start_character":31,"end_line":178,"end_character":40},"in_reply_to":"1aa78d24_3db6fbf8","updated":"2016-07-07 15:33:07.000000000","message":"Done","commit_id":"efa47f0d93882ab37cda3dc610d896b2f00e56ec"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9f4b8bbc5f5ab902dbdd52d91996c1061775dfee","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                \"type\": \"object\","},{"line_number":175,"context_line":"                \"properties\": {"},{"line_number":176,"context_line":"                    \"name\": {\"type\": \"string\"},"},{"line_number":177,"context_line":"                    \"hosts\": {\"type\": \"string\"},"},{"line_number":178,"context_line":"                    }}"},{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":"        response \u003d self.ironic(\u0027driver-list\u0027, flags\u003d\u0027--json\u0027, parse\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_273e548c","line":177,"updated":"2016-07-29 16:55:14.000000000","message":"Hmm, this is a strange inconsistency, might be worth changing https://github.com/openstack/python-ironicclient/blob/master/ironicclient/v1/driver_shell.py#L35 so that in case of json output, hosts are not converted to a string. Not a blocker for this patch tho.","commit_id":"c42e55bfb5070a22096ea6d07af87d77e1184e7f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9f4b8bbc5f5ab902dbdd52d91996c1061775dfee","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        \"\"\"Test JSON response for driver properties.\"\"\""},{"line_number":202,"context_line":"        schema \u003d {"},{"line_number":203,"context_line":"            \"type\": \"object\","},{"line_number":204,"context_line":"            \"items\": {\"type\": \"string\"}"},{"line_number":205,"context_line":"        }"},{"line_number":206,"context_line":"        drivers_names \u003d self.get_drivers_names()"},{"line_number":207,"context_line":"        for driver in drivers_names:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_27e494df","line":204,"updated":"2016-07-29 16:55:14.000000000","message":"This does not do what it\u0027s supposed to, \"items\" is array related property. What could be useful here instead is \n\n \"additionalProperties\": { \"type\": \"string\" }","commit_id":"c42e55bfb5070a22096ea6d07af87d77e1184e7f"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fcf6ec2580c57aea4d6716638dfa2c804189f833","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        \"\"\"Test JSON response for driver properties.\"\"\""},{"line_number":202,"context_line":"        schema \u003d {"},{"line_number":203,"context_line":"            \"type\": \"object\","},{"line_number":204,"context_line":"            \"items\": {\"type\": \"string\"}"},{"line_number":205,"context_line":"        }"},{"line_number":206,"context_line":"        drivers_names \u003d self.get_drivers_names()"},{"line_number":207,"context_line":"        for driver in drivers_names:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_432fc0a0","line":204,"in_reply_to":"bacf61ea_27e494df","updated":"2016-08-01 11:31:56.000000000","message":"Thanks!","commit_id":"c42e55bfb5070a22096ea6d07af87d77e1184e7f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3cc316477d475374f1cf4c09519dcb3ac2c72db8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                \"properties\": {"},{"line_number":176,"context_line":"                    \"name\": {\"type\": \"string\"},"},{"line_number":177,"context_line":"                    \"hosts\": {\"type\": \"string\"},"},{"line_number":178,"context_line":"                    }}"},{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":"        response \u003d self.ironic(\u0027driver-list\u0027, flags\u003d\u0027--json\u0027, parse\u003dFalse)"},{"line_number":181,"context_line":"        self.assertTrue(_is_valid_json(response, schema))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_165f6b76","line":178,"updated":"2016-08-12 16:08:18.000000000","message":"please pep8-ize indentation here","commit_id":"4e82421f00696b5b12547382189513f8b4775f76"}]}