)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"784940f7b93ee8c17702c193a5ae2b1d63b6ba31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Turivnyi \u003csturivnyi@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-14 05:20:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with Node."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Negative test for the Ironic CLI commands which checks actions with"},{"line_number":10,"context_line":"node command like use commands without arguments or with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_c3c99a7b","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":45},"updated":"2016-07-14 09:55:16.000000000","message":"Period char is not necessary at the end of first line.","commit_id":"a3cda323e6847fdb229d777ddb5dd716c79cd638"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"3e3a7c9469deffb1a8b87bf0ab07e4885e918b08","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Turivnyi \u003csturivnyi@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-14 05:20:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with Node."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Negative test for the Ironic CLI commands which checks actions with"},{"line_number":10,"context_line":"node command like use commands without arguments or with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_84082edb","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":45},"in_reply_to":"1aa78d24_c3c99a7b","updated":"2016-07-14 14:16:34.000000000","message":"Done","commit_id":"a3cda323e6847fdb229d777ddb5dd716c79cd638"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f3c49004f8802dafa0c7704066562ce3095d2225","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Negative test for the Ironic CLI commands which checks actions with"},{"line_number":10,"context_line":"node command like use commands without arguments or with"},{"line_number":11,"context_line":"incorrect arguments and check that correct error message raised."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I72ba086a080389acbda0632b5c466dfd67cb2db0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_d77b48bc","line":12,"updated":"2016-07-21 17:21:17.000000000","message":"is there a bug for this?","commit_id":"f0d72167f73984b2cc0af72ac6d8d9b9074f1158"}],"ironicclient/tests/functional/test_node_negative.py":[{"author":{"_account_id":20771,"name":"Oleksandr Berezovskyi","email":"berezovskyi.oleksandr@gmail.com","username":"berezovskyi.oleksandr"},"change_message_id":"606c2b64c5cb90fde057064cf11d102ccab5ec4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_1be022cc","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2016-07-14 11:46:29.000000000","message":"I think should be 2016","commit_id":"a3cda323e6847fdb229d777ddb5dd716c79cd638"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"3e3a7c9469deffb1a8b87bf0ab07e4885e918b08","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_a45c4af1","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"1aa78d24_1be022cc","updated":"2016-07-14 14:16:34.000000000","message":"Done","commit_id":"a3cda323e6847fdb229d777ddb5dd716c79cd638"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"2e6b90da7e5e3b04ea9d0653af6e95ccba0bd011","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class NodeNegativeTestsIronicClient(base.FunctionalTestBase):"},{"line_number":25,"context_line":"    \"\"\"Negative tests for testing actions with Node."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Negative test for the Ironic CLI commands which checks  actions with"},{"line_number":28,"context_line":"    node command like use commands without arguments or with"},{"line_number":29,"context_line":"    incorrect arguments and check that correct error message raised."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_ee491662","line":27,"range":{"start_line":27,"start_character":58,"end_line":27,"end_character":60},"updated":"2016-07-14 11:59:21.000000000","message":"excessive whitespace","commit_id":"a3cda323e6847fdb229d777ddb5dd716c79cd638"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"3e3a7c9469deffb1a8b87bf0ab07e4885e918b08","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class NodeNegativeTestsIronicClient(base.FunctionalTestBase):"},{"line_number":25,"context_line":"    \"\"\"Negative tests for testing actions with Node."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Negative test for the Ironic CLI commands which checks  actions with"},{"line_number":28,"context_line":"    node command like use commands without arguments or with"},{"line_number":29,"context_line":"    incorrect arguments and check that correct error message raised."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_e45652cd","line":27,"range":{"start_line":27,"start_character":58,"end_line":27,"end_character":60},"in_reply_to":"1aa78d24_ee491662","updated":"2016-07-14 14:16:34.000000000","message":"Done","commit_id":"a3cda323e6847fdb229d777ddb5dd716c79cd638"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fbf8029769e2f73368cbb602b2480b5453e8ad5f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @ddt.data(*data)"},{"line_number":37,"context_line":"    @ddt.unpack"},{"line_number":38,"context_line":"    def test_get_boot_device(self, value, ex_text):"},{"line_number":39,"context_line":"        six.assertRaisesRegex(self,"},{"line_number":40,"context_line":"                              exceptions.CommandFailed,"},{"line_number":41,"context_line":"                              ex_text,"},{"line_number":42,"context_line":"                              self.ironic,"},{"line_number":43,"context_line":"                              \u0027node-get-boot-device\u0027,"},{"line_number":44,"context_line":"                              params\u003dvalue)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @ddt.data(*data)"},{"line_number":47,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_aec26e84","line":44,"range":{"start_line":39,"start_character":30,"end_line":44,"end_character":43},"updated":"2016-07-14 12:03:04.000000000","message":"You can make code shorter if will not break on new strings per each argument.","commit_id":"a3cda323e6847fdb229d777ddb5dd716c79cd638"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"3e3a7c9469deffb1a8b87bf0ab07e4885e918b08","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @ddt.data(*data)"},{"line_number":37,"context_line":"    @ddt.unpack"},{"line_number":38,"context_line":"    def test_get_boot_device(self, value, ex_text):"},{"line_number":39,"context_line":"        six.assertRaisesRegex(self,"},{"line_number":40,"context_line":"                              exceptions.CommandFailed,"},{"line_number":41,"context_line":"                              ex_text,"},{"line_number":42,"context_line":"                              self.ironic,"},{"line_number":43,"context_line":"                              \u0027node-get-boot-device\u0027,"},{"line_number":44,"context_line":"                              params\u003dvalue)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @ddt.data(*data)"},{"line_number":47,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_c45b56f5","line":44,"range":{"start_line":39,"start_character":30,"end_line":44,"end_character":43},"in_reply_to":"1aa78d24_aec26e84","updated":"2016-07-14 14:16:34.000000000","message":"Done","commit_id":"a3cda323e6847fdb229d777ddb5dd716c79cd638"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f3c49004f8802dafa0c7704066562ce3095d2225","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@ddt.ddt"},{"line_number":24,"context_line":"class NodeNegativeTestsIronicClient(base.FunctionalTestBase):"},{"line_number":25,"context_line":"    \"\"\"Negative tests for testing actions with Node."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Negative test for the Ironic CLI commands which checks actions with"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_776c1c08","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":35},"updated":"2016-07-21 17:21:17.000000000","message":"raised on other reviews we use less generic name.","commit_id":"f0d72167f73984b2cc0af72ac6d8d9b9074f1158"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fcf2e835bc6c9491cb0b90bb44dceff45d14d5d1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import ddt"},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.lib import exceptions"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironicclient.tests.functional import base"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_01e30434","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":34},"updated":"2016-08-29 11:35:45.000000000","message":":( Please see the guideline - http://docs.openstack.org/developer/hacking/#imports","commit_id":"6663d9c419a8876469a6221512c20917d98f70d6"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"dc5a342cff0a074ecd6c8be37e52c1a66ee85540","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import ddt"},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.lib import exceptions"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironicclient.tests.functional import base"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_52e66ee8","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":34},"in_reply_to":"fa7ab95a_01e30434","updated":"2016-08-30 12:33:16.000000000","message":"Done","commit_id":"6663d9c419a8876469a6221512c20917d98f70d6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fcf2e835bc6c9491cb0b90bb44dceff45d14d5d1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    data \u003d ((\u0027\u0027, (r\u0027too few arguments\u0027)),"},{"line_number":33,"context_line":"            (\u00271234-1234-1234\u0027, (r\u0027could not be found\u0027)),"},{"line_number":34,"context_line":"            (\u00271234 1234\u0027, (r\u0027unrecognized arguments\u0027)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @ddt.data(*data)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_c1f83cc6","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":28},"updated":"2016-08-29 11:35:45.000000000","message":"Oh, this is true for all the negative tests that are added - it is a valid node name actually, if you want to pass an invalid one, please check the regex that does the validation on ironic side - https://github.com/openstack/ironic/blob/4f0eef646dd2c21cc325d0c23f1750df9bcecaf2/ironic/common/utils.py#L187-L194","commit_id":"6663d9c419a8876469a6221512c20917d98f70d6"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"dc5a342cff0a074ecd6c8be37e52c1a66ee85540","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    data \u003d ((\u0027\u0027, (r\u0027too few arguments\u0027)),"},{"line_number":33,"context_line":"            (\u00271234-1234-1234\u0027, (r\u0027could not be found\u0027)),"},{"line_number":34,"context_line":"            (\u00271234 1234\u0027, (r\u0027unrecognized arguments\u0027)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @ddt.data(*data)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_92d476ec","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":28},"in_reply_to":"fa7ab95a_c1f83cc6","updated":"2016-08-30 12:33:16.000000000","message":"Done","commit_id":"6663d9c419a8876469a6221512c20917d98f70d6"}],"test-requirements.txt":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c818c56ffaf52466227c6af1959b900741748d5f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"testtools\u003e\u003d1.4.0 # MIT"},{"line_number":17,"context_line":"tempest\u003e\u003d12.1.0 # Apache-2.0"},{"line_number":18,"context_line":"os-testr\u003e\u003d0.8.0 # Apache-2.0"},{"line_number":19,"context_line":"jsonschema!\u003d2.5.0,\u003c3.0.0,\u003e\u003d2.0.0 # MIT"},{"line_number":20,"context_line":"ddt\u003e\u003d1.0.1 # MIT"}],"source_content_type":"text/plain","patch_set":12,"id":"5a3905b3_01e1dafe","line":19,"updated":"2017-01-24 18:36:22.000000000","message":"Why the added requirement? AFAICT it\u0027s not used in this code?","commit_id":"ab1f413b5f0be88af172437858da1b6de2e0f96e"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"4032851eebff06a7595245354584b9a116b58a6d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"testtools\u003e\u003d1.4.0 # MIT"},{"line_number":17,"context_line":"tempest\u003e\u003d12.1.0 # Apache-2.0"},{"line_number":18,"context_line":"os-testr\u003e\u003d0.8.0 # Apache-2.0"},{"line_number":19,"context_line":"jsonschema!\u003d2.5.0,\u003c3.0.0,\u003e\u003d2.0.0 # MIT"},{"line_number":20,"context_line":"ddt\u003e\u003d1.0.1 # MIT"}],"source_content_type":"text/plain","patch_set":12,"id":"3f044301_f039ccd6","line":19,"in_reply_to":"5a3905b3_01e1dafe","updated":"2017-05-11 10:31:35.000000000","message":"Done","commit_id":"ab1f413b5f0be88af172437858da1b6de2e0f96e"}]}
