)]}'
{"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"a0dd03f4d3f9244cc7322791d7129925873e637a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class TestBaremetalNodeCreate(TestBaremetalNode):"},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(TestBaremetalNodeCreate, self).setUp()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.baremetal_mock.node.create.return_value \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_9a64d522","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":20},"updated":"2016-08-09 21:03:59.000000000","message":"Add empty line like in 28 or delete line 28)","commit_id":"954e3e6805b9c37216a0c0ba49a72ab6579a8d8e"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"a0dd03f4d3f9244cc7322791d7129925873e637a","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"class TestBaremetalNodeDelete(TestBaremetalNode):"},{"line_number":167,"context_line":"    def setUp(self):"},{"line_number":168,"context_line":"        super(TestBaremetalNodeDelete, self).setUp()"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        self.baremetal_mock.node.get.return_value \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_da6e4d00","line":167,"range":{"start_line":167,"start_character":8,"end_line":167,"end_character":13},"updated":"2016-08-09 21:03:59.000000000","message":"ditto","commit_id":"954e3e6805b9c37216a0c0ba49a72ab6579a8d8e"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"a0dd03f4d3f9244cc7322791d7129925873e637a","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"class TestBaremetalNodeList(TestBaremetalNode):"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def setUp(self):"},{"line_number":233,"context_line":"        super(TestBaremetalNodeList, self).setUp()"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ba71d9e2","line":231,"updated":"2016-08-09 21:03:59.000000000","message":"ditto","commit_id":"954e3e6805b9c37216a0c0ba49a72ab6579a8d8e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d7abbb46c9baeb5f5576873ac4c8effd9ac9bfff","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            \u0027node_uuid\u0027)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class TestBaremetalNodeCreate(TestBaremetalNode):"},{"line_number":207,"context_line":"    def setUp(self):"},{"line_number":208,"context_line":"        super(TestBaremetalNodeCreate, self).setUp()"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_13c918ad","line":206,"updated":"2016-11-21 14:36:40.000000000","message":"let\u0027s just make everything consistent.\n\nThe above TestConsoleShow is of the form Test\u003coperation\u003e. You are suggesting TestBaremetalNode\u003coperation\u003e here. I would agree that \u0027TestBaremetal\u003coperation\u003e\u0027 is somewhat odd.\n\nWhat do you suggest?","commit_id":"1f283471008d472f01443600fccee61248ef46dd"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"e4ee41904e7c3231dac2815d5535e9adf9b603d6","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            \u0027node_uuid\u0027)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class TestBaremetalNodeCreate(TestBaremetalNode):"},{"line_number":207,"context_line":"    def setUp(self):"},{"line_number":208,"context_line":"        super(TestBaremetalNodeCreate, self).setUp()"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_d9e7c144","line":206,"in_reply_to":"7a77a97e_13c918ad","updated":"2016-11-21 15:20:18.000000000","message":"Hello, Ruby! I`d suggest to add word `Node` only to classes where word `Baremetal` exists, because they are raising a question \"Baremetal what?\" when we know that baremetal can be nodes, ports, chassis, portgroups.","commit_id":"1f283471008d472f01443600fccee61248ef46dd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"40d4f200da37af6b9e48e7026b842a05466004fe","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            \u0027node_uuid\u0027)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class TestBaremetalNodeCreate(TestBaremetalNode):"},{"line_number":207,"context_line":"    def setUp(self):"},{"line_number":208,"context_line":"        super(TestBaremetalNodeCreate, self).setUp()"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_01a7ed4f","line":206,"in_reply_to":"7a77a97e_d9e7c144","updated":"2016-11-21 22:50:43.000000000","message":"This file is named \u0027test_baremetal_node.py\u0027, and the base class is called \u0027TestBaremetalNode\u0027, so I think it should be clear that this is testing stuff related to baremetal node.\n\nIt seems to me that if you want it to be TestBaremetalNode\u003coperation\u003e, then we should change all the classes to be similar, for consistency reasons. So eg \u0027TestBaremetalNodeConsoleShow\u0027? I\u0027d actually prefer if we just named them \u0027Test\u003coperation\u003e, which would make this TestCreate.\n\nhindsight is that I should have insisted more in the beginning, about the naming. Although either way, we\u0027re going to bikeshed on it which is what I tried to avoid in the beginning by not saying anything.","commit_id":"1f283471008d472f01443600fccee61248ef46dd"}]}