)]}'
{"ironicclient/osc/v1/baremetal_chassis.py":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"6aebbebabee2b23150358f02b49ee5decca986d8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from cliff import command"},{"line_number":21,"context_line":"from cliff import lister"},{"line_number":22,"context_line":"from cliff import show"},{"line_number":23,"context_line":"from openstackclient.common import utils as oscutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ironicclient.common.i18n import _"},{"line_number":26,"context_line":"from ironicclient.common import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2bcea583","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":52},"updated":"2016-07-27 14:30:56.000000000","message":"Should we use osc_lib.utils instead of deprecated openstackclient.common.utils? I ask because i have same import in my patch about \u0027baremetal port list\u0027 command.","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e7bc19128b976c0d0552b864838b6bffc2f582fd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from cliff import command"},{"line_number":21,"context_line":"from cliff import lister"},{"line_number":22,"context_line":"from cliff import show"},{"line_number":23,"context_line":"from openstackclient.common import utils as oscutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ironicclient.common.i18n import _"},{"line_number":26,"context_line":"from ironicclient.common import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_97cb6e1e","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":52},"in_reply_to":"bacf61ea_2bcea583","updated":"2016-07-27 15:25:00.000000000","message":"no, there is a separate patch that is proposing that.","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ffd60032f9ee24fefdd55d7c7113d7adadcf4d09","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \u0027--description\u0027,"},{"line_number":41,"context_line":"            dest\u003d\u0027description\u0027,"},{"line_number":42,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":43,"context_line":"            help\u003d\u0027Description for the chassis\u0027)"},{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027--extra\u0027,"},{"line_number":46,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_97fd40b3","line":43,"updated":"2016-08-02 08:17:16.000000000","message":"dot at the end.","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ffd60032f9ee24fefdd55d7c7113d7adadcf4d09","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        parser.add_argument("},{"line_number":51,"context_line":"            \u0027--uuid\u0027,"},{"line_number":52,"context_line":"            metavar\u003d\u0027\u003cuuid\u003e\u0027,"},{"line_number":53,"context_line":"            help\u003d\"Unique UUID of the chassis\")"},{"line_number":54,"context_line":"        return parser"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_17283032","line":53,"range":{"start_line":53,"start_character":44,"end_line":53,"end_character":45},"updated":"2016-08-02 08:17:16.000000000","message":"ditto about dot","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ffd60032f9ee24fefdd55d7c7113d7adadcf4d09","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \"chassis\","},{"line_number":81,"context_line":"            metavar\u003d\"\u003cchassis\u003e\","},{"line_number":82,"context_line":"            nargs\u003d\"+\","},{"line_number":83,"context_line":"            help\u003d\"UUIDs of chassis to delete\")"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return parser"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_37dc5445","line":83,"updated":"2016-08-02 08:17:16.000000000","message":"ditto","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ffd60032f9ee24fefdd55d7c7113d7adadcf4d09","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        display_group.add_argument("},{"line_number":134,"context_line":"            \u0027--long\u0027,"},{"line_number":135,"context_line":"            default\u003dFalse,"},{"line_number":136,"context_line":"            help\u003d\"Show detailed information about the chassis\","},{"line_number":137,"context_line":"            action\u003d\u0027store_true\u0027)"},{"line_number":138,"context_line":"        parser.add_argument("},{"line_number":139,"context_line":"            \u0027--marker\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f7b8fcc9","line":136,"updated":"2016-08-02 08:17:16.000000000","message":"ditto","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ffd60032f9ee24fefdd55d7c7113d7adadcf4d09","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        parser.add_argument("},{"line_number":199,"context_line":"            \u0027chassis\u0027,"},{"line_number":200,"context_line":"            metavar\u003d\u0027\u003cchassis\u003e\u0027,"},{"line_number":201,"context_line":"            help\u003d\"UUID of the chassis\","},{"line_number":202,"context_line":"        )"},{"line_number":203,"context_line":"        parser.add_argument("},{"line_number":204,"context_line":"            \"--description\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f7063c84","line":201,"updated":"2016-08-02 08:17:16.000000000","message":"ditto","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ffd60032f9ee24fefdd55d7c7113d7adadcf4d09","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        parser.add_argument("},{"line_number":204,"context_line":"            \"--description\","},{"line_number":205,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":206,"context_line":"            help\u003d\"Set the description of the chassis\","},{"line_number":207,"context_line":"        )"},{"line_number":208,"context_line":"        parser.add_argument("},{"line_number":209,"context_line":"            \"--extra\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_17003065","line":206,"updated":"2016-08-02 08:17:16.000000000","message":"ditto","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ffd60032f9ee24fefdd55d7c7113d7adadcf4d09","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        parser.add_argument("},{"line_number":277,"context_line":"            \u0027chassis\u0027,"},{"line_number":278,"context_line":"            metavar\u003d\u0027\u003cchassis\u003e\u0027,"},{"line_number":279,"context_line":"            help\u003d\"UUID of the chassis\""},{"line_number":280,"context_line":"        )"},{"line_number":281,"context_line":"        parser.add_argument("},{"line_number":282,"context_line":"            \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_5724680b","line":279,"range":{"start_line":279,"start_character":36,"end_line":279,"end_character":37},"updated":"2016-08-02 08:17:16.000000000","message":"ditto","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ffd60032f9ee24fefdd55d7c7113d7adadcf4d09","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            \u0027--description\u0027,"},{"line_number":283,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":284,"context_line":"            default\u003dFalse,"},{"line_number":285,"context_line":"            help\u003d\u0027Clear the chassis description\u0027,"},{"line_number":286,"context_line":"        )"},{"line_number":287,"context_line":"        parser.add_argument("},{"line_number":288,"context_line":"            \"--extra\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f77bdcf2","line":285,"range":{"start_line":285,"start_character":46,"end_line":285,"end_character":47},"updated":"2016-08-02 08:17:16.000000000","message":"ditto","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"6aebbebabee2b23150358f02b49ee5decca986d8","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        if parsed_args.extra:"},{"line_number":306,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027remove\u0027,"},{"line_number":307,"context_line":"                              [\u0027extra/\u0027 + x for x in parsed_args.extra]))"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        baremetal_client.chassis.update(parsed_args.chassis, properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6ee70b41","line":308,"updated":"2016-07-27 14:30:56.000000000","message":"It looks that \"baremetal chassis unset \u003cchassis\u003e\" command without specifying field to unset will silently do nothing like it does for nodes. I have filed an issue about it: https://bugs.launchpad.net/python-ironicclient/+bug/1606908\nShould we add a warning or some info for user in this case?","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8f3efcf00aac9ecac1f1a6819a9669700a1292c2","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        if parsed_args.extra:"},{"line_number":306,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027remove\u0027,"},{"line_number":307,"context_line":"                              [\u0027extra/\u0027 + x for x in parsed_args.extra]))"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        baremetal_client.chassis.update(parsed_args.chassis, properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_87b5c7ce","line":308,"in_reply_to":"bacf61ea_2a32edf1","updated":"2016-07-28 13:57:08.000000000","message":"Kyrylo, thanks for looking into this!","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"58c2240706d25bae3681581bc44aaf665f042bcc","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        if parsed_args.extra:"},{"line_number":306,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027remove\u0027,"},{"line_number":307,"context_line":"                              [\u0027extra/\u0027 + x for x in parsed_args.extra]))"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        baremetal_client.chassis.update(parsed_args.chassis, properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2a32edf1","line":308,"in_reply_to":"bacf61ea_370c4242","updated":"2016-07-28 11:00:58.000000000","message":"Ruby, i have checked it with \"openstack flavor unset\", \"openstack image unset\". In both cases unset without args silently does nothing. \nI discussed together with colleagues, that in usual UNIX-style CLI behavior programs should be silent in case of successful execution, and in case of lack of arguments better to raise an error/warning message. So i\u0027ll propose fix to openstackclient and will see how it will be adopted there or not.","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e7bc19128b976c0d0552b864838b6bffc2f582fd","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        if parsed_args.extra:"},{"line_number":306,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027remove\u0027,"},{"line_number":307,"context_line":"                              [\u0027extra/\u0027 + x for x in parsed_args.extra]))"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        baremetal_client.chassis.update(parsed_args.chassis, properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_370c4242","line":308,"in_reply_to":"bacf61ea_6ee70b41","updated":"2016-07-27 15:25:00.000000000","message":"Would you do me a favour and see how the unset command works in other (non-ironic) OSC commands?","commit_id":"158268c51855516fede11b7b74fd2490453852e1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e56f437f7c4dc7fc07dafe6d1d8ff0791d2fa51a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from cliff import command"},{"line_number":21,"context_line":"from cliff import lister"},{"line_number":22,"context_line":"from cliff import show"},{"line_number":23,"context_line":"from openstackclient.common import utils as oscutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ironicclient.common.i18n import _"},{"line_number":26,"context_line":"from ironicclient.common import utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_2a15b248","line":23,"updated":"2016-08-25 10:13:04.000000000","message":"we\u0027ve switched to osc-lib for both, please update","commit_id":"1508441662cc2372af882ef8dcc8c0d79c9b2f84"}]}