)]}'
{"ironicclient/osc/v1/baremetal_port.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"35bfcade9a0ab05cb1d85639aacb52359b08bd4c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            try:"},{"line_number":157,"context_line":"                baremetal_client.port.delete(port)"},{"line_number":158,"context_line":"                print(_(\u0027Deleted port %s\u0027) % port)"},{"line_number":159,"context_line":"            except exc.ClientException as e:"},{"line_number":160,"context_line":"                failures.append(_(\"Failed to delete port %(port)s: %(error)s\")"},{"line_number":161,"context_line":"                                % {\u0027port\u0027: port, \u0027error\u0027: e})"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_9f54e721","line":159,"updated":"2016-07-28 15:44:59.000000000","message":"What whould happen if the port is already deleted (NotFound returned)?\nI checked the port.delete method and it does not look like that is handles this case on Python API side. IMO it would be quite safe to ignore such errors.","commit_id":"bae9e7b950cded4f0a553e690b907684fedaa098"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"97d34f6d6be4e6cd0a11621f31456ebcbfe15886","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            try:"},{"line_number":157,"context_line":"                baremetal_client.port.delete(port)"},{"line_number":158,"context_line":"                print(_(\u0027Deleted port %s\u0027) % port)"},{"line_number":159,"context_line":"            except exc.ClientException as e:"},{"line_number":160,"context_line":"                failures.append(_(\"Failed to delete port %(port)s: %(error)s\")"},{"line_number":161,"context_line":"                                % {\u0027port\u0027: port, \u0027error\u0027: e})"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_cdcb2b52","line":159,"in_reply_to":"bacf61ea_9f54e721","updated":"2016-07-29 12:16:40.000000000","message":"I have checked, it raises error exit code:\nFailed to delete port 33724cd1-6e93-4da4-9d69-4288b43e572a: Port 33724cd1-6e93-4da4-9d69-4288b43e572a could not be found. (HTTP 404)\n$ echo $?\n1","commit_id":"bae9e7b950cded4f0a553e690b907684fedaa098"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"70ee93ffbf66003aa1064fb337c6892977f671d9","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            try:"},{"line_number":157,"context_line":"                baremetal_client.port.delete(port)"},{"line_number":158,"context_line":"                print(_(\u0027Deleted port %s\u0027) % port)"},{"line_number":159,"context_line":"            except exc.ClientException as e:"},{"line_number":160,"context_line":"                failures.append(_(\"Failed to delete port %(port)s: %(error)s\")"},{"line_number":161,"context_line":"                                % {\u0027port\u0027: port, \u0027error\u0027: e})"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_252a0c2d","line":159,"in_reply_to":"bacf61ea_9f54e721","updated":"2016-07-28 16:04:44.000000000","message":"In case of single already deleted port i have output:\nFailed to delete port 2ea37168-3bc5-410e-bb83-83de54a89189: Port 2ea37168-3bc5-410e-bb83-83de54a89189 could not be found. (HTTP 404)\n\nWhen deleting two ports in one command, than i get response about one port deleted and one failed. Without difference was deleted port leading or trailing in line:\n\n$ openstack baremetal port delete c6e64b4e-b770-441d-bf48-58d742f2fa35 2ea37168-3bc5-410e-bb83-83de54a89189 \n\nDeleted port c6e64b4e-b770-441d-bf48-58d742f2fa35\nFailed to delete port 2ea37168-3bc5-410e-bb83-83de54a89189: Port 2ea37168-3bc5-410e-bb83-83de54a89189 could not be found. (HTTP 404)\n\n$ openstack baremetal port delete 2ea37168-3bc5-410e-bb83-83de54a89189 33724cd1-6e93-4da4-9d69-4288b43e572a\n\nDeleted port 33724cd1-6e93-4da4-9d69-4288b43e572a\nFailed to delete port 2ea37168-3bc5-410e-bb83-83de54a89189: Port 2ea37168-3bc5-410e-bb83-83de54a89189 could not be found. (HTTP 404)","commit_id":"bae9e7b950cded4f0a553e690b907684fedaa098"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b4e4dddc475d77caa4596c630a60ae3a14f6e56a","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class DeleteBaremetalPort(command.Command):"},{"line_number":249,"context_line":"    \"\"\"Delete a baremetal port.\"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    log \u003d logging.getLogger(__name__ + \".DeleteBaremetalPort\")"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_e4129461","line":249,"updated":"2016-08-25 17:02:55.000000000","message":"nit, we should get rid of \u0027baremetal\u0027 (I know, it is used elsewhere but it isn\u0027t needed)\n\nOh, really meant to say how about\n\n\"Delete port(s)\"","commit_id":"c6fc4498e98ca4a29da9c64969815789cf10b122"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"ceda34358d9f6a01cafa1188a3716e901628c5d9","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class DeleteBaremetalPort(command.Command):"},{"line_number":249,"context_line":"    \"\"\"Delete a baremetal port.\"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    log \u003d logging.getLogger(__name__ + \".DeleteBaremetalPort\")"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_1b7d8ab1","line":249,"in_reply_to":"1ac06dbe_e4129461","updated":"2016-08-25 17:35:07.000000000","message":"Done","commit_id":"c6fc4498e98ca4a29da9c64969815789cf10b122"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b4e4dddc475d77caa4596c630a60ae3a14f6e56a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            \"ports\","},{"line_number":257,"context_line":"            metavar\u003d\"\u003cport\u003e\","},{"line_number":258,"context_line":"            nargs\u003d\"+\","},{"line_number":259,"context_line":"            help\u003d\"UUID of the port.\")"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return parser"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_f83a34cc","line":259,"updated":"2016-08-25 17:02:55.000000000","message":"how about \u0027UUID(s) of the port(s) to delete\u0027","commit_id":"c6fc4498e98ca4a29da9c64969815789cf10b122"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"ceda34358d9f6a01cafa1188a3716e901628c5d9","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            \"ports\","},{"line_number":257,"context_line":"            metavar\u003d\"\u003cport\u003e\","},{"line_number":258,"context_line":"            nargs\u003d\"+\","},{"line_number":259,"context_line":"            help\u003d\"UUID of the port.\")"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return parser"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_fb5eae43","line":259,"in_reply_to":"1ac06dbe_f83a34cc","updated":"2016-08-25 17:35:07.000000000","message":"Agree with you.","commit_id":"c6fc4498e98ca4a29da9c64969815789cf10b122"}],"setup.cfg":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b4928e35e35fa3b9a18e08dc3c806aa59fb06098","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    baremetal_port_show \u003d ironicclient.osc.v1.baremetal_port:ShowBaremetalPort"},{"line_number":55,"context_line":"    baremetal_port_unset \u003d ironicclient.osc.v1.baremetal_port:UnsetBaremetalPort"},{"line_number":56,"context_line":"    baremetal_port_set \u003d ironicclient.osc.v1.baremetal_port:SetBaremetalPort"},{"line_number":57,"context_line":"    baremetal_port_delete \u003d ironicclient.osc.v1.baremetal_port:DeleteBaremetalPort"},{"line_number":58,"context_line":"    baremetal_set \u003d ironicclient.osc.v1.baremetal_node:SetBaremetal"},{"line_number":59,"context_line":"    baremetal_show \u003d ironicclient.osc.v1.baremetal_node:ShowBaremetal"},{"line_number":60,"context_line":"    baremetal_unset \u003d ironicclient.osc.v1.baremetal_node:UnsetBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"1ac06dbe_90a4fe08","line":57,"updated":"2016-08-24 20:31:10.000000000","message":"These are in ABC order. Please move this up three lines :)","commit_id":"bf96c3731431927098c013de941bce80c4fba93a"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"1a23aed1597b9c325ef4ae1bdf8dfc56c6ee7632","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    baremetal_port_show \u003d ironicclient.osc.v1.baremetal_port:ShowBaremetalPort"},{"line_number":55,"context_line":"    baremetal_port_unset \u003d ironicclient.osc.v1.baremetal_port:UnsetBaremetalPort"},{"line_number":56,"context_line":"    baremetal_port_set \u003d ironicclient.osc.v1.baremetal_port:SetBaremetalPort"},{"line_number":57,"context_line":"    baremetal_port_delete \u003d ironicclient.osc.v1.baremetal_port:DeleteBaremetalPort"},{"line_number":58,"context_line":"    baremetal_set \u003d ironicclient.osc.v1.baremetal_node:SetBaremetal"},{"line_number":59,"context_line":"    baremetal_show \u003d ironicclient.osc.v1.baremetal_node:ShowBaremetal"},{"line_number":60,"context_line":"    baremetal_unset \u003d ironicclient.osc.v1.baremetal_node:UnsetBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"1ac06dbe_054d4e72","line":57,"in_reply_to":"1ac06dbe_90a4fe08","updated":"2016-08-25 09:13:26.000000000","message":"Sorry, fixed.","commit_id":"bf96c3731431927098c013de941bce80c4fba93a"}]}
