)]}'
{"ironicclient/osc/v1/baremetal_port.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eb3257737ade495d9dc8f0a2e1f7a94933bd7f56","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def get_parser(self, prog_name):"},{"line_number":194,"context_line":"        parser \u003d super(SetBaremetalPort, self).get_parser(prog_name)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        parser.add_argument("},{"line_number":197,"context_line":"            \u0027port\u0027,"},{"line_number":198,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_99906b45","line":195,"updated":"2016-08-16 14:06:10.000000000","message":"I don\u0027t understand why, in the same patch, you\u0027d remove blank lines from UnsetBaremetalPort, yet leave them in here.","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"b6c3b3a9183eb7ee043127f0156f7230771811b6","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def get_parser(self, prog_name):"},{"line_number":194,"context_line":"        parser \u003d super(SetBaremetalPort, self).get_parser(prog_name)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        parser.add_argument("},{"line_number":197,"context_line":"            \u0027port\u0027,"},{"line_number":198,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_7fed8f24","line":195,"in_reply_to":"3ac371cc_99906b45","updated":"2016-08-16 14:18:19.000000000","message":"rabasing issue, fixed :)","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eb3257737ade495d9dc8f0a2e1f7a94933bd7f56","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            \"--address\","},{"line_number":208,"context_line":"            metavar\u003d\"\u003caddress\u003e\","},{"line_number":209,"context_line":"            dest\u003d\u0027address\u0027,"},{"line_number":210,"context_line":"            help\u003d\"Set MAC address for this port.\")"},{"line_number":211,"context_line":"        parser.add_argument("},{"line_number":212,"context_line":"            \"--extra\","},{"line_number":213,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_f9f4ff87","line":210,"updated":"2016-08-16 14:06:10.000000000","message":"if you do another revision, please remove the periods at the end of the above help messages.","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"b6c3b3a9183eb7ee043127f0156f7230771811b6","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            \"--address\","},{"line_number":208,"context_line":"            metavar\u003d\"\u003caddress\u003e\","},{"line_number":209,"context_line":"            dest\u003d\u0027address\u0027,"},{"line_number":210,"context_line":"            help\u003d\"Set MAC address for this port.\")"},{"line_number":211,"context_line":"        parser.add_argument("},{"line_number":212,"context_line":"            \"--extra\","},{"line_number":213,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_ffd97f84","line":210,"in_reply_to":"3ac371cc_f9f4ff87","updated":"2016-08-16 14:18:19.000000000","message":"ok","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"}],"ironicclient/tests/unit/osc/v1/test_baremetal_port.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eb3257737ade495d9dc8f0a2e1f7a94933bd7f56","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    def test_baremetal_port_set_node_uuid(self):"},{"line_number":243,"context_line":"        arglist \u003d ["},{"line_number":244,"context_line":"            baremetal_fakes.baremetal_port_uuid,"},{"line_number":245,"context_line":"            \u0027--node\u0027, baremetal_fakes.baremetal_uuid]"},{"line_number":246,"context_line":"        verifylist \u003d ["},{"line_number":247,"context_line":"            (\u0027port\u0027, baremetal_fakes.baremetal_port_uuid),"},{"line_number":248,"context_line":"            (\u0027node_uuid\u0027, baremetal_fakes.baremetal_uuid)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_e410d603","line":245,"updated":"2016-08-16 14:06:10.000000000","message":"I am wondering what this test is doing. Doesn\u0027t the port already have node_uuid set to this value? If so, why set it to the same value again?\n\nIn the context of this particular test, which doesn\u0027t actually do much, I guess it doesn\u0027t matter, but it is odd. Up to you whether you want to change it or leave it as is.","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"b6c3b3a9183eb7ee043127f0156f7230771811b6","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    def test_baremetal_port_set_node_uuid(self):"},{"line_number":243,"context_line":"        arglist \u003d ["},{"line_number":244,"context_line":"            baremetal_fakes.baremetal_port_uuid,"},{"line_number":245,"context_line":"            \u0027--node\u0027, baremetal_fakes.baremetal_uuid]"},{"line_number":246,"context_line":"        verifylist \u003d ["},{"line_number":247,"context_line":"            (\u0027port\u0027, baremetal_fakes.baremetal_port_uuid),"},{"line_number":248,"context_line":"            (\u0027node_uuid\u0027, baremetal_fakes.baremetal_uuid)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_7f2f4ff6","line":245,"in_reply_to":"3ac371cc_e410d603","updated":"2016-08-16 14:18:19.000000000","message":"heh, agree, it doesn\u0027t make sense, I think I can set another node_uuid here","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eb3257737ade495d9dc8f0a2e1f7a94933bd7f56","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":252,"context_line":"        self.baremetal_mock.port.update.assert_called_once_with("},{"line_number":253,"context_line":"            \u0027zzz-zzzzzz-zzzz\u0027,"},{"line_number":254,"context_line":"            [{\u0027path\u0027: \u0027/node_uuid\u0027, \u0027value\u0027: \u0027xxx-xxxxxx-xxxx\u0027, \u0027op\u0027: \u0027add\u0027}])"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def test_baremetal_port_set_address(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_a4389ea1","line":253,"updated":"2016-08-16 14:06:10.000000000","message":"if you\u0027re going to use baremetal_fakes.baremetal_port_uuid in the arglist, why wouldn\u0027t you use that here?","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"b6c3b3a9183eb7ee043127f0156f7230771811b6","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":252,"context_line":"        self.baremetal_mock.port.update.assert_called_once_with("},{"line_number":253,"context_line":"            \u0027zzz-zzzzzz-zzzz\u0027,"},{"line_number":254,"context_line":"            [{\u0027path\u0027: \u0027/node_uuid\u0027, \u0027value\u0027: \u0027xxx-xxxxxx-xxxx\u0027, \u0027op\u0027: \u0027add\u0027}])"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def test_baremetal_port_set_address(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_7f1c6f77","line":253,"in_reply_to":"3ac371cc_a4389ea1","updated":"2016-08-16 14:18:19.000000000","message":"I have no idea, I\u0027ll fix it","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eb3257737ade495d9dc8f0a2e1f7a94933bd7f56","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":252,"context_line":"        self.baremetal_mock.port.update.assert_called_once_with("},{"line_number":253,"context_line":"            \u0027zzz-zzzzzz-zzzz\u0027,"},{"line_number":254,"context_line":"            [{\u0027path\u0027: \u0027/node_uuid\u0027, \u0027value\u0027: \u0027xxx-xxxxxx-xxxx\u0027, \u0027op\u0027: \u0027add\u0027}])"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def test_baremetal_port_set_address(self):"},{"line_number":257,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_c45cbaef","line":254,"updated":"2016-08-16 14:06:10.000000000","message":"ditto for baremetal_fakes.baremetal_uuid.","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eb3257737ade495d9dc8f0a2e1f7a94933bd7f56","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":267,"context_line":"        self.baremetal_mock.port.update.assert_called_once_with("},{"line_number":268,"context_line":"            \u0027zzz-zzzzzz-zzzz\u0027,"},{"line_number":269,"context_line":"            [{\u0027path\u0027: \u0027/address\u0027, \u0027value\u0027: \u0027AA:BB:CC:DD:EE:FF\u0027, \u0027op\u0027: \u0027add\u0027}])"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def test_baremetal_set_extra(self):"},{"line_number":272,"context_line":"        arglist \u003d [\u0027port\u0027, \u0027--extra\u0027, \u0027foo\u003dbar\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_24b2ee94","line":269,"updated":"2016-08-16 14:06:10.000000000","message":"ditto comments from above test.","commit_id":"b426583eabb1c49a35eb70239b7b2a2fe9b22ed2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"93027ad7102f8598348e506c4df899296d9d44eb","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    def test_baremetal_port_set_address(self):"},{"line_number":264,"context_line":"        arglist \u003d ["},{"line_number":265,"context_line":"            baremetal_fakes.baremetal_port_uuid,"},{"line_number":266,"context_line":"            \u0027--address\u0027, baremetal_fakes.baremetal_port_address]"},{"line_number":267,"context_line":"        verifylist \u003d ["},{"line_number":268,"context_line":"            (\u0027port\u0027, baremetal_fakes.baremetal_port_uuid),"},{"line_number":269,"context_line":"            (\u0027address\u0027, baremetal_fakes.baremetal_port_address)]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_a596d8ed","line":266,"updated":"2016-08-16 14:40:48.000000000","message":"you could also add a new_port_address but probably a nit.","commit_id":"3a4f3af948a6a6ed3f3899bd76d9f1b652937272"}]}
