)]}'
{"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3eaa6db21d62aefb8680fde1471449562e6a3ec","unresolved":false,"context_lines":[{"line_number":804,"context_line":"                               in parsed_args.instance_info]))"},{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_3b954f88","line":807,"updated":"2016-08-12 09:37:46.000000000","message":"I think we can use just use\n\n if not properties:\n\nthen we won\u0027t forget to extend the list","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"5e9a9cd4c5959d6938332fa5ea5de85cf6cbd271","unresolved":false,"context_lines":[{"line_number":804,"context_line":"                               in parsed_args.instance_info]))"},{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_15080f28","line":807,"in_reply_to":"9ad45d7e_3b954f88","updated":"2016-08-12 12:45:31.000000000","message":"+1","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"04b08d260169465070b1cb0d83650aeaa97dd83e","unresolved":false,"context_lines":[{"line_number":804,"context_line":"                               in parsed_args.instance_info]))"},{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_093ac0e7","line":807,"in_reply_to":"9ad45d7e_3b954f88","updated":"2016-08-12 12:56:56.000000000","message":"Done","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3eaa6db21d62aefb8680fde1471449562e6a3ec","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_1b920ba0","line":808,"updated":"2016-08-12 09:37:46.000000000","message":"This is an error with the current client, so I think we should raise an exception here.","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"12a49896b904820d8950ee80cdd8fcdc5f884d12","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_c90388bd","line":808,"in_reply_to":"9ad45d7e_1b920ba0","updated":"2016-08-12 11:41:46.000000000","message":"I\u0027m wondering if we choose right syntax here, imo parser should track such errors, it\u0027s malformed command.","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"04b08d260169465070b1cb0d83650aeaa97dd83e","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_892eb0a3","line":808,"in_reply_to":"9ad45d7e_1b920ba0","updated":"2016-08-12 12:56:56.000000000","message":"Thanks!","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"53495e81461168ee4151c3e3c5109f4c5af16149","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_e9b3ece7","line":808,"in_reply_to":"9ad45d7e_c90388bd","updated":"2016-08-12 11:46:12.000000000","message":"I\u0027m surprised, but I can\u0027t find anything like that in argparse :/","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"889dae2f1324638b77d07f6cdfb949fb5e1570c7","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_a41af17a","line":808,"in_reply_to":"9ad45d7e_da48648d","updated":"2016-10-04 09:13:50.000000000","message":"Changed this patch by the same way as it done for ports.","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fe1d9087435824ecf66fdf4e18d81c00cad7903d","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_f5f61bf8","line":808,"in_reply_to":"9ad45d7e_da48648d","updated":"2016-08-12 12:49:10.000000000","message":"Hmm, ok. But I don\u0027t think we should make an empty API call in this case.","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"5e9a9cd4c5959d6938332fa5ea5de85cf6cbd271","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_da48648d","line":808,"in_reply_to":"9ad45d7e_e9b3ece7","updated":"2016-08-12 12:45:31.000000000","message":"As me, but looks like raising exception would be wrong here https://bugs.launchpad.net/python-openstackclient/+bug/1588588","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"aaf53f52883814153533194c42851909de033fb9","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        if not any([parsed_args.instance_uuid, parsed_args.name,"},{"line_number":806,"context_line":"                    parsed_args.property, parsed_args.extra,"},{"line_number":807,"context_line":"                    parsed_args.driver_info, parsed_args.instance_info]):"},{"line_number":808,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_55a2879b","line":808,"in_reply_to":"9ad45d7e_f5f61bf8","updated":"2016-08-12 12:54:03.000000000","message":"yeah, odd, as I can see  `openstack image unset` was raising with \"No arguments specified\" before, and now passing silently (","commit_id":"42c67af31f6f962f29d4b58675d906244312c13d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ebcd00387dd876f85fed64d23ee20c5a5316e061","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        if properties:"},{"line_number":904,"context_line":"            baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":905,"context_line":"        else:"},{"line_number":906,"context_line":"            self.log.warning(\"Please specify what to set.\")"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"class SetBaremetal(SetBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_1c6afd80","line":906,"updated":"2016-11-23 14:15:39.000000000","message":"this file seems to use i18n (at least partly), so let\u0027s wrap this in _LW()","commit_id":"e43d597d0ece505cb0a5959d17cc1d2eb0e68e25"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"3fa0c56364ad9ae4d5748cc3f9ad8566f71b6a3f","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        if properties:"},{"line_number":904,"context_line":"            baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":905,"context_line":"        else:"},{"line_number":906,"context_line":"            self.log.warning(\"Please specify what to set.\")"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"class SetBaremetal(SetBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_6241830b","line":906,"in_reply_to":"5a74a57a_1c6afd80","updated":"2016-11-23 16:23:23.000000000","message":"Thanks!","commit_id":"e43d597d0ece505cb0a5959d17cc1d2eb0e68e25"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ebcd00387dd876f85fed64d23ee20c5a5316e061","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"        if properties:"},{"line_number":1101,"context_line":"            baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":1102,"context_line":"        else:"},{"line_number":1103,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"class UnsetBaremetal(UnsetBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_3c05f9c1","line":1103,"updated":"2016-11-23 14:15:39.000000000","message":"ditto","commit_id":"e43d597d0ece505cb0a5959d17cc1d2eb0e68e25"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"3fa0c56364ad9ae4d5748cc3f9ad8566f71b6a3f","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"        if properties:"},{"line_number":1101,"context_line":"            baremetal_client.node.update(parsed_args.node, properties)"},{"line_number":1102,"context_line":"        else:"},{"line_number":1103,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"class UnsetBaremetal(UnsetBaremetalNode):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_82469f21","line":1103,"in_reply_to":"5a74a57a_3c05f9c1","updated":"2016-11-23 16:23:23.000000000","message":"Done","commit_id":"e43d597d0ece505cb0a5959d17cc1d2eb0e68e25"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"6f89b126b401af0dbe0498c3d370234906b1fc28","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from osc_lib.command import command"},{"line_number":22,"context_line":"from osc_lib import utils as oscutils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironicclient.common.i18n import _"},{"line_number":25,"context_line":"from ironicclient.common.i18n import _LW"},{"line_number":26,"context_line":"from ironicclient.common import utils"},{"line_number":27,"context_line":"from ironicclient import exc"},{"line_number":28,"context_line":"from ironicclient.v1 import resource_fields as res_fields"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_f43443fc","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":40},"updated":"2016-11-24 14:09:51.000000000","message":"nit: from ironicclient.common.i18n import _, _LW","commit_id":"0ba52656fb48cd2720edbe87a9b52e5f39906d3c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"bb34a94b5b4c77e50d519bf7144484e3da3ecaee","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from osc_lib.command import command"},{"line_number":22,"context_line":"from osc_lib import utils as oscutils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironicclient.common.i18n import _"},{"line_number":25,"context_line":"from ironicclient.common.i18n import _LW"},{"line_number":26,"context_line":"from ironicclient.common import utils"},{"line_number":27,"context_line":"from ironicclient import exc"},{"line_number":28,"context_line":"from ironicclient.v1 import resource_fields as res_fields"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_4840f4a5","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":40},"in_reply_to":"5a74a57a_f43443fc","updated":"2016-11-24 15:28:41.000000000","message":"Thanks!","commit_id":"0ba52656fb48cd2720edbe87a9b52e5f39906d3c"}]}
