)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"773fa0a81340b70147369eb807162a0b42b809a0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ruby Loo \u003cruby.loo@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-18 14:09:05 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds node boot-device \u0026 passthu OSC commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds the following node boot-device and node passthru commands"},{"line_number":10,"context_line":"to the OpenStackClient plugin:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_ba1bee7f","line":7,"updated":"2016-08-18 21:12:11.000000000","message":"s/passthu/passthru/","commit_id":"0c1b2a7769ec3c6243f292419f188882fab38c8a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"545145b515ac23debd7d15a093e6c1009034ffaa","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  - openstack baremetal node passthrough call"},{"line_number":14,"context_line":"  - openstack baremetal node passthrough list"},{"line_number":15,"context_line":"  - openstack baremetal node passthru call (alias to passthrough call)"},{"line_number":16,"context_line":"  - openstack baremetal node passthru list (alias to passthrough list)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I803bf263c0e548019425e769f1d3ae5ae33d9940"},{"line_number":19,"context_line":"Partial-Bug: #1526479"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_5092589f","line":16,"updated":"2016-08-28 08:29:37.000000000","message":"Why do we need both commands? I suspect the spelling might differ, but I\u0027d still prefer us to pick only one..","commit_id":"64741e5dffe81898bd00a48cfe1bc275bba44f97"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8e4c1a270ebba1b172f5645ff3d55975d9e5579b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  - openstack baremetal node passthrough call"},{"line_number":14,"context_line":"  - openstack baremetal node passthrough list"},{"line_number":15,"context_line":"  - openstack baremetal node passthru call (alias to passthrough call)"},{"line_number":16,"context_line":"  - openstack baremetal node passthru list (alias to passthrough list)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I803bf263c0e548019425e769f1d3ae5ae33d9940"},{"line_number":19,"context_line":"Partial-Bug: #1526479"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_c37ae0f0","line":16,"in_reply_to":"fa7ab95a_5092589f","updated":"2016-08-29 19:30:06.000000000","message":"Went with what seemed like consensus on \u0027passthru\u0027 (http://lists.openstack.org/pipermail/openstack-dev/2016-August/102449.html)","commit_id":"64741e5dffe81898bd00a48cfe1bc275bba44f97"}],"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9eef15afd96f6e977d80dae5abda3e8ff928453f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            help\u003d\"Name or UUID of the node\""},{"line_number":129,"context_line":"        )"},{"line_number":130,"context_line":"        parser.add_argument("},{"line_number":131,"context_line":"            \u0027--supported\u0027,"},{"line_number":132,"context_line":"            dest\u003d\u0027supported\u0027,"},{"line_number":133,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":134,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_e6db204e","line":131,"updated":"2016-08-24 12:08:35.000000000","message":"I wonder if we should split this in a separate command... the resulting table is completely different if this is provided. Also putting it in one field prevents useful things like\n\n for dev in $(openstack baremetal node boot device show --supported -f value -c Device); do ... done","commit_id":"668b5b875cc4c4612896e704b75936aa39157edc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7d320a3c887675c3825cf0a4285e0582d5c60a08","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            help\u003d\"Name or UUID of the node\""},{"line_number":129,"context_line":"        )"},{"line_number":130,"context_line":"        parser.add_argument("},{"line_number":131,"context_line":"            \u0027--supported\u0027,"},{"line_number":132,"context_line":"            dest\u003d\u0027supported\u0027,"},{"line_number":133,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":134,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_41b807e6","line":131,"in_reply_to":"1ac06dbe_e6db204e","updated":"2016-08-24 19:46:46.000000000","message":"Do you think I should remove the supported part from this patch, so we can discuss later? I actually think it makes sense to have this, because \u0027openstack baremetal node boot device show --supported\u0027 seems better than a separate command eg \u0027openstack baremetal node supported boot devices show\u0027. Unless we want to roll that in with \u0027openstack baremetal node show\u0027 but if we did that, we\u0027d probably need to show the actual boot device info too.\n\nwrt putting it in one field. We could change it to return a list I suppose. Which would be inconsistent with \u0027ironic-node-get-supported-boot-devices\u0027 (but I don\u0027t think we care about that). Hmm, also, it might not make sense with \u0027openstack baremetal node boot device show --supported\u0027 (as opposed to \u0027openstack baremetal node boot device list --supported\u0027).\n\nSIGH. Should we leave it as coded here, until someone has a better idea?","commit_id":"668b5b875cc4c4612896e704b75936aa39157edc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"545145b515ac23debd7d15a093e6c1009034ffaa","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        parser.add_argument("},{"line_number":631,"context_line":"            \u0027method\u0027,"},{"line_number":632,"context_line":"            metavar\u003d\u0027\u003cmethod\u003e\u0027,"},{"line_number":633,"context_line":"            help\u003d\"Vendor-passthrough method to be executed\""},{"line_number":634,"context_line":"        )"},{"line_number":635,"context_line":"        parser.add_argument("},{"line_number":636,"context_line":"            \u0027--arg\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_708d9c7a","line":633,"updated":"2016-08-28 08:29:37.000000000","message":"nit: I think the dash should be removed (here and everywhere)","commit_id":"64741e5dffe81898bd00a48cfe1bc275bba44f97"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8e4c1a270ebba1b172f5645ff3d55975d9e5579b","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        parser.add_argument("},{"line_number":631,"context_line":"            \u0027method\u0027,"},{"line_number":632,"context_line":"            metavar\u003d\u0027\u003cmethod\u003e\u0027,"},{"line_number":633,"context_line":"            help\u003d\"Vendor-passthrough method to be executed\""},{"line_number":634,"context_line":"        )"},{"line_number":635,"context_line":"        parser.add_argument("},{"line_number":636,"context_line":"            \u0027--arg\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_837538fb","line":633,"in_reply_to":"fa7ab95a_708d9c7a","updated":"2016-08-29 19:30:06.000000000","message":"Sure. I have no idea which is the more correct form :)","commit_id":"64741e5dffe81898bd00a48cfe1bc275bba44f97"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d32daa501441d5e19ab5f22e411211472e6af7e3","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    log \u003d logging.getLogger(__name__ + \".BootdeviceSetBaremetalNode\")"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    BOOT_DEVICES \u003d [\u0027pxe\u0027, \u0027disk\u0027, \u0027cdrom\u0027, \u0027bios\u0027, \u0027safe\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def get_parser(self, prog_name):"},{"line_number":83,"context_line":"        parser \u003d super(BootdeviceSetBaremetalNode, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_3a0e15e5","line":80,"range":{"start_line":80,"start_character":19,"end_line":80,"end_character":59},"updated":"2016-08-30 15:20:54.000000000","message":"Nit - would be nice to move it to some common place for both ironic and openstack commands.","commit_id":"0f005338e9a166412eba1fb010eb5063d63dc5ef"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"39830432263216d372b6891e49b083a1a8dd7cd3","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    log \u003d logging.getLogger(__name__ + \".BootdeviceSetBaremetalNode\")"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    BOOT_DEVICES \u003d [\u0027pxe\u0027, \u0027disk\u0027, \u0027cdrom\u0027, \u0027bios\u0027, \u0027safe\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def get_parser(self, prog_name):"},{"line_number":83,"context_line":"        parser \u003d super(BootdeviceSetBaremetalNode, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_b1fe5c03","line":80,"range":{"start_line":80,"start_character":19,"end_line":80,"end_character":59},"in_reply_to":"fa7ab95a_3a0e15e5","updated":"2016-09-01 03:04:48.000000000","message":"+1. See https://review.openstack.org/364038","commit_id":"0f005338e9a166412eba1fb010eb5063d63dc5ef"}]}