)]}'
{"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d4bcfad1358affaa839ae0949038dc9f55dcd027","unresolved":false,"context_lines":[{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        baremetal_client.node.inject_nmi(parsed_args.nmi, parsed_args.node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_5f122758","line":1175,"updated":"2016-09-07 12:26:00.000000000","message":"Should this command return anything?","commit_id":"800f084934b68092310c2a825f1ce3358ee8d5e8"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"66f9e8b10a8d1ed33a0b0f4b30f5d577285d3cba","unresolved":false,"context_lines":[{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        baremetal_client.node.inject_nmi(parsed_args.nmi, parsed_args.node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_c46c870a","line":1175,"in_reply_to":"9a89bdaa_5f122758","updated":"2016-09-08 04:23:13.000000000","message":"Kyrylo,\n\nThanks for the comment.\n\nThis call should return nothing such as reboot at L.777 in this file.\n\nBest regards,\nNaohiro","commit_id":"800f084934b68092310c2a825f1ce3358ee8d5e8"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ed21b3972b76707a307833668416af4a06cc9e72","unresolved":false,"context_lines":[{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        baremetal_client.node.inject_nmi(parsed_args.nmi, parsed_args.node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_c2cd4d67","line":1175,"in_reply_to":"9a89bdaa_c46c870a","updated":"2016-09-08 09:24:04.000000000","message":"Thank you for the response, Naohiro.","commit_id":"800f084934b68092310c2a825f1ce3358ee8d5e8"}],"releasenotes/notes/osc-instance-crash-dump-22634a57104561a5.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d065623cc38cfe7c251a20cb5c4f437560c03e4b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new OSC command for Inject NMI, \"openstack baremetal node inject nmi\"."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a3c09a3_a797b846","line":3,"range":{"start_line":3,"start_character":37,"end_line":3,"end_character":40},"updated":"2017-01-16 20:04:33.000000000","message":"Nit: I think it would be good to spell out NMI since this is user visible documentation.","commit_id":"57493bd7ec3e75fb9bddee1bada1d33ad1941277"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bc8a4d0e74c827af73741224de13ce70ce7f9746","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new OSC command for Inject NMI, \"openstack baremetal node inject nmi\"."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5a3905b3_5622c5ba","line":3,"range":{"start_line":3,"start_character":37,"end_line":3,"end_character":40},"in_reply_to":"7a3c09a3_a797b846","updated":"2017-01-19 06:47:48.000000000","message":"I\u0027ll fix that.","commit_id":"57493bd7ec3e75fb9bddee1bada1d33ad1941277"}],"setup.cfg":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"5a05c67e41db7c79d18ae7835fe9a281007211c1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    baremetal_node_undeploy \u003d ironicclient.osc.v1.baremetal_node:UndeployBaremetalNode"},{"line_number":70,"context_line":"    baremetal_node_unset \u003d ironicclient.osc.v1.baremetal_node:UnsetBaremetalNode"},{"line_number":71,"context_line":"    baremetal_node_validate \u003d ironicclient.osc.v1.baremetal_node:ValidateBaremetalNode"},{"line_number":72,"context_line":"    baremetal_node_inject \u003d ironicclient.osc.v1.baremetal_node:InjectBaremetalNode"},{"line_number":73,"context_line":"    baremetal_port_create \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":74,"context_line":"    baremetal_port_delete \u003d ironicclient.osc.v1.baremetal_port:DeleteBaremetalPort"},{"line_number":75,"context_line":"    baremetal_port_list \u003d ironicclient.osc.v1.baremetal_port:ListBaremetalPort"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"5a8bc5a2_27bcfa04","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":25},"updated":"2016-09-23 03:16:04.000000000","message":"I prefer setting baremetal_node_inject_nmi here because nmi is constant word.","commit_id":"800f084934b68092310c2a825f1ce3358ee8d5e8"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a9187954121924f46ac505e430826a58bc3efeaf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    baremetal_node_undeploy \u003d ironicclient.osc.v1.baremetal_node:UndeployBaremetalNode"},{"line_number":70,"context_line":"    baremetal_node_unset \u003d ironicclient.osc.v1.baremetal_node:UnsetBaremetalNode"},{"line_number":71,"context_line":"    baremetal_node_validate \u003d ironicclient.osc.v1.baremetal_node:ValidateBaremetalNode"},{"line_number":72,"context_line":"    baremetal_node_inject \u003d ironicclient.osc.v1.baremetal_node:InjectBaremetalNode"},{"line_number":73,"context_line":"    baremetal_port_create \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":74,"context_line":"    baremetal_port_delete \u003d ironicclient.osc.v1.baremetal_port:DeleteBaremetalPort"},{"line_number":75,"context_line":"    baremetal_port_list \u003d ironicclient.osc.v1.baremetal_port:ListBaremetalPort"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"5a8bc5a2_fe76afd5","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":25},"in_reply_to":"5a8bc5a2_27bcfa04","updated":"2016-09-26 05:53:44.000000000","message":"\u0027nmi\u0027 is not constant word, but an  an argument of the class InjectBaremetalNode.\n\nhttps://review.openstack.org/#/c/357661/4/ironicclient/osc/v1/baremetal_node.py\n\nPlease notice the syntax of OSC inject nmi.\nusage: openstack baremetal node inject nmi \u003cuuid\u003e\n\n\u0027inject nmi\u0027 is two words, but not one word.\n\nSo I believe that \u0027baremetal_node_inject\u0027 is more consistent with the class InjectBaremetalNode.","commit_id":"800f084934b68092310c2a825f1ce3358ee8d5e8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f237ba76a1df12c5361af0d4e473ca33b91b4186","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    baremetal_node_undeploy \u003d ironicclient.osc.v1.baremetal_node:UndeployBaremetalNode"},{"line_number":70,"context_line":"    baremetal_node_unset \u003d ironicclient.osc.v1.baremetal_node:UnsetBaremetalNode"},{"line_number":71,"context_line":"    baremetal_node_validate \u003d ironicclient.osc.v1.baremetal_node:ValidateBaremetalNode"},{"line_number":72,"context_line":"    baremetal_node_inject \u003d ironicclient.osc.v1.baremetal_node:InjectBaremetalNode"},{"line_number":73,"context_line":"    baremetal_port_create \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":74,"context_line":"    baremetal_port_delete \u003d ironicclient.osc.v1.baremetal_port:DeleteBaremetalPort"},{"line_number":75,"context_line":"    baremetal_port_list \u003d ironicclient.osc.v1.baremetal_port:ListBaremetalPort"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"5a8bc5a2_2956045c","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":25},"in_reply_to":"5a8bc5a2_fe76afd5","updated":"2016-09-26 14:24:07.000000000","message":"It seems that OSC commands usually end with verbs.\nSo, \u0027baremetal_node_inject_nmi\u0027 is not appropriate anyway.\nAlthough another option is \u0027baremetal_node_nmi_inject\u0027, I prefer the order \u0027inject nmi\u0027. Then, I agree that \u0027nmi\u0027 is an argument.","commit_id":"800f084934b68092310c2a825f1ce3358ee8d5e8"}]}
