)]}'
{"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7f43f0ed077bffd9ffb934ab7c6f0b1f983ca154","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        parser.add_argument("},{"line_number":578,"context_line":"            \u0027--target-raid-config\u0027,"},{"line_number":579,"context_line":"            metavar\u003d\u0027\u003ctarget_raid_config\u003e\u0027,"},{"line_number":580,"context_line":"            help\u003d\u0027A file containing JSON data of the RAID configuration. Use \u0027"},{"line_number":581,"context_line":"                 \u0027\"-\" to read the contents from standard input. This can \u0027"},{"line_number":582,"context_line":"                 \u0027also be a valid JSON string.\u0027,"},{"line_number":583,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_47e3a7a3","line":580,"updated":"2016-08-26 17:02:04.000000000","message":"Maybe:\n\n Set the target RAID config of the node. A file containing ...\n\nJust to be sort of consistent with the unset message.","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"db38003315c4bff368c67bbae1a12e8d45acdabb","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        parser.add_argument("},{"line_number":578,"context_line":"            \u0027--target-raid-config\u0027,"},{"line_number":579,"context_line":"            metavar\u003d\u0027\u003ctarget_raid_config\u003e\u0027,"},{"line_number":580,"context_line":"            help\u003d\u0027A file containing JSON data of the RAID configuration. Use \u0027"},{"line_number":581,"context_line":"                 \u0027\"-\" to read the contents from standard input. This can \u0027"},{"line_number":582,"context_line":"                 \u0027also be a valid JSON string.\u0027,"},{"line_number":583,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_806544b6","line":580,"in_reply_to":"fa7ab95a_47e3a7a3","updated":"2016-08-29 14:13:44.000000000","message":"++. I modified the help string a bit too, let me know what you think.","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2c57b2f1d280b94551700681da791263661940e5","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            metavar\u003d\u0027\u003ctarget_raid_config\u003e\u0027,"},{"line_number":580,"context_line":"            help\u003d\u0027A file containing JSON data of the RAID configuration. Use \u0027"},{"line_number":581,"context_line":"                 \u0027\"-\" to read the contents from standard input. This can \u0027"},{"line_number":582,"context_line":"                 \u0027also be a valid JSON string.\u0027,"},{"line_number":583,"context_line":"        )"},{"line_number":584,"context_line":"        parser.add_argument("},{"line_number":585,"context_line":"            \"--property\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_7a9ea857","line":582,"updated":"2016-08-26 08:28:52.000000000","message":"Is it worth mentioning that the overall update is not atomic in this case?","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"db38003315c4bff368c67bbae1a12e8d45acdabb","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            metavar\u003d\u0027\u003ctarget_raid_config\u003e\u0027,"},{"line_number":580,"context_line":"            help\u003d\u0027A file containing JSON data of the RAID configuration. Use \u0027"},{"line_number":581,"context_line":"                 \u0027\"-\" to read the contents from standard input. This can \u0027"},{"line_number":582,"context_line":"                 \u0027also be a valid JSON string.\u0027,"},{"line_number":583,"context_line":"        )"},{"line_number":584,"context_line":"        parser.add_argument("},{"line_number":585,"context_line":"            \"--property\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_40edfced","line":582,"in_reply_to":"fa7ab95a_7a9ea857","updated":"2016-08-29 14:13:44.000000000","message":"Dmitry suggested \u0027RAID configuration is updated separately from the remaining fields\u0027. Thinking a little more about it, I think we should then do it for \u0027baremetal create\u0027, \u0027baremetal node delete\u0027, \u0027baremetal port delete\u0027.\n\nI\u0027d like to check with the openstackclient community about this, so whatever/if we add this, it\u0027ll be in a separate patch.","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"}],"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7f43f0ed077bffd9ffb934ab7c6f0b1f983ca154","unresolved":false,"context_lines":[{"line_number":962,"context_line":"    def test_baremetal_set_target_raid_config(self, mock_handle, mock_stdin):"},{"line_number":963,"context_line":"        target_raid_config_string \u003d \u0027{\"raid\": \"config\"}\u0027"},{"line_number":964,"context_line":"        expected_target_raid_config \u003d {\u0027raid\u0027: \u0027config\u0027}"},{"line_number":965,"context_line":"        mock_handle.return_value \u003d expected_target_raid_config"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"        arglist \u003d [\u0027node_uuid\u0027,"},{"line_number":968,"context_line":"                   \u0027--target-raid-config\u0027, target_raid_config_string]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_42ab9574","line":965,"updated":"2016-08-26 17:02:04.000000000","message":"Should this be:\n  .... \u003d expected_target_raid_config.copy()\n\nJust thinking that the expected value could get mangled inside the function and then we think it is matching what was defined before but in reality it isn\u0027t. Not saying that is happening but...","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"db38003315c4bff368c67bbae1a12e8d45acdabb","unresolved":false,"context_lines":[{"line_number":962,"context_line":"    def test_baremetal_set_target_raid_config(self, mock_handle, mock_stdin):"},{"line_number":963,"context_line":"        target_raid_config_string \u003d \u0027{\"raid\": \"config\"}\u0027"},{"line_number":964,"context_line":"        expected_target_raid_config \u003d {\u0027raid\u0027: \u0027config\u0027}"},{"line_number":965,"context_line":"        mock_handle.return_value \u003d expected_target_raid_config"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"        arglist \u003d [\u0027node_uuid\u0027,"},{"line_number":968,"context_line":"                   \u0027--target-raid-config\u0027, target_raid_config_string]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_5e3882ef","line":965,"in_reply_to":"fa7ab95a_42ab9574","updated":"2016-08-29 14:13:44.000000000","message":"hmm. good point. I guess you can\u0027t be too paranoid :)","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7f43f0ed077bffd9ffb934ab7c6f0b1f983ca154","unresolved":false,"context_lines":[{"line_number":974,"context_line":""},{"line_number":975,"context_line":"        self.assertFalse(mock_stdin.called)"},{"line_number":976,"context_line":"        mock_handle.assert_called_once_with(target_raid_config_string)"},{"line_number":977,"context_line":"        self.baremetal_mock.node.set_target_raid_config.\\"},{"line_number":978,"context_line":"            assert_called_once_with(\u0027node_uuid\u0027, expected_target_raid_config)"},{"line_number":979,"context_line":"        self.assertFalse(self.baremetal_mock.node.update.called)"},{"line_number":980,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_58d0e853","line":977,"updated":"2016-08-26 17:02:04.000000000","message":"Instead of backslash can do:\n\n (self.baremetal_mock.node.set_target_raid_config.\n   assert_called_once_with(\u0027node_uuid\u0027, expected_target_raid_config))\n\nSee http://docs.openstack.org/developer/hacking/#general\n\n It is preferred to wrap long lines in parentheses and not a backslash for line continuation.","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"db38003315c4bff368c67bbae1a12e8d45acdabb","unresolved":false,"context_lines":[{"line_number":974,"context_line":""},{"line_number":975,"context_line":"        self.assertFalse(mock_stdin.called)"},{"line_number":976,"context_line":"        mock_handle.assert_called_once_with(target_raid_config_string)"},{"line_number":977,"context_line":"        self.baremetal_mock.node.set_target_raid_config.\\"},{"line_number":978,"context_line":"            assert_called_once_with(\u0027node_uuid\u0027, expected_target_raid_config)"},{"line_number":979,"context_line":"        self.assertFalse(self.baremetal_mock.node.update.called)"},{"line_number":980,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_00413438","line":977,"in_reply_to":"fa7ab95a_58d0e853","updated":"2016-08-29 14:13:44.000000000","message":"Thanks. It is preferred, but I don\u0027t like it, at least not in this case. If you prefer it, I\u0027ll change it, otherwise, I will leave it as-is.","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7f43f0ed077bffd9ffb934ab7c6f0b1f983ca154","unresolved":false,"context_lines":[{"line_number":984,"context_line":"            self, mock_handle, mock_stdin):"},{"line_number":985,"context_line":"        target_raid_config_string \u003d \u0027{\"raid\": \"config\"}\u0027"},{"line_number":986,"context_line":"        expected_target_raid_config \u003d {\u0027raid\u0027: \u0027config\u0027}"},{"line_number":987,"context_line":"        mock_handle.return_value \u003d expected_target_raid_config"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        arglist \u003d [\u0027node_uuid\u0027,"},{"line_number":990,"context_line":"                   \u0027--name\u0027, \u0027xxxxx\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_b8465421","line":987,"updated":"2016-08-26 17:02:04.000000000","message":"See Line 965 comment","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7f43f0ed077bffd9ffb934ab7c6f0b1f983ca154","unresolved":false,"context_lines":[{"line_number":998,"context_line":""},{"line_number":999,"context_line":"        self.assertFalse(mock_stdin.called)"},{"line_number":1000,"context_line":"        mock_handle.assert_called_once_with(target_raid_config_string)"},{"line_number":1001,"context_line":"        self.baremetal_mock.node.set_target_raid_config.\\"},{"line_number":1002,"context_line":"            assert_called_once_with(\u0027node_uuid\u0027, expected_target_raid_config)"},{"line_number":1003,"context_line":"        self.baremetal_mock.node.update.assert_called_once_with("},{"line_number":1004,"context_line":"            \u0027node_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_9858b0fc","line":1001,"updated":"2016-08-26 17:02:04.000000000","message":"See Line 977 comment","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7f43f0ed077bffd9ffb934ab7c6f0b1f983ca154","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        target_raid_config_string \u003d \u0027{\"raid\": \"config\"}\u0027"},{"line_number":1013,"context_line":"        expected_target_raid_config \u003d {\u0027raid\u0027: \u0027config\u0027}"},{"line_number":1014,"context_line":"        mock_stdin.return_value \u003d target_raid_config_string"},{"line_number":1015,"context_line":"        mock_handle.return_value \u003d expected_target_raid_config"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"        arglist \u003d [\u0027node_uuid\u0027,"},{"line_number":1018,"context_line":"                   \u0027--target-raid-config\u0027, target_value]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_f848dc2f","line":1015,"updated":"2016-08-26 17:02:04.000000000","message":"See Line 965 comment","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7f43f0ed077bffd9ffb934ab7c6f0b1f983ca154","unresolved":false,"context_lines":[{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"        mock_stdin.assert_called_once_with(\u0027target_raid_config\u0027)"},{"line_number":1026,"context_line":"        mock_handle.assert_called_once_with(target_raid_config_string)"},{"line_number":1027,"context_line":"        self.baremetal_mock.node.set_target_raid_config.\\"},{"line_number":1028,"context_line":"            assert_called_once_with(\u0027node_uuid\u0027, expected_target_raid_config)"},{"line_number":1029,"context_line":"        self.assertFalse(self.baremetal_mock.node.update.called)"},{"line_number":1030,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_b85d74eb","line":1027,"updated":"2016-08-26 17:02:04.000000000","message":"See Line 977 comment","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7f43f0ed077bffd9ffb934ab7c6f0b1f983ca154","unresolved":false,"context_lines":[{"line_number":1381,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":1382,"context_line":""},{"line_number":1383,"context_line":"        self.assertFalse(self.baremetal_mock.node.update.called)"},{"line_number":1384,"context_line":"        self.baremetal_mock.node.set_target_raid_config.\\"},{"line_number":1385,"context_line":"            assert_called_once_with(\u0027node_uuid\u0027, {})"},{"line_number":1386,"context_line":""},{"line_number":1387,"context_line":"    def test_baremetal_unset_target_raid_config_and_name(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_f86ffc8f","line":1384,"updated":"2016-08-26 17:02:04.000000000","message":"See Line 977 comment","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7f43f0ed077bffd9ffb934ab7c6f0b1f983ca154","unresolved":false,"context_lines":[{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"        self.baremetal_mock.node.set_target_raid_config.\\"},{"line_number":1404,"context_line":"            assert_called_once_with(\u0027node_uuid\u0027, {})"},{"line_number":1405,"context_line":"        self.baremetal_mock.node.update.assert_called_once_with("},{"line_number":1406,"context_line":"            \u0027node_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_386a4481","line":1403,"updated":"2016-08-26 17:02:04.000000000","message":"See Line 977 comment","commit_id":"835987b6a1bfcbd87cd70a8142dc2d8e18ca8313"}]}