)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"484f20747d66f239b4a12dca640791a4eeb31b8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofiia Andriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-28 05:12:06 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I182303194519042b2b87fe7f4cae021c1dd91e6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_db6aef80","line":7,"updated":"2016-08-29 10:58:29.000000000","message":"It does not contain tests for all node actions, please list the ones that are included here.","commit_id":"e828ab53a952a404c59d5d60e09c1381c0dbfa98"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"607c6e65ff3682b5e0c2cfccfa55157585510022","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofiia Andriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-28 05:12:06 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I182303194519042b2b87fe7f4cae021c1dd91e6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_d02b1e93","line":7,"in_reply_to":"fa7ab95a_db6aef80","updated":"2016-08-31 08:03:00.000000000","message":"Done","commit_id":"e828ab53a952a404c59d5d60e09c1381c0dbfa98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"444b7e5ed2b86be2317c863dd7ff636545fc59bc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofiia Andriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-31 03:52:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with node:"},{"line_number":8,"context_line":"   test_node_show_states"},{"line_number":9,"context_line":"   test_node_show"},{"line_number":10,"context_line":"   test_node_validate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_dfe7a944","line":7,"updated":"2016-08-31 09:21:16.000000000","message":"The title should be separated from the message itself. I\u0027d suggest the following:\n\n Negative tests for testing actions with node\n\n The negative tests in this change pass an incorrect node\n identifier to the following commands:\n \n * ironic node-show-states\n * ironic node-show\n * ironic node-validate\n * ironic node-set-boot-device\n * ironic node-set-power-state\n * ironic node-set-provision-state\n * ironic node-set-console-mode\n * ironic node-set-maintenance\n * ironic node-update","commit_id":"ee888b4c54800fc28c602046da057b759558be49"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"9631b83693d28e338a2a5e69776a19cbbbfc801a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofiia Andriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-31 03:52:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Negative tests for testing actions with node:"},{"line_number":8,"context_line":"   test_node_show_states"},{"line_number":9,"context_line":"   test_node_show"},{"line_number":10,"context_line":"   test_node_validate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_c057a8c8","line":7,"in_reply_to":"fa7ab95a_dfe7a944","updated":"2016-09-01 07:57:59.000000000","message":"Done","commit_id":"ee888b4c54800fc28c602046da057b759558be49"}],"ironicclient/tests/functional/test_node_negative.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"484f20747d66f239b4a12dca640791a4eeb31b8f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"\"\"Negative tests for testing actions with Node."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Negative test for the Ironic CLI commands which checks actions with"},{"line_number":27,"context_line":"    node command like use commands without arguments or with"},{"line_number":28,"context_line":"    incorrect arguments and check that correct error message"},{"line_number":29,"context_line":"    raised."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_3b7bdb8d","line":27,"range":{"start_line":27,"start_character":17,"end_line":27,"end_character":25},"updated":"2016-08-29 10:58:29.000000000","message":"by using","commit_id":"e828ab53a952a404c59d5d60e09c1381c0dbfa98"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"607c6e65ff3682b5e0c2cfccfa55157585510022","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"\"\"Negative tests for testing actions with Node."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Negative test for the Ironic CLI commands which checks actions with"},{"line_number":27,"context_line":"    node command like use commands without arguments or with"},{"line_number":28,"context_line":"    incorrect arguments and check that correct error message"},{"line_number":29,"context_line":"    raised."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_50162e56","line":27,"range":{"start_line":27,"start_character":17,"end_line":27,"end_character":25},"in_reply_to":"fa7ab95a_3b7bdb8d","updated":"2016-08-31 08:03:00.000000000","message":"Done","commit_id":"e828ab53a952a404c59d5d60e09c1381c0dbfa98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"484f20747d66f239b4a12dca640791a4eeb31b8f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def test_node_set_boot_device(self, value, ex_text):"},{"line_number":62,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"},{"line_number":63,"context_line":"                              ex_text, self.ironic, \u0027node-set-boot-device\u0027,"},{"line_number":64,"context_line":"                              params\u003d\u0027{0} pxe\u0027.format(value))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @ddt.data(*data)"},{"line_number":67,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_fbc33355","line":64,"range":{"start_line":64,"start_character":42,"end_line":64,"end_character":45},"updated":"2016-08-29 10:58:29.000000000","message":"What about incorrect values here, eg setting boot device to abcd. ditto for the following tests.","commit_id":"e828ab53a952a404c59d5d60e09c1381c0dbfa98"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"2d86e989548bb30b2c5256ad9d1ff58bfb3f5490","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def test_node_set_boot_device(self, value, ex_text):"},{"line_number":62,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed,"},{"line_number":63,"context_line":"                              ex_text, self.ironic, \u0027node-set-boot-device\u0027,"},{"line_number":64,"context_line":"                              params\u003d\u0027{0} pxe\u0027.format(value))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @ddt.data(*data)"},{"line_number":67,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_8e80988d","line":64,"range":{"start_line":64,"start_character":42,"end_line":64,"end_character":45},"in_reply_to":"fa7ab95a_fbc33355","updated":"2016-08-31 07:40:01.000000000","message":"I agree with you. It\u0027s good idea but I think for another patch","commit_id":"e828ab53a952a404c59d5d60e09c1381c0dbfa98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"444b7e5ed2b86be2317c863dd7ff636545fc59bc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    data \u003d ((\u0027\u0027, (r\u0027too few arguments\u0027)),"},{"line_number":33,"context_line":"            (\u00271234-1234-1234\u0027, (r\u0027could not be found\u0027)),"},{"line_number":34,"context_line":"            (\u00271234 1234\u0027, (r\u0027unrecognized arguments\u0027)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @ddt.data(*data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_bfee65b2","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":28},"updated":"2016-08-31 09:21:16.000000000","message":"IIUC this should be testing incorrect node identifiers, but this one is actually correct, which is what the message says - the node can not be found. If you\u0027ll change - to some other special symbol, the tests will be showing this. See e.g. what Sergii has done here - https://review.openstack.org/#/c/342060/8/ironicclient/tests/functional/test_node_negative.py","commit_id":"ee888b4c54800fc28c602046da057b759558be49"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"9631b83693d28e338a2a5e69776a19cbbbfc801a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    data \u003d ((\u0027\u0027, (r\u0027too few arguments\u0027)),"},{"line_number":33,"context_line":"            (\u00271234-1234-1234\u0027, (r\u0027could not be found\u0027)),"},{"line_number":34,"context_line":"            (\u00271234 1234\u0027, (r\u0027unrecognized arguments\u0027)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @ddt.data(*data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_00f990c8","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":28},"in_reply_to":"fa7ab95a_bfee65b2","updated":"2016-09-01 07:57:59.000000000","message":"Done","commit_id":"ee888b4c54800fc28c602046da057b759558be49"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd04e994c8a54d25aa4abcc99cc49ab132b94fe9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    data \u003d ((\u0027\u0027, (r\u0027too few arguments\u0027)),"},{"line_number":33,"context_line":"            (\u00271234~1234~1234\u0027, (r\u0027unable to convert to uuid_or_name\u0027)),"},{"line_number":34,"context_line":"            (\u00271234 1234\u0027, (r\u0027unrecognized arguments\u0027)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @ddt.data(*data)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_401b3cca","line":33,"range":{"start_line":33,"start_character":13,"end_line":33,"end_character":69},"updated":"2016-09-01 22:10:33.000000000","message":"in this case the message from node-validate is different, please see here - http://logs.openstack.org/83/361583/7/check/gate-ironicclient-dsvm-functional/50fd221/console.html and change accordingly (and it happens only in case of node-validate, node-show and node-show-states remain the same for now)","commit_id":"f1668a7a524d0032e0784e22db3febd303ab8d03"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"304bd8897c802339fe0f9ca9c0b5d2b2adbbc3f0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    data \u003d ((\u0027\u0027, (r\u0027too few arguments\u0027)),"},{"line_number":33,"context_line":"            (\u00271234~1234~1234\u0027, (r\u0027unable to convert to uuid_or_name\u0027)),"},{"line_number":34,"context_line":"            (\u00271234 1234\u0027, (r\u0027unrecognized arguments\u0027)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @ddt.data(*data)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a430d35_4693015b","line":33,"range":{"start_line":33,"start_character":13,"end_line":33,"end_character":69},"in_reply_to":"fa7ab95a_401b3cca","updated":"2017-02-09 13:04:08.000000000","message":"Done","commit_id":"f1668a7a524d0032e0784e22db3febd303ab8d03"}]}