)]}'
{".gitignore":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c451687c83b582f1a37b8fa0e6087afdf6586afb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Compiled files"},{"line_number":2,"context_line":"*.py[co]"},{"line_number":3,"context_line":"*.a"},{"line_number":4,"context_line":"*.o"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa7ab95a_eceb1b11","side":"PARENT","line":1,"updated":"2016-08-30 15:28:37.000000000","message":"why did you delete this file?","commit_id":"e1e8d63a98212de308e916da4bbfd1425c78e1b5"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"9e665d0454b40e3f67e2a40126a8028f97525b6e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Compiled files"},{"line_number":2,"context_line":"*.py[co]"},{"line_number":3,"context_line":"*.a"},{"line_number":4,"context_line":"*.o"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa7ab95a_d3da32e9","side":"PARENT","line":1,"in_reply_to":"fa7ab95a_eceb1b11","updated":"2016-08-31 13:22:48.000000000","message":"Done","commit_id":"e1e8d63a98212de308e916da4bbfd1425c78e1b5"}],"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c451687c83b582f1a37b8fa0e6087afdf6586afb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Galyna Zholtkevych \u003cgzholtkevych@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-30 15:59:40 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related"},{"line_number":10,"context_line":"to the drivers:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_757fce14","line":7,"updated":"2016-08-30 15:28:37.000000000","message":"You should update the commit, since you\u0027re adding a --raid_logical_disk_properties to openstack baremetal driver show.","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"9e665d0454b40e3f67e2a40126a8028f97525b6e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Galyna Zholtkevych \u003cgzholtkevych@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-30 15:59:40 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related"},{"line_number":10,"context_line":"to the drivers:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_d353126b","line":7,"in_reply_to":"fa7ab95a_757fce14","updated":"2016-08-31 13:22:48.000000000","message":"Done","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"1a24aa416523566c7295a11d1ee8a56334778e7e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Galyna Zholtkevych \u003cgzholtkevych@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-31 16:17:51 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related"},{"line_number":10,"context_line":"to the drivers:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_a662bcab","line":7,"updated":"2016-08-31 16:18:05.000000000","message":"Please write more specific caption.","commit_id":"0554e567200cf60da5e51cbbeb3314f51d28039c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6afcab8ff510ff23d45bf0c28fd1f5d172bf48c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Galyna Zholtkevych \u003cgzholtkevych@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-31 16:17:51 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related"},{"line_number":10,"context_line":"to the drivers:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_3e35e2f6","line":7,"updated":"2016-08-31 21:38:16.000000000","message":"how about\n\nAdd --raid-logical-disk-properties\u0027 to osc driver show","commit_id":"0554e567200cf60da5e51cbbeb3314f51d28039c"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"05ca7fc3f2b2a5b768cd3959203dde8e8c99f13e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Galyna Zholtkevych \u003cgzholtkevych@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-31 16:17:51 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related"},{"line_number":10,"context_line":"to the drivers:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a89bdaa_b14b6c86","line":7,"in_reply_to":"fa7ab95a_3e35e2f6","updated":"2016-09-07 12:10:02.000000000","message":"I would propose it as\nopenstack baremetal driver raid-logical-disk-properties show\n\nraid option looks like entire inseparable one, so it may be put together separated somehow by some signs","commit_id":"0554e567200cf60da5e51cbbeb3314f51d28039c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6afcab8ff510ff23d45bf0c28fd1f5d172bf48c3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related"},{"line_number":10,"context_line":"to the drivers:"},{"line_number":11,"context_line":"  openstack baremetal driver show"},{"line_number":12,"context_line":"\t--raid-logical-disk-properties."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_99a9a8e2","line":10,"updated":"2016-08-31 21:38:16.000000000","message":"that\u0027s not true because it isn\u0027t a new command.\n\nHow about \n\nAdds option \u0027--raid-logical-disk-properties\u0027 to the \u0027openstack baremetal driver show\u0027 command. This will result in showing the RAID logical disk properties of a driver.","commit_id":"0554e567200cf60da5e51cbbeb3314f51d28039c"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"05ca7fc3f2b2a5b768cd3959203dde8e8c99f13e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related"},{"line_number":10,"context_line":"to the drivers:"},{"line_number":11,"context_line":"  openstack baremetal driver show"},{"line_number":12,"context_line":"\t--raid-logical-disk-properties."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a89bdaa_31603c01","line":10,"in_reply_to":"fa7ab95a_99a9a8e2","updated":"2016-09-07 12:10:02.000000000","message":"Done","commit_id":"0554e567200cf60da5e51cbbeb3314f51d28039c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ef8cae1d96856456f6175d985514d804dce0fe3d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Galyna Zholtkevych \u003cgzholtkevych@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-07 15:01:32 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related to"},{"line_number":10,"context_line":"the drivers:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a89bdaa_01c8ca73","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":42},"updated":"2016-09-09 11:06:07.000000000","message":"Write some more specific message like: \"Add command to show driver RAID logical disk properties\".","commit_id":"fde2f7cd4a3d74e4ba418093406096a4786f30df"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"b5dddebc7b87b1508076583433523293fc0f8e9e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Galyna Zholtkevych \u003cgzholtkevych@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-07 15:01:32 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related to"},{"line_number":10,"context_line":"the drivers:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a89bdaa_4f62f917","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":42},"in_reply_to":"9a89bdaa_01c8ca73","updated":"2016-09-09 11:45:58.000000000","message":"Done. I corrected your proposition a little bit in order to satisfy rules of git commit messages","commit_id":"fde2f7cd4a3d74e4ba418093406096a4786f30df"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"c58c0f45e55e5e0b392639d6eef6902d5acde096","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Galyna Zholtkevych \u003cgzholtkevych@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-07 15:01:32 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack baremetal driver commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related to"},{"line_number":10,"context_line":"the drivers:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a89bdaa_d0406638","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":42},"in_reply_to":"9a89bdaa_4f62f917","updated":"2016-09-09 12:20:25.000000000","message":"Wonderful! :)","commit_id":"fde2f7cd4a3d74e4ba418093406096a4786f30df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"817d2fde423a80de8c6ad7a782997d376452e985","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extends the OSC plugin with new commands related to"},{"line_number":10,"context_line":"the drivers:"},{"line_number":11,"context_line":"  openstack baremetal driver raid-logical-disk-properties show"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Updated patch as a proposition: how to specify this command"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa31d9ce_dbadd332","line":11,"updated":"2017-02-10 15:00:50.000000000","message":"I have a gut feeling that this command is too long :) what about\n\n openstack baremetal driver raid properties show\n\n? It\u0027s also a bit longer than I wanted, but I don\u0027t have suggestions how to shorten it even more.\n\nNote that we don\u0027t use dashes in OSC commands, and your patch is not using them as well.","commit_id":"8e70f5ff1754deb9cdb4226b1e2b7764c6bc8576"}],"ironicclient/osc/v1/baremetal_driver.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c451687c83b582f1a37b8fa0e6087afdf6586afb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--raid-logical-disk-properties\u0027,"},{"line_number":62,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":63,"context_line":"            help\u003d\"The option used to show driver raid logical disk properties\""},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":"        return parser"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_ecd5db1b","line":63,"updated":"2016-08-30 15:28:37.000000000","message":"Maybe \u0027Only show the RAID logical disk properties for the driver\u0027","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"9e665d0454b40e3f67e2a40126a8028f97525b6e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--raid-logical-disk-properties\u0027,"},{"line_number":62,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":63,"context_line":"            help\u003d\"The option used to show driver raid logical disk properties\""},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":"        return parser"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_f3d736bd","line":63,"in_reply_to":"fa7ab95a_ecd5db1b","updated":"2016-08-31 13:22:48.000000000","message":"Done","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c451687c83b582f1a37b8fa0e6087afdf6586afb","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        driver \u003d baremetal_client.driver.get(parsed_args.driver_name)._info"},{"line_number":77,"context_line":"        driver.pop(\"links\", None)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return zip(*sorted(driver.items()))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_cc71f70d","line":78,"updated":"2016-08-30 15:28:37.000000000","message":"probably better not to have this blank line","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"9e665d0454b40e3f67e2a40126a8028f97525b6e","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        driver \u003d baremetal_client.driver.get(parsed_args.driver_name)._info"},{"line_number":77,"context_line":"        driver.pop(\"links\", None)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return zip(*sorted(driver.items()))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_f3fe5637","line":78,"in_reply_to":"fa7ab95a_cc71f70d","updated":"2016-08-31 13:22:48.000000000","message":"Done","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c451687c83b582f1a37b8fa0e6087afdf6586afb","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def get_parser(self, prog_name):"},{"line_number":109,"context_line":"        parser \u003d super(BaremetalDriverPassthruShow, self).get_parser("},{"line_number":110,"context_line":"            prog_name)"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027driver_name\u0027,"},{"line_number":113,"context_line":"            metavar\u003d\u0027\u003cdriver\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_ccec97bd","line":110,"updated":"2016-08-30 15:28:37.000000000","message":"why did you modify this?","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6afcab8ff510ff23d45bf0c28fd1f5d172bf48c3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        parser.add_argument("},{"line_number":62,"context_line":"            \u0027--raid-logical-disk-properties\u0027,"},{"line_number":63,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":64,"context_line":"            help\u003d\"The option used to show driver raid logical disk properties\""},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        return parser"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_1969188c","line":64,"updated":"2016-08-31 21:38:16.000000000","message":"how about \u0027Only show the RAID logical disk properties for the driver\u0027","commit_id":"0554e567200cf60da5e51cbbeb3314f51d28039c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"ef8cae1d96856456f6175d985514d804dce0fe3d","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class ShowBaremetalDriverRaidLogicalDiskProperties(command.ShowOne):"},{"line_number":164,"context_line":"    \"\"\"Show information about a driver.\"\"\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    log \u003d logging.getLogger(__name__ + \".ShowBaremetalDriver\")"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_01552ac5","line":164,"range":{"start_line":164,"start_character":7,"end_line":164,"end_character":39},"updated":"2016-09-09 11:06:07.000000000","message":"This docstring is copypaste from class ShowBaremetalDriver. \nPlease update it according to new one.","commit_id":"fde2f7cd4a3d74e4ba418093406096a4786f30df"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"b5dddebc7b87b1508076583433523293fc0f8e9e","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class ShowBaremetalDriverRaidLogicalDiskProperties(command.ShowOne):"},{"line_number":164,"context_line":"    \"\"\"Show information about a driver.\"\"\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    log \u003d logging.getLogger(__name__ + \".ShowBaremetalDriver\")"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_8f6c010a","line":164,"range":{"start_line":164,"start_character":7,"end_line":164,"end_character":39},"in_reply_to":"9a89bdaa_01552ac5","updated":"2016-09-09 11:45:58.000000000","message":"Done","commit_id":"fde2f7cd4a3d74e4ba418093406096a4786f30df"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"c58c0f45e55e5e0b392639d6eef6902d5acde096","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class ShowBaremetalDriverRaidLogicalDiskProperties(command.ShowOne):"},{"line_number":164,"context_line":"    \"\"\"Show information about a driver.\"\"\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    log \u003d logging.getLogger(__name__ + \".ShowBaremetalDriver\")"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_907b3e7b","line":164,"range":{"start_line":164,"start_character":7,"end_line":164,"end_character":39},"in_reply_to":"9a89bdaa_8f6c010a","updated":"2016-09-09 12:20:25.000000000","message":"Thanks!","commit_id":"fde2f7cd4a3d74e4ba418093406096a4786f30df"}],"ironicclient/tests/unit/osc/v1/test_baremetal_driver.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c451687c83b582f1a37b8fa0e6087afdf6586afb","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class TestBaremetalDriverShowRaidLogicalDiskProperties(TestBaremetalDriver):"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def setUp(self):"},{"line_number":107,"context_line":"        super(TestBaremetalDriverShowRaidLogicalDiskProperties, self).setUp()"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_754eee3b","line":105,"updated":"2016-08-30 15:28:37.000000000","message":"I\u0027d actually combine this with the above TestBaremetalDriverShow. Then you can show that eg self.baremetal_mock.driver.show is not called if --raid-blah-blah was specified.\n\nAnd test_baremetal_raid_logical_disk_properties_no_arg is basically the same thing (same code) as test_baremetal_driver_show_no_arg.","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"9e665d0454b40e3f67e2a40126a8028f97525b6e","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class TestBaremetalDriverShowRaidLogicalDiskProperties(TestBaremetalDriver):"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def setUp(self):"},{"line_number":107,"context_line":"        super(TestBaremetalDriverShowRaidLogicalDiskProperties, self).setUp()"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_936c2a0a","line":105,"in_reply_to":"fa7ab95a_754eee3b","updated":"2016-08-31 13:22:48.000000000","message":"Done","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c451687c83b582f1a37b8fa0e6087afdf6586afb","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_baremetal_raid_logical_disk_properties(self):"},{"line_number":117,"context_line":"        arglist \u003d [\u0027fakedrivername\u0027, \u0027--raid-logical-disk-properties\u0027]"},{"line_number":118,"context_line":"        verifylist \u003d [(\u0027driver_name\u0027, baremetal_fakes.baremetal_driver_name), ]"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_95cc528a","line":118,"updated":"2016-08-30 15:28:37.000000000","message":"does this work? I would have thought you\u0027d need (\u0027raid_logical_disk_properties\u0027, True) or something like that.","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"9e665d0454b40e3f67e2a40126a8028f97525b6e","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_baremetal_raid_logical_disk_properties(self):"},{"line_number":117,"context_line":"        arglist \u003d [\u0027fakedrivername\u0027, \u0027--raid-logical-disk-properties\u0027]"},{"line_number":118,"context_line":"        verifylist \u003d [(\u0027driver_name\u0027, baremetal_fakes.baremetal_driver_name), ]"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_5349c28d","line":118,"in_reply_to":"fa7ab95a_95cc528a","updated":"2016-08-31 13:22:48.000000000","message":"Yes, exactly this works for me. \nAs action parameter in add_argument method store the default true, it does not require to put the parameter for \n--raid-logical-disk-properties","commit_id":"e9f1ee3e304bb6a85f55b2c043e0e498834bb163"}],"releasenotes/notes/osc-baremetal-driver-raid-properties-159bd57058c0fc0e.yaml":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"31558a474839ffd657d0dfd420b3158dd759be5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds command `openstack baremetal driver raid properies show\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa31d9ce_09cb5e73","line":3,"range":{"start_line":3,"start_character":64,"end_line":3,"end_character":65},"updated":"2017-02-13 13:36:30.000000000","message":"Incorrect closing quote caused release notes check to failure.","commit_id":"6ccfd9bf51ea73baad5747c9e4dc0a5bae5f2235"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6443e7426a08ddb13fe503bc2bbde75459525c79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the `openstack baremetal driver raid property list \u003cdriver\u003e`"},{"line_number":4,"context_line":"    command. For a specified driver, this returns a list of the"},{"line_number":5,"context_line":"    RAID logical disk properties that can be specified, along with"},{"line_number":6,"context_line":"    a description for each property. (The values of these properties"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7f231b9d_c1e675e9","line":3,"updated":"2017-06-12 10:43:41.000000000","message":"nit: `` instead of `","commit_id":"b00d74a57eb841d71c2daf89774859f6e7dba44e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b63f4a2b5d6a80cc185a4aa538d448300ed735f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds the `openstack baremetal driver raid property list \u003cdriver\u003e`"},{"line_number":4,"context_line":"    command. For a specified driver, this returns a list of the"},{"line_number":5,"context_line":"    RAID logical disk properties that can be specified, along with"},{"line_number":6,"context_line":"    a description for each property. (The values of these properties"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7f231b9d_ce0fb92c","line":3,"in_reply_to":"7f231b9d_c1e675e9","updated":"2017-06-12 14:34:55.000000000","message":"yeah, good to make consistent. thx.","commit_id":"b00d74a57eb841d71c2daf89774859f6e7dba44e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6443e7426a08ddb13fe503bc2bbde75459525c79","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    command. For a specified driver, this returns a list of the"},{"line_number":5,"context_line":"    RAID logical disk properties that can be specified, along with"},{"line_number":6,"context_line":"    a description for each property. (The values of these properties"},{"line_number":7,"context_line":"    are specified in a node\u0027s `target_raid_config` field.)"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7f231b9d_a1eb79ae","line":7,"updated":"2017-06-12 10:43:41.000000000","message":"ditto","commit_id":"b00d74a57eb841d71c2daf89774859f6e7dba44e"}]}