)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5d9ddede30de4771b04ffc28a10d76bf42db2d05","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  * list"},{"line_number":13,"context_line":"  * show"},{"line_number":14,"context_line":"  * set"},{"line_number":15,"context_line":"  * unset"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Kyrylo Romanenko \u003ckromanenko@mirantis.com\u003e"},{"line_number":18,"context_line":"Change-Id: Ic9c37495a82b9115d97f9b330cc13a1063f8b529"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9a629dbe_99857cd0","line":15,"updated":"2016-11-11 13:02:47.000000000","message":"missed Partial-Bug: 1618754","commit_id":"886c8c3896ef70432482985e47df76609427f09d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"eb58059259363a269f5683209e55fb3e3f758b8d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  * list"},{"line_number":13,"context_line":"  * show"},{"line_number":14,"context_line":"  * set"},{"line_number":15,"context_line":"  * unset"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Kyrylo Romanenko \u003ckromanenko@mirantis.com\u003e"},{"line_number":18,"context_line":"Change-Id: Ic9c37495a82b9115d97f9b330cc13a1063f8b529"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9a629dbe_c53519a9","line":15,"in_reply_to":"9a629dbe_99857cd0","updated":"2016-11-14 08:23:17.000000000","message":"Done","commit_id":"886c8c3896ef70432482985e47df76609427f09d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d2dd273674ec6274eb8a827fdad5ac57043bad86","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  * set"},{"line_number":15,"context_line":"  * unset"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Bump osc client last known api version to 1.25"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related-Bug: #1618754"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1a6eadb0_057bde28","line":17,"updated":"2016-12-16 01:46:24.000000000","message":"Oh. I\u0027m guessing this bumped it, but then it got bumped in a separate patch? If someone else +2\u0027s this, I think it would be OK to edit this, and then +A it all. Or update and get it reviewed again...","commit_id":"f63f04b8f897c1d49fffda4390286b8e3e6a42df"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b09c391664202bcaf92d9d1d3d1af0891b2ba5b2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  * set"},{"line_number":15,"context_line":"  * unset"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Bump osc client last known api version to 1.25"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related-Bug: #1618754"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1a6eadb0_d78653da","line":17,"in_reply_to":"1a6eadb0_057bde28","updated":"2016-12-20 17:21:04.000000000","message":"indeed this was bumped in another change: https://github.com/openstack/python-ironicclient/commit/4e359baf4d99b306e83b496ffefa8bc0a9224b6a\n\nand now it is not visible here, removed mention from commit message.","commit_id":"f63f04b8f897c1d49fffda4390286b8e3e6a42df"}],"ironicclient/osc/v1/baremetal_port.py":[{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"72bd839d4ea2c6084c715102763dfc8fd5304a90","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        if parsed_args.portgroup_uuid:"},{"line_number":193,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027remove\u0027,"},{"line_number":194,"context_line":"                              [\u0027portgroup_uuid\u0027]))"},{"line_number":195,"context_line":"        if not properties:"},{"line_number":196,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        baremetal_client.port.update(parsed_args.port, properties)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_b624140d","line":196,"range":{"start_line":195,"start_character":12,"end_line":196,"end_character":61},"updated":"2016-11-11 10:19:07.000000000","message":"If the user did not specify what to unset, should not it be an error, because he will not get any result in this case?","commit_id":"886c8c3896ef70432482985e47df76609427f09d"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"cd818baad9eb83f2e86f760d2515033c7d7c5ad7","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        if parsed_args.portgroup_uuid:"},{"line_number":193,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027remove\u0027,"},{"line_number":194,"context_line":"                              [\u0027portgroup_uuid\u0027]))"},{"line_number":195,"context_line":"        if not properties:"},{"line_number":196,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        baremetal_client.port.update(parsed_args.port, properties)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_09bacbc0","line":196,"range":{"start_line":195,"start_character":12,"end_line":196,"end_character":61},"in_reply_to":"9a629dbe_45c3c98a","updated":"2016-11-14 09:01:15.000000000","message":"Thanks. \nI have a patch up fixing that in osc https://review.openstack.org/#/c/384345/","commit_id":"886c8c3896ef70432482985e47df76609427f09d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"eb58059259363a269f5683209e55fb3e3f758b8d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        if parsed_args.portgroup_uuid:"},{"line_number":193,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027remove\u0027,"},{"line_number":194,"context_line":"                              [\u0027portgroup_uuid\u0027]))"},{"line_number":195,"context_line":"        if not properties:"},{"line_number":196,"context_line":"            self.log.warning(\"Please specify what to unset.\")"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        baremetal_client.port.update(parsed_args.port, properties)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_45c3c98a","line":196,"range":{"start_line":195,"start_character":12,"end_line":196,"end_character":61},"in_reply_to":"9a629dbe_b624140d","updated":"2016-11-14 08:23:17.000000000","message":"Other commands like for example: \u0027openstack server unset \u003cserver-uuid\u003e\u0027 just silently ignore if no paramters are specified. This behaviour is not right to me, as {set|unset} requires at least one property to be specified. We need to raise this question at openstack-dev.","commit_id":"886c8c3896ef70432482985e47df76609427f09d"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"72bd839d4ea2c6084c715102763dfc8fd5304a90","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            portgroup_uuid \u003d [\"portgroup_uuid\u003d%s\" % parsed_args.portgroup_uuid]"},{"line_number":259,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027add\u0027, portgroup_uuid))"},{"line_number":260,"context_line":"        if not properties:"},{"line_number":261,"context_line":"            self.log.warning(\"Please specify what to set.\")"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        baremetal_client.port.update(parsed_args.port, properties)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_d6e6e842","line":261,"range":{"start_line":261,"start_character":12,"end_line":261,"end_character":59},"updated":"2016-11-11 10:19:07.000000000","message":"ditto","commit_id":"886c8c3896ef70432482985e47df76609427f09d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027--port-group\u0027,"},{"line_number":79,"context_line":"            dest\u003d\u0027portgroup_uuid\u0027,"},{"line_number":80,"context_line":"            metavar\u003d\u0027\u003cuuid\u003e\u0027,"},{"line_number":81,"context_line":"            help\u003d\"UUID of the port group that this port belongs to.\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        return parser"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_022da6fd","line":81,"updated":"2016-12-15 18:44:11.000000000","message":"I don\u0027t know if we need to mention that this is optional, since it looks like these are all under \u0027optional\u0027. Probably good for now.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            \"--port-group\","},{"line_number":242,"context_line":"            metavar\u003d\"\u003cuuid\u003e\","},{"line_number":243,"context_line":"            dest\u003d\u0027portgroup_uuid\u0027,"},{"line_number":244,"context_line":"            help\u003d\u0027Update port\\\u0027s port group membership.\u0027)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        return parser"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_0d54f7fc","line":244,"updated":"2016-12-15 18:44:11.000000000","message":"may be a nit. to be more consistent with the help for the node, how about \u0027Set UUID of the port group that this port belongs to.\u0027 (That\u0027s also what is used in the port-create)","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            \"--port-group\","},{"line_number":242,"context_line":"            metavar\u003d\"\u003cuuid\u003e\","},{"line_number":243,"context_line":"            dest\u003d\u0027portgroup_uuid\u0027,"},{"line_number":244,"context_line":"            help\u003d\u0027Update port\\\u0027s port group membership.\u0027)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        return parser"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_07420b68","line":244,"in_reply_to":"1a6eadb0_0d54f7fc","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"}],"ironicclient/osc/v1/baremetal_portgroup.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a26270721f50d6cb417f226cbf4a801213999389","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        standalone_ports_group.add_argument("},{"line_number":59,"context_line":"            \u0027--support-standalone-ports\u0027,"},{"line_number":60,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":61,"context_line":"            default\u003dNone,"},{"line_number":62,"context_line":"            help\u003d\"Ports that are members of this portgroup \""},{"line_number":63,"context_line":"                 \"can be used as stand-alone ports.\""},{"line_number":64,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a74a57a_dcc16582","line":61,"updated":"2016-11-23 14:14:08.000000000","message":"the default is redundant","commit_id":"096f7b64cfa7c1556fb1493dd91692ebce7d219d"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d6e27116d29597b166c242d4fc6151603334b627","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        standalone_ports_group.add_argument("},{"line_number":59,"context_line":"            \u0027--support-standalone-ports\u0027,"},{"line_number":60,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":61,"context_line":"            default\u003dNone,"},{"line_number":62,"context_line":"            help\u003d\"Ports that are members of this portgroup \""},{"line_number":63,"context_line":"                 \"can be used as stand-alone ports.\""},{"line_number":64,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a74a57a_c43923d9","line":61,"in_reply_to":"5a74a57a_dcc16582","updated":"2016-11-25 16:51:44.000000000","message":"Done","commit_id":"096f7b64cfa7c1556fb1493dd91692ebce7d219d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class CreateBaremetalPortGroup(command.ShowOne):"},{"line_number":30,"context_line":"    \"\"\"Create a new baremetal portgroup.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetalPortGroup\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_22b45d80","line":30,"updated":"2016-12-15 18:44:11.000000000","message":"this is shown in the help, so s/portgroup/port group/","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class CreateBaremetalPortGroup(command.ShowOne):"},{"line_number":30,"context_line":"    \"\"\"Create a new baremetal portgroup.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetalPortGroup\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_47608301","line":30,"in_reply_to":"1a6eadb0_22b45d80","updated":"2016-12-15 22:47:18.000000000","message":"Good catch, forgot about that!","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"},{"line_number":35,"context_line":"        parser \u003d super(CreateBaremetalPortGroup, self).get_parser(prog_name)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027--address\u0027,"},{"line_number":39,"context_line":"            metavar\u003d\u0027\u003cmac-address\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_e8bb29e3","line":36,"updated":"2016-12-15 18:44:11.000000000","message":"we also allow --uuid (see ironic portgroup-create)","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"},{"line_number":35,"context_line":"        parser \u003d super(CreateBaremetalPortGroup, self).get_parser(prog_name)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027--address\u0027,"},{"line_number":39,"context_line":"            metavar\u003d\u0027\u003cmac-address\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_abf5a1ed","line":36,"in_reply_to":"1a6eadb0_e8bb29e3","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":67,"context_line":"            help\u003d\"Ports that are members of this port group \""},{"line_number":68,"context_line":"                 \"cannot be used as stand-alone ports.\""},{"line_number":69,"context_line":"        )"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        return parser"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_2dcff329","line":69,"updated":"2016-12-15 18:44:11.000000000","message":"I was wondering if we needed both --support-standalone-ports and --unsupport-standalone-ports. The default is unsupported, right? So it should be sufficient to just allow them to specify --support-standalone-ports.\n\nIf we want to have both, then I think we ought to indicate in the help of both, what the default value is if they don\u0027t specify either of them.\n\nI think this is the first case I\u0027ve seen for this in our osc. Not sure what osc does in general in these cases.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":67,"context_line":"            help\u003d\"Ports that are members of this port group \""},{"line_number":68,"context_line":"                 \"cannot be used as stand-alone ports.\""},{"line_number":69,"context_line":"        )"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        return parser"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_cb449d4b","line":69,"in_reply_to":"1a6eadb0_2dcff329","updated":"2016-12-15 22:47:18.000000000","message":"default is supported. Seems like the docs suggest having both - http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class ShowBaremetalPortGroup(command.ShowOne):"},{"line_number":95,"context_line":"    \"\"\"Show baremetal portgroup details.\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    log \u003d logging.getLogger(__name__ + \".ShowBaremetalPortGroup\")"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_c28e49cf","line":95,"updated":"2016-12-15 18:44:11.000000000","message":"this is shown in the help, so s/portgroup/port group/","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class ShowBaremetalPortGroup(command.ShowOne):"},{"line_number":95,"context_line":"    \"\"\"Show baremetal portgroup details.\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    log \u003d logging.getLogger(__name__ + \".ShowBaremetalPortGroup\")"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_ebdb197a","line":95,"in_reply_to":"1a6eadb0_c28e49cf","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":111,"context_line":"            default\u003dFalse,"},{"line_number":112,"context_line":"            help\u003d\u0027\u003cport group\u003e is the MAC address (instead of the UUID) of the\u0027"},{"line_number":113,"context_line":"                 \u0027 port group.\u0027)"},{"line_number":114,"context_line":"        parser.add_argument("},{"line_number":115,"context_line":"            \u0027--fields\u0027,"},{"line_number":116,"context_line":"            nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_85dc5b74","line":113,"updated":"2016-12-15 18:44:11.000000000","message":"We changed it so that address is optional instead of mandatory. Which makes me wonder if we should support this. I\u0027m thinking we shouldn\u0027t.\n\nWe just merged the CLI part where we allow this though.\n\nIf we do allow this, L102 should probably be \u0027id\u0027 or something like that. And here, it is \u0027instead of UUID or name\u0027","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":111,"context_line":"            default\u003dFalse,"},{"line_number":112,"context_line":"            help\u003d\u0027\u003cport group\u003e is the MAC address (instead of the UUID) of the\u0027"},{"line_number":113,"context_line":"                 \u0027 port group.\u0027)"},{"line_number":114,"context_line":"        parser.add_argument("},{"line_number":115,"context_line":"            \u0027--fields\u0027,"},{"line_number":116,"context_line":"            nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_abccc1bb","line":113,"in_reply_to":"1a6eadb0_519841c0","updated":"2016-12-15 22:47:18.000000000","message":"Yeah, that\u0027s exposed in API, so I\u0027d vote for leaving it too","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"11ef51c52ff898fff3443fc17a193bb86a3a3ea1","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":111,"context_line":"            default\u003dFalse,"},{"line_number":112,"context_line":"            help\u003d\u0027\u003cport group\u003e is the MAC address (instead of the UUID) of the\u0027"},{"line_number":113,"context_line":"                 \u0027 port group.\u0027)"},{"line_number":114,"context_line":"        parser.add_argument("},{"line_number":115,"context_line":"            \u0027--fields\u0027,"},{"line_number":116,"context_line":"            nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_519841c0","line":113,"in_reply_to":"1a6eadb0_85dc5b74","updated":"2016-12-15 20:13:06.000000000","message":"Discussed with Julia on irc [1] and she thinks it is OK to have this even if it is optional, so I\u0027m good with it too.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2016-12-15.log.html#t2016-12-15T19:17:38","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                parsed_args.portgroup, fields\u003dfields)._info"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        portgroup.pop(\"links\", None)"},{"line_number":141,"context_line":"        portgroup.pop(\"ports\", None)"},{"line_number":142,"context_line":"        return zip(*sorted(portgroup.items()))"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_255627ce","line":141,"updated":"2016-12-15 18:44:11.000000000","message":"oh, this reminds me. Do we need to pop \u0027portgroups\u0027 from the node?","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                parsed_args.portgroup, fields\u003dfields)._info"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        portgroup.pop(\"links\", None)"},{"line_number":141,"context_line":"        portgroup.pop(\"ports\", None)"},{"line_number":142,"context_line":"        return zip(*sorted(portgroup.items()))"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_2bfef1ad","line":141,"in_reply_to":"1a6eadb0_255627ce","updated":"2016-12-15 22:47:18.000000000","message":"aha, yup.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"class ListBaremetalPortGroup(command.Lister):"},{"line_number":146,"context_line":"    \"\"\"List baremetal portgroups.\"\"\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    log \u003d logging.getLogger(__name__ + \".ListBaremetalPortGroup\")"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_a2a86d21","line":146,"updated":"2016-12-15 18:44:11.000000000","message":"this is shown in the help, so s/portgroups/port groups/","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"class ListBaremetalPortGroup(command.Lister):"},{"line_number":146,"context_line":"    \"\"\"List baremetal portgroups.\"\"\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    log \u003d logging.getLogger(__name__ + \".ListBaremetalPortGroup\")"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_ebccf98a","line":146,"in_reply_to":"1a6eadb0_a2a86d21","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class DeleteBaremetalPortGroup(command.Command):"},{"line_number":249,"context_line":"    \"\"\"Unregister baremetal portgroup(s).\"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    log \u003d logging.getLogger(__name__ + \".DeleteBaremetalPortGroup\")"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_827611d5","line":249,"updated":"2016-12-15 18:44:11.000000000","message":"this is shown in the help, so s/portgroup(s)/port group(s)/","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class DeleteBaremetalPortGroup(command.Command):"},{"line_number":249,"context_line":"    \"\"\"Unregister baremetal portgroup(s).\"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    log \u003d logging.getLogger(__name__ + \".DeleteBaremetalPortGroup\")"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_4ba40db9","line":249,"in_reply_to":"1a6eadb0_827611d5","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            \"portgroups\","},{"line_number":257,"context_line":"            metavar\u003d\"\u003cport group\u003e\","},{"line_number":258,"context_line":"            nargs\u003d\"+\","},{"line_number":259,"context_line":"            help\u003d\"Port group(s) to delete (name or UUID)\")"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return parser"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_a5c23732","line":259,"updated":"2016-12-15 18:44:11.000000000","message":"nit, the other help strings end with a period.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            \"portgroups\","},{"line_number":257,"context_line":"            metavar\u003d\"\u003cport group\u003e\","},{"line_number":258,"context_line":"            nargs\u003d\"+\","},{"line_number":259,"context_line":"            help\u003d\"Port group(s) to delete (name or UUID)\")"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return parser"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_6ba709bd","line":259,"in_reply_to":"1a6eadb0_a5c23732","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"class SetBaremetalPortGroup(command.Command):"},{"line_number":283,"context_line":"    \"\"\"Set baremetal portgroup properties.\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    log \u003d logging.getLogger(__name__ + \".SetBaremetalPortGroup\")"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_c27c89b7","line":283,"updated":"2016-12-15 18:44:11.000000000","message":"this is shown in the help, so s/portgroup/port group/","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"class SetBaremetalPortGroup(command.Command):"},{"line_number":283,"context_line":"    \"\"\"Set baremetal portgroup properties.\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    log \u003d logging.getLogger(__name__ + \".SetBaremetalPortGroup\")"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_8baaa583","line":283,"in_reply_to":"1a6eadb0_c27c89b7","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":303,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":304,"context_line":"            help\u003d\u0027Extra to set on this baremetal port group \u0027"},{"line_number":305,"context_line":"                 \u0027(repeat option to set multiple extras)\u0027,"},{"line_number":306,"context_line":"        )"},{"line_number":307,"context_line":"        standalone_ports_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":308,"context_line":"        standalone_ports_group.add_argument("}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_4538833d","line":305,"updated":"2016-12-15 18:44:11.000000000","message":"to be consistent, should end with period.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":303,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":304,"context_line":"            help\u003d\u0027Extra to set on this baremetal port group \u0027"},{"line_number":305,"context_line":"                 \u0027(repeat option to set multiple extras)\u0027,"},{"line_number":306,"context_line":"        )"},{"line_number":307,"context_line":"        standalone_ports_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":308,"context_line":"        standalone_ports_group.add_argument("}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_eb931959","line":305,"in_reply_to":"1a6eadb0_4538833d","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":318,"context_line":"            help\u003d\"Ports that are members of this port group \""},{"line_number":319,"context_line":"                 \"cannot be used as stand-alone ports.\""},{"line_number":320,"context_line":"        )"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return parser"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_85537b6a","line":320,"updated":"2016-12-15 18:44:11.000000000","message":"we don\u0027t allow changing the node uuid and address?","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":318,"context_line":"            help\u003d\"Ports that are members of this port group \""},{"line_number":319,"context_line":"                 \"cannot be used as stand-alone ports.\""},{"line_number":320,"context_line":"        )"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return parser"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_8e34734a","line":320,"in_reply_to":"1a6eadb0_85537b6a","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        if parsed_args.extra:"},{"line_number":342,"context_line":"            properties.extend(utils.args_array_to_patch("},{"line_number":343,"context_line":"                \u0027add\u0027, [\u0027extra/\u0027 + x for x in parsed_args.extra]))"},{"line_number":344,"context_line":"        baremetal_client.portgroup.update(parsed_args.portgroup, properties)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"class UnsetBaremetalPortGroup(command.Command):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_a57f97a9","line":344,"updated":"2016-12-15 18:44:11.000000000","message":"Do we want to check that there were properties specified first?","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        if parsed_args.extra:"},{"line_number":342,"context_line":"            properties.extend(utils.args_array_to_patch("},{"line_number":343,"context_line":"                \u0027add\u0027, [\u0027extra/\u0027 + x for x in parsed_args.extra]))"},{"line_number":344,"context_line":"        baremetal_client.portgroup.update(parsed_args.portgroup, properties)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"class UnsetBaremetalPortGroup(command.Command):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_6e31d759","line":344,"in_reply_to":"1a6eadb0_a57f97a9","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"class UnsetBaremetalPortGroup(command.Command):"},{"line_number":348,"context_line":"    \"\"\"Unset baremetal portgroup properties.\"\"\""},{"line_number":349,"context_line":"    log \u003d logging.getLogger(__name__ + \".UnsetBaremetalPortGroup\")"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_42479976","line":348,"updated":"2016-12-15 18:44:11.000000000","message":"this is shown in the help, so s/portgroup/port group/","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"class UnsetBaremetalPortGroup(command.Command):"},{"line_number":348,"context_line":"    \"\"\"Unset baremetal portgroup properties.\"\"\""},{"line_number":349,"context_line":"    log \u003d logging.getLogger(__name__ + \".UnsetBaremetalPortGroup\")"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_6b8e292f","line":348,"in_reply_to":"1a6eadb0_42479976","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        parser.add_argument("},{"line_number":355,"context_line":"            \u0027portgroup\u0027,"},{"line_number":356,"context_line":"            metavar\u003d\u0027\u003cportgroup\u003e\u0027,"},{"line_number":357,"context_line":"            help\u003d\"Name or UUID of the port group.\""},{"line_number":358,"context_line":"        )"},{"line_number":359,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_855d3b49","line":356,"updated":"2016-12-15 18:44:11.000000000","message":"to be consistent, s/portgroup/port group/","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        parser.add_argument("},{"line_number":355,"context_line":"            \u0027portgroup\u0027,"},{"line_number":356,"context_line":"            metavar\u003d\u0027\u003cportgroup\u003e\u0027,"},{"line_number":357,"context_line":"            help\u003d\"Name or UUID of the port group.\""},{"line_number":358,"context_line":"        )"},{"line_number":359,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_8b81c5fd","line":356,"in_reply_to":"1a6eadb0_855d3b49","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":371,"context_line":"            metavar\u003d\"\u003ckey\u003e\","},{"line_number":372,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":373,"context_line":"            help\u003d\u0027Extra to unset on this baremetal port group \u0027"},{"line_number":374,"context_line":"                 \u0027(repeat option to unset multiple extras)\u0027,"},{"line_number":375,"context_line":"        )"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_453ec3da","line":374,"updated":"2016-12-15 18:44:11.000000000","message":"ditto about period at the end.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":371,"context_line":"            metavar\u003d\"\u003ckey\u003e\","},{"line_number":372,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":373,"context_line":"            help\u003d\u0027Extra to unset on this baremetal port group \u0027"},{"line_number":374,"context_line":"                 \u0027(repeat option to unset multiple extras)\u0027,"},{"line_number":375,"context_line":"        )"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_cb7f3d13","line":374,"in_reply_to":"1a6eadb0_453ec3da","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9afc4e26dfade02372f21e137c73a2cfbab2719c","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027remove\u0027,"},{"line_number":393,"context_line":"                              [\u0027extra/\u0027 + x for x in parsed_args.extra]))"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        baremetal_client.portgroup.update(parsed_args.portgroup, properties)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_d1b7f1d5","line":395,"updated":"2016-12-15 20:26:02.000000000","message":"ditto about checking if properties were specified. FYI, I just submitted this patch to address that in chassis \u0026 port, so please use a similar copy/paste pattern :) https://review.openstack.org/411486","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            properties.extend(utils.args_array_to_patch(\u0027remove\u0027,"},{"line_number":393,"context_line":"                              [\u0027extra/\u0027 + x for x in parsed_args.extra]))"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        baremetal_client.portgroup.update(parsed_args.portgroup, properties)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_cb29fde7","line":395,"in_reply_to":"1a6eadb0_d1b7f1d5","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d2dd273674ec6274eb8a827fdad5ac57043bad86","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            \u0027--node\u0027,"},{"line_number":301,"context_line":"            dest\u003d\u0027node_uuid\u0027,"},{"line_number":302,"context_line":"            metavar\u003d\u0027\u003cuuid\u003e\u0027,"},{"line_number":303,"context_line":"            help\u003d\u0027Update UUID of the node that this port group belongs to.\u0027)"},{"line_number":304,"context_line":"        parser.add_argument("},{"line_number":305,"context_line":"            \"--address\","},{"line_number":306,"context_line":"            metavar\u003d\"\u003cmac-address\u003e\","}],"source_content_type":"text/x-python","patch_set":23,"id":"1a6eadb0_6550120c","line":303,"updated":"2016-12-16 01:46:24.000000000","message":"just a nit (a really really small nit), I\u0027m guessing you copy/pasted this. The ending parenthesis is on a separate line for all the other .add_argument(.. :)","commit_id":"f63f04b8f897c1d49fffda4390286b8e3e6a42df"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b09c391664202bcaf92d9d1d3d1af0891b2ba5b2","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            \u0027--node\u0027,"},{"line_number":301,"context_line":"            dest\u003d\u0027node_uuid\u0027,"},{"line_number":302,"context_line":"            metavar\u003d\u0027\u003cuuid\u003e\u0027,"},{"line_number":303,"context_line":"            help\u003d\u0027Update UUID of the node that this port group belongs to.\u0027)"},{"line_number":304,"context_line":"        parser.add_argument("},{"line_number":305,"context_line":"            \"--address\","},{"line_number":306,"context_line":"            metavar\u003d\"\u003cmac-address\u003e\","}],"source_content_type":"text/x-python","patch_set":23,"id":"1a6eadb0_f7542f55","line":303,"in_reply_to":"1a6eadb0_6550120c","updated":"2016-12-20 17:21:04.000000000","message":"Done","commit_id":"f63f04b8f897c1d49fffda4390286b8e3e6a42df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d2dd273674ec6274eb8a827fdad5ac57043bad86","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":325,"context_line":"            default\u003dNone,"},{"line_number":326,"context_line":"            help\u003d\"Ports that are members of this port group \""},{"line_number":327,"context_line":"                 \"can be used as stand-alone ports.\""},{"line_number":328,"context_line":"        )"},{"line_number":329,"context_line":"        standalone_ports_group.add_argument("},{"line_number":330,"context_line":"            \u0027--unsupport-standalone-ports\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a6eadb0_85a1aefa","line":327,"updated":"2016-12-16 01:46:24.000000000","message":"I don\u0027t know (or care that much) if we should add \u0027(default)\u0027 here.","commit_id":"f63f04b8f897c1d49fffda4390286b8e3e6a42df"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b09c391664202bcaf92d9d1d3d1af0891b2ba5b2","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":325,"context_line":"            default\u003dNone,"},{"line_number":326,"context_line":"            help\u003d\"Ports that are members of this port group \""},{"line_number":327,"context_line":"                 \"can be used as stand-alone ports.\""},{"line_number":328,"context_line":"        )"},{"line_number":329,"context_line":"        standalone_ports_group.add_argument("},{"line_number":330,"context_line":"            \u0027--unsupport-standalone-ports\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a6eadb0_9715bb9c","line":327,"in_reply_to":"1a6eadb0_85a1aefa","updated":"2016-12-20 17:21:04.000000000","message":"The default is defined on API side, I prefer to keep it in one place.","commit_id":"f63f04b8f897c1d49fffda4390286b8e3e6a42df"}],"ironicclient/tests/unit/osc/v1/fakes.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                        \"description\": \"\","},{"line_number":75,"context_line":"                                        \"async\": \"false\"}}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"portgroup_id \u003d 987"},{"line_number":78,"context_line":"portgroup_uuid \u003d \u0027ppp-gggggg-pppp\u0027"},{"line_number":79,"context_line":"portgroup_name \u003d \u0027Portgroup name\u0027"},{"line_number":80,"context_line":"portgroup_address \u003d \u0027AA:BB:CC:DD:EE:FF\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_13c336ee","line":77,"updated":"2016-12-15 18:44:11.000000000","message":"i don\u0027t think we need this","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                        \"description\": \"\","},{"line_number":75,"context_line":"                                        \"async\": \"false\"}}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"portgroup_id \u003d 987"},{"line_number":78,"context_line":"portgroup_uuid \u003d \u0027ppp-gggggg-pppp\u0027"},{"line_number":79,"context_line":"portgroup_name \u003d \u0027Portgroup name\u0027"},{"line_number":80,"context_line":"portgroup_address \u003d \u0027AA:BB:CC:DD:EE:FF\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_0bfcd53c","line":77,"in_reply_to":"1a6eadb0_13c336ee","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"portgroup_id \u003d 987"},{"line_number":78,"context_line":"portgroup_uuid \u003d \u0027ppp-gggggg-pppp\u0027"},{"line_number":79,"context_line":"portgroup_name \u003d \u0027Portgroup name\u0027"},{"line_number":80,"context_line":"portgroup_address \u003d \u0027AA:BB:CC:DD:EE:FF\u0027"},{"line_number":81,"context_line":"portgroup_extra \u003d {\u0027key1\u0027: \u0027value1\u0027,"},{"line_number":82,"context_line":"                   \u0027key2\u0027: \u0027value2\u0027}"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_d37c5eb7","line":79,"updated":"2016-12-15 18:44:11.000000000","message":"we don\u0027t allow names with spaces, so maybe just concatenate this.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"portgroup_id \u003d 987"},{"line_number":78,"context_line":"portgroup_uuid \u003d \u0027ppp-gggggg-pppp\u0027"},{"line_number":79,"context_line":"portgroup_name \u003d \u0027Portgroup name\u0027"},{"line_number":80,"context_line":"portgroup_address \u003d \u0027AA:BB:CC:DD:EE:FF\u0027"},{"line_number":81,"context_line":"portgroup_extra \u003d {\u0027key1\u0027: \u0027value1\u0027,"},{"line_number":82,"context_line":"                   \u0027key2\u0027: \u0027value2\u0027}"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_4b988d1c","line":79,"in_reply_to":"1a6eadb0_d37c5eb7","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"portgroup_id \u003d 987"},{"line_number":78,"context_line":"portgroup_uuid \u003d \u0027ppp-gggggg-pppp\u0027"},{"line_number":79,"context_line":"portgroup_name \u003d \u0027Portgroup name\u0027"},{"line_number":80,"context_line":"portgroup_address \u003d \u0027AA:BB:CC:DD:EE:FF\u0027"},{"line_number":81,"context_line":"portgroup_extra \u003d {\u0027key1\u0027: \u0027value1\u0027,"},{"line_number":82,"context_line":"                   \u0027key2\u0027: \u0027value2\u0027}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_7360ea01","line":80,"updated":"2016-12-15 18:44:11.000000000","message":"do we really want the same address as the port? And if we do, let\u0027s be explicit about it, \u003d baremetal_port_address.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":77,"context_line":"portgroup_id \u003d 987"},{"line_number":78,"context_line":"portgroup_uuid \u003d \u0027ppp-gggggg-pppp\u0027"},{"line_number":79,"context_line":"portgroup_name \u003d \u0027Portgroup name\u0027"},{"line_number":80,"context_line":"portgroup_address \u003d \u0027AA:BB:CC:DD:EE:FF\u0027"},{"line_number":81,"context_line":"portgroup_extra \u003d {\u0027key1\u0027: \u0027value1\u0027,"},{"line_number":82,"context_line":"                   \u0027key2\u0027: \u0027value2\u0027}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_cb8c9ddc","line":80,"in_reply_to":"1a6eadb0_7360ea01","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"portgroup_extra \u003d {\u0027key1\u0027: \u0027value1\u0027,"},{"line_number":82,"context_line":"                   \u0027key2\u0027: \u0027value2\u0027}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"PORTGROUP \u003d {\u0027id\u0027: portgroup_id,"},{"line_number":85,"context_line":"             \u0027uuid\u0027: portgroup_uuid,"},{"line_number":86,"context_line":"             \u0027name\u0027: portgroup_name,"},{"line_number":87,"context_line":"             \u0027node_uuid\u0027: baremetal_uuid,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_d32a9e8f","line":84,"updated":"2016-12-15 18:44:11.000000000","message":"ditto, don\u0027t need","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":81,"context_line":"portgroup_extra \u003d {\u0027key1\u0027: \u0027value1\u0027,"},{"line_number":82,"context_line":"                   \u0027key2\u0027: \u0027value2\u0027}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"PORTGROUP \u003d {\u0027id\u0027: portgroup_id,"},{"line_number":85,"context_line":"             \u0027uuid\u0027: portgroup_uuid,"},{"line_number":86,"context_line":"             \u0027name\u0027: portgroup_name,"},{"line_number":87,"context_line":"             \u0027node_uuid\u0027: baremetal_uuid,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_0b93f5fa","line":84,"in_reply_to":"1a6eadb0_d32a9e8f","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"}],"ironicclient/tests/unit/osc/v1/test_baremetal_port.py":[{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"72bd839d4ea2c6084c715102763dfc8fd5304a90","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            baremetal_fakes.baremetal_port_uuid,"},{"line_number":320,"context_line":"            [{\u0027path\u0027: \u0027/portgroup_uuid\u0027, \u0027value\u0027: new_portgroup_uuid,"},{"line_number":321,"context_line":"              \u0027op\u0027: \u0027add\u0027}])"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_baremetal_port_set_no_options(self):"},{"line_number":324,"context_line":"        arglist \u003d []"},{"line_number":325,"context_line":"        verifylist \u003d []"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_16a4e0b7","line":322,"updated":"2016-11-11 10:19:07.000000000","message":"Should the unittest of setting port with non-existing portgroup uuid be present?","commit_id":"886c8c3896ef70432482985e47df76609427f09d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"eb58059259363a269f5683209e55fb3e3f758b8d","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            baremetal_fakes.baremetal_port_uuid,"},{"line_number":320,"context_line":"            [{\u0027path\u0027: \u0027/portgroup_uuid\u0027, \u0027value\u0027: new_portgroup_uuid,"},{"line_number":321,"context_line":"              \u0027op\u0027: \u0027add\u0027}])"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_baremetal_port_set_no_options(self):"},{"line_number":324,"context_line":"        arglist \u003d []"},{"line_number":325,"context_line":"        verifylist \u003d []"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_856b2185","line":322,"in_reply_to":"9a629dbe_16a4e0b7","updated":"2016-11-14 08:23:17.000000000","message":"no, we already have this test in ironic API.","commit_id":"886c8c3896ef70432482985e47df76609427f09d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        # DisplayCommandBase.take_action() returns two tuples"},{"line_number":139,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Set expected values"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_8edc7d74","line":138,"updated":"2016-12-15 18:44:11.000000000","message":"I\u0027m not sure why, but this comment isn\u0027t in the other functions that call .take_action(), although I see it in other files.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        verifylist \u003d [(\u0027portgroup\u0027, baremetal_fakes.portgroup_uuid)]"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":483,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        kwargs \u003d {"},{"line_number":486,"context_line":"            \u0027portgroup\u0027: baremetal_fakes.portgroup_uuid,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_ae74d935","line":483,"updated":"2016-12-15 18:44:11.000000000","message":"I think that comment in L138 could be added before this line.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        verifylist \u003d [(\u0027portgroup\u0027, baremetal_fakes.portgroup_uuid)]"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":483,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        kwargs \u003d {"},{"line_number":486,"context_line":"            \u0027portgroup\u0027: baremetal_fakes.portgroup_uuid,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a6eadb0_2ba51146","line":483,"in_reply_to":"1a6eadb0_ae74d935","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"}],"ironicclient/v1/port.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a26270721f50d6cb417f226cbf4a801213999389","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        :param node: Optional, name or UUID of a node. Used to get"},{"line_number":67,"context_line":"                     ports of this node."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param node: Optional, name or UUID of a portgroup. Used to get"},{"line_number":70,"context_line":"                     ports of this portgroup."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        :returns: A list of ports."}],"source_content_type":"text/x-python","patch_set":15,"id":"5a74a57a_9ccfedaf","line":69,"updated":"2016-11-23 14:14:08.000000000","message":":param portgroup:","commit_id":"096f7b64cfa7c1556fb1493dd91692ebce7d219d"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d6e27116d29597b166c242d4fc6151603334b627","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        :param node: Optional, name or UUID of a node. Used to get"},{"line_number":67,"context_line":"                     ports of this node."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param node: Optional, name or UUID of a portgroup. Used to get"},{"line_number":70,"context_line":"                     ports of this portgroup."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        :returns: A list of ports."}],"source_content_type":"text/x-python","patch_set":15,"id":"5a74a57a_a498a7c1","line":69,"in_reply_to":"5a74a57a_9ccfedaf","updated":"2016-11-25 16:51:44.000000000","message":"Done","commit_id":"096f7b64cfa7c1556fb1493dd91692ebce7d219d"}],"releasenotes/notes/osc-plugin-f87e0fbb472261dd.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a26270721f50d6cb417f226cbf4a801213999389","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    * openstack baremetal portgroup list"},{"line_number":9,"context_line":"    * openstack baremetal portgroup delete"},{"line_number":10,"context_line":"    * openstack baremetal portgroup set"},{"line_number":11,"context_line":"    * openstack baremetal portgroup unset"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a74a57a_bcc4a992","line":11,"updated":"2016-11-23 14:14:08.000000000","message":"I\u0027d slightly (treat it as a nit) prefer we split portgroup into actual English words \"port\" and \"group\": \"openstack baremetal port group create\". And then use --port-group-uuid instead of --portgroup-uuid. This may be only me, let\u0027s see what the others say.","commit_id":"096f7b64cfa7c1556fb1493dd91692ebce7d219d"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d6e27116d29597b166c242d4fc6151603334b627","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    * openstack baremetal portgroup list"},{"line_number":9,"context_line":"    * openstack baremetal portgroup delete"},{"line_number":10,"context_line":"    * openstack baremetal portgroup set"},{"line_number":11,"context_line":"    * openstack baremetal portgroup unset"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a74a57a_e732a1f1","line":11,"in_reply_to":"5a74a57a_bcc4a992","updated":"2016-11-25 16:51:44.000000000","message":"Done","commit_id":"096f7b64cfa7c1556fb1493dd91692ebce7d219d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1a6eadb0_9394a643","line":12,"updated":"2016-12-15 18:44:11.000000000","message":"Probably worth mentioning that the port commands also support port group (but don\u0027t know if it is worth mentioning each one).\n\nSomething like\n\nExtends the \u0027openstack baremetal port\u0027 commands (where applicable) to allow specifying the port group (if any) that a port is a member of, via  the new --port-group argument.","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1a6eadb0_6b3709ff","line":12,"in_reply_to":"1a6eadb0_9394a643","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"}],"setup.cfg":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0308374da0078fc118ee6fc321ab5df2b7e20b8f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    baremetal_port_group_show \u003d ironicclient.osc.v1.baremetal_portgroup:ShowBaremetalPortGroup"},{"line_number":84,"context_line":"    baremetal_port_group_delete \u003d ironicclient.osc.v1.baremetal_portgroup:DeleteBaremetalPortGroup"},{"line_number":85,"context_line":"    baremetal_port_group_set \u003d ironicclient.osc.v1.baremetal_portgroup:SetBaremetalPortGroup"},{"line_number":86,"context_line":"    baremetal_port_group_unset \u003d ironicclient.osc.v1.baremetal_portgroup:UnsetBaremetalPortGroup"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"[pbr]"},{"line_number":89,"context_line":"autodoc_index_modules \u003d True"}],"source_content_type":"text/x-ttcn-cfg","patch_set":22,"id":"1a6eadb0_f305da79","line":86,"updated":"2016-12-15 18:44:11.000000000","message":"would you mind moving these so the list is alphabetical? (I think it was.)","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd878e100664470bec2e1dc26b59f8b11a934944","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    baremetal_port_group_show \u003d ironicclient.osc.v1.baremetal_portgroup:ShowBaremetalPortGroup"},{"line_number":84,"context_line":"    baremetal_port_group_delete \u003d ironicclient.osc.v1.baremetal_portgroup:DeleteBaremetalPortGroup"},{"line_number":85,"context_line":"    baremetal_port_group_set \u003d ironicclient.osc.v1.baremetal_portgroup:SetBaremetalPortGroup"},{"line_number":86,"context_line":"    baremetal_port_group_unset \u003d ironicclient.osc.v1.baremetal_portgroup:UnsetBaremetalPortGroup"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"[pbr]"},{"line_number":89,"context_line":"autodoc_index_modules \u003d True"}],"source_content_type":"text/x-ttcn-cfg","patch_set":22,"id":"1a6eadb0_0b06951f","line":86,"in_reply_to":"1a6eadb0_f305da79","updated":"2016-12-15 22:47:18.000000000","message":"Done","commit_id":"3d1ecc0d40b7d66850cbda58192b19fd75000b98"}]}