)]}'
{"ironicclient/osc/v1/baremetal_node.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a36c96a706bad1ea6fc7de5fb9390288ae1c1de2","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        )"},{"line_number":732,"context_line":"        parser.add_argument("},{"line_number":733,"context_line":"            \u0027--power-state\u0027,"},{"line_number":734,"context_line":"            default\u003dself.POWER_STATE,"},{"line_number":735,"context_line":"            required\u003dFalse,"},{"line_number":736,"context_line":"            choices\u003d[self.POWER_STATE],"},{"line_number":737,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_793bd8d1","line":734,"updated":"2016-12-02 10:19:56.000000000","message":"executing gives an error:\n\n$ openstack baremetal node power\n\u0027PowerBaremetalNode\u0027 object has no attribute \u0027POWER_STATE\u0027","commit_id":"a6f38b36ea6f1ddd7d4ee29a4ddc655663982954"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"26cb0a3837a8241ec0b8d1e8d82cca0123b88c1e","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        )"},{"line_number":732,"context_line":"        parser.add_argument("},{"line_number":733,"context_line":"            \u0027--power-state\u0027,"},{"line_number":734,"context_line":"            default\u003dself.POWER_STATE,"},{"line_number":735,"context_line":"            required\u003dFalse,"},{"line_number":736,"context_line":"            choices\u003d[self.POWER_STATE],"},{"line_number":737,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_f5d67227","line":734,"in_reply_to":"3a71b18c_13173fee","updated":"2017-11-15 02:52:42.000000000","message":"heh. I can fix it by setting the attribute, but I actually want it to barf cuz that command should not work.","commit_id":"a6f38b36ea6f1ddd7d4ee29a4ddc655663982954"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8a2d759907b5b4ae42d93c14f7d5a4ef7169570c","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        )"},{"line_number":732,"context_line":"        parser.add_argument("},{"line_number":733,"context_line":"            \u0027--power-state\u0027,"},{"line_number":734,"context_line":"            default\u003dself.POWER_STATE,"},{"line_number":735,"context_line":"            required\u003dFalse,"},{"line_number":736,"context_line":"            choices\u003d[self.POWER_STATE],"},{"line_number":737,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_13173fee","line":734,"in_reply_to":"3a71b18c_793bd8d1","updated":"2016-12-08 08:05:02.000000000","message":"omg, it may happen when code is updated but didn\u0027t run setup.py install. Please disregard this comment.","commit_id":"a6f38b36ea6f1ddd7d4ee29a4ddc655663982954"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f06da7ee4520919230cbf74b6f8f9a76e7747f2","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            default\u003dself.POWER_STATE,"},{"line_number":735,"context_line":"            required\u003dFalse,"},{"line_number":736,"context_line":"            choices\u003d[self.POWER_STATE],"},{"line_number":737,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":738,"context_line":"        return parser"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_44589e8a","line":737,"updated":"2017-01-23 14:17:00.000000000","message":"why can\u0027t we drop the argument and just use self.POWER_STATE below?","commit_id":"a6f38b36ea6f1ddd7d4ee29a4ddc655663982954"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"26cb0a3837a8241ec0b8d1e8d82cca0123b88c1e","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            default\u003dself.POWER_STATE,"},{"line_number":735,"context_line":"            required\u003dFalse,"},{"line_number":736,"context_line":"            choices\u003d[self.POWER_STATE],"},{"line_number":737,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":738,"context_line":"        return parser"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_359aca6d","line":737,"in_reply_to":"5a3905b3_44589e8a","updated":"2017-11-15 02:52:42.000000000","message":"Because... we can. I just followed the way it was done in ProvisionStateBaremetalNode to be consistent (and I don\u0027t know why it was done that way).\n\nI changed it, and for consistency, maybe we should change ProvisionStateBaremetalNode in a separate patch...","commit_id":"a6f38b36ea6f1ddd7d4ee29a4ddc655663982954"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"89231935042402dae0f8385c20e1883c793bc919","unresolved":false,"context_lines":[{"line_number":820,"context_line":"            default\u003dNone,"},{"line_number":821,"context_line":"            type\u003dint,"},{"line_number":822,"context_line":"            help\u003d_(\"Timeout (in seconds, positive integer) to wait for the \""},{"line_number":823,"context_line":"                   \"target power state before erroring out.\")"},{"line_number":824,"context_line":"        )"},{"line_number":825,"context_line":"        return parser"},{"line_number":826,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f485f77_0ddea210","line":823,"range":{"start_line":823,"start_character":20,"end_line":823,"end_character":32},"updated":"2017-11-15 08:13:21.000000000","message":"nit: now when we have separate commands we can update this help to provide expected target state \u0027power {} state\u0027.format(self.POWER_STATE)","commit_id":"d1cbe0737fc656ad742b8ddee76b8edf739b31ee"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"253a710edaaa66d9d955cfbe02d8a9ccbd1110f0","unresolved":false,"context_lines":[{"line_number":820,"context_line":"            default\u003dNone,"},{"line_number":821,"context_line":"            type\u003dint,"},{"line_number":822,"context_line":"            help\u003d_(\"Timeout (in seconds, positive integer) to wait for the \""},{"line_number":823,"context_line":"                   \"target power state before erroring out.\")"},{"line_number":824,"context_line":"        )"},{"line_number":825,"context_line":"        return parser"},{"line_number":826,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f485f77_c254cc00","line":823,"range":{"start_line":823,"start_character":20,"end_line":823,"end_character":32},"in_reply_to":"1f485f77_0ddea210","updated":"2017-11-15 15:24:28.000000000","message":"yeowww, that\u0027s a good suggestion. Maybe in a separate patch if someone can think of the right words.\n\n\u0027target power state\u0027 to me, means \u0027power on\u0027, \u0027power off\u0027, \u0027soft power off\u0027\n\nIs it sufficient for it to say eg \u0027Timeout (in seconds, positive integer) to wait for the node to be powered \u003con|off\u003e before erroring out\u0027? \n\nNo \u0027soft\u0027 there. And the string is clunky. Another patch if someone wants to work on it...","commit_id":"d1cbe0737fc656ad742b8ddee76b8edf739b31ee"}],"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f927dea11a6f6f8e47229cae8167fc23d19a24f3","unresolved":false,"context_lines":[{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        self.baremetal_mock.node.set_power_state.assert_called_once_with("},{"line_number":921,"context_line":"            \u0027node_uuid\u0027, \u0027off\u0027)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"class TestDeployBaremetalProvisionState(TestBaremetal):"},{"line_number":925,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_b5ae18e4","line":922,"updated":"2016-09-06 22:19:48.000000000","message":"Should there be a:\n\n def test_baremetal_power_off_no_args ?","commit_id":"b61095c302c5b88361820f64bb7d1c9c0b6f5652"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59e87003439c8dcc38e543ab2eaee029f063ab2c","unresolved":false,"context_lines":[{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        self.baremetal_mock.node.set_power_state.assert_called_once_with("},{"line_number":921,"context_line":"            \u0027node_uuid\u0027, \u0027off\u0027)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"class TestDeployBaremetalProvisionState(TestBaremetal):"},{"line_number":925,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_a15e5510","line":922,"in_reply_to":"9a89bdaa_b5ae18e4","updated":"2016-09-09 01:12:26.000000000","message":"Yes, I forgot to copy/paste that one :)","commit_id":"b61095c302c5b88361820f64bb7d1c9c0b6f5652"}],"releasenotes/notes/osc-node-power-on-off-c269980e3b9c79ca.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"420cb750883889229cb8469cfe927103d2476e01","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    the two commands:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``openstack baremetal node power on`` and"},{"line_number":8,"context_line":"    * ``openstack baremetal node power off``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa7ab95a_1da18b46","line":8,"updated":"2016-09-02 09:43:48.000000000","message":"worth nothing that this is not a user-visible change","commit_id":"b61095c302c5b88361820f64bb7d1c9c0b6f5652"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59e87003439c8dcc38e543ab2eaee029f063ab2c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    the two commands:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``openstack baremetal node power on`` and"},{"line_number":8,"context_line":"    * ``openstack baremetal node power off``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_016d41cc","line":8,"in_reply_to":"fa7ab95a_1da18b46","updated":"2016-09-09 01:12:26.000000000","message":"Yup. I elaborated on that :)","commit_id":"b61095c302c5b88361820f64bb7d1c9c0b6f5652"}]}