)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"fc669f0aa276b8258a6278dd955e461b0deb779b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add unit tests for provision state commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are several missing unit tests for provision state"},{"line_number":10,"context_line":"commands. This patch adds and reorder them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie5b08f682f3cb8fbc5016cb02e689bb1934798f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_5a1e6f0c","line":10,"updated":"2016-09-27 14:08:59.000000000","message":"Do you mean that it adds some tests and reorders existing ones? If so, it would be better to do that as two patches, so it\u0027s obvious which tests are new.","commit_id":"e4ff6daf0102a812e45486faf7f6e3f48f5f3059"}],"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"fc669f0aa276b8258a6278dd955e461b0deb779b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                \"step\": \"create_configuration\","},{"line_number":105,"context_line":"                \"args\": {\"create_nonroot_volumes\": False}"},{"line_number":106,"context_line":"            },"},{"line_number":107,"context_line":"            {"},{"line_number":108,"context_line":"                \"interface\": \"deploy\","},{"line_number":109,"context_line":"                \"step\": \"erase_devices\""},{"line_number":110,"context_line":"            }]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_1ddf813a","line":107,"updated":"2016-09-27 14:08:59.000000000","message":"PEP8 error here.","commit_id":"e4ff6daf0102a812e45486faf7f6e3f48f5f3059"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"734ccbfee2b31beda56f6d70a273648785a11bea","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \u0027node_uuid\u0027, \u0027abort\u0027, cleansteps\u003dNone, configdrive\u003dNone)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class TestBaremetalAdopt(TestBaremetal):"},{"line_number":63,"context_line":"    def setUp(self):"},{"line_number":64,"context_line":"        super(TestBaremetalAdopt, self).setUp()"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_c030af0a","line":62,"updated":"2016-11-14 22:53:32.000000000","message":"this file has a mix of naming for the classes and tests. I believe they started with TestBaremetal\u003cCmd\u003e, and then we started to just do Test\u003cCmd\u003e. I\u0027d prefer it to be the latter, because it makes no sense to have the entire file contain TestBaremetal* and test_baremetal_*.\n\nSince we have a mix of both -- it is acceptable for you to add the new TestBaremetalAbort class above. BUT I don\u0027t think it is acceptable to modify the existing TestAdopt class; the only change you\u0027ve made is to change its name. This is outside the scope of this patch.","commit_id":"f79170eac50ef1270c2296b8df7d744c9d0b23f8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"31dd1350d9b01ec8641cfb1478ac8118e0c57a42","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                \"interface\": \"raid\","},{"line_number":105,"context_line":"                \"step\": \"create_configuration\","},{"line_number":106,"context_line":"                \"args\": {\"create_nonroot_volumes\": False}"},{"line_number":107,"context_line":"            }, {"},{"line_number":108,"context_line":"                \"interface\": \"deploy\","},{"line_number":109,"context_line":"                \"step\": \"erase_devices\""},{"line_number":110,"context_line":"            }]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_5a110d03","line":107,"updated":"2016-11-11 16:00:04.000000000","message":"nit - underindent","commit_id":"f79170eac50ef1270c2296b8df7d744c9d0b23f8"}]}