)]}'
{"ironicclient/tests/unit/osc/v1/test_baremetal_node.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1e0dbb415f5b9f94ab13f0548bb0d57863df7e1a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            \u0027node_uuid\u0027, \u0027clean\u0027, cleansteps\u003dsteps_dict, configdrive\u003dNone)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class TestBaremetalDeploy(TestBaremetal):"},{"line_number":130,"context_line":"    def setUp(self):"},{"line_number":131,"context_line":"        super(TestBaremetalDeploy, self).setUp()"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_61dc8046","line":129,"range":{"start_line":129,"start_character":19,"end_line":129,"end_character":25},"updated":"2016-11-11 05:21:52.000000000","message":"Shouldn\u0027t it be s/Deploy/Active/ in order to keep consistency?","commit_id":"666e34f5518788b95f634276b286edd8e37098b5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d499ad5617d816c8d5ba99a792838831bb0123fb","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            \u0027node_uuid\u0027, \u0027clean\u0027, cleansteps\u003dsteps_dict, configdrive\u003dNone)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class TestBaremetalDeploy(TestBaremetal):"},{"line_number":130,"context_line":"    def setUp(self):"},{"line_number":131,"context_line":"        super(TestBaremetalDeploy, self).setUp()"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_bf6bfb83","line":129,"range":{"start_line":129,"start_character":19,"end_line":129,"end_character":25},"in_reply_to":"9a629dbe_61dc8046","updated":"2016-11-11 15:30:08.000000000","message":"This actually seems to be consistent with Undeploy test, see L254. It seems like all these tests use verbs to describe an action happening, not the target state.","commit_id":"666e34f5518788b95f634276b286edd8e37098b5"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a4f4d940c36d08c10dc076a1f5f523fd95a3330f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            \u0027node_uuid\u0027, \u0027clean\u0027, cleansteps\u003dsteps_dict, configdrive\u003dNone)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class TestBaremetalDeploy(TestBaremetal):"},{"line_number":130,"context_line":"    def setUp(self):"},{"line_number":131,"context_line":"        super(TestBaremetalDeploy, self).setUp()"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_f60d79e9","line":129,"range":{"start_line":129,"start_character":19,"end_line":129,"end_character":25},"in_reply_to":"9a629dbe_bf6bfb83","updated":"2016-11-14 04:23:46.000000000","message":"Vladyslav,\n\nNow I can see the consistency.\n\nThanks.\nNaohiro","commit_id":"666e34f5518788b95f634276b286edd8e37098b5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9af1c73c244f35d4ada01849af4b598fe029c6e0","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        self.assertRaises(oscutils.ParserException,"},{"line_number":162,"context_line":"                          self.check_parser,"},{"line_number":163,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"class TestBaremetalInspect(TestBaremetal):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_93e4533c","line":163,"updated":"2016-11-14 22:59:15.000000000","message":"I agree with renaming the class to make it consistent with the other classes in this file, but I\u0027m not convinced about reordering this. Would you please elaborate on why you think it should be moved to here?","commit_id":"666e34f5518788b95f634276b286edd8e37098b5"},{"author":{"_account_id":25316,"name":"yongjie.xu","email":"yongjie.xu@easystack.cn","username":"yongjie.xu"},"change_message_id":"1a6985b4eb8a986964a2776a653ce12d3e4de239","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        self.assertRaises(oscutils.ParserException,"},{"line_number":162,"context_line":"                          self.check_parser,"},{"line_number":163,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"class TestBaremetalInspect(TestBaremetal):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_8e7299e2","line":163,"in_reply_to":"7a77a97e_93e4533c","updated":"2017-04-19 12:02:59.000000000","message":"adopt,clean,deploy,inspect.actually sort alphabetically","commit_id":"666e34f5518788b95f634276b286edd8e37098b5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d12363012cce07bf0e6fa387b7b7e8fb431fe9e1","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        self.assertRaises(oscutils.ParserException,"},{"line_number":162,"context_line":"                          self.check_parser,"},{"line_number":163,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"class TestBaremetalInspect(TestBaremetal):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_5ed88679","line":163,"in_reply_to":"7ffa3b31_8e7299e2","updated":"2017-04-20 17:43:31.000000000","message":"But TestBaremetalCreate and TestBaremetalDelete are below. This file is in random order anyway, so it doesn\u0027t make sense to me to move this.","commit_id":"666e34f5518788b95f634276b286edd8e37098b5"}]}