)]}'
{"ironicclient/tests/functional/osc/v1/test_baremetal_node_fields.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d528975065836d6566e9dc8e6dc486e98aca5d27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_b9d087ca","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":23},"updated":"2017-03-10 17:57:50.000000000","message":"2017","commit_id":"1583f9c136ddbf7fac1b065a9070f427b0ca688c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d17f446781175c3a19e8f86601a08de1aa169544","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_988718b4","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":23},"in_reply_to":"9a30ddce_b9d087ca","updated":"2017-03-13 12:15:26.000000000","message":"Done","commit_id":"1583f9c136ddbf7fac1b065a9070f427b0ca688c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"549f8e692f7e2a73fd6d6bf90013d1000e310d0c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        nodes_list \u003d self.openstack(\u0027baremetal node list\u0027)"},{"line_number":39,"context_line":"        nodes_list_headers \u003d self._get_table_headers(nodes_list)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.assertEqual(sorted(headers), sorted(nodes_list_headers))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_list_minimal_fields(self):"},{"line_number":44,"context_line":"        headers \u003d [\u0027Instance UUID\u0027, \u0027Name\u0027, \u0027UUID\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_6ea574a0","line":41,"updated":"2017-03-10 13:19:57.000000000","message":"nit: I\u0027d prefer we use sets instead of lists and avoid sorting","commit_id":"1583f9c136ddbf7fac1b065a9070f427b0ca688c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d17f446781175c3a19e8f86601a08de1aa169544","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        nodes_list \u003d self.openstack(\u0027baremetal node list\u0027)"},{"line_number":39,"context_line":"        nodes_list_headers \u003d self._get_table_headers(nodes_list)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.assertEqual(sorted(headers), sorted(nodes_list_headers))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_list_minimal_fields(self):"},{"line_number":44,"context_line":"        headers \u003d [\u0027Instance UUID\u0027, \u0027Name\u0027, \u0027UUID\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_497074a4","line":41,"in_reply_to":"9a30ddce_6ea574a0","updated":"2017-03-13 12:15:26.000000000","message":"Thanks! Done.","commit_id":"1583f9c136ddbf7fac1b065a9070f427b0ca688c"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d528975065836d6566e9dc8e6dc486e98aca5d27","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        fields \u003d [\u0027instance_uuid\u0027, \u0027name\u0027, \u0027uuid\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        node_list \u003d self.openstack("},{"line_number":48,"context_line":"            \u0027baremetal node list --fields {0} {1}\u0027"},{"line_number":49,"context_line":"            .format(\u0027 \u0027.join(fields), self.api))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        nodes_list_headers \u003d self._get_table_headers(node_list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_d95c5b7f","line":48,"range":{"start_line":48,"start_character":41,"end_line":48,"end_character":49},"updated":"2017-03-10 17:57:50.000000000","message":"Please don\u0027t use this style.  Just: {} {}\n\nAs these were removed previously in commit: 20d960ff98807a7b93310af753f2145dce093401\n\nAnd in the rest of these tests too.","commit_id":"1583f9c136ddbf7fac1b065a9070f427b0ca688c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d17f446781175c3a19e8f86601a08de1aa169544","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        fields \u003d [\u0027instance_uuid\u0027, \u0027name\u0027, \u0027uuid\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        node_list \u003d self.openstack("},{"line_number":48,"context_line":"            \u0027baremetal node list --fields {0} {1}\u0027"},{"line_number":49,"context_line":"            .format(\u0027 \u0027.join(fields), self.api))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        nodes_list_headers \u003d self._get_table_headers(node_list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_38438c6d","line":48,"range":{"start_line":48,"start_character":41,"end_line":48,"end_character":49},"in_reply_to":"9a30ddce_d95c5b7f","updated":"2017-03-13 12:15:26.000000000","message":"Done","commit_id":"1583f9c136ddbf7fac1b065a9070f427b0ca688c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"549f8e692f7e2a73fd6d6bf90013d1000e310d0c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                \u0027target_power_state\u0027,"},{"line_number":103,"context_line":"                \u0027target_provision_state\u0027,"},{"line_number":104,"context_line":"                \u0027updated_at\u0027,"},{"line_number":105,"context_line":"                \u0027uuid\u0027]"},{"line_number":106,"context_line":"        node_show \u003d self.openstack(\u0027baremetal node show {0}\u0027"},{"line_number":107,"context_line":"                                   .format(self.node[\u0027uuid\u0027]))"},{"line_number":108,"context_line":"        nodes_show_rows \u003d self._get_table_rows(node_show)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_8ea2a897","line":105,"updated":"2017-03-10 13:19:57.000000000","message":"note: if we start defaulting the API version to \u0027latest\u0027, this is going to break every time.","commit_id":"1583f9c136ddbf7fac1b065a9070f427b0ca688c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"d17f446781175c3a19e8f86601a08de1aa169544","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                \u0027target_power_state\u0027,"},{"line_number":103,"context_line":"                \u0027target_provision_state\u0027,"},{"line_number":104,"context_line":"                \u0027updated_at\u0027,"},{"line_number":105,"context_line":"                \u0027uuid\u0027]"},{"line_number":106,"context_line":"        node_show \u003d self.openstack(\u0027baremetal node show {0}\u0027"},{"line_number":107,"context_line":"                                   .format(self.node[\u0027uuid\u0027]))"},{"line_number":108,"context_line":"        nodes_show_rows \u003d self._get_table_rows(node_show)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_c95c641b","line":105,"in_reply_to":"9a30ddce_8ea2a897","updated":"2017-03-13 12:15:26.000000000","message":"Thanks, changed this to assertion of subsets.","commit_id":"1583f9c136ddbf7fac1b065a9070f427b0ca688c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"763e31fc8f92cb2b1f0e1da7e042472b0f25294b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                   .format(self.node[\u0027uuid\u0027]))"},{"line_number":108,"context_line":"        nodes_show_rows \u003d self._get_table_rows(node_show)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.assertTrue(set(rows).issubset(set(nodes_show_rows)))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_show_minimal_fields(self):"},{"line_number":113,"context_line":"        rows \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_2463271c","line":110,"updated":"2017-03-17 17:02:46.000000000","message":"Why not assertEqual here?","commit_id":"1bed0fae009b5c5c476d4142928c187e879d3611"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66b58520c40bfbe540d60385925fdf24aca80d71","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                   .format(self.node[\u0027uuid\u0027]))"},{"line_number":108,"context_line":"        nodes_show_rows \u003d self._get_table_rows(node_show)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.assertTrue(set(rows).issubset(set(nodes_show_rows)))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_show_minimal_fields(self):"},{"line_number":113,"context_line":"        rows \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_ffe4363c","line":110,"in_reply_to":"1a1ced50_2463271c","updated":"2017-03-17 17:11:29.000000000","message":"OK, I see, it\u0027s not to break every time we add new things. I\u0027d personally be OK with just adding things here as we add them in client.","commit_id":"1bed0fae009b5c5c476d4142928c187e879d3611"}]}