)]}'
{"id":"openstack%2Fpython-ironicclient~406263","triplet_id":"openstack%2Fpython-ironicclient~stable%2Fnewton~I27540f58e31817d4de604334bc4c62899d82f4cc","project":"openstack/python-ironicclient","branch":"stable/newton","topic":"bug/1629068","hashtags":[],"change_id":"I27540f58e31817d4de604334bc4c62899d82f4cc","subject":"Fix python3 compatibility when HTTP Error are returned","status":"ABANDONED","created":"2016-12-02 17:42:51.000000000","updated":"2016-12-07 22:10:19.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7d096958c0c70f299697e853adbab24d4c11dbed","_number":406263,"virtual_id_number":406263,"owner":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":1,"date":"2016-12-02 18:07:41.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-12-02 18:39:12.000000000","_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},{"date":"2016-12-05 09:36:46.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":18063,"name":"Marc Aubry","email":"maubry@internap.com","username":"maubry-i"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"disliked":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"all":[{"value":-1,"date":"2016-12-06 02:21:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2016-12-02 18:37:23.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18063,"name":"Marc Aubry","email":"maubry@internap.com","username":"maubry-i"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"date":"2016-12-02 17:42:51.000000000","_account_id":18063,"name":"Marc Aubry","email":"maubry@internap.com","username":"maubry-i"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":18063,"name":"Marc Aubry","email":"maubry@internap.com","username":"maubry-i"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":18063,"name":"Marc Aubry","email":"maubry@internap.com","username":"maubry-i"},{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-02 17:42:51.000000000","updated_by":{"_account_id":18063,"name":"Marc Aubry","email":"maubry@internap.com","username":"maubry-i"},"reviewer":{"_account_id":18063,"name":"Marc Aubry","email":"maubry@internap.com","username":"maubry-i"},"state":"REVIEWER"},{"updated":"2016-12-02 18:07:41.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-12-02 18:37:23.000000000","updated_by":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"reviewer":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"state":"REVIEWER"},{"updated":"2016-12-05 09:36:46.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-12-06 02:21:38.000000000","updated_by":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"reviewer":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"state":"REVIEWER"}],"messages":[{"id":"ea5717bbce2f7ed96eff06ecf9f1033a384c340e","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-12-02 17:42:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8069d27dbddd52645af946fe30f754da80f3b445","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-02 18:07:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python34 http://logs.openstack.org/63/406263/1/check/gate-python-ironicclient-python34/101988c/ : SUCCESS in 2m 20s\n- gate-python-ironicclient-python35 http://logs.openstack.org/63/406263/1/check/gate-python-ironicclient-python35/34da18f/ : SUCCESS in 2m 07s\n- gate-python-ironicclient-docs-ubuntu-xenial http://docs-draft.openstack.org/63/406263/1/check/gate-python-ironicclient-docs-ubuntu-xenial/f7e974f//doc/build/html/ : SUCCESS in 2m 33s\n- gate-python-ironicclient-pep8-ubuntu-xenial http://logs.openstack.org/63/406263/1/check/gate-python-ironicclient-pep8-ubuntu-xenial/d0b7497/ : SUCCESS in 2m 42s\n- gate-python-ironicclient-python27-ubuntu-xenial http://logs.openstack.org/63/406263/1/check/gate-python-ironicclient-python27-ubuntu-xenial/1f8ddd7/ : SUCCESS in 2m 28s\n- gate-python-ironicclient-requirements http://logs.openstack.org/63/406263/1/check/gate-python-ironicclient-requirements/c6b52a6/ : SUCCESS in 1m 46s\n- gate-python-ironicclient-pypy http://logs.openstack.org/63/406263/1/check/gate-python-ironicclient-pypy/4e2a231/ : SUCCESS in 3m 01s (non-voting)\n- gate-python-ironicclient-releasenotes http://docs-draft.openstack.org/63/406263/1/check/gate-python-ironicclient-releasenotes/4539ae0//releasenotes/build/html/ : SUCCESS in 2m 28s\n- check-osc-plugins http://logs.openstack.org/63/406263/1/check/check-osc-plugins/f07a2a3/ : SUCCESS in 3m 40s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src http://logs.openstack.org/63/406263/1/check/gate-tempest-dsvm-python-ironicclient-src/ad72142/ : SUCCESS in 24m 33s\n- gate-ironicclient-dsvm-functional http://logs.openstack.org/63/406263/1/check/gate-ironicclient-dsvm-functional/e33c931/ : SUCCESS in 8m 36s\n- python-ironicclient-coverage-ubuntu-xenial http://logs.openstack.org/63/406263/1/check/python-ironicclient-coverage-ubuntu-xenial/ff5e079/ : SUCCESS in 4m 16s","accounts_in_message":[],"_revision_number":1},{"id":"bb8135c23729accb2e4f072ff8081b246242484a","author":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"date":"2016-12-02 18:37:23.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e728e4e07f79f36b10b1a136487a81ceda91e174","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-12-02 18:39:12.000000000","message":"Patch Set 1:\n\nHey Annie,\n\nIn this case, this is a back port from a commit that has already landed in master. We avoid making code changes to cherry-picked commits into stable.\n\nThanks! \nJay","accounts_in_message":[],"_revision_number":1},{"id":"56c34f41085eaf44096c7d9cf1894cca71420c2f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-12-05 09:36:46.000000000","message":"Patch Set 1:\n\nThis involves adding a requirement, which is generally a bad idea. I\u0027d like Tony to weigh in.","accounts_in_message":[],"_revision_number":1},{"id":"65e0fa014b8146a600e99ddf76f930113b5fb08c","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-12-05 16:30:30.000000000","message":"Patch Set 1:\n\nAfter reading the stable policy before posting this, it seemed OK to add a requirement as long as it was already in general-requirements for that release, as Oslo.serialization was.","accounts_in_message":[],"_revision_number":1},{"id":"adaf8fc592d5d8cf43e0d9898faed58db2a98d7b","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2016-12-06 02:21:38.000000000","message":"Patch Set 1: Code-Review-1\n\nFrom a \u0027letter of the policy\u0027 POV this is fine.  There are challenges though.  When adding a requirement that is signaled by bumping the minor version, which we can\u0027t do here as 1.8.0 is already out.  So at the least there needs to be a followup release note explaining the addition of the new library.\n\nThen we come the the change at hand.  It\u0027s easy to see this as a bug *OR* a feature.  My opinion is it\u0027s much closer to a feature than an bug as Python3 support is still a \"strive for\" not a \"must have\".\n\nWith that in mind I\u0027m going to vote -1 on this but leave the way open for the Ironic team to disagree with me and take this.","accounts_in_message":[],"_revision_number":1},{"id":"e095e83f63524b09882c197e3eeb8a61aa42918b","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-12-07 22:10:19.000000000","message":"Abandoned\n\nAfter Tony\u0027s comment, abandoning the patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c56e7d8eca8f2ddccff13c4ce2bb3357b459ca03","revisions":{"c56e7d8eca8f2ddccff13c4ce2bb3357b459ca03":{"kind":"REWORK","_number":1,"created":"2016-12-02 17:42:51.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/63/406263/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/63/406263/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/63/406263/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/63/406263/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/63/406263/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/63/406263/1"}}},"commit":{"parents":[{"commit":"1e5b34dc0f402fcfd775311f07794cd8c529624b","subject":"Use stable/newton branch in tox_install.sh wrapper script.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/1e5b34dc0f402fcfd775311f07794cd8c529624b"}]}],"author":{"name":"Marc Aubry","email":"maubry@internap.com","date":"2016-09-27 21:42:53.000000000","tz":-240},"committer":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2016-12-02 17:42:50.000000000","tz":-480},"subject":"Fix python3 compatibility when HTTP Error are returned","message":"Fix python3 compatibility when HTTP Error are returned\n\nWhen trying to contact Ironic with a bad token, Forbidden exception\nshould be raised, in python3 a TypeError is raised due to json\nlib being unable do decode a bytes object.\n\nIn order to be really python3 compatible, the json lib was replaced\nwith oslo.serialization module jsontuils since it\u0027s the recommended\nmigration to python3 guide. This is to ensure that data coming from\nthe requests lib can be read even if it\u0027s not string any more but\nbytes.\nhttps://wiki.openstack.org/wiki/Python3\n\nChange-Id: I27540f58e31817d4de604334bc4c62899d82f4cc\nCloses-Bug: #1629068\n(cherry picked from commit e512550ab7d61b8bdafd50022dfa8b80a8502922)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/c56e7d8eca8f2ddccff13c4ce2bb3357b459ca03"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/c56e7d8eca8f2ddccff13c4ce2bb3357b459ca03"}]},"branch":"refs/heads/stable/newton"}},"requirements":[],"submit_records":[],"submit_requirements":[]}