)]}'
{"id":"openstack%2Fpython-ironicclient~424293","triplet_id":"openstack%2Fpython-ironicclient~master~Iaaa9e88b4a4b1e1086217900480fb528bfae56dc","project":"openstack/python-ironicclient","branch":"master","hashtags":[],"change_id":"Iaaa9e88b4a4b1e1086217900480fb528bfae56dc","subject":"Fix node-inject-nmi to pass an empty body","status":"MERGED","created":"2017-01-23 19:01:13.000000000","updated":"2017-01-24 12:45:58.000000000","submitted":"2017-01-24 12:45:58.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3c3ecdcba2e77d52ff73b7407ec8b7d38d77416c","_number":424293,"virtual_id_number":424293,"owner":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-01-24 12:45:58.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},{"value":0,"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-01-23 19:58:35.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":1,"date":"2017-01-24 06:11:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},{"value":1,"date":"2017-01-23 21:41:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},{"value":2,"date":"2017-01-24 12:05:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},{"value":0,"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},{"value":1,"date":"2017-01-24 12:05:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},{"value":0,"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-23 19:27:54.000000000","updated_by":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"reviewer":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"state":"REVIEWER"},{"updated":"2017-01-23 19:58:35.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2017-01-23 21:41:55.000000000","updated_by":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"reviewer":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"state":"REVIEWER"},{"updated":"2017-01-24 06:11:05.000000000","updated_by":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"reviewer":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"state":"REVIEWER"},{"updated":"2017-01-24 12:05:54.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-01-24 12:45:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d7a13a72db7e800777d925fa979cb8723f4110fe","author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"date":"2017-01-23 19:01:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"98603f04bae19271c5864a859f40f2dafd0a7285","author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"date":"2017-01-23 19:19:08.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI\u0027d like to better understand the PUT method\u0027s requirement of non-0-length body. Could you elaborate on that, please?","accounts_in_message":[],"_revision_number":1},{"id":"cff45f670df6b3640470d3fbbdb4eadf657d8128","author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"date":"2017-01-23 19:19:14.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"6cb67d5ad18c433b5b794829590bfa387e4397bf","author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"date":"2017-01-23 19:27:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"62aa6aea7f05364ddcb42ed729234624c798bdd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-23 19:32:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python35 http://logs.openstack.org/93/424293/1/check/gate-python-ironicclient-python35/267e0c2/ : SUCCESS in 3m 10s\n- gate-python-ironicclient-docs-ubuntu-xenial http://docs-draft.openstack.org/93/424293/1/check/gate-python-ironicclient-docs-ubuntu-xenial/6acbe59//doc/build/html/ : SUCCESS in 4m 23s\n- gate-python-ironicclient-pep8-ubuntu-xenial http://logs.openstack.org/93/424293/1/check/gate-python-ironicclient-pep8-ubuntu-xenial/417976f/ : SUCCESS in 5m 01s\n- gate-python-ironicclient-python27-ubuntu-xenial http://logs.openstack.org/93/424293/1/check/gate-python-ironicclient-python27-ubuntu-xenial/8fbd2e3/ : SUCCESS in 3m 35s\n- gate-python-ironicclient-pypy http://logs.openstack.org/93/424293/1/check/gate-python-ironicclient-pypy/441d71e/ : SUCCESS in 4m 12s (non-voting)\n- check-osc-plugins http://logs.openstack.org/93/424293/1/check/check-osc-plugins/c71a159/ : FAILURE in 3m 12s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial http://logs.openstack.org/93/424293/1/check/gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial/40bb66f/ : SUCCESS in 28m 04s\n- gate-ironicclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/93/424293/1/check/gate-ironicclient-dsvm-functional-ubuntu-xenial/b3ebc30/ : SUCCESS in 9m 49s\n- python-ironicclient-coverage-ubuntu-xenial http://logs.openstack.org/93/424293/1/check/python-ironicclient-coverage-ubuntu-xenial/92f46ee/ : SUCCESS in 2m 49s","accounts_in_message":[],"_revision_number":1},{"id":"a30a7e55223afea98661fabf81559abbecaaddfd","author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"date":"2017-01-23 19:46:47.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"f58d86e421d406a4e24a679fa6ccfc4d43ed6f0b","author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"date":"2017-01-23 19:55:15.000000000","message":"Patch Set 2:\n\nThank you for review.\n\nBad request is returned when passing a request without a body.\n$ ironic --ironic-api-version 1.29 node-inject-nmi node-0         \nRequest must be a JSON dict (HTTP 400)","accounts_in_message":[],"_revision_number":2},{"id":"3a887954ee41d58e088232b0ba68f67f9a396ab6","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2017-01-23 19:58:35.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"678a742e0354fb7c935d5ce202bb4f783f64ac9b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-23 20:16:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python35 http://logs.openstack.org/93/424293/2/check/gate-python-ironicclient-python35/d1a1f88/ : SUCCESS in 2m 16s\n- gate-python-ironicclient-docs-ubuntu-xenial http://docs-draft.openstack.org/93/424293/2/check/gate-python-ironicclient-docs-ubuntu-xenial/a6ee9cb//doc/build/html/ : SUCCESS in 2m 32s\n- gate-python-ironicclient-pep8-ubuntu-xenial http://logs.openstack.org/93/424293/2/check/gate-python-ironicclient-pep8-ubuntu-xenial/34f8300/ : SUCCESS in 3m 06s\n- gate-python-ironicclient-python27-ubuntu-xenial http://logs.openstack.org/93/424293/2/check/gate-python-ironicclient-python27-ubuntu-xenial/bb50ba1/ : SUCCESS in 2m 17s\n- gate-python-ironicclient-pypy http://logs.openstack.org/93/424293/2/check/gate-python-ironicclient-pypy/d06e737/ : SUCCESS in 5m 59s (non-voting)\n- check-osc-plugins http://logs.openstack.org/93/424293/2/check/check-osc-plugins/23b84b0/ : FAILURE in 3m 44s (non-voting)\n- gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial http://logs.openstack.org/93/424293/2/check/gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial/445d015/ : SUCCESS in 26m 28s\n- gate-ironicclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/93/424293/2/check/gate-ironicclient-dsvm-functional-ubuntu-xenial/16656e7/ : SUCCESS in 9m 11s\n- python-ironicclient-coverage-ubuntu-xenial http://logs.openstack.org/93/424293/2/check/python-ironicclient-coverage-ubuntu-xenial/b4706a7/ : SUCCESS in 2m 16s","accounts_in_message":[],"_revision_number":2},{"id":"92a9da65fb4f8383d3608c52b4ecc3bd51005137","author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"date":"2017-01-23 21:41:55.000000000","message":"Patch Set 2: Code-Review+1\n\nThank you for the answer and fixing the nit.","accounts_in_message":[],"_revision_number":2},{"id":"0dc38256b022de4b3672a86adcf84a0ca43b4e5d","author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"date":"2017-01-24 06:11:05.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks!","accounts_in_message":[],"_revision_number":2},{"id":"e0a0ecb7d8d68cdfef7f6a41c3ae37f367c9af4d","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-01-24 12:05:54.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9e1b17a5a8df2a57637ac29fda5aa557a9ed58c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-24 12:06:05.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e65b38271b6e78bdf409612d6f0becf6d6c18096","date":"2017-01-24 12:45:58.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"3c3ecdcba2e77d52ff73b7407ec8b7d38d77416c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-24 12:45:58.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironicclient-python35 http://logs.openstack.org/93/424293/2/gate/gate-python-ironicclient-python35/2f65353/ : SUCCESS in 5m 14s\n- gate-python-ironicclient-docs-ubuntu-xenial http://docs-draft.openstack.org/93/424293/2/gate/gate-python-ironicclient-docs-ubuntu-xenial/e7e4f18//doc/build/html/ : SUCCESS in 5m 12s\n- gate-python-ironicclient-pep8-ubuntu-xenial http://logs.openstack.org/93/424293/2/gate/gate-python-ironicclient-pep8-ubuntu-xenial/2577957/ : SUCCESS in 4m 02s\n- gate-python-ironicclient-python27-ubuntu-xenial http://logs.openstack.org/93/424293/2/gate/gate-python-ironicclient-python27-ubuntu-xenial/ac11b3d/ : SUCCESS in 3m 08s\n- gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial http://logs.openstack.org/93/424293/2/gate/gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial/f4933b4/ : SUCCESS in 39m 25s\n- gate-ironicclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/93/424293/2/gate/gate-ironicclient-dsvm-functional-ubuntu-xenial/d4c7c2e/ : SUCCESS in 14m 45s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1afaaa18c79124558a7ea5f1ba09c3401fdae62c","revisions":{"92a8a64eae7bbf00fd52aefa7943f3ad940d8bc1":{"kind":"REWORK","_number":1,"created":"2017-01-23 19:01:13.000000000","uploader":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"ref":"refs/changes/93/424293/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/93/424293/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/93/424293/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/93/424293/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/93/424293/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/93/424293/1"}}},"commit":{"parents":[{"commit":"8a1d09e8985f916630412f13158d1577c23235c7","subject":"Merge \"Add a new command \"ironic node-inject-nmi\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/8a1d09e8985f916630412f13158d1577c23235c7"}]}],"author":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-01-23 18:53:32.000000000","tz":540},"committer":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-01-23 19:01:02.000000000","tz":540},"subject":"Fix node-inject-nmi to pass an empty body","message":"Fix node-inject-nmi to pass an empty body\n\nFix a request of inject_nmi API to pass an empty body because PUT\nmethod requies a body in a request.\n\nChange-Id: Iaaa9e88b4a4b1e1086217900480fb528bfae56dc\nPartial-Bug: #1526226\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/92a8a64eae7bbf00fd52aefa7943f3ad940d8bc1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/92a8a64eae7bbf00fd52aefa7943f3ad940d8bc1"}]},"branch":"refs/heads/master"},"1afaaa18c79124558a7ea5f1ba09c3401fdae62c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-01-23 19:46:47.000000000","uploader":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"ref":"refs/changes/93/424293/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/93/424293/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/93/424293/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/93/424293/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/93/424293/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/93/424293/2"}}},"commit":{"parents":[{"commit":"8a1d09e8985f916630412f13158d1577c23235c7","subject":"Merge \"Add a new command \"ironic node-inject-nmi\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/8a1d09e8985f916630412f13158d1577c23235c7"}]}],"author":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-01-23 18:53:32.000000000","tz":540},"committer":{"name":"Hironori Shiina","email":"shiina.hironori@jp.fujitsu.com","date":"2017-01-23 19:44:47.000000000","tz":0},"subject":"Fix node-inject-nmi to pass an empty body","message":"Fix node-inject-nmi to pass an empty body\n\nFix a request of inject_nmi API to pass an empty body because PUT\nrequest must be a JSON dict. A request without a body causes a\nvalidation error in the server.\n\nChange-Id: Iaaa9e88b4a4b1e1086217900480fb528bfae56dc\nPartial-Bug: #1526226\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/1afaaa18c79124558a7ea5f1ba09c3401fdae62c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/1afaaa18c79124558a7ea5f1ba09c3401fdae62c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}